Commit graph

295 commits

Author SHA1 Message Date
Omar Ajoue 3b73cb6a56 Adjustments suggested by @mutdmour 2021-08-19 15:26:38 +02:00
Omar Ajoue 82dbbcd2e0 Changed the webhook id change code placement 2021-08-19 10:51:30 +02:00
Omar Ajoue 86fa3a6b9e Updates webhook UUIDs to a new one when duplicating 2021-08-18 16:25:05 +02:00
Ahsan Virani 31cf43c294
Add additional frontend hooks (#2073) 2021-08-13 12:01:12 +02:00
Jan 6ffc46c79d
Revert "🐛 Fix ipad drag issue (#2016)" (#2062)
This reverts commit 5bdcadf93d.
2021-08-08 11:14:09 +02:00
Mutasem Aldmour 5bdcadf93d
🐛 Fix ipad drag issue (#2016) 2021-08-08 10:43:34 +02:00
Mutasem Aldmour fa31c0c7b6
🐛 Fix UI blocking with large workflows (#2053)
* fix reactivity bug

* Clean up props

* add comma

* clean up, reduce reactivity more

* ts issues
2021-08-07 09:35:59 +02:00
Jan Oberhauser 2afd93520a 🐛 Fix issue that it displayed URLs after credential change for all
node types
2021-07-23 22:27:22 +02:00
Mutasem Aldmour 47eb2c73ca
Refresh options #1678 (#2012)
* Allow refresh remoteOptions

* clean up pr, update option name, move option down

Co-authored-by: Anthr@X <4828355+AnthraX1@users.noreply.github.com>
2021-07-23 17:52:25 +02:00
Mutasem Aldmour a9550202df
🧹 clean up editor based on #1418 (#2010)
* clean up editor based on #1418

* remove unused ref

* address comment on guard style
2021-07-23 17:50:47 +02:00
MedAliMarz 5602929210
🎨 Update webhook URL details UI (#2004)
* Update the webhook URL details

* Change radio buttons values

* Limit the effects for the webhook node
2021-07-23 17:42:46 +02:00
MedAliMarz 10acbecfaa
🐛 Fix workflow activation confirmation modal (#2005)
* Show the activation message if the workflow is not saved

* Apply review changes
2021-07-23 09:32:56 +02:00
Mutasem Aldmour 98ec23544b
Add new version notification (#1977)
* add menu item

* implement versions modal

* fix up modal

* clean up badges

* implement key features

* fix up spacing

* add error message

* add notification icon

* fix notification

* fix bug when no updates

* address lint issues

* address multi line nodes

* add closing animation

* keep drawer open

* address design feedback

* address badge styling

* use grid for icons

* update cli to return version information

* set env variables

* add scss color variables

* address comments

* fix lint issue

* handle edge cases

* update scss variables, spacing

* update spacing

* build

* override top value for theme

* bolden version

* update config

* check endpoint exists

* handle long names

* set dates

* set title

* fix bug

* update warning

* remove unused component

* refactor components

* add fragments

* inherit styles

* fix icon size

* fix lint issues

* add cli dep

* address comments

* handle network error

* address empty case

* Revert "address comments"

480f969e07

* remove dependency

* build

* update variable names

* update variable names

* refactor verion card

* split out variables

* clean up impl

* clean up scss

* move from nodeview

* refactor out gift notification icon

* fix lint issues

* clean up variables

* update scss variables

* update info url

* Add instanceId to frontendSettings

* Use createHash from crypto module

* Add instanceId to store & send it as http header

* Fix lintings

* Fix interfaces & apply review changes

* Apply review changes

* add console message

* update text info

* update endpoint

* clean up interface

* address comments

* cleanup todo

* Update packages/cli/config/index.ts

Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>

* update console message

*  Display node-name on hover

*  Formatting fix

Co-authored-by: MedAliMarz <servfrdali@yahoo.fr>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-07-22 10:22:17 +02:00
MedAliMarz e2e57539d6
🐛 Change the dirty state after deleting a workflow (#1992) 2021-07-17 09:00:39 +02:00
Iván Ovejero 922880f93d
Fix workflow ID type on download (#1956) 2021-07-10 23:23:19 +02:00
Omar Ajoue d3da5023f0
🐛 Fix "unknown", never-end workflow and not displaying error message (#1978)
* Added try catch blocks to avoid endlessly running workflows

* Added handling for subworkflows

*  Fix one cause of "unkown" status of worklows with "main" mode

*  Fix one cause of "unkown" status of worklows with "own" mode

*  Fix one cause of "unkown" status of worklows with "queue" mode

* Saving database recovery

* 🐛 Fix issue that errors did not get saved correctly and also not
displayed

*  Save workflow timeout correctly as error

* Adding error capture to queued jobs

*  Mark canceled executions as not finished consistently across all
modes

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-07-10 11:34:41 +02:00
Mutasem Aldmour a842e4bc0a
🐛 Fix nodes panel reactivity bug (#1972)
* add keys

* fix nodes panel reactivity bug

* fix lint issues
2021-07-08 07:46:20 +02:00
Omar Ajoue 8d235e94cb
Performance improvements for executions count on Postgres (#1888)
* Performance improvements for executions count on Postgres

As reported by a community member https://community.n8n.io/t/stress-load-testing/4846/5
and https://github.com/n8n-io/n8n/issues/1578, when using postgres with
a big volume of executions, the executions list's performance degrades.

This PR is aimed at Postgres specifically by querying postgres' stats
collector instead of running a full table scan, providing a good
estimate.

More can be read here: https://www.citusdata.com/blog/2016/10/12/count-performance/

* Removed order of magnitude so we display closer numbers

* Making count based on statistics only when not applying filters

*  Minor styling improvements

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-07-06 23:25:25 +02:00
Jan Oberhauser b49202687d Add support to display binary video content 2021-07-03 14:30:02 +02:00
Mutasem Aldmour a42bbf88f8
Enable tags selection (#1960) 2021-07-01 10:15:28 +02:00
Mutasem Aldmour a080fab1f1
Update click outside events to limit only to click events, ignoring blur (#1953) 2021-06-30 09:17:30 +02:00
Iván Ovejero bd4fbf3a4b
Touch up display for large error cause (#1927) 2021-06-22 19:43:43 +02:00
Mutasem Aldmour 1d5ba3d437
Allow to load workflow templates (#1887)
* implement import

* set name, remove console log

* add validation and such

* remove monday.com package for testing

* clean up code

* await new name

* refactor api requests

* remove unnessary import

* build

* add zoom button

* update positions on loading template

* update error handling

* build

* update zoom to center

* set state to dirty upon leaving

* clean up pr

* refactor func

* refactor redir

* fix lint issue

* refactor func out

* use new endpoint

* revert error changes

* revert error changes

* update logic to find top left node

* zoom to fit when opening workflow

* revert testing change

* update case

* address comments

* reset zoom when opening new workflow

* update endpoint to plural form

* update endpoint

*  Minor improvements

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-06-22 19:33:07 +02:00
Ben Hesseldieck c0c994d245
Add hooks to Node Lifecycle (#1882)
*  add hook when closing node editing view

*  add hook for node deletion

*  add hook call to escape key
2021-06-18 22:47:03 +02:00
Ben Hesseldieck 0470740737
Change the UI of the Nodes Panel (#1855)
* Add codex search properties to node types

* implement basic styles

* update header designs

* update node list designs

* add trigger icon

* refactor node creator list

* implement categories and subcategories

* fix up spacing

* add arrows

* implement navigatable list

* implement more of feature

* implement navigation

* add transitions

* fix lint issues

* fix overlay

*  Get and add codex categories

* fix up design

* update borders

* implement no-matches view

* fix preview bug

* add color to search

* clean up borders

* add comma

* Revert "Merge branch 'add-codex-data' of github.com:n8n-io/n8n into PROD-819-nodes-panel-redesign"

38b7d7ead1

* use new impl

* remove empty categories

* update scrolling, hide start node

* make scrollable

* remove text while subcategory panel is open

* fix up spacing

* fix lint issues

* update descriptions

* update path

* update images

* fix tags manager

* give min height to image

* gst

* update clear color

* update font size

* fix firefox spacing

* close on click outside

* add external link icon

* update iterator key

* add client side caching for images

* update caching header

* ️ Add properties to codex for nodes panel (#1854)

*  Get and add codex categories

*  Add parens to evaluation + destructuring

* 🔥 Remove non-existing class reference

*  Add alias to codex property

* move constants

* 🔨 Rename CodexCategories to CodexData

* ✏️ Update getCodex documentation

* refactor and move

* refactor no results view

* more refactoring

* refactor subcategory panel

* more refactoring

* update text

* update no results view

* add miscellaneous to end of list

* address design feedback

* reimplement node search

* fix up clear

* update placeholder color

* impl transition

* focus on tab

* update spacing

* fix transition bug on start

* fix up x

* fix position

* build

* safari fix

* remove input changes

* css bleed issue with image

* update css value

* clean up

* simplify impl

* rename again

* rename again

* rename all

* fix hover bug

* remove keep alive

* delete icon

* update interface type

* refactor components

* update scss to module

* clean up impl

* clean up colors as vars

* fix indentation

* clean up scss

* clean up scss

* clean up scss

* clean up scss

* Clean up files

* update logic to be more efficient

* fix search bug

* update type

* remove unused

* clean up js

* update scrollable, border impl, transition

* fix simicolon

* build

* update search

* address max's comments

* change icon border radius

* change margin

* update icon size

* update icon size

* update slide transition out

* add comma

* remove full

* update trigger icon size

* fix image size

* address design feedback

* update external link icons

* address codacy issues

* support custom nodes without codex file

* address jan's feedback

* address Ben's comments

* add subcategory index

* open/close categories with arrow keys

* add lint comment

* Address latest comments

*  Minor changes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-06-18 07:58:26 +02:00
Iván Ovejero c0ec1ed606
Show activation error details for trigger nodes (#1787)
*  Implement error details in toast notification

*  Refactor error notification

*  Pipe activation error in prod mode to FE

*  Add node name to activation error details

*  Disable ignoring with ts-check

* 📝 fix spelling

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
2021-06-12 17:06:56 +02:00
Jan Oberhauser 09e14987f0 🐛 Display issue that view crashes with large requests 2021-06-06 14:53:48 -05:00
MedAliMarz 6ccb42156d
🐛 Fix NodeViewNew navigation handling (#1853)
* 🐛 Fix NodeViewNew navigation handling

* Use event emitter pattern to fix duplicate navigation

* Apply review suggestions

* Remove unnecessary arrow function

*  Also fix for keyboard shortcut

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-06-04 16:13:42 -05:00
Iván Ovejero 40e41f7506
Restructure IPushData union types (#1836)
*  Send console.log messages to editor-UI

*  Send message only to session which started workflow

*  Made it also work in own process

*  Add support for console.log UI forward also to FunctionItem Node

* 👕 Fix lint issue

* 👕 Fix linting issue

*  Restructure IPushData unions in /cli

*  Restructure IPushData unions in /editor-ui

* 🔥 Remove unneeded castings

* 🔥 Remove commented code

*  Improve code

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Jan <janober@users.noreply.github.com>
2021-06-03 18:17:18 -05:00
Jan Oberhauser e4bac15d05 🐛 Fix issue that deleted value in expression did reappear after item select 2021-06-03 16:53:01 -05:00
Jan Oberhauser 8ce158d1a4 🐛 Fix error message on textarea field clicks 2021-06-02 20:48:07 -05:00
Jan Oberhauser 8f6344fbd5 🐛 Fix issue with selecting variables in Expression Editor 2021-05-31 12:59:45 -05:00
Mutasem Aldmour 7a5e69d4e5
🐛 Enable header clicks on tags (#1848)
* enable header clicks

* remove unused func
2021-05-31 18:34:55 +02:00
Jan Oberhauser 4d86384d9d 🐛 Fix issue with adding expression to parameter 2021-05-29 22:41:54 -05:00
Jan Oberhauser 2d9c2e1a1e Speed up expression editor 2021-05-29 21:08:41 -05:00
Jan Oberhauser a5300a5f24 Fix errors in expression editor 2021-05-29 19:49:20 -05:00
Jan 4946bfcd3e
Add functionality to send console.log messages to editor-UI (#1816)
*  Send console.log messages to editor-UI

*  Send message only to session which started workflow

*  Made it also work in own process

*  Add support for console.log UI forward also to FunctionItem Node

* 👕 Fix lint issue

* 👕 Fix linting issue

*  Improve code

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2021-05-29 13:41:25 -05:00
Jan Oberhauser 8e793e27b3 Temporary disable tag selection on click 2021-05-29 13:37:04 -05:00
Ben Hesseldieck 05eec87d1d
Add tagging of workflows (#1647)
* clean up dropdown

* clean up focusoncreate

*  Ignore mistaken ID in POST /workflows

*  Fix undefined tag ID in PATCH /workflows

*  Shorten response for POST /tags

* remove scss mixins

* clean up imports

*  Implement validation with class-validator

* address ivan's comments

* implement modals

* Fix lint issues

* fix disabling shortcuts

* fix focus issues

* fix focus issues

* fix focus issues with modal

* fix linting issues

* use dispatch

* use constants for modal keys

* fix focus

* fix lint issues

* remove unused prop

* add modal root

* fix lint issues

* remove unused methods

* fix shortcut

* remove max width

*  Fix duplicate entry error for pg and MySQL

* update rename messaging

* update order of buttons

* fix firefox overflow on windows

* fix dropdown height

* 🔨 refactor tag crud controllers

* 🧹 remove unused imports

* use variable for number of items

* fix dropdown spacing

*  Restore type to fix build

*  Fix post-refactor PATCH /workflows/:id

*  Fix PATCH /workflows/:id for zero tags

*  Fix usage count becoming stringified

* address max's comments

* fix filter spacing

* fix blur bug

* address most of ivan's comments

* address tags type concern

* remove defaults

*  return tag id as string

* 🔨 add hooks to tag CUD operations

* 🏎 simplify timestamp pruning

* remove blur event

* fix onblur bug

*  Fix fs import to fix build

* address max's comments

* implement responsive tag container

* fix lint issues

* Set default dates in entities

* 👕 Fix lint in migrations

* update tag limits

* address ivan's comments

* remove rename, refactor header, implement new designs for save, remove responsive tag container

* update styling

* update styling

* implement responsive tag container

* implement header tags edit

* implement header tags edit

* fix lint issues

* implement expandable input

* minor fixes

* minor fixes

* use variable

* rename save as

* duplicate fixes

*  Implement unique workflow names

*  Create /workflows/new endpoint

* minor edit fixes

* lint fixes

* style fixes

* hook up saving name

* hook up tags

* clean up impl

* fix dirty state bug

* update limit

* update notification messages

* on click outside

* fix minor bug with count

* lint fixes

*  Add query string params to /workflows/new

* handle minor edge cases

* handle minor edge cases

* handle minor bugs; fix firefox dropdown issue

* Fix min width

* apply tags only after api success

* remove count fix

* 🚧 Adjust to new qs requirements

* clean up workflow tags impl, fix tags delete bug

* fix minor issue

* fix minor spacing issue

* disable wrap for ops

* fix viewport root; save on click in dropdown

* save button loading when saving name/tags

* implement max width on tags container

* implement cleaner create experience

* disable edit while updating

* codacy hex color

* refactor tags container

* fix clickability

* fix workflow open and count

* clean up structure

* fix up lint issues

*  Create migrations for unique workflow names

* fix button size

* increase workflow name limit for larger screen

* tslint fixes

* disable responsiveness for workflow modal

* rename event

* change min width for tags

* clean up pr

*  Adjust quotes in MySQL migration

*  Adjust quotes in Postgres migration

* address max's comments on styles

* remove success toasts

* add hover mode to name

* minor fixes

* refactor name preview

* fix name input not to jiggle

* finish up name input

* Fix up add tags

* clean up param

* clean up scss

* fix resizing name

* fix resizing name

* fix resize bug

* clean up edit spacing

* ignore on esc

* fix input bug

* focus input on clear

* build

* fix up add tags clickablity

* remove scrollbars

* move into folders

* clean up multiple patch req

* remove padding top from edit

* update tags on enter

* build

* rollout blur on enter behavior

* rollout esc behavior

* fix tags bug when duplicating tags

* move key to reload tags

* update header spacing

* build

* update hex case

* refactor workflow title

* remove unusued prop

* keep focus on error, fix bug on error

* Fix bug with name / tags toggle on error

* impl creating new workflow name

*  Refactor endpoint per new guidelines

* support naming endpoint

*  Refactor to support numeric suffixes

* 👕 Lint migrations for unique workflow names

*  Add migrations set default dates to indexes

* fix connection push bug

*  Lowercase default workflow name

*  Add prefixes to set default dates migration

*  Fix indentation on default dates migrations

*  Add temp ts-ignore for unrelated change

*  Adjust default dates migration for MySQL

Remove change to data column in credentials_entity, already covered by Omar's migration. Also, fix quotes from table prefix addition.

*  Adjust quotes in dates migration for PG

* fix safari color bug

* fix count bug

* fix scroll bugs in dropdown

* expand filter size

* apply box-sizing to main header

* update workflow names in executions to be wrapped by quotes

* fix bug where key is same in dropdown

* fix firefox bug

* move up push connection session

* 🔨 Remove mistakenly added nullable property

* 🔥 Remove unneeded index drop-create (PG)

* 🔥 Remove unneeded table copying

*  Merge dates migration with tags migration

* 🔨 Refactor endpoint and make wf name env

* dropdown colors in firefox

* update colors to use variables

* update thumb color

* change error message

* remove 100 char maximum

* fix bug with saving tags dropdowns multiple times

* update error message when no name

*  Update name missing toast message

*  Update workflow already exists message

* disable saving for executions

* fix bug causing modal to close

* make tags in workflow open clickable

* increase workflow limit to 3

* remove success notifications

* update header spacing

* escape tag names

* update tag and table colors

* remove tags from export

* build

* clean up push connection dependencies

* address ben's comments

* revert tags optional interface

* address comments

* update duplicate message

* build

* fix eol

* add one more eol

*  Update comment

* add hover style for workflow open, fix up font weight

Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2021-05-29 13:31:21 -05:00
Jan Oberhauser d3c59a6fe3 Fix issue with option parameters that are named the same #1808 2021-05-28 18:13:15 -05:00
Jan Oberhauser e21382baee 🐛 Fix issue that it sets default values correctly for multipleValues
and makes previous change backward compatible
2021-05-19 19:26:29 -05:00
Jan Oberhauser bf7800cb15 🐛 Fix bug with sibling loading with fixedCollections 2021-05-16 19:25:04 -05:00
Jan Oberhauser 002f53a4af Allow to load sibling parameters in loadOptionsMethod 2021-05-16 18:16:24 -05:00
Jan Oberhauser 0877b0779d 🐛 Fix issue with displaying parameter with root level reference 2021-05-15 18:59:33 -05:00
Jan Oberhauser fd86229b30 🐛 Fix issue that it did not save values for parameters which did get
displayed depending on another parameter with expression
2021-05-15 17:51:14 -05:00
Jan Oberhauser 446c284540 👕 Fix lint issue 2021-05-15 00:36:41 -05:00
Jan Oberhauser cb2887a8ab 🐛 Fix issue that expressions did not resolve for displayOptions 2021-05-15 00:28:51 -05:00
Jan Oberhauser 1aa0a5cc8d Make it possible to read sibling parameter 2021-05-14 18:16:48 -05:00
Omar Ajoue c739a498f1
🐛 Fix ordering when auto refreshing (#1761)
* Fix ordering when auto refreshing

* Fix ordering for current executinos as well
2021-05-12 10:51:54 -05:00
Ahsan Virani caa55a022b
Add more FE hooks (#1772)
*  add FE hook for expressionEdit dialogVisibleChanged

*  update FE hook for expressionEdit dialogVisibleChanged

*  add FE hook for expressionEdit itemSelected

*  add FE hook for nodeSettings valueChanged

*  add FE hook for nodeSettings credentialSelected

* cleanup
2021-05-11 22:12:53 -05:00