कारतोफ्फेलस्क्रिप्ट™
6aa7b93473
refactor(core): Deprecate prepareOutputData (no-changelog) ( #7091 )
2023-09-05 12:59:02 +02:00
Jon
c3e76ec697
fix(Lemlist Node): Fix pagination issues with campaigns and activities ( #6734 )
2023-07-26 11:59:55 +01:00
Chris Wu
1111c915f2
refactor(core): Replace lodash's "soft-deprecated" individual packages with lodash to resolve CVE (no-changelog) ( #6450 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-16 16:26:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
6a8c9b7ccc
refactor: Improve typings for webhook methods (no-changelog) ( #5713 )
2023-03-17 12:25:31 +01:00
कारतोफ्फेलस्क्रिप्ट™
7a4e9ef5fa
refactor: Remove n8n-core dependency in nodes-base (no-changelog) ( #5649 )
2023-03-09 18:13:15 +01:00
Michael Kret
bb4db58819
fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog)
2023-02-28 05:39:43 +02:00
Alex Grozav
f0695827f5
feat: Migrate packages from lodash to lodash-es (no-changelog) ( #5538 )
2023-02-23 16:16:05 +01:00
Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
61e26804ba
refactor(core): Remove linting exceptions in nodes-base ( #4794 )
...
* ⚡ enabled array-type
* ⚡ await-thenable on
* ⚡ ban-types on
* ⚡ default-param-last on
* ⚡ dot-notation on
* ⚡ member-delimiter-style on
* ⚡ no-duplicate-imports on
* ⚡ no-empty-interface on
* ⚡ no-floating-promises on
* ⚡ no-for-in-array on
* ⚡ no-invalid-void-type on
* ⚡ no-loop-func on
* ⚡ no-shadow on
* ⚡ ban-ts-comment re enabled
* ⚡ @typescript-eslint/lines-between-class-members on
* address my own comment
* @typescript-eslint/return-await on
* @typescript-eslint/promise-function-async on
* @typescript-eslint/no-unnecessary-boolean-literal-compare on
* @typescript-eslint/no-unnecessary-type-assertion on
* prefer-const on
* @typescript-eslint/prefer-optional-chain on
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Iván Ovejero
632f573021
refactor(core): Introduce overload for string-type node parameter (no-changelog) ( #4797 )
...
* 📘 Set up overload
* 🔥 Remove inferrable assertions
2022-12-02 12:53:59 +01:00
agobrech
67983e8f94
fix: Remove redundant await in node's api request functions without try/catch ( #4639 )
...
* 🐛 Remove useless await for actionNetwork
* 🔥 Remove useless await
* 🔥 Remove useless await keyword to other generic functions
2022-11-22 17:57:17 +01:00
Iván Ovejero
0d9eeea024
refactor(core): Introduce overload for record-type node parameter (no-changelog) ( #4648 )
...
* 📘 Set up overload
* 🔥 Remove inferrable record assertions
* 👕 Fix semicolon
* 👕 Fix another semicolon
2022-11-18 16:29:44 +01:00
Iván Ovejero
0565194473
refactor(core): Introduce overload for number-type node parameter (no-changelog) ( #4644 )
...
* 📘 Set up overloads
* 📘 Add temporary assertion
* 🔥 Remove inferrable number assertions
* ✏️ Add ticket ref
2022-11-18 15:26:22 +01:00
Iván Ovejero
6757c9a2ea
refactor(core): Introduce overload for boolean-type node parameter (no-changelog) ( #4647 )
...
* 📘 Set up overloads
* 📘 Add temporary assertion
* 🔥 Remove inferrable boolean assertions
* ⏪ Undo autoformatting
2022-11-18 14:31:38 +01:00
Iván Ovejero
52f38df867
refactor: Remove unused vars to fix build (no-changelog) ( #4584 )
...
* 🔥 Remove unused vars to fix build
* 👕 Make unused vars severity conditional
2022-11-11 16:07:50 +01:00
agobrech
c7133ecd3f
fix(core): Deduplicate error handling in nodes ( #4319 )
...
* Fix issue with isAxios property
* 🥅 Deduplicate errors handeling improve errors for credentials
* 🎨 correctly throws error
2022-11-11 11:32:43 +01:00
Mike Arvela
6e8e4f5937
fix(nodes-base): fix and harmonize all primaryDocumentation links ( #4191 )
...
* fix(nodes-base): fix and harmonize all primaryDocumentation links
* feat(workflow, cli): expose documentation links to UI via node codex
* fix(editor-ui): link to correct node and credential documentation URLs
* config(nodes-base): update 'format' script to also format node descriptor json
* chore: fix outdated links to node reference documentation
2022-09-29 13:33:16 +03:00
Iván Ovejero
d4f858db92
refactor(nodes-base): Apply lint rule node-param-operation-option-action-wrong-for-get-many ( #4055 )
...
* 👕 Apply `node-param-operation-option-action-wrong-for-get-many`
* 🔥 Remove `package-lock.json`
* 📦 Re-add `package-lock.json`
* ⚡ master update
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-09-08 17:10:13 +02:00
Iván Ovejero
ca8c2d6577
refactor(nodes-base): Apply lint rule node-param-option-name-wrong-for-get-many ( #4051 )
...
* ⬆️ Upgrade linter
* 📦 Update `package-lock.json`
* 👕 Substitute rule
* 👕 Apply lintfix for `node-param-option-name-wrong-for-get-many`
* 👕 Restore lint exceptions
2022-09-07 16:51:14 +02:00
Omar Ajoue
b2c674591c
Feature/paired item support ( #3869 )
...
* Add paired item helper and implement it in some nodes
2022-08-30 17:55:33 +02:00
agobrech
76f9ad8bae
N8N-4126 credentials injection and testing on specific nodes ( #3816 )
...
* Add credential injection and testing to Lemlist, Uproc, Supabase, Segment, Phantombuster, Mailgun and Dropcontact
2022-08-24 10:26:48 +02:00
Michael Kret
91d7e16c81
n8n-3867-progressively-apply-prettier-to-all ( #3873 )
...
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
Mutasem Aldmour
c9b7b6d30f
fix: Fix broken links in nodes ( #3716 )
2022-07-14 22:05:11 +02:00
Iván Ovejero
6f95121fac
refactor: Add action to all operations on all nodes ( #3655 )
...
* 👕 Add `action` to `INodePropertyOptions`
* 👕 Apply `node-param-operation-option-without-action`
* ✏️ Fix add/remove phrasing
* ✏️ Fix email template phrasing
* ✏️ Fix add/remove phrasing
* ✏️ Fix custom fields phrasing
* ✏️ Fix job report phrasing
* ✏️ Fix query phrasing
* ✏️ Various phrasing fixes
* ✏️ Fix final phrasings
* ✏️ Remove `conversation`
* ✏️ Fix plural
2022-07-10 23:50:51 +03:00
Ricardo Espinoza
42d2959f47
fix: Fix issue with required optional parameters ( #3577 )
2022-06-23 10:44:25 -07:00
Iván Ovejero
88dea330b9
refactor: Apply more eslint-plugin-n8n-nodes-base rules ( #3534 )
...
* ⚡ Update `lintfix` script
* ⚡ Run baseline `lintfix`
* 🔥 Remove unneeded exceptions (#3538 )
* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`
* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`
* ⚡ Update version
* 👕 Apply `node-param-placeholder-missing` (#3542 )
* 👕 Apply `filesystem-wrong-cred-filename` (#3543 )
* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-class-description-empty-string` (#3546 )
* 👕 Apply `node-class-description-icon-not-svg` (#3548 )
* 👕 Apply `filesystem-wrong-node-filename` (#3549 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Expand lintings to credentials (#3550 )
* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552 )
* ⚡ fix
* ⚡ Minor fixes
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541 )
* ⚡ Add new lint rule, node-param-description-wrong-for-dynamic-multi-options
* ⚡ Fix with updated linting rules
* ⚡ Minor fixes
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-boolean-without-whether` (#3553 )
* ⚡ fix
* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537 )
* 👕 Add exceptions
* 👕 Add exception
* ✏️ Alphabetize rules
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-06-20 07:54:01 -07:00
Iván Ovejero
70ae90fa3c
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3432 )
...
* ⚡ Update `lintfix` script
* 👕 Remove unneeded lint exceptions
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-description-miscased-url` (#3441 )
* 👕 Apply `rule node-param-placeholder-miscased-id` (#3443 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446 )
* 👕 Apply `node-param-min-value-wrong-for-limit` (#3442 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-wrong-for-dynamic-options` (#3454 )
* 🔨 fix
* ⚡ Fix `Assigned To` fields
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `rule node-param-default-wrong-for-number` (#3453 )
* 👕 Apply `node-param-default-wrong-for-string` (#3452 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-miscased` (#3449 )
* 🔨 fix
* 🔨 exceptions
* ⚡ review fixes
* 👕 Apply `node-param-description-lowercase-first-char` (#3451 )
* ⚡ fix
* ⚡ review fixes
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456 )
* Rule working as intended
* Add rule
* 🔥 Remove repetitions
* 👕 Add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Small fix for `node-param-description-wrong-for-dynamic-options`
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460 )
* 👕 Apply `node-param-description-line-break-html-tag` (#3462 )
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-options-type-unsorted-items` (#3459 )
* ⚡ fix
* 🔨 exceptions
* Add exception for Salesmate and Zoom
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Restore `lintfix` command
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
2022-06-03 19:23:49 +02:00
Iván Ovejero
6dcdb30bf4
refactor: Apply more nodelinting rules ( #3324 )
...
* ✏️ Alphabetize lint rules
* 🔥 Remove duplicates
* ⚡ Update `lintfix` script
* 👕 Apply `node-param-operation-without-no-data-expression` (#3329 )
* 👕 Apply `node-param-operation-without-no-data-expression`
* 👕 Add exceptions
* 👕 Apply `node-param-description-weak` (#3328 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-value-duplicate` (#3331 )
* 👕 Apply `node-param-description-miscased-json` (#3337 )
* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-type-options-missing-from-limit` (#3336 )
* Rule workig as intended
* ✏️ Uncomment rules
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-duplicate` (#3338 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-simplify` (#3334 )
* ⚡ fix
* ⚡ exceptions
* ⚡ changed rule ignoring from file to line
* 👕 Apply `node-param-resource-without-no-data-expression` (#3339 )
* 👕 Apply `node-param-display-name-untrimmed` (#3341 )
* 👕 Apply `node-param-display-name-miscased-id` (#3340 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-resource-with-plural-option` (#3342 )
* 👕 Apply `node-param-description-wrong-for-upsert` (#3333 )
* ⚡ fix
* ⚡ replaced record with contact in description
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-description-identical-to-name` (#3343 )
* 👕 Apply `node-param-option-name-containing-star` (#3347 )
* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348 )
* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345 )
* ⚡ fix
* ⚡ exceptions
* 👕 Apply node-param-display-name-wrong-for-simplify (#3344 )
* Rule working as intended
* Uncomented other rules
* 👕 Undo and add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Alphabetize lint rules
* ⚡ Restore `lintfix` script
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
2022-05-20 23:47:24 +02:00
Iván Ovejero
63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3243 )
...
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200 )
* Removing unneeded backticks (#3249 )
* 👕 Apply node-param-description-wrong-for-return-all (#3253 )
* 👕 Apply node-param-description-missing-limit (#3252 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258 )
* 👕 Apply `node-param-description-miscased-id` (#3254 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261 )
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-05-06 23:01:25 +02:00
Iván Ovejero
2b74b6238e
⚡ Deprecate step size and node color ( #2586 )
...
* 🔥 Deprecate numberStepSize
* 🔥 Deprecate color in non-FA nodes
* ⚡ Minor node name fixes
* 📦 Update package-lock.json
* ⏪ Restore Merge node color
* 👕 Fix lint
2021-12-23 13:30:35 +01:00
Iván Ovejero
a783288338
⚡ Enforce type checking in all node params ( #2509 )
2021-12-03 09:44:16 +01:00
Tom
2125beb216
⚡ Add additional fields available through Lemlist API ( #2377 )
2021-11-03 22:47:41 -06:00
Ricardo Espinoza
2e098c25ed
🐛 Fix issue not sending the event in the correct property on Lemlist ( #2198 )
2021-09-15 10:28:48 +02:00
Omar Ajoue
7ce7285f7a
⚡ Load credentials from the database ( #1741 )
...
* Changes to types so that credentials can be always loaded from DB
This first commit changes all return types from the execute functions
and calls to get credentials to be async so we can use await.
This is a first step as previously credentials were loaded in memory and
always available. We will now be loading them from the DB which requires
turning the whole call chain async.
* Fix updated files
* Removed unnecessary credential loading to improve performance
* Fix typo
* ⚡ Fix issue
* Updated new nodes to load credentials async
* ⚡ Remove not needed comment
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-08-20 18:57:30 +02:00
Jan Oberhauser
d33dad7ebc
⚡ Optimize svgs
2021-04-17 17:23:59 +02:00
Konstantin Nosov
5e7f27d137
⚡ Optimize svg ( #1653 )
...
* add optimize-svg command to npm scripts
* run svgo over all svg assets in repo
2021-04-17 17:17:16 +02:00
Iván Ovejero
1d27a9e87e
✨ Improve node error handling ( #1309 )
...
* Add path mapping and response error interfaces
* Add error handling and throwing functionality
* Refactor error handling into a single function
* Re-implement error handling in Hacker News node
* Fix linting details
* Re-implement error handling in Spotify node
* Re-implement error handling in G Suite Admin node
* 🚧 create basic setup NodeError
* 🚧 add httpCodes
* 🚧 add path priolist
* 🚧 handle statusCode in error, adjust interfaces
* 🚧 fixing type issues w/Ivan
* 🚧 add error exploration
* 👔 fix linter issues
* 🔧 improve object check
* 🚧 remove path passing from NodeApiError
* 🚧 add multi error + refactor findProperty method
* 👔 allow any
* 🔧 handle multi error message callback
* ⚡ change return type of callback
* ⚡ add customCallback to MultiError
* 🚧 refactor to use INode
* 🔨 handle arrays, continue search after first null property found
* 🚫 refactor method access
* 🚧 setup NodeErrorView
* ⚡ change timestamp to Date.now
* 📚 Add documentation for methods and constants
* 🚧 change message setting
* 🚚 move NodeErrors to workflow
* ✨ add new ErrorView for Nodes
* 🎨 improve error notification
* 🎨 refactor interfaces
* ⚡ add WorkflowOperationError, refactor error throwing
* 👕 fix linter issues
* 🎨 rename param
* 🐛 fix handling normal errors
* ⚡ add usage of NodeApiError
* 🎨 fix throw new error instead of constructor
* 🎨 remove unnecessary code/comments
* 🎨 adjusted spacing + updated status messages
* 🎨 fix tab indentation
* ✨ Replace current errors with custom errors (#1576 )
* ⚡ Introduce NodeApiError in catch blocks
* ⚡ Introduce NodeOperationError in nodes
* ⚡ Add missing errors and remove incompatible
* ⚡ Fix NodeOperationError in incompatible nodes
* 🔧 Adjust error handling in missed nodes
PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes
* 🔨 Adjust Strava Trigger node error handling
* 🔨 Adjust AWS nodes error handling
* 🔨 Remove duplicate instantiation of NodeApiError
* 🐛 fix strava trigger node error handling
* Add XML parsing to NodeApiError constructor (#1633 )
* 🐛 Remove type annotation from catch variable
* ✨ Add XML parsing to NodeApiError
* ⚡ Simplify error handling in Rekognition node
* ⚡ Pass in XML flag in generic functions
* 🔥 Remove try/catch wrappers at call sites
* 🔨 Refactor setting description from XML
* 🔨 Refactor let to const in resource loaders
* ⚡ Find property in parsed XML
* ⚡ Change let to const
* 🔥 Remove unneeded try/catch block
* 👕 Fix linting issues
* 🐛 Fix errors from merge conflict resolution
* ⚡ Add custom errors to latest contributions
* 👕 Fix linting issues
* ⚡ Refactor MongoDB helpers for custom errors
* 🐛 Correct custom error type
* ⚡ Apply feedback to A nodes
* ⚡ Apply feedback to missed A node
* ⚡ Apply feedback to B-D nodes
* ⚡ Apply feedback to E-F nodes
* ⚡ Apply feedback to G nodes
* ⚡ Apply feedback to H-L nodes
* ⚡ Apply feedback to M nodes
* ⚡ Apply feedback to P nodes
* ⚡ Apply feedback to R nodes
* ⚡ Apply feedback to S nodes
* ⚡ Apply feedback to T nodes
* ⚡ Apply feedback to V-Z nodes
* ⚡ Add HTTP code to iterable node error
* 🔨 Standardize e as error
* 🔨 Standardize err as error
* ⚡ Fix error handling for non-standard nodes
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Harshil Agrawal
a503c0e86b
⚡ Add new codex files and fix previous files ( #1608 )
...
* ✨ Add new codex files and fixed previous files
* 🔨 Minor fix
* 🔨 Minor fix
2021-04-10 10:18:10 +02:00
Iván Ovejero
7be61e2f23
✨ Add Lemlist node ( #1506 )
...
* 🎉 Register node and credentials
* ⚡ Add credentials file
* 🎨 Add SVG icon
* ⚡ Add generic functions file
* ⚡ Add preliminary node stub
* ⚡ Add resource description stubs
* ⚡ Extract get CSV from getAll
* ⚡ Implement lead:create
* ⚡ Implement all lead operations
* ⚡ Implement unsubscribe:create and delete
* ⚡ Preload campaigns
* 🔥 Remove logging
* 🔥 Remove operation per feedback
* 🎨 Prettify error message
* ⚡ Implement unsubscribe:getAll
* ⚡ Add trigger and small improvements
* ⚡ Minor improvement and fixes
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-03-04 10:25:47 +01:00
