Michael Kret
dc844528f4
fix(MySQL Node): Query to statements splitting fix ( #9207 )
2024-04-25 16:30:59 +03:00
Michael Kret
610ead9a38
fix(MySQL Node): Query Parameters parse string to number ( #9011 )
2024-04-09 04:48:17 +03:00
Iván Ovejero
89df277b80
fix(MySQL Node): Set paired items correctly in single query batch mode ( #8940 )
2024-03-21 12:17:43 +01:00
Tomi Turtiainen
9a1cc56806
fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) ( #8363 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Elias Meire
3b01eb60c9
fix(MySQL Node): Only escape table names when needed ( #8246 )
2024-01-10 14:41:00 +01:00
Elias Meire
048b588852
fix: Make params panel double width for all SQL nodes ( #8236 )
...
## Summary
Make params panel double width for all SQL nodes
<img width="1445" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/422e7c6c-90c9-4cf0-832b-fab7679275d3 ">
## Related tickets and issues
https://linear.app/n8n/issue/NODE-986/make-all-sql-nodes-have-a-double-width-params-pane
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-05 12:31:11 +01:00
Elias Meire
071e6d6b6e
feat(editor): Add fullscreen view to code editor ( #8084 )
...
## Summary
<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a ">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe ">
1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed
It should work the same way for HTML/SQL/JSON editors
⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 17:23:24 +01:00
Iván Ovejero
0ca2759d75
refactor: Optimize SVG icons for nodes ( #8195 )
...
Running `svgo` to optimize icon size for nodes.
2024-01-02 17:40:08 +01:00
Jon
97e39c39d9
docs: Replace references to set node (no-changelog) ( #7973 )
...
## Summary
This replaces the set node references with edit fields.
Ref: https://n8nio.slack.com/archives/C036PA5D42D/p1702040900165709
2023-12-11 10:10:03 +00:00
Iván Ovejero
e77fd5d286
refactor: Switch plain errors in nodes-base
to ApplicationError
(no-changelog) ( #7914 )
...
Ensure all errors in `nodes-base` are `ApplicationError` or children of
it and contain no variables in the message, to continue normalizing all
the backend errors we report to Sentry. Also, skip reporting to Sentry
errors from user input and from external APIs. In future we should
refine `ApplicationError` to more specific errors.
Follow-up to: [#7877 ](https://github.com/n8n-io/n8n/pull/7877 )
- [x] Test workflows:
https://github.com/n8n-io/n8n/actions/runs/7084627970
- [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-05 11:17:08 +01:00
Iván Ovejero
62c096710f
refactor: Run lintfix
(no-changelog) ( #7537 )
...
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
कारतोफ्फेलस्क्रिप्ट™
b6de910cbe
refactor(core): Abstract away InstanceSettings and encryptionKey
into injectable services (no-changelog) ( #7471 )
...
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
2023-10-23 13:39:35 +02:00
Michael Kret
5c46bb09c1
fix(MySQL Node): Resolve expressions in v1 ( #7464 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-20 11:09:39 +03:00
Michael Kret
e2c3c7aceb
fix(core): Missing pairing info ( #7326 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-10 18:36:20 +03:00
कारतोफ्फेलस्क्रिप्ट™
597669aa62
refactor(core): Move copyInputItems
to node helpers (no-changelog) ( #7299 )
2023-10-06 16:25:58 +02:00
Michael Kret
3a474552b2
feat(Set Node): Overhaul ( #6348 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/pull/6348
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-09-19 13:16:35 +03:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473
refactor(core): Deprecate prepareOutputData
(no-changelog) ( #7091 )
2023-09-05 12:59:02 +02:00
Michael Kret
176ccd62bc
fix(Postgres Node): Empty return data fix for Postgres and MySQL ( #7016 )
2023-08-25 18:38:09 +03:00
Jon
0e075c9cb5
fix: Fix issue with key formatting introduced in 1.2.0 ( #6896 )
2023-08-09 16:23:35 +01:00
Jon
db21a8db75
fix: Fix issue with key based credentials not being read correctly ( #6824 )
2023-08-09 12:30:53 +01:00
Iván Ovejero
24ce141815
refactor: Clear unused ESLint directives from nodes-base (no-changelog) ( #6812 )
...
* refactor: Clear unused ESLint directives from nodes-base (no-changelog)
* removed unused disable directives
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 15:32:33 +02:00
Michael Kret
aaa9ee3949
fix(Postgres Node): Upsert does not fetch columns when schema other then public ( #6643 )
2023-07-12 13:26:46 +03:00
कारतोफ्फेलस्क्रिप्ट™
e57e85edf7
refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) ( #6631 )
2023-07-12 11:15:38 +02:00
Iván Ovejero
beedfb609c
feat(editor): SQL editor overhaul ( #6282 )
...
* Draft setup
* ⚡ Implemented expression evaluation in Postgres node, minor SQL editor UI improvements, minor refacring
* ⚡ Added initial version of expression preview for SQL editor
* ⚡ Linking npm package for codemirror sql grammar instead of a local file
* ⚡ Moving expression editor wrapper elements to the component
* ⚡ Using expression preview in SQL editor
* Use SQL parser skipping whitespace
* ✨ Added support for custom skipped segments specification
* ✨ Fixing highlight problems with dots and expressions that resolve to zero
* 👕 Fixing linting error
* ✨ Added current item support
* ⚡ Added expression support to more nodes with sql editor
* ✨ Added expression support for other nodes
* ✨ Implemented different SQL dialect support
* 🐛 Fixing hard-coded parameter names for editors
* ✨ Fixing preview for nested queries, updating query when input data changes, adding keyboard shortcut to toggle comments
* ✨ Adding a custom automcomplete notice for different editors
* ⚡ Updating SQL autocomplete notice
* ✅ Added unit tests for SQL editor
* ⚡ Using latest grammar
* 🐛 Fixing code node editor rendering
* 💄 SQL preview dropdown matches editor width. Removing unnecessary css
* ⚡ Addressing PR review feedback
* 👌 Addressing PR review feedback pt2
* 👌 Added path alias for utils in nodes-base package
* 👌 Addressing more PR review feedback
* ✅ Adding tests for `getResolvables` utility function
* ⚡ Fixing lodash imports
* 👌 Better focus handling, adding more plugins to the editor, other minor imrovements
* ⚡ Not showing SQL autocomplete suggestions inside expressions
* ⚡ Using npm package for sql grammar
* ⚡ Removing autocomplete notice, adding line highlight on syntax error
* 👌 Addressing code review feedback
---------
Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2023-06-22 16:47:28 +02:00
Michael Kret
5d77ec76e3
fix(MySQL Node): Node should return date types as strings ( #6169 )
2023-05-03 18:45:21 +03:00
Michael Kret
cb497fbbec
feat(core): Add notice to alert users a new version is available
2023-05-02 11:45:04 +03:00
Jan Oberhauser
70aaf24784
feat(editor): Add SQL editor support ( #5517 )
2023-04-25 18:18:27 +02:00
Jon
871d4193e2
docs: Remove version notice from overhauled nodes (no-changelog) ( #6071 )
2023-04-24 13:21:26 +01:00
कारतोफ्फेलस्क्रिप्ट™
308a94311f
refactor: Async functions don't need to explicitly return promises (no-changelog) ( #6041 )
2023-04-24 13:17:08 +02:00
Michael Kret
0a53c957c4
feat(MySQL Node): Overhaul
2023-04-12 17:24:17 +03:00
कारतोफ्फेलस्क्रिप्ट™
7a4e9ef5fa
refactor: Remove n8n-core dependency in nodes-base (no-changelog) ( #5649 )
2023-03-09 18:13:15 +01:00
Michael Kret
bb4db58819
fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog)
2023-02-28 05:39:43 +02:00
agobrech
f1589d4f0f
feat: Add Required path name mapping to multiple nodes ( #5369 )
...
* ✨ Add requiresDataPath to Set
* Add Data path mapping to rename keys
* Add required path name to airtable
* Add required data path
* Add required data path to airtable trigger
* Fix multiple keyword for required path
* ⚡ ️use multiple for Airtable ignore fields
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-02-21 14:49:59 +01:00
Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports
in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05
.
* 👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
e667df783c
fix(core): Revert rule @typescript-eslint/prefer-nullish-coalescing
2023-01-19 14:37:19 +02:00
Michael Kret
6608e69457
refactor(core): Remove linting exceptions in nodes-base (no-changelog) ( #4944 )
2023-01-13 18:11:56 +01:00
Iván Ovejero
fbb8611ae2
refactor: Deprecate alwaysOpenEditWindow
for string
( #4839 )
...
* 🔥 Remove from client
* 📘 Update interface comment
* ✏️ Update docs
* ⚡ Update nodes
* ✏️ Fix typo
* ⏪ Restore misremoved property
* 🔥 Remove more instances
2022-12-07 15:29:45 +01:00
Michael Kret
61e26804ba
refactor(core): Remove linting exceptions in nodes-base ( #4794 )
...
* ⚡ enabled array-type
* ⚡ await-thenable on
* ⚡ ban-types on
* ⚡ default-param-last on
* ⚡ dot-notation on
* ⚡ member-delimiter-style on
* ⚡ no-duplicate-imports on
* ⚡ no-empty-interface on
* ⚡ no-floating-promises on
* ⚡ no-for-in-array on
* ⚡ no-invalid-void-type on
* ⚡ no-loop-func on
* ⚡ no-shadow on
* ⚡ ban-ts-comment re enabled
* ⚡ @typescript-eslint/lines-between-class-members on
* address my own comment
* @typescript-eslint/return-await on
* @typescript-eslint/promise-function-async on
* @typescript-eslint/no-unnecessary-boolean-literal-compare on
* @typescript-eslint/no-unnecessary-type-assertion on
* prefer-const on
* @typescript-eslint/prefer-optional-chain on
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Iván Ovejero
cfd32d2642
refactor: Phase out TSLint in nodes-base
(no-changelog) ( #4798 )
...
* 🔥 Remove TSLint scripts
* 🔥 Remove TSLint config
* 🔥 Remove TSLint exceptions
* 👕 Adjust lint config
* ✏️ Add story numbers
2022-12-02 15:25:21 +01:00
Iván Ovejero
632f573021
refactor(core): Introduce overload for string-type node parameter (no-changelog) ( #4797 )
...
* 📘 Set up overload
* 🔥 Remove inferrable assertions
2022-12-02 12:53:59 +01:00
Michael Kret
479644a499
refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ ( #4523 )
...
* ⚡ rule and fixes
* ⚡ clean up
2022-11-08 15:28:21 +01:00
Michael Kret
9d6a2c32d7
refactor(core): fixes n8n-local-rules/no-json-parse-json-stringify warnings ( #4407 )
...
* 🔨 fixes
* 🔨 set rule to error
2022-10-21 17:24:58 +02:00
Marcus
9a06c6df25
feat(MySql Node): use resource locator component for table parameter ( #4313 )
...
insert/update operation table parameter as resource locator
2022-10-12 11:54:38 +02:00
agobrech
8bd99e0600
docs: remove impertinent Jsdocs comments (no-changelog) ( #4181 )
...
* 🔥 Remove impertinent Jsdocs comments
* Lint fixes
2022-09-29 14:37:56 +02:00
Mike Arvela
6e8e4f5937
fix(nodes-base): fix and harmonize all primaryDocumentation links ( #4191 )
...
* fix(nodes-base): fix and harmonize all primaryDocumentation links
* feat(workflow, cli): expose documentation links to UI via node codex
* fix(editor-ui): link to correct node and credential documentation URLs
* config(nodes-base): update 'format' script to also format node descriptor json
* chore: fix outdated links to node reference documentation
2022-09-29 13:33:16 +03:00
agobrech
d82e87979d
feature: add database and non http credentials test
...
Add credential testing to Postgres, MySQL, MicrosoftSQL, Redis, FTP, SFTP, IMAP, RabbitMQ and MQTT
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2022-09-01 14:29:15 +02:00
Omar Ajoue
b2c674591c
Feature/paired item support ( #3869 )
...
* Add paired item helper and implement it in some nodes
2022-08-30 17:55:33 +02:00
Michael Kret
91d7e16c81
n8n-3867-progressively-apply-prettier-to-all ( #3873 )
...
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
Iván Ovejero
6f95121fac
refactor: Add action
to all operations on all nodes ( #3655 )
...
* 👕 Add `action` to `INodePropertyOptions`
* 👕 Apply `node-param-operation-option-without-action`
* ✏️ Fix add/remove phrasing
* ✏️ Fix email template phrasing
* ✏️ Fix add/remove phrasing
* ✏️ Fix custom fields phrasing
* ✏️ Fix job report phrasing
* ✏️ Fix query phrasing
* ✏️ Various phrasing fixes
* ✏️ Fix final phrasings
* ✏️ Remove `conversation`
* ✏️ Fix plural
2022-07-10 23:50:51 +03:00
Iván Ovejero
88dea330b9
refactor: Apply more eslint-plugin-n8n-nodes-base
rules ( #3534 )
...
* ⚡ Update `lintfix` script
* ⚡ Run baseline `lintfix`
* 🔥 Remove unneeded exceptions (#3538 )
* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`
* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`
* ⚡ Update version
* 👕 Apply `node-param-placeholder-missing` (#3542 )
* 👕 Apply `filesystem-wrong-cred-filename` (#3543 )
* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-class-description-empty-string` (#3546 )
* 👕 Apply `node-class-description-icon-not-svg` (#3548 )
* 👕 Apply `filesystem-wrong-node-filename` (#3549 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Expand lintings to credentials (#3550 )
* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552 )
* ⚡ fix
* ⚡ Minor fixes
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541 )
* ⚡ Add new lint rule, node-param-description-wrong-for-dynamic-multi-options
* ⚡ Fix with updated linting rules
* ⚡ Minor fixes
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-boolean-without-whether` (#3553 )
* ⚡ fix
* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537 )
* 👕 Add exceptions
* 👕 Add exception
* ✏️ Alphabetize rules
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-06-20 07:54:01 -07:00