Commit graph

6148 commits

Author SHA1 Message Date
Milorad FIlipović 96a109a57c
fix(editor): Fix conflicting hover states between sticky button and node view (#3368)
* 🐛 Fixing conflicting hover states between sticky button and node view.

* 🔨 Updating and optimizing sticky menu hover logic

* 📇 Removing redundant comments from `NodeView`.
2022-05-27 17:04:14 +02:00
Alex Grozav 993554f22a
fix(core): Prevent expressions XSS (#3366)
*  Added checks for window object access in template strings.

*  Added self, prompt and confirm to blocklist. Changed window usage condition.
2022-05-27 17:00:51 +02:00
Jan Oberhauser 1910299a88 fix(core): Fix issue that "closeFunction" got called twice 2022-05-27 16:05:16 +02:00
Jan Oberhauser 02cdec1416 📚 Update CHANGELOG.md with version 0.178.2 2022-05-25 10:27:09 +02:00
Jan Oberhauser ab54109551 🔖 Update main package.json to 0.178.2 2022-05-25 10:25:48 +02:00
Jan Oberhauser d24232d0c4 🔖 Release n8n@0.178.2 2022-05-25 10:24:05 +02:00
Jan Oberhauser 582f73afbb ⬆️ Set n8n-editor-ui@0.144.2 on n8n 2022-05-25 10:23:35 +02:00
Jan Oberhauser f42a16b190 🔖 Release n8n-editor-ui@0.144.2 2022-05-25 10:22:25 +02:00
Mutasem Aldmour c7c2061590
fix(editor): Fix parameter loading bug (#3374)
* fix parameter loading bug

* remove duplicate check
2022-05-25 10:15:51 +02:00
Jan Oberhauser 1de364e2a6 📚 Update CHANGELOG.md with version 0.178.1 2022-05-24 18:33:39 +02:00
Jan Oberhauser 7c00ab0ec6 🔖 Update main package.json to 0.178.1 2022-05-24 18:32:59 +02:00
Jan Oberhauser 1199493826 🔖 Release n8n@0.178.1 2022-05-24 18:30:50 +02:00
Jan Oberhauser 5b6cfce818 ⬆️ Set n8n-editor-ui@0.144.1 on n8n 2022-05-24 18:30:13 +02:00
Jan Oberhauser 96d75017d1 🔖 Release n8n-editor-ui@0.144.1 2022-05-24 18:28:42 +02:00
Mutasem Aldmour c5fc3bc45e
fix(editor): Fix problem with HTTP Request Node 1 credentials to be set (#3371) 2022-05-24 18:26:31 +02:00
Jan Oberhauser e5d9a7b20f 📚 Update CHANGELOG.md with version 0.178.0 2022-05-24 11:53:01 +02:00
Jan Oberhauser 99910e9160 🔖 Update main package.json to 0.178.0 2022-05-24 11:51:11 +02:00
Jan Oberhauser b6bdfa46da 🔖 Release n8n@0.178.0 2022-05-24 09:49:50 +00:00
Jan Oberhauser b73a2a1cdc ⬆️ Set n8n-core@0.118.0, n8n-editor-ui@0.144.0, n8n-nodes-base@0.176.0 and n8n-workflow@0.100.0 on n8n 2022-05-24 09:49:50 +00:00
Jan Oberhauser 67a369a1cc 🔖 Release n8n-editor-ui@0.144.0 2022-05-24 09:48:30 +00:00
Jan Oberhauser 36b49cb635 ⬆️ Set n8n-design-system@0.21.0 and n8n-workflow@0.100.0 on n8n-editor-ui 2022-05-24 09:48:30 +00:00
Jan Oberhauser 27782a01f5 🔖 Release n8n-design-system@0.21.0 2022-05-24 09:48:21 +00:00
Jan Oberhauser b7879e5652 🔖 Release n8n-nodes-base@0.176.0 2022-05-24 09:47:35 +00:00
Jan Oberhauser d376d01b98 ⬆️ Set n8n-core@0.118.0 and n8n-workflow@0.100.0 on n8n-nodes-base 2022-05-24 09:47:34 +00:00
Jan Oberhauser 22ab6fcb4d 🔖 Release n8n-node-dev@0.57.0 2022-05-24 09:47:28 +00:00
Jan Oberhauser 1f36a124f4 ⬆️ Set n8n-core@0.118.0 and n8n-workflow@0.100.0 on n8n-node-dev 2022-05-24 09:47:28 +00:00
Jan Oberhauser 5e84bbb32f 🔖 Release n8n-core@0.118.0 2022-05-24 09:47:19 +00:00
Jan Oberhauser 35105219c3 ⬆️ Set n8n-workflow@0.100.0 on n8n-core 2022-05-24 09:47:19 +00:00
Jan Oberhauser faccefcfa6 🔖 Release n8n-workflow@0.100.0 2022-05-24 09:47:08 +00:00
Jan Oberhauser c5ee8944b3 ⬆️ Update package-lock.json file 2022-05-24 11:46:28 +02:00
Iván Ovejero 336fc9e2a8
feat(core): Allow credential reuse on HTTP Request node (#3228)
*  Create controller

*  Mount controller

* ✏️ Add error messages

*  Create scopes fetcher

*  Account for non-existent credential type

* 📘 Type scopes request

*  Adjust error message

* 🧪 Add tests

*  Introduce simple node versioning

*  Add example how to read version in node-code for custom logic

* 🐛 Fix setting of parameters

* 🐛 Fix another instance where it sets the wrong parameter

*  Remove unnecessary TOODs

*  Re-version HTTP Request node

* 👕 Satisfy linter

*  Retrieve node version

*  Undo Jan's changes to Set node

* 🧪 Fix CI/CD for `/oauth2-credential` tests (#3230)

* 🐛 Fix notice warning missing background color (#3231)

* 🐛 Check for generic auth in node cred types

*  Refactor credentials dropdown for HTTP Request node (#3222)

*  Discoverability flow (#3229)

*  Added node credentials type proxy. Changed node credentials input order.

*  Add computed property from versioning branch

* 🐛 Fix cred ref lost and unsaved

*  Make options consistent with cred type names

*  Use prop to set component order

*  Use constant and version

*  Fix rendering for generic auth creds

*  Mark as required on first selection

*  Implement discoverability flow

*  Mark as required on subsequent selections

*  Fix marking as required after cred deletion

*  Refactor to clean up

*  Detect position automatically

*  Add i18n to option label

*  Hide subtitle for custom action

*  Detect active credential type

*  Prop drilling to re-render select

* 🔥 Remove unneeded property

* ✏️ Rename arg

* 🔥 Remove unused import

* 🔥 Remove unneeded getters

* 🔥 Remove unused import

*  Generalize cred component positioning

*  Set up request

* 🐛 Fix edge case in endpoint

*  Display scopes alert box

*  Revert "Generalize cred comp positioning"

This reverts commit 75eea89273.

*  Consolidate HTTPRN check

*  Fix hue percentage to degree

* 🔥 Remove unused import

* 🔥 Remove unused import

* 🔥 Remove unused class

* 🔥 Remove unused import

* 📘 Create type for HTTPRN v2 auth params

* ✏️ Rename check

* 🔥 Remove unused import

* ✏️ Add i18n to `reportUnsetCredential()`

*  Refactor Alex's spacing changes

*  Post-merge fixes

*  Add docs link

* 🔥 Exclude Notion OAuth cred

* ✏️ Update copy

* ✏️ Rename param

* 🎨 Reposition notice and simplify styling

* ✏️ Update copy

* ✏️ Update copy

*  Hide params during custom action

*  Show notice if any cred type supported

* 🐛 Prevent scopes text overflow

* 🔥 Remove superfluous check

* ✏️ Break up docstring

* 🎨 Tweak notice styling

*  Reorder cred param in Webhook node

* ✏️ Shorten cred name in scopes notice

* 🧪 Update Notice snapshots

* 🐛 Fix check when `globalRole` is `undefined`

*  Revert 3f2c4a6

*  Apply feedback from Product

* 🧪 Update snapshot

*  Adjust regex expansion pattern for singular

* 🔥 Remove unused import

* 🔥 Remove logging

*  Make `somethingElse` key more unique

*  Move something else to constants

*  Consolidate notice component

*  Apply latest feedback

* 🧪 Update tests

* 🧪 Update snapshot

* ✏️ Fix singular version

* 🧪 Finalize tests

* ✏️ Rename constant

* 🧪 Expand tests

* 🔥 Remove `truncate` prop

* 🚚 Move scopes fetching to store

* 🚚 Move method to component

*  Use constant

*  Refactor `Notice` component

* 🧪 Update tests

* 🔥 Remove unused keys

*  Inject custom API call option

* 🔥 Remove unused props

* 🎨 Use `compact` prop

* 🧪 Update snapshots

* 🚚 Move scopes to store

* 🚚 Move `nodeCredentialTypes` to parent

* ✏️ Rename cred types per branding

* 🐛 Clear scopes when none

*  Add default

* 🚚 Move `newHttpRequestNodeCredentialType` to parent

* 🔥 Remove test data

*  Separate lines for readability

*  Change reference from node to node name

* ✏️ Rename i18n keys

*  Refactor OAuth check

* 🔥 Remove unused key

* 🚚 Move `OAuth1/2 API` to i18n

*  Refactor `skipCheck`

*  Add `stopPropagation` and `preventDefault`

* 🚚 Move active credential scopes logic to store

* 🎨 Fix spacing for `NodeWebhooks` component

*  Implement feedback

*  Update HTTPRN default and issue copy

* Refactor to use `CredentialsSelect` param (#3304)

*  Refactor into cred type param

*  Componentize scopes notice

* 🔥 Remove unused data

* 🔥 Remove unused `loadOptions`

*  Componentize `NodeCredentialType`

* 🐛 Fix param validation

* 🔥 Remove dup methods

*  Refactor all references to `isHttpRequestNodeV2`

* 🎨 Fix styling

* 🔥 Remove unused import

* 🔥 Remove unused properties

* 🎨 Fix spacing for Pipedrive Trigger node

* 🎨 Undo Webhook node styling change

* 🔥 Remove unused style

*  Cover `httpHeaderAuth` edge case

* 🐛 Fix `this.node` reference

* 🚚 Rename to `credentialsSelect`

* 🐛 Fix mistaken renaming

*  Set one attribute per line

*  Move condition to instantiation site

* 🚚 Rename prop

*  Refactor away `prepareScopesNotice`

* ✏️ Rename i18n keys

* ✏️ Update i18n calls

* ✏️ Add more i18n keys

* 🔥 Remove unused props

* ✏️ Add explanatory comment

*  Adjust check in `hasProxyAuth`

*  Refactor `credentialSelected` from prop to event

*  Eventify `valueChanged`, `setFocus`, `onBlur`

*  Eventify `optionSelected`

*  Add `noDataExpression`

* 🔥 Remove logging

* 🔥 Remove URL from scopes

*  Disregard expressions for display

* 🎨 Use CSS modules

* 📘 Tigthen interface

* 🐛 Fix generic auth display

* 🐛 Fix generic auth validation

* 📘 Loosen type

* 🚚 Move event params to end

*  Generalize reference

*  Refactor generic auth as `credentialsSelect` param

*  Restore check for `httpHeaderAuth `

* 🚚 Rename `existing` to `predefined`

* Extend metrics for HTTP Request node (#3282)

*  Extend metrics

* 🧪 Add tests

*  Update param names

Co-authored-by: Alex Grozav <alex@grozav.com>

*  Update check per new branch

*  Include generic auth check

*  Adjust telemetry (#3359)

*  Filter credential types by label

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2022-05-24 11:36:19 +02:00
Jan Oberhauser 0212d65dae
fix(Slack Node): Fix Channel->Kick (#3365) 2022-05-24 09:12:10 +02:00
Michael Kret 90a1bc120b
feat(Salesforce Node): Add country field (#3314) 2022-05-24 08:56:33 +02:00
maxtkacz 5c5de0c92c
refactor(editor): Updated Welcome sticky content (#3362)
* Updated Welcome sticky content

* 🎨 Update dimensions of sticky

* 🎨 Update position

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-05-23 21:37:22 +02:00
Mutasem Aldmour 3af0abd9e0
feat(editor): Add input panel to NDV (#3204)
* refactor tabs out

* refactor execute button

* refactor header

* add more views

* fix error view

* fix workflow rename bug

* rename component

* fix small screen bug

* move items, fix positions

* add hover state

* show selector on empty state

* add empty run state

* fix binary view

* 1 item

* add vjs styles

* show empty row for every item

* refactor tabs

* add branch names

* fix spacing

* fix up spacing

* add run selector

* fix positioning

* clean up

* increase width of selector

* fix up spacing

* fix copy button

* fix branch naming; type issues

* fix docs in custom nodes

* add type

* hide items when run selector is shown

* increase selector size

* add select prepend

* clean up a bit

* Add pagination

* add stale icon

* enable stale data in execution run

* Revert "enable stale data in execution run"

8edb68dbff

* move metadata to its own state

* fix smaller size

* add scroll buttons

* update tabs on resize

* update stale data on rename

* remove metadata on delete

* hide x

* change title colors

* binary data classes

* remove duplicate css

* add colors

* delete unused keys

* use event bus

* refactor header out

* support different nodes

* update selector

* add immediate input

* add branch overrides

* split output input run index

* clean up unnessary data

* add missing keys

* update key names

* remove unnessary css/js

* fix outputs panel

* set max width on input selector

* fix selector to show parent nodes

* fix bug when switching between nodes

* add linking and refactor

* add linking

* fix minor issues

* hide linking when cannot link

* fix type

* fix error state

* clean up import

* fix linking edge cases

* hide input panel for triggers

* disable for start node

* format file

* refactor output panel

* add empty input hint

* update too much data view

* update slot, message under branch

* no input data view

* add node not run/no output data views

* add tooltip support on execute prev

* fix spacing in view

* address output views

* fix run node hint view

* fix spinner

* center button

* update message to use node name

* update title of no output data message

* implement loading states

* fix sizes

* fix sizes

* update spinner

* add wire me up image

* update link

* update panels design

* fix unclickable area bug

* revert change

* fix clickable bg

* fix up positioning

* ensure bg is clickable

* fix up borders

* fix height

* move border to wrapper

* set box shadow

* set box shadow

* add drag button

* add dragging for main panel

* set max width of panels

* set min width in js

* keep showing drag while dragging

* fix dragging leaving modal

* update trigger position of main panel

* move main panel position into store

* clear metadata after changing workflow

* center grid correctly

* add drag arrows

* add dragging hover

* fix cursor behavior

* update no output state

* show last run on open

* always set to latest run

* fix padding

* add I wish this node would

* clean up unsued data

* inject run info into run

* refactor out drag button

* fix dragging issue

* fix arrow bug

* increase width of panel

* change run logic

* set label font sizes

* update radiobutton pos

* address header issues

* fix prev spacing bug

* fix input order

* set package lock

* add close modal event

* complete close modal event

* add input change event

* add dragging event

* add event on view change

* add page size event

* rename event

* add event on page change

* add link click event

* add linking event

* rename var

* add run change event

* add button events

* add branch event

* add structure for open event

* add input type

* set session id

* set sessionid/source for expression events

* add params to expression events

* make display modes global

* add display mode to tracking

* add more event tracking

* add has_mapping param

* make main panel position global

* dedupe list

* fix cursor while dragging

* address feedback

* reduce bottom scrim

* remove empty option hint

* add hint tooltip

* add tritary button

* update param names

* update parameter buttons

* center empty states

* move feature request message

* increase max width for inputs selector

* fix error dispaly padding

* remove immediate

* refactor search logic to return object

* fix console errors

* fix console errors

* add node distance

* refactor how input nodes listed

* remove console log

* set package lock

* refactor recursive logic

* handle overrides

* handle default case without inputs

* fix bug width link

* fix tabs arrow bug

* handle binary data case

* update node execution

* fix merge logic

* remove console log

* delete func

* update package lock

* add hover area

* switch first input node

* keep recursive order

* make breadth first traversal

* fix overflow bug, add pluralization

* update docs url

* update drop shadow

* set background color for button

* update input

* fix truncation

* update index of input dropdown

* fix binary background

* update telemetry

* fix binary data switching

* check all parent connections for executed node

* check current state for executing node

* fix executing states

* update loading states

* use pluralization for items

* rename modal

* update pluralization

* update package lock

* update empty messagE

* format file

* refactor out dragging logic

* refactor out dragging

* add back panel position

* add telemetry params

* add survey url as const

* remove extra space, add dot

* rename tabs, update telemetery, fix telemetry bug

* update execute prev button

* rename workflow func

* rename workflow func

* delete unnessary component

* fix build issue

* add tests for workflow search

* format + add tests

* remove todo comment

* update iconnection type to match workflows

* Revert "update iconnection type to match workflows"

3772487d98

* update func comment

* fix formatting issues

* add tertiary story

* add spinner story

* remove todo comment

* remove eslint check

* update empty messagE
2022-05-23 17:56:15 +02:00
Jan Oberhauser 061e36e8ab build: Fix docker custom build 2022-05-21 09:42:12 +02:00
Jan Oberhauser 68db12ce6d fix(editor): Do not display diving line unless necessary 2022-05-20 23:49:27 +02:00
Iván Ovejero 6dcdb30bf4
refactor: Apply more nodelinting rules (#3324)
* ✏️ Alphabetize lint rules

* 🔥 Remove duplicates

*  Update `lintfix` script

* 👕 Apply `node-param-operation-without-no-data-expression` (#3329)

* 👕 Apply `node-param-operation-without-no-data-expression`

* 👕 Add exceptions

* 👕 Apply `node-param-description-weak` (#3328)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-value-duplicate` (#3331)

* 👕 Apply `node-param-description-miscased-json` (#3337)

* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-type-options-missing-from-limit` (#3336)

* Rule workig as intended

* ✏️ Uncomment rules

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-name-duplicate` (#3338)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-wrong-for-simplify` (#3334)

*  fix

*  exceptions

*  changed rule ignoring from file to line

* 👕 Apply `node-param-resource-without-no-data-expression` (#3339)

* 👕 Apply `node-param-display-name-untrimmed` (#3341)

* 👕 Apply `node-param-display-name-miscased-id` (#3340)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-resource-with-plural-option` (#3342)

* 👕 Apply `node-param-description-wrong-for-upsert` (#3333)

*  fix

*  replaced record with contact in description

*  fix

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-description-identical-to-name` (#3343)

* 👕 Apply `node-param-option-name-containing-star` (#3347)

* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348)

* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345)

*  fix

*  exceptions

* 👕 Apply node-param-display-name-wrong-for-simplify (#3344)

* Rule working as intended

* Uncomented other rules

* 👕 Undo and add exceptions

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

*  Alphabetize lint rules

*  Restore `lintfix` script

Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
2022-05-20 23:47:24 +02:00
Iván Ovejero e7fa0ae883
test(core): Skip SMTP tests if service unavailable (#3293) 2022-05-20 21:28:05 +02:00
Milorad FIlipović 29ddac30d3
fix(editor): Do not display welcome sticky in template workflows (#3320)
* 🐛 Stopping a welcome sticky note to show up in template workflows

* add space

Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2022-05-20 12:04:52 +02:00
Ben Hesseldieck a0b5ad357b
test: Enhance owner completion test (#3175) 2022-05-19 17:57:23 +02:00
Jonathan Bennetts 8cb58bcbdc
build(core): Fix cli build issue under windows (#3322) 2022-05-19 16:33:23 +02:00
Tom 680c9684cb
Sort out typo in error message (#3307) 2022-05-17 12:00:26 +02:00
Milorad FIlipović 17f98384a0
Fix a typo in welcome experience telemetry event (#3308) 2022-05-17 11:59:28 +02:00
Jan Oberhauser df683d4b1a 📚 Update n8n screenshot 2022-05-17 11:01:47 +02:00
Jan Oberhauser 8ccb4f6eca 📚 Remove screenshot width 2022-05-17 10:54:13 +02:00
Jan Oberhauser c43fc4e978 📚 Update n8n video and formatting 2022-05-17 10:46:06 +02:00
Jan Oberhauser 2a54f3eaf5 📚 Update n8n screenshot 2022-05-17 10:36:11 +02:00
Jan Oberhauser 7f16a71415 📚 Update CHANGELOG.md with version 0.177.0 2022-05-16 18:35:32 +02:00
Jan Oberhauser edb4dd31ef 🔖 Update main package.json to 0.177.0 2022-05-16 18:35:11 +02:00