Iván Ovejero
f667b384c9
refactor(core): Standardize filenames in cli (no-changelog) ( #10484 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-08-22 11:10:37 +02:00
कारतोफ्फेलस्क्रिप्ट™
65c5609ab5
feat(core): Use WebCrypto to generate all random numbers and strings ( #9786 )
2024-06-19 13:33:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
56c8791aff
refactor(core): Remove all legacy auth middleware code (no-changelog) ( #8755 )
2024-02-28 13:12:28 +01:00
कारतोफ्फेलस्क्रिप्ट™
d6deceacde
refactor(core): Remove roleId indirection (no-changelog) ( #8413 )
2024-01-24 13:38:57 +01:00
Iván Ovejero
c378f60a25
refactor(core): Introduce password utility (no-changelog) ( #7979 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
Continue breaking down `UserManagementHelper.ts`
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-11 18:23:42 +01:00
कारतोफ्फेलस्क्रिप्ट™
3460eb5eeb
fix(core): Initialize JWT Secret before it's used anywhere ( #7707 )
...
HELP-394
2023-11-15 12:17:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
000e76e3b4
ci(core): Reduce memory usage in tests (part-2) (no-changelog) ( #7671 )
...
This also gets rid of `Db.collection`, which was another source of
circular dependencies.
2023-11-10 15:04:26 +01:00
कारतोफ्फेलस्क्रिप्ट™
0346b211a7
ci(core): Reduce memory usage in tests (part-1) (no-changelog) ( #7654 )
2023-11-08 16:29:39 +01:00
कारतोफ्फेलस्क्रिप्ट™
60314248f4
fix(core): Make password-reset urls valid only for single-use ( #7622 )
2023-11-07 15:35:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
b6de910cbe
refactor(core): Abstract away InstanceSettings and encryptionKey into injectable services (no-changelog) ( #7471 )
...
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
2023-10-23 13:39:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
55c6a1b0d3
fix(core): Do not return inviteAcceptUrl in response if email was sent ( #7465 )
2023-10-19 13:58:06 +02:00
Ricardo Espinoza
d47986aec3
fix: Bug when trailing user reset password on instance (no-changelog) ( #7250 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 09:55:33 -04:00
Ricardo Espinoza
303bc8e71e
fix: Issue enforcing user limits on start plan ( #7188 )
2023-09-21 05:56:40 -04:00
कारतोफ्फेलस्क्रिप्ट™
eeb49e9375
ci: Fix tests on postgres (no-changelog)
2023-07-25 00:11:33 +02:00
Ricardo Espinoza
89f44021b9
fix(core): Use JWT as reset password token ( #6714 )
...
* use jwt to reset password
* increase expiration time to 1d
* drop user id query string
* refactor
* use service instead of package in tests
* sqlite migration
* postgres migration
* mysql migration
* remove unused properties
* remove userId from FE
* fix test for users.api
* move migration to the common folder
* move type assertion to the jwt.service
* Add jwt secret as a readonly property
* use signData instead of sign in user.controller
* remove base class
* remove base class
* add tests
2023-07-24 17:40:17 -04:00
कारतोफ्फेलस्क्रिप्ट™
b895ba438a
refactor(core): Reduce boilterplate code in between tests 🧹 , and fix the tests in node.js 20 (no-changelog) ( #6654 )
...
refactor(core): Reduce boilterplate code in between tests
also cleaned up some imports, and fixed the tests in node.js 20
2023-07-13 10:14:48 +02:00
Iván Ovejero
06fa6f1fb3
ci: Expand ESLint to tests in BE packages (no-changelog) ( #6147 )
...
* 🔧 Adjust base ESLint config
* 🔧 Adjust `lint` and `lintfix` in `nodes-base`
* 🔧 Include `test` and `utils` in `nodes-base`
* 📘 Convert JS tests to TS
* 👕 Apply lintfixes
2023-05-02 10:37:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
5bcab8fcbe
fix(core): Password reset should pass in the correct values to external hooks ( #5842 )
2023-03-30 16:44:39 +02:00
Michael Auerswald
2216455760
feat(core): Prevent non owners password reset when saml is enabled ( #5788 )
...
* prevent non owners from pw reset when saml is enabled
* improve tests
* change error type
2023-03-30 12:44:53 +02:00
कारतोफ्फेलस्क्रिप्ट™
6242cac53b
ci: Refactor cli tests to speed up CI (no-changelog) ( #5718 )
...
* ci: Refactor cli tests to speed up CI (no-changelog)
* upgrade jest to address memory leaks
2023-03-17 17:24:05 +01:00
कारतोफ्फेलस्क्रिप्ट™
845f0f9d20
refactor(core): Switch over all user-management routes to use decorators ( #5115 )
2023-01-27 11:19:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
0a5ab560b1
refactor: Upgrade typeorm to 0.3.x ( #5151 )
2023-01-13 18:12:22 +01:00
Michael Auerswald
b67f803cbe
feat: Add global event bus ( #4860 )
...
* fix branch
* fix deserialize, add filewriter
* add catchAll eventGroup/Name
* adding simple Redis sender and receiver to eventbus
* remove native node threads
* improve eventbus
* refactor and simplify
* more refactoring and syslog client
* more refactor, improved endpoints and eventbus
* remove local broker and receivers from mvp
* destination de/serialization
* create MessageEventBusDestinationEntity
* db migrations, load destinations at startup
* add delete destination endpoint
* pnpm merge and circular import fix
* delete destination fix
* trigger log file shuffle after size reached
* add environment variables for eventbus
* reworking event messages
* serialize to thread fix
* some refactor and lint fixing
* add emit to eventbus
* cleanup and fix sending unsent
* quicksave frontend trial
* initial EventTree vue component
* basic log streaming settings in vue
* http request code merge
* create destination settings modals
* fix eventmessage options types
* credentials are loaded
* fix and clean up frontend code
* move request code to axios
* update lock file
* merge fix
* fix redis build
* move destination interfaces into workflow pkg
* revive sentry as destination
* migration fixes and frontend cleanup
* N8N-5777 / N8N-5789 N8N-5788
* N8N-5784
* N8N-5782 removed event levels
* N8N-5790 sentry destination cleanup
* N8N-5786 and refactoring
* N8N-5809 and refactor/cleanup
* UI fixes and anonymize renaming
* N8N-5837
* N8N-5834
* fix no-items UI issues
* remove card / settings label in modal
* N8N-5842 fix
* disable webhook auth for now and update ui
* change sidebar to tabs
* remove payload option
* extend audit events with more user data
* N8N-5853 and UI revert to sidebar
* remove redis destination
* N8N-5864 / N8N-5868 / N8N-5867 / N8N-5865
* ui and licensing fixes
* add node events and info bubbles to frontend
* ui wording changes
* frontend tests
* N8N-5896 and ee rename
* improves backend tests
* merge fix
* fix backend test
* make linter happy
* remove unnecessary cfg / limit actions to owners
* fix multiple sentry DSN and anon bug
* eslint fix
* more tests and fixes
* merge fix
* fix workflow audit events
* remove 'n8n.workflow.execution.error' event
* merge fix
* lint fix
* lint fix
* review fixes
* fix merge
* prettier fixes
* merge
* review changes
* use loggerproxy
* remove catch from internal hook promises
* fix tests
* lint fix
* include review PR changes
* review changes
* delete duplicate lines from a bad merge
* decouple log-streaming UI options from public API
* logstreaming -> log-streaming for consistency
* do not make unnecessary api calls when log streaming is disabled
* prevent sentryClient.close() from being called if init failed
* fix the e2e test for log-streaming
* review changes
* cleanup
* use `private` for one last private property
* do not use node prefix package names.. just yet
* remove unused import
* fix the tests
because there is a folder called `events`, tsc-alias is messing up all imports for native events module.
https://github.com/justkey007/tsc-alias/issues/152
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-01-04 09:47:48 +01:00
कारतोफ्फेलस्क्रिप्ट™
698d96a617
refactor: Setup typescript project references across workflow, core, and cli ( #4519 )
...
* refactor: use consistent folder structure across workflow, core, and cli
* setup typescript project references across workflow, core, and cli
2022-11-09 15:25:00 +01:00
Iván Ovejero
eefd594074
test: Mock mailer service ( #3711 )
...
* 🧪 Mock mailer service
* 🔥 Remove unneeded imports
2022-07-14 22:07:07 +02:00
Iván Ovejero
f8eb5aa52a
🧪 Add missing SMTP timeout
2022-06-30 15:53:43 +02:00
Ricardo Espinoza
a18081d749
feat: Add n8n Public API ( #3064 )
...
* ✨ Inicial setup
* ⚡ Add authentication handler
* ⚡ Add GET /users route
* ⚡ Improvements
* 👕 Fix linting issues
* ⚡ Add GET /users/:identifier endpoint
* ⚡ Add POST /users endpoint
* ⚡ Add DELETE /users/:identifier endpoint
* ⚡ Return error using express native functions
* 👕 Fix linting issue
* ⚡ Possibility to add custom middleware
* ⚡ Refactor POST /users
* ⚡ Refactor DELETE /users
* ⚡ Improve cleaning function
* ⚡ Refactor GET /users and /users/:identifier
* ⚡ Add API spec to route
* ⚡ Add raw option to response helper
* 🐛 Fix issue adding custom middleware
* ⚡ Enable includeRole parameter in GET /users/:identifier
* ⚡ Fix linting issues after merge
* ⚡ Add missing config variable
* ⚡ General improvements
⚡ asasas
* ⚡ Add POST /users tests
* Debug public API tests
* Fix both sets of tests
* ⚡ Improvements
* ⚡ Load api versions dynamically
* ⚡ Add endpoints to UM to create/delete an API Key
* ⚡ Add index to apiKey column
* 👕 Fix linting issue
* ⚡ Clean open api spec
* ⚡ Improvements
* ⚡ Skip tests
* 🐛 Fix bug with test
* ⚡ Fix issue with the open api spec
* ⚡ Fix merge issue
* ⚡ Move token enpoints from /users to /me
* ⚡ Apply feedback to openapi.yml
* ⚡ Improvements to api-key endpoints
* 🐛 Fix test to suport API dynamic loading
* ⚡ Expose swagger ui in GET /{version}/docs
* ⚡ Allow to disable public api via env variable
* ⚡ Change handlers structure
* 🚧 WIP create credential, delete credential complete
* 🐛 fix route for creating api key
* ⚡ return api key of authenticated user
* ⚡ Expose public api activation to the settings
* ⬆️ Update package-lock.json file
* ⚡ Add execution resource
* ⚡ Fix linting issues
* 🛠 conditional public api endpoints excluding
* ⚡ ️ create credential complete
* ✨ Added n8n-card component. Added spacing utility classes.
* ♻️ Made use of n8n-card in existing components.
* ✨ Added api key setup view.
* ✨ Added api keys get/create/delete actions.
* ✨ Added public api permissions handling.
* ♻️ Temporarily disabling card tests.
* ♻️ Changed translations. Storing api key only in component.
* ✨ Added utilities storybook entry
* ♻️ Changed default value for generic copy input.
* 🧹 clean up createCredential
* ⚡ Add workflow resource to openapi spec
* 🐛 Fix naming with env variable
* ⚡ Allow multifile openapi spec
* ⚡ Add POST /workflows/:workflowId/activate
* fix up view, fix issues
* remove delete api key modal
* remove unused prop
* clean up store api
* remove getter
* remove unused dispatch
* fix component size to match
* use existing components
* match figma closely
* fix bug when um is disabled in sidebar
* set copy input color
* remove unused import
* ⚡ Remove css path
* ⚡ Add POST /workflows/:workflowId/desactivate
* ⚡ Add POST /workflows
* Revert "⚡ Remove css path"
a3d0a71719b70e29433e886e5164fb⚡ PUT /workflows/:workflowId
* ⚡ Refactor workflow endpoints
* ⚡ Refactor executions endpoints
* ⚡ Fix typo
* ✅ add credentials tests
* ✅ adjust users tests
* update text
* add try it out link
* ⚡ Add delete, getAll and get to the workflow resource
* address spacing comments
* ⚡ ️ apply correct structure
* ⚡ Add missing test to user resource and fix some issues
* ⚡ Add workflow tests
* ⚡ Add missing workflow tests and fix some issues
* ⚡ Executions tests
* ⚡ finish execution tests
* ⚡ Validate credentials data depending on type
* ⚡ ️ implement review comments
* 👕 fix lint issues
* ⚡ Add apiKey to sanatizeUser
* ⚡ Fix issues with spec and tests
* ⚡ Add new structure
* ⚡ Validate credentials type and properties
* ⚡ Make all endpoints except /users independent on UM
* ⚡ Add instance base path to swagger UI
* ⚡ Remove testing endpoints
* ⚡ Fix issue with openapi tags
* ⚡ Add endpoint GET /credentialTypes/:id/schema
* 🐛 Fix issue adding json middleware to public api
* ⚡ Add API playground path to FE
* ⚡ Add telemetry and external hooks
* 🐛 Fix issue with user tests
* ⚡ Move /credentialTypes under /credentials
* ⚡ Add test to GET /credentials/schema/:id
* 🛠 refactor schema naming
* ⚡ Add DB migrations
asas
* ✅ add tests for crd apiKey
* ✨ Added API View telemetry events.
* ⚡ Remove rsync from the building process as it is missing on alpine base image
* ⚡ add missing BE telemetry events
* 🐛 Fix credential tests
* ⚡ address outstanding feedback
* 🔨 Remove move:openapi script
* ⬆️ update dependency
* ⬆️ update package-lock.json
* 👕 Fix linting issue
* 🐛 Fix package.json issue
* 🐛 fix migrations and tests
* 🐛 fix typos + naming
* 🚧 WIP fixing tests
* ⚡ Add json schema validation
* ⚡ Add missing fields to node schema
* ⚡ Add limit max upper limit
* ⚡ Rename id paths
* 🐛 Fix tests
* Add package-lock.jsonto custom dockerfile
* ⬆️ Update package-lock.json
* 🐛 Fix issue with build
* ✏️ add beta label to api view
* 🔥 Remove user endpoints
* ⚡ Add schema examples to GET /credentials/schema/:id
* 🔥 Remove user endpoints tests
* 🐛 Fix tests
* 🎨 adapt points from design review
* 🔥 remove unnecessary text-align
* ⚡ ️ update UI
* 🐛 Fix issue with executions filter
* ⚡ Add tags filter to GET /workflows
* ⚡ Add missing error messages
* ✅ add and update public api tests
* ✅ add tests for owner activiating/deactivating non-owned wfs
* 🧪 add tests for filter for tags
* 🧪 add tests for more filter params
* 🐛 fix inclusion of tags
* 🛠 enhance readability
* ⚡ ️ small refactorings
* 💄 improving readability/naming
* ⚡ Set API latest version dinamically
* Add comments to toJsonSchema function
* ⚡ Fix issue
* ⚡ Make execution data usable
* ⚡ Fix validation issue
* ⚡ Rename data field and change parameter and options
* 🐛 Fix issue parameter "detailsFieldFormat" not resolving correctly
* Skip executions tests
* skip workflow failing test
* Rename details property to data
* ⚡ Add includeData parameter
* 🐛 Fix issue with openapi spec
* 🐛 Fix linting issue
* ⚡ Fix execution schema
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-06-08 20:53:12 +02:00
Iván Ovejero
e7fa0ae883
test(core): Skip SMTP tests if service unavailable ( #3293 )
2022-05-20 21:28:05 +02:00
Iván Ovejero
5e2589e626
refactor: Remove reintroduced non-null assertions in Db calls ( #3162 )
...
* 🔥 Remove reintroduced non-null assertions
* 🔥 Remove duplicate cred references
* 🔥 Remove unneeded `@ts-ignore`
* 🔥 Remove another `@ts-ignore`
* 🔥 Remove outdated suite version
* 🔥 Remove leftover non-null assertion
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
* 🔥 Remove more leftovers
* 🔥 Remove unneeded optional chaining operators
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2022-04-28 18:39:57 +02:00
Iván Ovejero
bc5749b7ae
test(core): Implement timeout in SMTP tests ( #3152 )
...
* ⚡ Implement timeout in SMTP tests
* 🚚 Move timeout to constants
2022-04-22 12:38:53 +02:00
Ben Hesseldieck
8532b0030d
fix(core): Make email for UM case insensitive ( #3078 )
...
* 🚧 lowercasing email
* ✅ add tests for case insensitive email
* 🐘 add migration to lowercase email
* 🚚 rename migration
* 🐛 fix package.lock
* 🐛 fix double import
* 📋 add todo
2022-04-15 08:11:35 +02:00
Iván Ovejero
027dfb2f0a
⚡ Enable esModuleInterop compiler option and upgrade to TypeScript 4.6 ( #3106 )
...
* ⚡ Enable `esModuleInterop` for /core
* ⚡ Adjust imports in /core
* ⚡ Enable `esModuleInterop` for /cli
* ⚡ Adjust imports in /cli
* ⚡ Enable `esModuleInterop` for /nodes-base
* ⚡ Adjust imports in /nodes-base
* ⚡ Make imports consistent
* ⬆️ Upgrade TypeScript to 4.6 (#3109 )
* ⬆️ Upgrade TypeScript to 4.6
* 📦 Update package-lock.json
* 🔧 Avoid erroring on untyped errors
* 📘 Fix type error
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-04-08 23:32:08 +02:00
Iván Ovejero
1e2d6daaa3
🚨 Optimize UM tests ( #3066 )
...
* ⚡ Declutter test logs
* 🐛 Fix random passwords length
* 🐛 Fix password hashing in test user creation
* 🐛 Hash leftover password
* ⚡ Improve error message for `compare`
* ⚡ Restore `randomInvalidPassword` contant
* ⚡ Mock Telemetry module to prevent `--forceExit`
* 🔥 Remove unused imports
* 🔥 Remove unused import
* ⚡ Add util for configuring test SMTP
* ⚡ Isolate user creation
* 🔥 De-duplicate `createFullUser`
* ⚡ Centralize hashing
* 🔥 Remove superfluous arg
* 🔥 Remove outdated comment
* ⚡ Prioritize shared tables during trucation
* 🧪 Add login tests
* ⚡ Use token helper
* ✏️ Improve naming
* ⚡ Make `createMemberShell` consistent
* 🔥 Remove unneeded helper
* 🔥 De-duplicate `beforeEach`
* ✏️ Improve naming
* 🚚 Move `categorize` to utils
* ✏️ Update comment
* 🧪 Simplify test
* 📘 Improve `User.password` type
* ⚡ Silence logger
* ⚡ Simplify condition
* ⚡ Unhash password in payload
* 🐛 Fix comparison against unhashed password
* ⚡ Increase timeout for fake SMTP service
* 🔥 Remove unneeded import
* ⚡ Use `isNull()`
* 🧪 Use `Promise.all()` in creds tests
* 🧪 Use `Promise.all()` in me tests
* 🧪 Use `Promise.all()` in owner tests
* 🧪 Use `Promise.all()` in password tests
* 🧪 Use `Promise.all()` in users tests
* ⚡ Re-set cookie if UM disabled
* 🔥 Remove repeated line
* ⚡ Refactor out shared owner data
* 🔥 Remove unneeded import
* 🔥 Remove repeated lines
* ⚡ Organize imports
* ⚡ Reuse helper
* 🚚 Rename tests to match routers
* 🚚 Rename `createFullUser()` to `createUser()`
* ⚡ Consolidate user shell creation
* ⚡ Make hashing async
* ⚡ Add email to user shell
* ⚡ Optimize array building
* 🛠 refactor user shell factory
* 🐛 Fix MySQL tests
* ⚡ Silence logger in other DBs
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
2022-04-08 18:37:07 +02:00
