Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
61e26804ba
refactor(core): Remove linting exceptions in nodes-base ( #4794 )
...
* ⚡ enabled array-type
* ⚡ await-thenable on
* ⚡ ban-types on
* ⚡ default-param-last on
* ⚡ dot-notation on
* ⚡ member-delimiter-style on
* ⚡ no-duplicate-imports on
* ⚡ no-empty-interface on
* ⚡ no-floating-promises on
* ⚡ no-for-in-array on
* ⚡ no-invalid-void-type on
* ⚡ no-loop-func on
* ⚡ no-shadow on
* ⚡ ban-ts-comment re enabled
* ⚡ @typescript-eslint/lines-between-class-members on
* address my own comment
* @typescript-eslint/return-await on
* @typescript-eslint/promise-function-async on
* @typescript-eslint/no-unnecessary-boolean-literal-compare on
* @typescript-eslint/no-unnecessary-type-assertion on
* prefer-const on
* @typescript-eslint/prefer-optional-chain on
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Iván Ovejero
1c229a7b52
refactor(core): apply lint rule cred-class-field-unobscured-sensitive-input ( #4495 )
...
* ⬆️ Upgrade linter
* 📦 Update `package-lock.json`
* 👕 Enable rule
* 👕 Apply rule
* 📦 Re-update `package-lock.json`
2022-11-01 17:41:45 +01:00
Iván Ovejero
57afd480ab
refactor: Format all credentials ( #3720 )
...
* Apply Prettier to all credentials
* Fix quotes for lint
* 👕 Remove `quotemark` rule
* 👕 Run Prettier to take over quotes
* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`
* 📦 Update `package-lock.json`
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-07-24 17:36:17 +02:00
Iván Ovejero
59f2e8e7d5
refactor: Apply more eslint-plugin-n8n-nodes-base rules ( #3624 )
...
* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`
* 📦 Update `package-lock.json`
* 🔧 Adjust renamed filesystem rules
* ✏️ Alphabetize ruleset
* ⚡ Categorize overrides
* ⚡ Set renamings in lint exceptions
* ⚡ Run baseline `lintfix`
* ⚡ Update linting scripts
* 👕 Apply `node-param-description-missing-from-dynamic-multi-options`
* 👕 Apply `cred-class-field-name-missing-oauth2` (#3627 )
* Rule working as intended
* Removed comments
* Move cred rule to different rule set
* 👕 Apply `node-param-array-type-assertion`
* 👕 Apply `node-dirname-against-convention`
* Apply `cred-class-field-display-name-oauth2` (#3628 )
* Apply `node-execute-block-wrong-error-thrown`
* Apply `node-class-description-display-name-unsuffixed-trigger-node`
* Apply `node-class-description-name-unsuffixed-trigger-node`
* Apply `cred-class-name-missing-oauth2-suffix` (#3636 )
* Rule working as intended, add exception to existing nodes
* 👕 Apply `cred-class-field-name-uppercase-first-char` (#3638 )
* ⬆️ Upgrade to plugin version 1.2.28
* 📦 Update `package-lock.json`
* 👕 Update lintings with 1.2.8 change
* 👕 Apply `cred-class-field-name-unsuffixed`
* 👕 Apply `cred-class-name-unsuffixed`
* 👕 Apply `node-class-description-credentials-name-unsuffixed`
* ✏️ Alphabetize rules
* ➖ Remove `nodelinter` package
* 📦 Update `package-lock.json`
* ⚡ Consolidate `lint` and `lintfix` scripts
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
2022-07-04 11:12:08 +02:00
Iván Ovejero
88dea330b9
refactor: Apply more eslint-plugin-n8n-nodes-base rules ( #3534 )
...
* ⚡ Update `lintfix` script
* ⚡ Run baseline `lintfix`
* 🔥 Remove unneeded exceptions (#3538 )
* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`
* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`
* ⚡ Update version
* 👕 Apply `node-param-placeholder-missing` (#3542 )
* 👕 Apply `filesystem-wrong-cred-filename` (#3543 )
* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-class-description-empty-string` (#3546 )
* 👕 Apply `node-class-description-icon-not-svg` (#3548 )
* 👕 Apply `filesystem-wrong-node-filename` (#3549 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Expand lintings to credentials (#3550 )
* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552 )
* ⚡ fix
* ⚡ Minor fixes
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541 )
* ⚡ Add new lint rule, node-param-description-wrong-for-dynamic-multi-options
* ⚡ Fix with updated linting rules
* ⚡ Minor fixes
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-boolean-without-whether` (#3553 )
* ⚡ fix
* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537 )
* 👕 Add exceptions
* 👕 Add exception
* ✏️ Alphabetize rules
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-06-20 07:54:01 -07:00
Ricardo Espinoza
e29c5975e1
feat(core): Add "Client Credentials" grant type to OAuth2 ( #3489 )
...
* ⚡ Add OAuth2 client credentials grant type
* ⚡ Improvements
* 🐛 Fix linting issue
* 🐛 Fix typo
* 🐛 Fix small issue with type
* 🐛 When token expire get a new one instead of refreshing it
* ⚡ Fix issue that it did not display it correctly for OAuth1
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-06-13 22:27:19 -07:00
Iván Ovejero
336fc9e2a8
feat(core): Allow credential reuse on HTTP Request node ( #3228 )
...
* ✨ Create controller
* ⚡ Mount controller
* ✏️ Add error messages
* ✨ Create scopes fetcher
* ⚡ Account for non-existent credential type
* 📘 Type scopes request
* ⚡ Adjust error message
* 🧪 Add tests
* ✨ Introduce simple node versioning
* ⚡ Add example how to read version in node-code for custom logic
* 🐛 Fix setting of parameters
* 🐛 Fix another instance where it sets the wrong parameter
* ⚡ Remove unnecessary TOODs
* ✨ Re-version HTTP Request node
* 👕 Satisfy linter
* ⚡ Retrieve node version
* ⏪ Undo Jan's changes to Set node
* 🧪 Fix CI/CD for `/oauth2-credential` tests (#3230 )
* 🐛 Fix notice warning missing background color (#3231 )
* 🐛 Check for generic auth in node cred types
* ⚡ Refactor credentials dropdown for HTTP Request node (#3222 )
* ⚡ Discoverability flow (#3229 )
* ✨ Added node credentials type proxy. Changed node credentials input order.
* ⚡ Add computed property from versioning branch
* 🐛 Fix cred ref lost and unsaved
* ⚡ Make options consistent with cred type names
* ⚡ Use prop to set component order
* ⚡ Use constant and version
* ⚡ Fix rendering for generic auth creds
* ⚡ Mark as required on first selection
* ⚡ Implement discoverability flow
* ⚡ Mark as required on subsequent selections
* ⚡ Fix marking as required after cred deletion
* ⚡ Refactor to clean up
* ⚡ Detect position automatically
* ⚡ Add i18n to option label
* ⚡ Hide subtitle for custom action
* ⚡ Detect active credential type
* ⚡ Prop drilling to re-render select
* 🔥 Remove unneeded property
* ✏️ Rename arg
* 🔥 Remove unused import
* 🔥 Remove unneeded getters
* 🔥 Remove unused import
* ⚡ Generalize cred component positioning
* ⚡ Set up request
* 🐛 Fix edge case in endpoint
* ⚡ Display scopes alert box
* ⏪ Revert "Generalize cred comp positioning"
This reverts commit 75eea89273⚡ Consolidate HTTPRN check
* ⚡ Fix hue percentage to degree
* 🔥 Remove unused import
* 🔥 Remove unused import
* 🔥 Remove unused class
* 🔥 Remove unused import
* 📘 Create type for HTTPRN v2 auth params
* ✏️ Rename check
* 🔥 Remove unused import
* ✏️ Add i18n to `reportUnsetCredential()`
* ⚡ Refactor Alex's spacing changes
* ⚡ Post-merge fixes
* ⚡ Add docs link
* 🔥 Exclude Notion OAuth cred
* ✏️ Update copy
* ✏️ Rename param
* 🎨 Reposition notice and simplify styling
* ✏️ Update copy
* ✏️ Update copy
* ⚡ Hide params during custom action
* ⚡ Show notice if any cred type supported
* 🐛 Prevent scopes text overflow
* 🔥 Remove superfluous check
* ✏️ Break up docstring
* 🎨 Tweak notice styling
* ⚡ Reorder cred param in Webhook node
* ✏️ Shorten cred name in scopes notice
* 🧪 Update Notice snapshots
* 🐛 Fix check when `globalRole` is `undefined`
* ⏪ Revert 3f2c4a6⚡ Apply feedback from Product
* 🧪 Update snapshot
* ⚡ Adjust regex expansion pattern for singular
* 🔥 Remove unused import
* 🔥 Remove logging
* ⚡ Make `somethingElse` key more unique
* ⚡ Move something else to constants
* ⚡ Consolidate notice component
* ⚡ Apply latest feedback
* 🧪 Update tests
* 🧪 Update snapshot
* ✏️ Fix singular version
* 🧪 Finalize tests
* ✏️ Rename constant
* 🧪 Expand tests
* 🔥 Remove `truncate` prop
* 🚚 Move scopes fetching to store
* 🚚 Move method to component
* ⚡ Use constant
* ⚡ Refactor `Notice` component
* 🧪 Update tests
* 🔥 Remove unused keys
* ⚡ Inject custom API call option
* 🔥 Remove unused props
* 🎨 Use `compact` prop
* 🧪 Update snapshots
* 🚚 Move scopes to store
* 🚚 Move `nodeCredentialTypes` to parent
* ✏️ Rename cred types per branding
* 🐛 Clear scopes when none
* ⚡ Add default
* 🚚 Move `newHttpRequestNodeCredentialType` to parent
* 🔥 Remove test data
* ⚡ Separate lines for readability
* ⚡ Change reference from node to node name
* ✏️ Rename i18n keys
* ⚡ Refactor OAuth check
* 🔥 Remove unused key
* 🚚 Move `OAuth1/2 API` to i18n
* ⚡ Refactor `skipCheck`
* ⚡ Add `stopPropagation` and `preventDefault`
* 🚚 Move active credential scopes logic to store
* 🎨 Fix spacing for `NodeWebhooks` component
* ⚡ Implement feedback
* ⚡ Update HTTPRN default and issue copy
* Refactor to use `CredentialsSelect` param (#3304 )
* ⚡ Refactor into cred type param
* ⚡ Componentize scopes notice
* 🔥 Remove unused data
* 🔥 Remove unused `loadOptions`
* ⚡ Componentize `NodeCredentialType`
* 🐛 Fix param validation
* 🔥 Remove dup methods
* ⚡ Refactor all references to `isHttpRequestNodeV2`
* 🎨 Fix styling
* 🔥 Remove unused import
* 🔥 Remove unused properties
* 🎨 Fix spacing for Pipedrive Trigger node
* 🎨 Undo Webhook node styling change
* 🔥 Remove unused style
* ⚡ Cover `httpHeaderAuth` edge case
* 🐛 Fix `this.node` reference
* 🚚 Rename to `credentialsSelect`
* 🐛 Fix mistaken renaming
* ⚡ Set one attribute per line
* ⚡ Move condition to instantiation site
* 🚚 Rename prop
* ⚡ Refactor away `prepareScopesNotice`
* ✏️ Rename i18n keys
* ✏️ Update i18n calls
* ✏️ Add more i18n keys
* 🔥 Remove unused props
* ✏️ Add explanatory comment
* ⚡ Adjust check in `hasProxyAuth`
* ⚡ Refactor `credentialSelected` from prop to event
* ⚡ Eventify `valueChanged`, `setFocus`, `onBlur`
* ⚡ Eventify `optionSelected`
* ⚡ Add `noDataExpression`
* 🔥 Remove logging
* 🔥 Remove URL from scopes
* ⚡ Disregard expressions for display
* 🎨 Use CSS modules
* 📘 Tigthen interface
* 🐛 Fix generic auth display
* 🐛 Fix generic auth validation
* 📘 Loosen type
* 🚚 Move event params to end
* ⚡ Generalize reference
* ⚡ Refactor generic auth as `credentialsSelect` param
* ⏪ Restore check for `httpHeaderAuth `
* 🚚 Rename `existing` to `predefined`
* Extend metrics for HTTP Request node (#3282 )
* ⚡ Extend metrics
* 🧪 Add tests
* ⚡ Update param names
Co-authored-by: Alex Grozav <alex@grozav.com>
* ⚡ Update check per new branch
* ⚡ Include generic auth check
* ⚡ Adjust telemetry (#3359 )
* ⚡ Filter credential types by label
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2022-05-24 11:36:19 +02:00
Iván Ovejero
ecd3bbfcd3
⚡ Fix credential formatting issues ( #3134 )
...
* 👕 Autofix creds lint issues
* 👕 Manually fix creds lint issues
* 👕 Fix indentation
* ✏️ Fix typo
* 👕 Fix indentation
* ✏️ Fix typo
2022-04-14 08:32:27 +02:00
Ricardo Espinoza
1854d505b8
🐛 Set new Hubspot granular scopes ( #2531 )
...
* Hubspot Developer API Credentials: Use granular scopes as contacts scope is no longer available for new apps
* ⚡ Add new scopes to regular node
* ⚡ Small fix
* ⚡ Load contacts, companies and deals from API
Co-authored-by: that-one-tom <19203795+that-one-tom@users.noreply.github.com>
2021-12-10 20:28:59 +01:00
Harshil Agrawal
5ea4dc03b8
⚡ Add OAuth to HubSpot Trigger node credentials ( #2166 )
...
* 🔨 HubSpot Trigger node credentials
* ⚡ Small changes
* ⚡ Add breaking change message
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2021-09-18 22:18:35 +02:00
Iván Ovejero
5481dc3d25
⚡ Simplify property types in credentials ( #1869 )
2021-06-12 18:39:55 +02:00
Ricardo Espinoza
dc98de1ab2
✨ Add support for multiple subscriptions in Hubspot Trigger ( #1358 )
...
* ⚡ Add support for multiple subscriptions in Hubspot Trigger
* ⚡ Load object properties for the user
* ⚡ Improvements
* ⚡ Some improvements to the Hubspot-Node
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-02-01 08:31:40 +01:00
Jan Oberhauser
899ca1a0a8
⚡ Fix naming of Hubspot Developer Credentials
2020-09-23 08:14:24 +02:00
Tanay Pant
815e663717
🔨 Add documentationUrl to credentials
2020-08-17 14:42:09 +02:00
Ricardo Espinoza
84d4f7eab9
✨ Hubspot Trigger
2020-03-08 22:39:20 -04:00
