Iván Ovejero
|
88dea330b9
|
refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)
* ⚡ Update `lintfix` script
* ⚡ Run baseline `lintfix`
* 🔥 Remove unneeded exceptions (#3538)
* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`
* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`
* ⚡ Update version
* 👕 Apply `node-param-placeholder-missing` (#3542)
* 👕 Apply `filesystem-wrong-cred-filename` (#3543)
* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-class-description-empty-string` (#3546)
* 👕 Apply `node-class-description-icon-not-svg` (#3548)
* 👕 Apply `filesystem-wrong-node-filename` (#3549)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Expand lintings to credentials (#3550)
* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)
* ⚡ fix
* ⚡ Minor fixes
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)
* ⚡ Add new lint rule, node-param-description-wrong-for-dynamic-multi-options
* ⚡ Fix with updated linting rules
* ⚡ Minor fixes
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-boolean-without-whether` (#3553)
* ⚡ fix
* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)
* 👕 Add exceptions
* 👕 Add exception
* ✏️ Alphabetize rules
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
|
2022-06-20 07:54:01 -07:00 |
|
|
Iván Ovejero
|
6dcdb30bf4
|
refactor: Apply more nodelinting rules (#3324)
* ✏️ Alphabetize lint rules
* 🔥 Remove duplicates
* ⚡ Update `lintfix` script
* 👕 Apply `node-param-operation-without-no-data-expression` (#3329)
* 👕 Apply `node-param-operation-without-no-data-expression`
* 👕 Add exceptions
* 👕 Apply `node-param-description-weak` (#3328)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-value-duplicate` (#3331)
* 👕 Apply `node-param-description-miscased-json` (#3337)
* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-type-options-missing-from-limit` (#3336)
* Rule workig as intended
* ✏️ Uncomment rules
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-duplicate` (#3338)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-simplify` (#3334)
* ⚡ fix
* ⚡ exceptions
* ⚡ changed rule ignoring from file to line
* 👕 Apply `node-param-resource-without-no-data-expression` (#3339)
* 👕 Apply `node-param-display-name-untrimmed` (#3341)
* 👕 Apply `node-param-display-name-miscased-id` (#3340)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-resource-with-plural-option` (#3342)
* 👕 Apply `node-param-description-wrong-for-upsert` (#3333)
* ⚡ fix
* ⚡ replaced record with contact in description
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-description-identical-to-name` (#3343)
* 👕 Apply `node-param-option-name-containing-star` (#3347)
* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348)
* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345)
* ⚡ fix
* ⚡ exceptions
* 👕 Apply node-param-display-name-wrong-for-simplify (#3344)
* Rule working as intended
* Uncomented other rules
* 👕 Undo and add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Alphabetize lint rules
* ⚡ Restore `lintfix` script
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
|
2022-05-20 23:47:24 +02:00 |
|
|
Iván Ovejero
|
63b6c9f128
|
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules (#3243)
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200)
* Removing unneeded backticks (#3249)
* 👕 Apply node-param-description-wrong-for-return-all (#3253)
* 👕 Apply node-param-description-missing-limit (#3252)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258)
* 👕 Apply `node-param-description-miscased-id` (#3254)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261)
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
|
2022-05-06 23:01:25 +02:00 |
|
|
Iván Ovejero
|
0448feec56
|
refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules (#3174)
* ⚡ Initial setup
* 👕 Update `.eslintignore`
* 👕 Autofix node-param-default-missing (#3173)
* 🔥 Remove duplicate key
* 👕 Add exceptions
* 📦 Update package-lock.json
* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176)
* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177)
* 👕 Apply `node-class-description-outputs-wrong` (#3178)
* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179)
* 👕 Apply `node-param-default-wrong-for-collection` (#3180)
* 👕 Apply node-param-default-wrong-for-boolean (#3181)
* Autofixed default missing
* Autofixed booleans, worked well
* ⚡ Fix params
* ⏪ Undo exempted autofixes
* 📦 Update package-lock.json
* 👕 Apply node-class-description-missing-subtitle (#3182)
* ⚡ Fix missing comma
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184)
* 👕 Add exception for `node-class-description-missing-subtitle`
* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185)
* 👕 Apply `node-param-collection-type-unsorted-items` (#3186)
* Missing coma
* 👕 Apply `node-param-default-wrong-for-simplify` (#3187)
* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190)
* 👕 Apply `node-param-description-empty-string` (#3189)
* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191)
* Rule looks good
* Add whitespace rule in eslint config
* :zao: fix
* 👕 Apply `node-param-description-identical-to-display-name` (#3193)
* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195)
* ⏪ Revert ":zao: fix"
This reverts commit ef8a76f3df.
* 👕 Apply `node-param-description-missing-for-simplify` (#3196)
* 👕 Apply `node-param-description-missing-final-period` (#3194)
* Rule working as intended
* Add rule to eslint
* 👕 Apply node-param-description-missing-for-return-all (#3197)
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
|
2022-04-22 18:29:51 +02:00 |
|
Anuj Kapoor
|
214dd5061e
|
✨ Add Syncromsp node (#2477)
* Init Node
* Added get customer details api for syncomsp-node
* Fixed formatting bug 🐛
* Updated description for query params, and removed redundant condition in router
* Changed default value for page parameter
* 🚢 Added tickets API
* 🚢 Added contacts API
* 🚢 Added RMM Alerts API
* Add customer API
* Updates post code review
* Rename SyncroMspAPI.credentials.ts to SyncroMspApi.credentials.ts
* added create and delete method to customers module
* fix liniting issue
* Added Update method to customer module
* Code Review Changes
* 🚢 Added CRUD for contacts endpoint
* 🚢 Added CRUD for RMM Alert endpoint
* Added options for status field
* 🐛 fix linting issues
* Init Node
* Added get customer details api for syncomsp-node
* Fixed formatting bug 🐛
* Updated description for query params, and removed redundant condition in router
* Changed default value for page parameter
* 🚢 Added tickets API
* 🚢 Added contacts API
* 🚢 Added RMM Alerts API
* Updates post code review
* Add customer API
* added create and delete method to customers module
* fix liniting issue
* Added Update method to customer module
* Rename SyncroMspAPI.credentials.ts to SyncroMspApi.credentials.ts
* Code Review Changes
* 🚢 Added CRUD for contacts endpoint
* 🚢 Added CRUD for RMM Alert endpoint
* Added options for status field
* 🐛 fix linting issues
* 🚢 Added CRUD for ticket endpoint
* :tag: update get customer module
* :tag: update get customer module
* Minor bug fixes
* Changed response for ticket update
* 👕 Fix lint issue
* Alphabetically ordered all options
* 🐛 Fixed build issue
* 🐛 Fixed Server.ts build issue, rebased from master
* ⚡ Fix node issues
* ⚡ Fix more issues
* ⚡ Fixed all operations with the standard convention
* 👕 Fix lint
* Fix reviewed changes
* update border color
* ⚡ minor fixes
* minor fixes
* Added fallback when port in use
* ⚡ Minor Fixes
* ⚡ Hide addtional paramerts when return all is active
* ⚡ Fix issues with Tickets
* ⚡ Fix issues with Rmm
* ⚡ Fix issues with Customer
* 👕 Fix lint
* ⚡ Fix issues with Contact
* 👕 Fixed formatting issue
* ⚡ Return 404 in ID not found
* 👕 Fixed formatting issue
* ⚡ Improvements
* ⚡ Improvements
* ⚡ Improvements
* ⚡ Add credentials verification
* ⚡ Improvements
* ⚡ Improvements
* ⚡ Additional improvements
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
|
2022-01-07 18:19:24 +01:00 |
|