agobrech
67983e8f94
fix: Remove redundant await in node's api request functions without try/catch ( #4639 )
...
* 🐛 Remove useless await for actionNetwork
* 🔥 Remove useless await
* 🔥 Remove useless await keyword to other generic functions
2022-11-22 17:57:17 +01:00
Iván Ovejero
52f38df867
refactor: Remove unused vars to fix build (no-changelog) ( #4584 )
...
* 🔥 Remove unused vars to fix build
* 👕 Make unused vars severity conditional
2022-11-11 16:07:50 +01:00
agobrech
c7133ecd3f
fix(core): Deduplicate error handling in nodes ( #4319 )
...
* Fix issue with isAxios property
* 🥅 Deduplicate errors handeling improve errors for credentials
* 🎨 correctly throws error
2022-11-11 11:32:43 +01:00
Michael Kret
91d7e16c81
n8n-3867-progressively-apply-prettier-to-all ( #3873 )
...
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
Jonathan Bennetts
2710061523
fix(Fix Rocketchat Node): Fix authentication issue ( #3778 )
2022-07-27 10:46:25 +02:00
agobrech
683d2dfc98
feat: Add more credentials tests ( #3668 )
...
* ✨ Add injection to notion,
Add test to notion in cred
* 🔥 Remove unuse method
* 🎨 Move testing from node file to cred file
* ✨ Add injection and testing in facebook graph
* Add cred injec with testing
* Add Cred injection and cred test
* Add cred injection, and cred testing for typeform, fix issue in clickup
* Add cred injection, move testing inside creds
* Add cred injection and cred testing to SendGrid
* Add cred injection and cred testing to woocommerce
* Add cred injection, add cred test to gitlab
* 🔥 Fix duplicated imports in Mautic cred
* 🔥 removed unused credentials testing in node
* Add cred injection, cred testing, handles slash trailing for Grafana node
* Add cred injection, cred testing to shopify
* Add cred injection , add cred testing to stripe
* changed cred injection, add testing to cred for mattermost
* add cred injection and testing for dropbox
* Add cred injection, cred testing to webflow
* ✨ Add cred injection and cred test to nocodb
* ✨ Add cred injection, cred testing to mailchimp
* 🐛 fix a bug In credentials testing
* ✨ Add cred injection, cred testing to sms77
* ✨ Add cred injection, cred testing to ActiveCampaign
* Add cred injection, cred testing to TheHive
* ✨ Add cred injection, add cred testing to ApiTemplateio
* ✨ Add cred injection, add cred testing for zoom
* ✨ Add cred injection, cred testing to rocketchat
* ✨ Add cred injection, add cred test to getResponse
* 🔥 Remove useless authentcate creds and testing from facebookGraphApp
* 🔥 Remove useless imports in FacebookGrappApp credentials file
* 🔥 Removed useless imports and if statement
* 🐛 Add version to header when testing cred
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
2022-07-15 16:20:41 +02:00
Omar Ajoue
d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials ( #3105 )
...
* Centralized error throwing for encryption key
* Unifying the error message used by cli and core packages
* Improvements to error messages to make it more DRY
* Removed unnecessary throw
* Throwing error when credential does not exist to simplify node behavior (#3112 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-04-15 08:00:47 +02:00
Omar Ajoue
7ce7285f7a
⚡ Load credentials from the database ( #1741 )
...
* Changes to types so that credentials can be always loaded from DB
This first commit changes all return types from the execute functions
and calls to get credentials to be async so we can use await.
This is a first step as previously credentials were loaded in memory and
always available. We will now be loading them from the DB which requires
turning the whole call chain async.
* Fix updated files
* Removed unnecessary credential loading to improve performance
* Fix typo
* ⚡ Fix issue
* Updated new nodes to load credentials async
* ⚡ Remove not needed comment
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-08-20 18:57:30 +02:00
Iván Ovejero
1d27a9e87e
✨ Improve node error handling ( #1309 )
...
* Add path mapping and response error interfaces
* Add error handling and throwing functionality
* Refactor error handling into a single function
* Re-implement error handling in Hacker News node
* Fix linting details
* Re-implement error handling in Spotify node
* Re-implement error handling in G Suite Admin node
* 🚧 create basic setup NodeError
* 🚧 add httpCodes
* 🚧 add path priolist
* 🚧 handle statusCode in error, adjust interfaces
* 🚧 fixing type issues w/Ivan
* 🚧 add error exploration
* 👔 fix linter issues
* 🔧 improve object check
* 🚧 remove path passing from NodeApiError
* 🚧 add multi error + refactor findProperty method
* 👔 allow any
* 🔧 handle multi error message callback
* ⚡ change return type of callback
* ⚡ add customCallback to MultiError
* 🚧 refactor to use INode
* 🔨 handle arrays, continue search after first null property found
* 🚫 refactor method access
* 🚧 setup NodeErrorView
* ⚡ change timestamp to Date.now
* 📚 Add documentation for methods and constants
* 🚧 change message setting
* 🚚 move NodeErrors to workflow
* ✨ add new ErrorView for Nodes
* 🎨 improve error notification
* 🎨 refactor interfaces
* ⚡ add WorkflowOperationError, refactor error throwing
* 👕 fix linter issues
* 🎨 rename param
* 🐛 fix handling normal errors
* ⚡ add usage of NodeApiError
* 🎨 fix throw new error instead of constructor
* 🎨 remove unnecessary code/comments
* 🎨 adjusted spacing + updated status messages
* 🎨 fix tab indentation
* ✨ Replace current errors with custom errors (#1576 )
* ⚡ Introduce NodeApiError in catch blocks
* ⚡ Introduce NodeOperationError in nodes
* ⚡ Add missing errors and remove incompatible
* ⚡ Fix NodeOperationError in incompatible nodes
* 🔧 Adjust error handling in missed nodes
PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes
* 🔨 Adjust Strava Trigger node error handling
* 🔨 Adjust AWS nodes error handling
* 🔨 Remove duplicate instantiation of NodeApiError
* 🐛 fix strava trigger node error handling
* Add XML parsing to NodeApiError constructor (#1633 )
* 🐛 Remove type annotation from catch variable
* ✨ Add XML parsing to NodeApiError
* ⚡ Simplify error handling in Rekognition node
* ⚡ Pass in XML flag in generic functions
* 🔥 Remove try/catch wrappers at call sites
* 🔨 Refactor setting description from XML
* 🔨 Refactor let to const in resource loaders
* ⚡ Find property in parsed XML
* ⚡ Change let to const
* 🔥 Remove unneeded try/catch block
* 👕 Fix linting issues
* 🐛 Fix errors from merge conflict resolution
* ⚡ Add custom errors to latest contributions
* 👕 Fix linting issues
* ⚡ Refactor MongoDB helpers for custom errors
* 🐛 Correct custom error type
* ⚡ Apply feedback to A nodes
* ⚡ Apply feedback to missed A node
* ⚡ Apply feedback to B-D nodes
* ⚡ Apply feedback to E-F nodes
* ⚡ Apply feedback to G nodes
* ⚡ Apply feedback to H-L nodes
* ⚡ Apply feedback to M nodes
* ⚡ Apply feedback to P nodes
* ⚡ Apply feedback to R nodes
* ⚡ Apply feedback to S nodes
* ⚡ Apply feedback to T nodes
* ⚡ Apply feedback to V-Z nodes
* ⚡ Add HTTP code to iterable node error
* 🔨 Standardize e as error
* 🔨 Standardize err as error
* ⚡ Fix error handling for non-standard nodes
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Jan Oberhauser
58353d6b8c
👕 Fix lint issue
2021-02-19 13:33:47 +01:00
Jan Oberhauser
70d2a988cc
⚡ Minor improvements on Rocketchat Node
2021-01-24 20:38:16 +01:00
ricardo
4ec458d56b
🐛 Fixes issue handling error responses in Rocketchat node ( #1367 )
2021-01-22 10:19:38 -05:00
Jan Oberhauser
40c2acd77b
👕 Fix lint issue
2020-10-22 15:46:03 +02:00
Jan Oberhauser
fe802c8f76
👕 Fix built issue by fixing lint issues
2020-10-01 15:18:47 +02:00
Jan Oberhauser
e09a4b91ad
🐛 Fix display of errors for rocket.chat
2020-05-08 09:24:33 +02:00
Ricardo Espinoza
5ecc955338
fixed issue with url
2020-01-08 11:06:28 -05:00
Ricardo Espinoza
3a70c3e33d
issue with name fixed
2019-12-01 11:13:35 -05:00
Ricardo Espinoza
ccbf80bce2
Changed subdomain for domain
2019-12-01 11:10:11 -05:00
Ricardo Espinoza
11826d6a4e
fixed tabs issue
2019-11-11 00:00:24 -05:00
Ricardo Espinoza
e9613944db
:sparkles Done
2019-11-09 20:29:05 -05:00
Ricardo Espinoza
edc6651a9b
rocketchat-node-setup
2019-11-08 23:11:01 -05:00
