39 commits

Author	SHA1	Message	Date
कारतोफ्फेलस्क्रिप्ट™	6a35812f92	ci: Setup biome and pre-commit hooks for formatting (no-changelog) (#10795) ... Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>	2024-09-17 15:10:22 +03:00
Michael Kret	5136d10ca3	fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201)	2024-07-26 11:45:00 +03:00
Michael Kret	d1821eba92	fix(Google Sheets Node): Append fails if cells have some default values added by data validation rules (#9950)	2024-07-06 01:05:08 +03:00
Michael Kret	223488f190	fix(Google Sheets Node): Check for column names changes before upsert, append, update (#9649)	2024-06-20 16:19:16 +03:00
कारतोफ्फेलस्क्रिप्ट™	2bdc459bb2	refactor(core): Fix type errors in workflow, core, nodes-langchain, and nodes-base (no-changelog) (#9450)	2024-05-22 17:40:52 +02:00
pengqiseven	8a26f4280a	fix: Typo fixes in various descriptions (no-changelog) (#8854) ... Signed-off-by: pengqiseven <912170095@qq.com> Co-authored-by: pengqiseven <i@sohu.com>	2024-04-29 09:06:32 +01:00
Elias Meire	29ee4fab61	fix(Google Sheets Node): Fix "Append or Update" on an empty sheet (#9175) ... Co-authored-by: Michael Kret <michael.k@radency.com>	2024-04-23 10:29:39 +02:00
Giulio Andreini	5301323906	feat(editor): Improve errors in output panel (#8644) ... Co-authored-by: Michael Kret <michael.k@radency.com>	2024-03-07 18:08:01 +02:00
Michael Kret	a5e522e536	feat(Google Sheets Node): Option how to combine filters when reading rows (#8652)	2024-02-21 09:59:59 +02:00
Tomi Turtiainen	9a1cc56806	fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-17 17:08:50 +02:00
Elias Meire	dce28f9cb9	feat(Google Sheets Node): Add "By Name" option to selector for Sheets (#8241) ... Co-authored-by: Michael Kret <michael.k@radency.com>	2024-01-10 14:30:09 +01:00
Iván Ovejero	1d46983b24	refactor: Unify severity and level for all application errors for Sentry (no-changelog) (#7956) ... ## Summary Unify `severity` and `level` for all backend application errors for Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7914#issuecomment-1840433542 ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 16:57:02 +01:00
Iván Ovejero	e77fd5d286	refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914) ... Ensure all errors in `nodes-base` are `ApplicationError` or children of it and contain no variables in the message, to continue normalizing all the backend errors we report to Sentry. Also, skip reporting to Sentry errors from user input and from external APIs. In future we should refine `ApplicationError` to more specific errors. Follow-up to: [#7877](https://github.com/n8n-io/n8n/pull/7877) - [x] Test workflows: https://github.com/n8n-io/n8n/actions/runs/7084627970 - [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861 --------- Co-authored-by: Michael Kret <michael.k@radency.com>	2023-12-05 11:17:08 +01:00
Michael Kret	88efb99587	fix(Google Sheets Node): Append exceeding grid limits (#7684) ... Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/error-appending-data-with-google-sheets/28691	2023-11-15 11:33:47 +02:00
Iván Ovejero	52f655f3d2	refactor(Google Sheets Node): Stop reporting to Sentry sheet not found error (no-changelog) (#7617) ... https://n8nio.sentry.io/issues/4264383378	2023-11-06 11:36:22 +01:00
Iván Ovejero	d885daa6a1	refactor(Google Sheets Node): Prevent reporting to Sentry failure to find spreadsheet (no-changelog) (#7518) ... To silence this very frequently reported error: https://n8nio.sentry.io/issues/3823103947/?project=4503924908883968&query=&referrer=issue-stream&statsPeriod=90d&stream_index=0	2023-10-26 11:33:11 +02:00
Michael Kret	d8531a53b9	fix(Google Sheets Node): Tweaks (#7357) ... Github issue / Community forum post (link here to close automatically):	2023-10-17 18:41:30 +03:00
Marcus	00268a019a	fix(Google Sheets Node): Fix short sheet name interpreted as range (#6989) ... Github issue / Community forum post (link here to close automatically): https://github.com/n8n-io/n8n/issues/6203	2023-08-22 18:05:54 +02:00
Iván Ovejero	24ce141815	refactor: Clear unused ESLint directives from nodes-base (no-changelog) (#6812) ... * refactor: Clear unused ESLint directives from nodes-base (no-changelog) * removed unused disable directives --------- Co-authored-by: Marcus <marcus@n8n.io>	2023-08-01 15:32:33 +02:00
Michael Kret	b6202b5585	fix(Google Sheets Node): Incorrect read of 0 and false (#6525)	2023-06-27 10:33:21 +02:00
Chris Wu	1111c915f2	refactor(core): Replace lodash's "soft-deprecated" individual packages with lodash to resolve CVE (no-changelog) (#6450) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-06-16 16:26:35 +02:00
Milorad FIlipović	04cfa548af	feat(editor): Implement Resource Mapper component (#6207) ... * ⚡ scaffolding * ⚡ finished scaffolding * ⚡ renamed types * ⚡ updated subtitle * ⚡ renamed functions file, UI updates * ⚡ query parameters fixes, ui updates, refactoring * ⚡ fixes for credentials test, setup for error parsing * ⚡ rlc for schema and table, error handling tweaks * ⚡ delete operation, new options * ⚡ columns loader * ⚡ linter fixes * ⚡ where clauses setup * ⚡ logic for processing where clauses * ⚡ select operation * ⚡ refactoring * ⚡ data mode for insert and update, wip * ⚡ data mapping, insert update, skip on conflict option * ⚡ select columns with spaces fix * ⚡ update operation update, wip * ⚡ finished update operation * ⚡ upsert operation * ⚡ ui fixes * Copy updates. * Copy updates. * ⚡ option to convert empty strings to nulls, schema checks * ⚡ UI requested updates * ⚡ ssh setup WIP * ⚡ fixes, ssh WIP * ⚡ ssh fixes, credentials * ⚡ credentials testing update * ⚡ uncaught error fix * ⚡ clean up * ⚡ address in use fix * ⚡ improved error message * ⚡ tests setup * ⚡ unit tests wip * ⚡ config files clean up * ⚡ utils unit tests * ⚡ refactoring * ⚡ setup for testing operations, tests for deleteTable operation * ⚡ executeQuery and insert operations tests * ⚡ select, update, upsert operations tests * ⚡ runQueries tests setup * ⚡ hint to query * Copy updates. * ⚡ ui fixes * ⚡ clean up * ⚡ error message update * ⚡ ui update * Minor tweaks to query params decription. * feat(Google Sheets Node): Implement Resource mapper in Google Sheets node (#5752) * ✨ Added initial resource mapping support in google sheets node * ✨ Wired mapping API endpoint with node-specific logic for fetching mapping fields * ✨ Implementing mapping fields logic for google sheets * ✨ Updating Google Sheets execute methods to support resource mapper fields * 🚧 Added initial version of `ResourceLocator` component * 👌 Added `update` mode to resource mapper modes * 👌 Addressing PR feedback * 👌 Removing leftover const reference * 👕 Fixing lint errors * ⚡ singlton for conections * ⚡ credentials test fix, clean up * feat(Postgres Node): Add resource mapper to new version of Postgres node (#5814) * ⚡ scaffolding * ⚡ finished scaffolding * ⚡ renamed types * ⚡ updated subtitle * ⚡ renamed functions file, UI updates * ⚡ query parameters fixes, ui updates, refactoring * ⚡ fixes for credentials test, setup for error parsing * ⚡ rlc for schema and table, error handling tweaks * ⚡ delete operation, new options * ⚡ columns loader * ⚡ linter fixes * ⚡ where clauses setup * ⚡ logic for processing where clauses * ⚡ select operation * ⚡ refactoring * ⚡ data mode for insert and update, wip * ⚡ data mapping, insert update, skip on conflict option * ⚡ select columns with spaces fix * ⚡ update operation update, wip * ⚡ finished update operation * ⚡ upsert operation * ⚡ ui fixes * Copy updates. * Copy updates. * ⚡ option to convert empty strings to nulls, schema checks * ⚡ UI requested updates * ⚡ ssh setup WIP * ⚡ fixes, ssh WIP * ⚡ ssh fixes, credentials * ⚡ credentials testing update * ⚡ uncaught error fix * ⚡ clean up * ⚡ address in use fix * ⚡ improved error message * ⚡ tests setup * ⚡ unit tests wip * ⚡ config files clean up * ⚡ utils unit tests * ⚡ refactoring * ⚡ setup for testing operations, tests for deleteTable operation * ⚡ executeQuery and insert operations tests * ⚡ select, update, upsert operations tests * ⚡ runQueries tests setup * ⚡ hint to query * Copy updates. * ⚡ ui fixes * ⚡ clean up * ⚡ error message update * ⚡ ui update * Minor tweaks to query params decription. * ✨ Updated Postgres node to use resource mapper component * ✨ Implemented postgres <-> resource mapper type mapping * ✨ Updated Postgres node execution to use resource mapper fields in v3 * 🔥 Removing unused import --------- Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: Giulio Andreini <g.andreini@gmail.com> * feat(core): Resource editor componend P0 (#5970) * ✨ Added inital value of mapping mode dropdown * ✨ Finished mapping mode selector * ✨ Finished implementing mapping mode selector * ✨ Implemented 'Columns to match on' dropdown * ✨ Implemented `loadOptionsDependOn` support in resource mapper * ✨ Implemented initial version of mapping fields * ✨ Implementing dependant fields watcher in new component setup * ✨ Generating correct resource mapper field types. Added `supportAutoMap` to node specification and UI. Not showing fields with `display=false`. Pre-selecting matching columns if it's the only one * ✨ Handling matching columns correctly in UI * ✨ Saving and loading resourceMapper values in component * ✨ Implemented proper data saving and loading * ✨ ResourceMapper component refactor, fixing value save/load * ✨ Refactoring MatchingColumnSelect component. Updating Sheets node to use single key match and Postgres to use multi key * ✨ Updated Google Sheets node to work with the new UI * ✨ Updating Postgres Node to work with new UI * ✨ Additional loading indicator that shown if there is no mapping mode selector * ✨ Removing hard-coded values, fixing matching columns ordering, refactoring * ✨ Updating field names in nodes * ✨ Fixing minor UI issues * ✨ Implemented matching fields filter logic * ✨ Moving loading label outside of fields list * ✅ Added initial unit tests for resource mapper * ✅ Finished default rendering test * ✅ Test refactoring * ✅ Finished unit tests * 🔨 Updating the way i18n is used in resource mapper components * ✔️ Fixing value to match on logic for postgres node * ✨ Hiding mapping fields when auto-map mode is selected * ✨ Syncing selected mapping mode between components * ✨ Fixing dateTime input rendering and adding update check to Postgres node * ✨ Properly handling database connections. Sending null for empty string values. * 💄 Updated wording in the error message for non-existing rows * ✨ Fixing issues with selected matching values * ✔️ Updating unit tests after matching logic update * ✨ Updating matching columns when new fields are loaded * ✨ Defaulting to null for empty parameter values * ✨ Allowing zero as valid value for number imputs * ✨ Updated list of types that use datepicker as widger * ✨ Using text inputs for time types * ✨ Initial mapping field rework * ✨ Added new component for mapping fields, moved bit of logic from root component to matching selector, fixing some lint errors * ✨ Added tooltip for columns that cannot be deleted * ✨ Saving deleted values in parameter value * ✨ Implemented control to add/remove mapping fields * ✨ Syncing field list with add field dropdown when changing dependent values * ✨ Not showing removed fields in matching columns selector. Updating wording in matching columns selector description * ✨ Implementing disabled states for add/remove all fields options * ✨ Saving removed columns separately, updating copy * ✨ Implemented resource mapper values validation * ✨ Updated validation logic and error input styling * ✨ Validating resource mapper fields when new nodes are added * ✨ Using node field words in validation, refactoring resource mapper component * ✨ Implemented schema syncing and add/remove all fields * ✨ Implemented custom parameter actions * ✨ Implemented loading indicator in parameter options * 🔨 Removing unnecessary constants and vue props * ✨ Handling default values properly * ✨ Fixing validation logic * 👕 Fixing lint errors * ⚡ Fixing type issues * ⚡ Not showing fields by default if `addAllFields` is set to `false` * ✨ Implemented field type validation in resource mapper * ✨ Updated casing in copy, removed all/remove all option from bottom menu * ✨ Added auto mapping mode notice * ✨ Added support for more types in validation * ✨ Added support for enumerated values * ✨ Fixing imports after merging * ✨ Not showing removed fields in matching columns selector. Refactoring validation logic. * 👕 Fixing imports * ✔️ Updating unit tests * ✅ Added resource mapper schema tests * ⚡ Removing `match` from resource mapper field definition, fixing matching columns loading * ⚡ Fixed schema merging * ⚡ update operation return data fix * ⚡ review * 🐛 Added missing import * 💄 Updating parameter actions icon based on the ui review * 💄 Updating word capitalisation in tooltips * 💄 Added empty state to mapping fields list * 💄 Removing asterisk from fields, updating tooltips for matching fields * ⚡ Preventing matching fields from being removed by 'Remove All option' * ⚡ Not showing hidden fields in the `Add field` dropdown * ⚡ Added support for custom matching columns labels * ⚡ query optimization * ⚡ fix * ⚡ Optimizing Postgres node enumeration logic * ⚡ Added empty state for matching columns * ⚡ Only fully loading fields if there is no schema fetched * ⚡ Hiding mapping fields if there is no matching columns available in the schema * ✔️ Fixing minor issues * ✨ Implemented runtime type validation * 🔨 Refactoring validation logic * ✨ Implemented required check, added more custom messages * ✨ Skipping boolean type in required check * Type check improvements * ✨ Only reloading fields if dependent values actually change * ✨ Adding item index to validation error title * ✨ Updating Postgres fetching logic, using resource mapper mode to determine if a field can be deleted * ✨ Resetting field values when adding them via the addAll option * ⚡ Using minor version (2.2) for new Postgres node * ⚡ Implemented proper date validation and type casting * 👕 Consolidating typing * ✅ Added unit tests for type validations * 👌 Addressing front-end review comments * ⚡ More refactoring to address review changes * ⚡ Updating leftover props * ⚡ Added fallback for ISO dates with invalid timezones * Added timestamp to datetime test cases * ⚡ Reseting matching columns if operation changes * ⚡ Not forcing auto-increment fields to be filled in in Postgres node. Handling null values * 💄 Added a custom message for invalid dates * ⚡ Better handling of JSON values * ⚡ Updating codemirror readonly stauts based on component property, handling objects in json validation * Deleting leftover console.log * ⚡ Better time validation * ⚡ Fixing build error after merging * 👕 Fixing lint error * ⚡ Updating node configuration values * ⚡ Handling postgres arrays better * ⚡ Handling SQL array syntax * ⚡ Updating time validation rules to include timezone * ⚡ Sending expressions that resolve to `null` or `undefined` by the resource mapper to delete cell content in Google Sheets * ⚡ Allowing removed fields to be selected for match * ⚡ Updated the query for fetching unique columns and primary keys * ⚡ Optimizing the unique query * ⚡ Setting timezone to all parsed dates * ⚡ Addressing PR review feedback * ⚡ Configuring Sheets node for production, minor vue component update * New cases added to the TypeValidation test. * ✅ Tweaking validation rules for arrays/objects and updating test cases --------- Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: Giulio Andreini <g.andreini@gmail.com>	2023-05-31 11:56:09 +02:00
Michael Kret	0e93fe064e	refactor(core): Forbid raw enums (no-changelog)	2023-04-21 14:23:15 +03:00
Michael Kret	0625e2e6bc	fix(Google Sheets Node): Fix insertOrUpdate cell update with object	2023-03-27 17:56:36 +03:00
कारतोफ्फेलस्क्रिप्ट™	7a4e9ef5fa	refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649)	2023-03-09 18:13:15 +01:00
Alex Grozav	f0695827f5	feat: Migrate packages from lodash to lodash-es (no-changelog) (#5538)	2023-02-23 16:16:05 +01:00
Iván Ovejero	b03e358a12	refactor: Integrate consistent-type-imports in nodes-base (no-changelog) (#5267) ... * 👕 Enable `consistent-type-imports` for nodes-base * 👕 Apply to nodes-base * ⏪ Undo unrelated changes * 🚚 Move to `.eslintrc.js` in nodes-base * ⏪ Revert "Enable `consistent-type-imports` for nodes-base" This reverts commit 529ad72b05. * 👕 Fix severity	2023-01-27 12:22:44 +01:00
Michael Kret	e667df783c	fix(core): Revert rule @typescript-eslint/prefer-nullish-coalescing	2023-01-19 14:37:19 +02:00
Michael Kret	e839a81cc5	feat: (Google Sheets Trigger Node): Trigger for Google Sheets	2023-01-17 15:21:16 +02:00
Michael Kret	6608e69457	refactor(core): Remove linting exceptions in nodes-base (no-changelog) (#4944)	2023-01-13 18:11:56 +01:00
Michael Kret	77031a2950	fix(Google Sheets Node): Fix for auto-range detection	2023-01-06 00:25:28 +02:00
Michael Kret	b5e70d45bf	fix(Google Sheets Node): Append or Update fails for numeric values	2023-01-05 17:31:47 +02:00
Iván Ovejero	d9b98fc8be	refactor: Lint for no unneeded backticks (#5057) (no-changelog) ... * ✨ Create rule `no-unneeded-backticks` * 👕 Enable rule * ⚡ Run rule on `cli` * ⚡ Run rule on `core` * ⚡ Run rule on `workflow` * ⚡ Rule rule on `design-system` * ⚡ Run rule on `node-dev` * ⚡ Run rule on `editor-ui` * ⚡ Run rule on `nodes-base`	2022-12-29 12:20:43 +01:00
कारतोफ्फेलस्क्रिप्ट™	5db9c46043	ci: Break most of the circular dependencies in code (no-changelog) (#4990)	2022-12-21 10:46:26 +01:00
Michael Kret	3bb3809eec	fix(core): Fix linter error (#4808)	2022-12-05 09:31:51 +02:00
Michael Kret	61e26804ba	refactor(core): Remove linting exceptions in nodes-base (#4794) ... * ⚡ enabled array-type * ⚡ await-thenable on * ⚡ ban-types on * ⚡ default-param-last on * ⚡ dot-notation on * ⚡ member-delimiter-style on * ⚡ no-duplicate-imports on * ⚡ no-empty-interface on * ⚡ no-floating-promises on * ⚡ no-for-in-array on * ⚡ no-invalid-void-type on * ⚡ no-loop-func on * ⚡ no-shadow on * ⚡ ban-ts-comment re enabled * ⚡ @typescript-eslint/lines-between-class-members on * address my own comment * @typescript-eslint/return-await on * @typescript-eslint/promise-function-async on * @typescript-eslint/no-unnecessary-boolean-literal-compare on * @typescript-eslint/no-unnecessary-type-assertion on * prefer-const on * @typescript-eslint/prefer-optional-chain on Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2022-12-02 21:54:28 +01:00
Michael Kret	741c7da8b1	fix(Google Sheets Node): Fix for append operation if no empty rows in sheet	2022-12-01 10:39:03 +02:00
Michael Kret	579f9c4d4e	fix(Google Sheets Node): Fix exception if no matching rows are found	2022-11-29 13:29:47 +02:00
Jonathan Bennetts	d96d6f11db	feat(Google Sheets Node): Overhaul of node	2022-11-15 15:57:07 +02:00