Iván Ovejero
70ae90fa3c
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3432 )
...
* ⚡ Update `lintfix` script
* 👕 Remove unneeded lint exceptions
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-description-miscased-url` (#3441 )
* 👕 Apply `rule node-param-placeholder-miscased-id` (#3443 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446 )
* 👕 Apply `node-param-min-value-wrong-for-limit` (#3442 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-wrong-for-dynamic-options` (#3454 )
* 🔨 fix
* ⚡ Fix `Assigned To` fields
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `rule node-param-default-wrong-for-number` (#3453 )
* 👕 Apply `node-param-default-wrong-for-string` (#3452 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-miscased` (#3449 )
* 🔨 fix
* 🔨 exceptions
* ⚡ review fixes
* 👕 Apply `node-param-description-lowercase-first-char` (#3451 )
* ⚡ fix
* ⚡ review fixes
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456 )
* Rule working as intended
* Add rule
* 🔥 Remove repetitions
* 👕 Add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Small fix for `node-param-description-wrong-for-dynamic-options`
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460 )
* 👕 Apply `node-param-description-line-break-html-tag` (#3462 )
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-options-type-unsorted-items` (#3459 )
* ⚡ fix
* 🔨 exceptions
* Add exception for Salesmate and Zoom
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Restore `lintfix` command
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
2022-06-03 19:23:49 +02:00
Iván Ovejero
6dcdb30bf4
refactor: Apply more nodelinting rules ( #3324 )
...
* ✏️ Alphabetize lint rules
* 🔥 Remove duplicates
* ⚡ Update `lintfix` script
* 👕 Apply `node-param-operation-without-no-data-expression` (#3329 )
* 👕 Apply `node-param-operation-without-no-data-expression`
* 👕 Add exceptions
* 👕 Apply `node-param-description-weak` (#3328 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-value-duplicate` (#3331 )
* 👕 Apply `node-param-description-miscased-json` (#3337 )
* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-type-options-missing-from-limit` (#3336 )
* Rule workig as intended
* ✏️ Uncomment rules
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-duplicate` (#3338 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-simplify` (#3334 )
* ⚡ fix
* ⚡ exceptions
* ⚡ changed rule ignoring from file to line
* 👕 Apply `node-param-resource-without-no-data-expression` (#3339 )
* 👕 Apply `node-param-display-name-untrimmed` (#3341 )
* 👕 Apply `node-param-display-name-miscased-id` (#3340 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-resource-with-plural-option` (#3342 )
* 👕 Apply `node-param-description-wrong-for-upsert` (#3333 )
* ⚡ fix
* ⚡ replaced record with contact in description
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-description-identical-to-name` (#3343 )
* 👕 Apply `node-param-option-name-containing-star` (#3347 )
* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348 )
* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345 )
* ⚡ fix
* ⚡ exceptions
* 👕 Apply node-param-display-name-wrong-for-simplify (#3344 )
* Rule working as intended
* Uncomented other rules
* 👕 Undo and add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Alphabetize lint rules
* ⚡ Restore `lintfix` script
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
2022-05-20 23:47:24 +02:00
Albert Kiskorov
b3dc6d9d9c
feat(Pushover Node): Add 'HTML Formatting' option and credential test ( #3082 )
...
* Add html additional field
https://pushover.net/api#html
* ⚡ replaced input type to boolean, added credential test
* ⚡ credentials and linter fixes
* ⚡ Improvements
* ⚡ Fix description
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-05-07 13:25:53 +02:00
Iván Ovejero
63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3243 )
...
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200 )
* Removing unneeded backticks (#3249 )
* 👕 Apply node-param-description-wrong-for-return-all (#3253 )
* 👕 Apply node-param-description-missing-limit (#3252 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258 )
* 👕 Apply `node-param-description-miscased-id` (#3254 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261 )
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-05-06 23:01:25 +02:00
Iván Ovejero
0448feec56
refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules ( #3174 )
...
* ⚡ Initial setup
* 👕 Update `.eslintignore`
* 👕 Autofix node-param-default-missing (#3173 )
* 🔥 Remove duplicate key
* 👕 Add exceptions
* 📦 Update package-lock.json
* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176 )
* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177 )
* 👕 Apply `node-class-description-outputs-wrong` (#3178 )
* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179 )
* 👕 Apply `node-param-default-wrong-for-collection` (#3180 )
* 👕 Apply node-param-default-wrong-for-boolean (#3181 )
* Autofixed default missing
* Autofixed booleans, worked well
* ⚡ Fix params
* ⏪ Undo exempted autofixes
* 📦 Update package-lock.json
* 👕 Apply node-class-description-missing-subtitle (#3182 )
* ⚡ Fix missing comma
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184 )
* 👕 Add exception for `node-class-description-missing-subtitle`
* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185 )
* 👕 Apply `node-param-collection-type-unsorted-items` (#3186 )
* Missing coma
* 👕 Apply `node-param-default-wrong-for-simplify` (#3187 )
* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190 )
* 👕 Apply `node-param-description-empty-string` (#3189 )
* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191 )
* Rule looks good
* Add whitespace rule in eslint config
* :zao: fix
* 👕 Apply `node-param-description-identical-to-display-name` (#3193 )
* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195 )
* ⏪ Revert ":zao: fix"
This reverts commit ef8a76f3df👕 Apply `node-param-description-missing-for-simplify` (#3196 )
* 👕 Apply `node-param-description-missing-final-period` (#3194 )
* Rule working as intended
* Add rule to eslint
* 👕 Apply node-param-description-missing-for-return-all (#3197 )
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-04-22 18:29:51 +02:00
Omar Ajoue
d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials ( #3105 )
...
* Centralized error throwing for encryption key
* Unifying the error message used by cli and core packages
* Improvements to error messages to make it more DRY
* Removed unnecessary throw
* Throwing error when credential does not exist to simplify node behavior (#3112 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-04-15 08:00:47 +02:00
Iván Ovejero
2b74b6238e
⚡ Deprecate step size and node color ( #2586 )
...
* 🔥 Deprecate numberStepSize
* 🔥 Deprecate color in non-FA nodes
* ⚡ Minor node name fixes
* 📦 Update package-lock.json
* ⏪ Restore Merge node color
* 👕 Fix lint
2021-12-23 13:30:35 +01:00
Iván Ovejero
0764c49dcf
🔥 Remove line breaks from param descriptions ( #2473 )
...
* 🔥 Remove line breaks from param descriptions
* 🔥 Remove more line breaks
* 🎨 Fix spacing for list item in tooltip
* ⚡ Apply multiline with <p> tags
* ⚡ Improve <code> and <a> tags
* ✏️ Improve grammar and spelling
* ⚡ Add missing <p> tags
* ✏️ Make "multiple" phrasing consistent
* ⚡ Fix unneeded quote escapes
* ⚡ Encode angle brackets
* ⚡ Fix typo and copy-paste artifact
2021-11-25 18:10:06 +01:00
Iván Ovejero
176e475c8e
:xap: Open tooltip links on new tab ( #2106 )
...
* ✨ Create mixin
* ⚡ Implement mixin
* 🔥 Remove hardcoded attribute
* 🔨 Refactor mixin into helper
* 🔨 Refactor string replacement
* ✏️ Unrelated description fixes
* ⚡ Simplify helper import
2021-08-26 19:42:38 +02:00
Omar Ajoue
7ce7285f7a
⚡ Load credentials from the database ( #1741 )
...
* Changes to types so that credentials can be always loaded from DB
This first commit changes all return types from the execute functions
and calls to get credentials to be async so we can use await.
This is a first step as previously credentials were loaded in memory and
always available. We will now be loading them from the DB which requires
turning the whole call chain async.
* Fix updated files
* Removed unnecessary credential loading to improve performance
* Fix typo
* ⚡ Fix issue
* Updated new nodes to load credentials async
* ⚡ Remove not needed comment
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-08-20 18:57:30 +02:00
Ahsan Virani
178235e148
✨ Initial changes for binary data management ( #2105 )
...
* introduce binary data management
* cr
* add binary data changes to awsS3 node
* add binary data changes to Box node
* add binary data changes to CiscoWebex node
* add binary data changes to HumaniticAi node
* add binary data changes to Jira node
* add binary data changes to Line node
* add binary data changes to MicrosoftOneDrive node
* add binary data changes to MicrosoftOutlook node
* add binary data changes to Mindee node
* add binary data changes to NocoDB node
* add binary data changes to Pushbullet node
* add binary data changes to Pushover node
* add binary data changes to Raindrop node
* add binary data changes to S3 node
* add binary data changes to Salesforce node
* add binary data changes to Ssh node
* add binary data changes to TheHive node
* add binary data changes to Twist node
* add binary data changes to Twitter node
* remove changes not needed right now
* 🐛 Fix issue with multiple runs
* 🐛 Revert fix and add support for multiple inputs
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-08-20 18:08:40 +02:00
Omar Ajoue
d6239d5bfb
⚡ Add full continue-on-fail support to all nodes ( #1996 )
...
* Update Compression node
* Update Crypto node
* Update DateTime node
* Update EditImage node
* Update EmailSend node
* Update ExecuteWorkflow node
* Update FTP node
* Update Function node
* Update FunctionItem node
* Update ExecuteCommand node
* Update OpenWeatherMap node
* Update ReadBinaryFile node
* Update ReadPdf node
* Update RssFeedRead node & add URL validation
* Update SpreadsheetFile node
* Update Switch node
* Update WriteBinaryFile node
* Update Xml node
* Update ActiveCampaign node
* Update Airtable node
* Update ApiTemplateIo node
* Update Asana node
* Update AwsLambda node
* Update AwsSns node
* Update AwsComprehend node
* Update AwsRekognition node
* Update AwsS3 node
* Fix Error item
* Update AwsSes node
* Update AwsSqs node
* Update Amqp node
* Update Bitly node
* Update Box node
* Update Brandfetch node
* Update CircleCi node
* Update Clearbit node
* Update ClickUp node
* Update Cockpit node
* Update CoinGecko node
* Update Contentful node
* Update ConvertKit node
* Update Cortex node
* Update CustomerIo node
* Update DeepL node
* Update Demio node
* Update Disqus node
* Update Drift node
* Update Dropbox node
* Update GetResponse node
* Refactor & Update Ghost node
* Update Github node
* Update Gitlab node
* Update GoogleAnalytics node
* Update GoogleBooks node
* Update GoogleCalendar node
* Update GoogleDrive node
* Update Gmail node
* Update GoogleSheets node
* Update GoogleSlides node
* Update GoogleTasks node
* Update Gotify node
* Update GraphQL node
* Update HackerNews node
* Update Harvest node
* Update HtmlExtract node
* Update Hubspot node
* Update Hunter node
* Update Intercom node
* Update Kafka node
* Refactor & update Line node
* Update LinkedIn node
* Update Mailchimp node
* Update Mandrill node
* Update Matrix node
* Update Mautic node
* Update Medium node
* Update MessageBird node
* Update Mindee node
* Update Mocean node
* Update MondayCom node
* Update MicrosoftExcel node
* Update MicrosoftOneDrive node
* Update MicrosoftOutlook node
* Update Affinity node
* Update Chargebee node
* Update Discourse node
* Update Freshdesk node
* Update YouTube node
* Update InvoiceNinja node
* Update MailerLite node
* Update Mailgun node
* Update Mailjet node
* Update Mattermost node
* Update Nasa node
* Update NextCloud node
* Update OpenThesaurus node
* Update Orbit node
* Update PagerDuty node
* Update PayPal node
* Update Peekalink node
* Update Phantombuster node
* Update PostHog node
* Update ProfitWell node
* Refactor & Update Pushbullet node
* Update QuickBooks node
* Update Raindrop node
* Update Reddit node
* Update Rocketchat node
* Update S3 node
* Update Salesforce node
* Update SendGrid node
* Update SentryIo node
* Update Shopify node
* Update Signl4 node
* Update Slack node
* Update Spontit node
* Update Spotify node
* Update Storyblok node
* Refactor & Update Strapi node
* Refactor & Update Strava node
* Update Taiga node
* Refactor & update Tapfiliate node
* Update Telegram node
* Update TheHive node
* Update Todoist node
* Update TravisCi node
* Update Trello node
* Update Twilio node
* Update Twist node
* Update Twitter node
* Update Uplead node
* Update UProc node
* Update Vero node
* Update Webflow node
* Update Wekan node
* Update Wordpress node
* Update Xero node
* Update Yourls node
* Update Zendesk node
* Update ZohoCrm node
* Refactor & Update Zoom node
* Update Zulip node
* Update Clockify node
* Update MongoDb node
* Update MySql node
* Update MicrosoftTeams node
* Update Stackby node
* Refactor Discourse node
* Support corner-case in Github node update
* Support corner-case in Gitlab node update
* Refactor & Update GoogleContacts node
* Refactor Mindee node
* Update Coda node
* Lint fixes
* Update Beeminder node
* Update Google Firebase RealtimeDatabase node
* Update HelpScout node
* Update Mailcheck node
* Update Paddle node
* Update Pipedrive node
* Update Pushover node
* Update Segment node
* Refactor & Update Vonage node
* Added new conditions to warnings on execute batch cmd
* Added keep only properties flag
* Fixed code for keep only props
* Added dependencies for image editing
Co-authored-by: dali <servfrdali@yahoo.fr>
2021-07-20 08:58:54 +02:00
Mutasem Aldmour
276eaea4bf
⚡ Clean up node description ( #1883 )
...
Co-authored-by: Jan <janober@users.noreply.github.com>
2021-07-03 14:40:16 +02:00
Iván Ovejero
1d27a9e87e
✨ Improve node error handling ( #1309 )
...
* Add path mapping and response error interfaces
* Add error handling and throwing functionality
* Refactor error handling into a single function
* Re-implement error handling in Hacker News node
* Fix linting details
* Re-implement error handling in Spotify node
* Re-implement error handling in G Suite Admin node
* 🚧 create basic setup NodeError
* 🚧 add httpCodes
* 🚧 add path priolist
* 🚧 handle statusCode in error, adjust interfaces
* 🚧 fixing type issues w/Ivan
* 🚧 add error exploration
* 👔 fix linter issues
* 🔧 improve object check
* 🚧 remove path passing from NodeApiError
* 🚧 add multi error + refactor findProperty method
* 👔 allow any
* 🔧 handle multi error message callback
* ⚡ change return type of callback
* ⚡ add customCallback to MultiError
* 🚧 refactor to use INode
* 🔨 handle arrays, continue search after first null property found
* 🚫 refactor method access
* 🚧 setup NodeErrorView
* ⚡ change timestamp to Date.now
* 📚 Add documentation for methods and constants
* 🚧 change message setting
* 🚚 move NodeErrors to workflow
* ✨ add new ErrorView for Nodes
* 🎨 improve error notification
* 🎨 refactor interfaces
* ⚡ add WorkflowOperationError, refactor error throwing
* 👕 fix linter issues
* 🎨 rename param
* 🐛 fix handling normal errors
* ⚡ add usage of NodeApiError
* 🎨 fix throw new error instead of constructor
* 🎨 remove unnecessary code/comments
* 🎨 adjusted spacing + updated status messages
* 🎨 fix tab indentation
* ✨ Replace current errors with custom errors (#1576 )
* ⚡ Introduce NodeApiError in catch blocks
* ⚡ Introduce NodeOperationError in nodes
* ⚡ Add missing errors and remove incompatible
* ⚡ Fix NodeOperationError in incompatible nodes
* 🔧 Adjust error handling in missed nodes
PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes
* 🔨 Adjust Strava Trigger node error handling
* 🔨 Adjust AWS nodes error handling
* 🔨 Remove duplicate instantiation of NodeApiError
* 🐛 fix strava trigger node error handling
* Add XML parsing to NodeApiError constructor (#1633 )
* 🐛 Remove type annotation from catch variable
* ✨ Add XML parsing to NodeApiError
* ⚡ Simplify error handling in Rekognition node
* ⚡ Pass in XML flag in generic functions
* 🔥 Remove try/catch wrappers at call sites
* 🔨 Refactor setting description from XML
* 🔨 Refactor let to const in resource loaders
* ⚡ Find property in parsed XML
* ⚡ Change let to const
* 🔥 Remove unneeded try/catch block
* 👕 Fix linting issues
* 🐛 Fix errors from merge conflict resolution
* ⚡ Add custom errors to latest contributions
* 👕 Fix linting issues
* ⚡ Refactor MongoDB helpers for custom errors
* 🐛 Correct custom error type
* ⚡ Apply feedback to A nodes
* ⚡ Apply feedback to missed A node
* ⚡ Apply feedback to B-D nodes
* ⚡ Apply feedback to E-F nodes
* ⚡ Apply feedback to G nodes
* ⚡ Apply feedback to H-L nodes
* ⚡ Apply feedback to M nodes
* ⚡ Apply feedback to P nodes
* ⚡ Apply feedback to R nodes
* ⚡ Apply feedback to S nodes
* ⚡ Apply feedback to T nodes
* ⚡ Apply feedback to V-Z nodes
* ⚡ Add HTTP code to iterable node error
* 🔨 Standardize e as error
* 🔨 Standardize err as error
* ⚡ Fix error handling for non-standard nodes
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Harshil Agrawal
f258f3ca33
✨ Add Node Codex ( #1335 )
...
* ✨ Add Node Codex 📇
* ⚡ Add codex files for new nodes
* ⚡ Change category for Affinity
* 🔨 Fix credential documentation link
* ⚡ Improve styling
* ⚡ Add blogposts
Co-authored-by: Amudhan <sm.amudhan@live.com>
2021-01-14 13:56:07 +01:00
Jan Oberhauser
546b79bea0
👕 Fix lint issue
2020-10-22 18:00:28 +02:00
Jan Oberhauser
40c2acd77b
👕 Fix lint issue
2020-10-22 15:46:03 +02:00
Jan Oberhauser
7daeed5c0b
👕 Fix lint issue
2020-10-22 09:16:58 +02:00
Jan Oberhauser
b9fc0b0ccf
⚡ Fix Pushover-Node
2020-10-21 23:40:37 +02:00
Ricardo Espinoza
ea2902816f
✨ Add Pushover Node ( #1069 )
2020-10-21 23:30:07 +02:00
