Iván Ovejero
|
70ae90fa3c
|
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules (#3432)
* ⚡ Update `lintfix` script
* 👕 Remove unneeded lint exceptions
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-description-miscased-url` (#3441)
* 👕 Apply `rule node-param-placeholder-miscased-id` (#3443)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446)
* 👕 Apply `node-param-min-value-wrong-for-limit` (#3442)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-wrong-for-dynamic-options` (#3454)
* 🔨 fix
* ⚡ Fix `Assigned To` fields
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `rule node-param-default-wrong-for-number` (#3453)
* 👕 Apply `node-param-default-wrong-for-string` (#3452)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-miscased` (#3449)
* 🔨 fix
* 🔨 exceptions
* ⚡ review fixes
* 👕 Apply `node-param-description-lowercase-first-char` (#3451)
* ⚡ fix
* ⚡ review fixes
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456)
* Rule working as intended
* Add rule
* 🔥 Remove repetitions
* 👕 Add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Small fix for `node-param-description-wrong-for-dynamic-options`
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460)
* 👕 Apply `node-param-description-line-break-html-tag` (#3462)
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-options-type-unsorted-items` (#3459)
* ⚡ fix
* 🔨 exceptions
* Add exception for Salesmate and Zoom
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Restore `lintfix` command
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
|
2022-06-03 19:23:49 +02:00 |
|
|
Iván Ovejero
|
6dcdb30bf4
|
refactor: Apply more nodelinting rules (#3324)
* ✏️ Alphabetize lint rules
* 🔥 Remove duplicates
* ⚡ Update `lintfix` script
* 👕 Apply `node-param-operation-without-no-data-expression` (#3329)
* 👕 Apply `node-param-operation-without-no-data-expression`
* 👕 Add exceptions
* 👕 Apply `node-param-description-weak` (#3328)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-value-duplicate` (#3331)
* 👕 Apply `node-param-description-miscased-json` (#3337)
* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-type-options-missing-from-limit` (#3336)
* Rule workig as intended
* ✏️ Uncomment rules
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-duplicate` (#3338)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-simplify` (#3334)
* ⚡ fix
* ⚡ exceptions
* ⚡ changed rule ignoring from file to line
* 👕 Apply `node-param-resource-without-no-data-expression` (#3339)
* 👕 Apply `node-param-display-name-untrimmed` (#3341)
* 👕 Apply `node-param-display-name-miscased-id` (#3340)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-resource-with-plural-option` (#3342)
* 👕 Apply `node-param-description-wrong-for-upsert` (#3333)
* ⚡ fix
* ⚡ replaced record with contact in description
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-description-identical-to-name` (#3343)
* 👕 Apply `node-param-option-name-containing-star` (#3347)
* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348)
* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345)
* ⚡ fix
* ⚡ exceptions
* 👕 Apply node-param-display-name-wrong-for-simplify (#3344)
* Rule working as intended
* Uncomented other rules
* 👕 Undo and add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Alphabetize lint rules
* ⚡ Restore `lintfix` script
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
|
2022-05-20 23:47:24 +02:00 |
|
|
Iván Ovejero
|
63b6c9f128
|
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules (#3243)
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200)
* Removing unneeded backticks (#3249)
* 👕 Apply node-param-description-wrong-for-return-all (#3253)
* 👕 Apply node-param-description-missing-limit (#3252)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258)
* 👕 Apply `node-param-description-miscased-id` (#3254)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261)
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
|
2022-05-06 23:01:25 +02:00 |
|
|
Iván Ovejero
|
2b74b6238e
|
⚡ Deprecate step size and node color (#2586)
* 🔥 Deprecate numberStepSize
* 🔥 Deprecate color in non-FA nodes
* ⚡ Minor node name fixes
* 📦 Update package-lock.json
* ⏪ Restore Merge node color
* 👕 Fix lint
|
2021-12-23 13:30:35 +01:00 |
|
|
Iván Ovejero
|
0764c49dcf
|
🔥 Remove line breaks from param descriptions (#2473)
* 🔥 Remove line breaks from param descriptions
* 🔥 Remove more line breaks
* 🎨 Fix spacing for list item in tooltip
* ⚡ Apply multiline with <p> tags
* ⚡ Improve <code> and <a> tags
* ✏️ Improve grammar and spelling
* ⚡ Add missing <p> tags
* ✏️ Make "multiple" phrasing consistent
* ⚡ Fix unneeded quote escapes
* ⚡ Encode angle brackets
* ⚡ Fix typo and copy-paste artifact
|
2021-11-25 18:10:06 +01:00 |
|
Mutasem Aldmour
|
ce066a160f
|
⚡ Remove unnessasry <br/> (#2340)
* introduce analytics
* add user survey backend
* add user survey backend
* set answers on survey submit
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
* change name to personalization
* lint
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
* N8n 2495 add personalization modal (#2280)
* update modals
* add onboarding modal
* implement questions
* introduce analytics
* simplify impl
* implement survey handling
* add personalized cateogry
* update modal behavior
* add thank you view
* handle empty cases
* rename modal
* standarize modal names
* update image, add tags to headings
* remove unused file
* remove unused interfaces
* clean up footer spacing
* introduce analytics
* refactor to fix bug
* update endpoint
* set min height
* update stories
* update naming from questions to survey
* remove spacing after core categories
* fix bug in logic
* sort nodes
* rename types
* merge with be
* rename userSurvey
* clean up rest api
* use constants for keys
* use survey keys
* clean up types
* move personalization to its own file
Co-authored-by: ahsan-virani <ahsan.virani@gmail.com>
* update parameter inputs to be multiline
* update spacing
* Survey new options (#2300)
* split up options
* fix quotes
* remove unused import
* refactor node credentials
* add user created workflow event (#2301)
* update multi params
* simplify env vars
* fix versionCli on FE
* update personalization env
* clean up node detail settings
* fix event User opened Credentials panel
* fix font sizes across modals
* clean up input spacing
* fix select modal spacing
* increase spacing
* fix input copy
* fix webhook, tab spacing, retry button
* fix button sizes
* fix button size
* add mini xlarge sizes
* fix webhook spacing
* fix nodes panel event
* fix workflow id in workflow execute event
* improve telemetry error logging
* fix config and stop process events
* add flush call on n8n stop
* ready for release
* fix input error highlighting
* revert change
* update toggle spacing
* fix delete positioning
* keep tooltip while focused
* set strict size
* increase left spacing
* fix sort icons
* remove unnessasry <br/>
* remove unnessary break
* remove unnessary margin
* clean unused functionality
* remove unnessary css
* remove duplicate tracking
* only show tooltip when hovering over label
* remove extra space
* add br
* remove extra space
* clean up commas
* clean up commas
* remove extra space
* remove extra space
* rewrite desc
* add commas
* add space
* remove extra space
* add space
* add dot
* update credentials section
* use includes
Co-authored-by: ahsan-virani <ahsan.virani@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
|
2021-10-27 15:00:13 -05:00 |
|
|
Mutasem Aldmour
|
276eaea4bf
|
⚡ Clean up node description (#1883)
Co-authored-by: Jan <janober@users.noreply.github.com>
|
2021-07-03 14:40:16 +02:00 |
|
|
Iván Ovejero
|
1d27a9e87e
|
✨ Improve node error handling (#1309)
* Add path mapping and response error interfaces
* Add error handling and throwing functionality
* Refactor error handling into a single function
* Re-implement error handling in Hacker News node
* Fix linting details
* Re-implement error handling in Spotify node
* Re-implement error handling in G Suite Admin node
* 🚧 create basic setup NodeError
* 🚧 add httpCodes
* 🚧 add path priolist
* 🚧 handle statusCode in error, adjust interfaces
* 🚧 fixing type issues w/Ivan
* 🚧 add error exploration
* 👔 fix linter issues
* 🔧 improve object check
* 🚧 remove path passing from NodeApiError
* 🚧 add multi error + refactor findProperty method
* 👔 allow any
* 🔧 handle multi error message callback
* ⚡ change return type of callback
* ⚡ add customCallback to MultiError
* 🚧 refactor to use INode
* 🔨 handle arrays, continue search after first null property found
* 🚫 refactor method access
* 🚧 setup NodeErrorView
* ⚡ change timestamp to Date.now
* 📚 Add documentation for methods and constants
* 🚧 change message setting
* 🚚 move NodeErrors to workflow
* ✨ add new ErrorView for Nodes
* 🎨 improve error notification
* 🎨 refactor interfaces
* ⚡ add WorkflowOperationError, refactor error throwing
* 👕 fix linter issues
* 🎨 rename param
* 🐛 fix handling normal errors
* ⚡ add usage of NodeApiError
* 🎨 fix throw new error instead of constructor
* 🎨 remove unnecessary code/comments
* 🎨 adjusted spacing + updated status messages
* 🎨 fix tab indentation
* ✨ Replace current errors with custom errors (#1576)
* ⚡ Introduce NodeApiError in catch blocks
* ⚡ Introduce NodeOperationError in nodes
* ⚡ Add missing errors and remove incompatible
* ⚡ Fix NodeOperationError in incompatible nodes
* 🔧 Adjust error handling in missed nodes
PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes
* 🔨 Adjust Strava Trigger node error handling
* 🔨 Adjust AWS nodes error handling
* 🔨 Remove duplicate instantiation of NodeApiError
* 🐛 fix strava trigger node error handling
* Add XML parsing to NodeApiError constructor (#1633)
* 🐛 Remove type annotation from catch variable
* ✨ Add XML parsing to NodeApiError
* ⚡ Simplify error handling in Rekognition node
* ⚡ Pass in XML flag in generic functions
* 🔥 Remove try/catch wrappers at call sites
* 🔨 Refactor setting description from XML
* 🔨 Refactor let to const in resource loaders
* ⚡ Find property in parsed XML
* ⚡ Change let to const
* 🔥 Remove unneeded try/catch block
* 👕 Fix linting issues
* 🐛 Fix errors from merge conflict resolution
* ⚡ Add custom errors to latest contributions
* 👕 Fix linting issues
* ⚡ Refactor MongoDB helpers for custom errors
* 🐛 Correct custom error type
* ⚡ Apply feedback to A nodes
* ⚡ Apply feedback to missed A node
* ⚡ Apply feedback to B-D nodes
* ⚡ Apply feedback to E-F nodes
* ⚡ Apply feedback to G nodes
* ⚡ Apply feedback to H-L nodes
* ⚡ Apply feedback to M nodes
* ⚡ Apply feedback to P nodes
* ⚡ Apply feedback to R nodes
* ⚡ Apply feedback to S nodes
* ⚡ Apply feedback to T nodes
* ⚡ Apply feedback to V-Z nodes
* ⚡ Add HTTP code to iterable node error
* 🔨 Standardize e as error
* 🔨 Standardize err as error
* ⚡ Fix error handling for non-standard nodes
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
|
2021-04-16 18:33:36 +02:00 |
|
Mikołaj Kamiński
|
530c4a0ea9
|
Fixed Strava Trigger node description
|
2020-10-31 16:27:20 +01:00 |
|
Jan Oberhauser
|
546b79bea0
|
👕 Fix lint issue
|
2020-10-22 18:00:28 +02:00 |
|
|
Jan Oberhauser
|
40c2acd77b
|
👕 Fix lint issue
|
2020-10-22 15:46:03 +02:00 |
|
|
Jan Oberhauser
|
9f8b11d4b5
|
🐛 Fix typo
|
2020-10-22 12:08:17 +02:00 |
|
|
Jan Oberhauser
|
3e56d5fc08
|
⚡ Fix issues on Strava-Node
|
2020-10-22 10:19:17 +02:00 |
|
Ricardo Espinoza
|
95b33662c9
|
✨ Strava Node & Trigger (#1071)
* ✨ Strava Node & Trigger
* ⚡ Small fixes
* ⚡ Add improvements
|
2020-10-22 10:17:39 +02:00 |
|