Commit graph

5 commits

Author SHA1 Message Date
Iván Ovejero 6d6e2488c6
refactor(core): Generalize binary data manager interface (no-changelog) (#7164)
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768)

This PR: 
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.

Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.

Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-22 17:22:12 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6aa7b93473
refactor(core): Deprecate prepareOutputData (no-changelog) (#7091) 2023-09-05 12:59:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ e57e85edf7
refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) 2023-07-12 11:15:38 +02:00
Iván Ovejero 88724bb056
ci: Enforce no unused imports (no-changelog) (#6073) 2023-04-25 11:47:03 +02:00
Val 233f1fa7ec
feat(QuickChart Node): Add QuickChart node (#3572)
*  Add basic QuickChart node

* 🏷️ Fix up types

* ❇️ Add Boxplot and Violin

* ❇️ Add point styles

* ❇️ Add horizontal charts

*  Make possible to provide array of labels via expressions

*  Improvements

*  Improvements

* 🎨 fix lint errors

* ️disable chart types we don't want to support in P0

* ️support setting labels manually or using an array

* ️move Horizontal parameter into options

* ️ update "Put Output In Field" param description and hint

* ️ removed font color

* ️fix Device Pixel Ratio

* ️fix Polar Chart not working

* ️Show Fill param only for charts supporting it

* ️Show pointStyle param only for charts supporting it

* ️remove second "Chart Type" option

*  updated error message, added json data, updated description

* Add codex json file

*  add unit test

*  improve unit test

*  removed any, added aliases

---------

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-03-17 12:50:26 +01:00