mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity
10231 commits 1039 branches 1592 tags 374 MiB
Commit graph

41 commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™ cc2f0ada76
ci: Enforce noUnusedLocals on all backend and nodes packages (no-changelog) (#8428) 2024-01-25 14:33:35 +01:00
Tomi Turtiainen 1aa35b190a
fix: Set '@typescript-eslint/return-await' rule to 'always' for FE (no-changelog) (#8373) 2024-01-18 11:28:01 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1286d6583c
ci: Disable import/no-extraneous-dependencies in frontend tests (no-changelog) (#8182) 
supersedes #8180
 2023-12-29 10:45:55 +01:00
कारतोफ्फेलस्क्रिप्ट™ 464b565283
ci: Remove unnecessary async/await, enable await-thenable linting rule (no-changelog) (#8076) 
## Summary
We accidentally made some functions `async` in
https://github.com/n8n-io/n8n/pull/7846
This PR reverts that change. 

## Review / Merge checklist
- [x] PR title and summary are descriptive.
 2023-12-19 13:52:42 +01:00
Iván Ovejero 8cb9c6b3ea
ci: Introduce no-plain-errors lint rule for BE packages (no-changelog) (#7961) 
## Summary
Require `ApplicationError` or its child classes instead of plain `Error`
in BE packages. This ensures the error will be normalized when reported
to Sentry, if applicable.

Follow-up to:
https://github.com/n8n-io/n8n/pulls?q=is%3Apr+is%3Aclosed+applicationerror

...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

...


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-08 12:51:49 +01:00
Csaba Tuncsik 152883eed1
build: Upgrade lint related packages (#7790) 2023-11-27 09:11:52 +01:00
Iván Ovejero f73a0597ba
refactor: Add rule no-constant-binary-expression (no-changelog) (#7670) 
https://eslint.org/docs/latest/rules/no-constant-binary-expression
 2023-11-09 17:50:59 +01:00
Iván Ovejero 62c096710f
refactor: Run lintfix (no-changelog) (#7537) 
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
 2023-10-27 14:15:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ c18ba370d5
ci: Remove eslint diff plugin. Run full linting on PRs (no-changelog) (#7175) 2023-09-14 16:55:06 +02:00
कारतोफ्फेलस्क्रिप्ट™ c188b0e9b2
ci: Improve the performance of the import/no-cycle linting rule (no-changelog) (#6985) 2023-08-22 13:44:50 +02:00
Iván Ovejero dceff675ec
perf(core): Add filtering and pagination to GET /workflows (#6845) 
* Initial setup

* Specify max paginated items

* Simplify

* Add tests

* Add more tests

* Add migrations

* Add top-level property

* Add field selection

* Cleanup

* Rename `total` to `count`

* More cleanup

* Move query logic into `WorkflowRepository`

* Create `AbstractRepository`

* Cleanup

* Fix name

* Remove leftover comments

* Replace reference

* Add default for `rawSkip`

* Remove unneeded typing

* Switch to `class-validator`

* Simplify

* Simplify

* Type as optional

* Make typing more accurate

* Fix lint

* Use `getOwnPropertyNames`

* Use DSL

* Set schema at repo level

* Cleanup

* Remove comment

* Refactor repository methods to middleware

* Add middleware tests

* Remove old test files

* Remove generic experiment

* Reuse `reportError`

* Remove unused type

* Cleanup

* Improve wording

* Reduce diff

* Add missing mw

* Use `Container.get`

* Adjust lint rule

* Reorganize into subdir

* Remove unused directive

* Remove nodes

* Silly mistake

* Validate take

* refactor(core): Adjust index handling in new migrations DSL (no-changelog) (#6876)

* refactor(core): Adjust index handling in new migrations DSL (no-changelog)

* Account for custom index name

* Also for dropping

* Fix `select` issue with `relations`

* Tighten validation

* Ensure `ownerId` is not added when specifying `select`
 2023-08-09 12:30:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ 7461085408
ci: Update most of the dev tooling (no-changelog) (#6780) 2023-07-28 13:55:16 +02:00
Iván Ovejero fe937a0ee3
ci: Forbid skipping tests (no-changelog) (#6199) 2023-05-24 09:45:37 +02:00
कारतोफ्फेलस्क्रिप्ट™ e046f656fe
feat(core): Remove all floating promises. Enforce @typescript-eslint/no-floating-promises (#6281) 2023-05-24 02:01:45 +02:00
Iván Ovejero 06fa6f1fb3
ci: Expand ESLint to tests in BE packages (no-changelog) (#6147) 
* 🔧 Adjust base ESLint config

* 🔧 Adjust `lint` and `lintfix` in `nodes-base`

* 🔧 Include `test` and `utils` in `nodes-base`

* 📘 Convert JS tests to TS

* 👕 Apply lintfixes
 2023-05-02 10:37:19 +02:00
Iván Ovejero 88724bb056
ci: Enforce no unused imports (no-changelog) (#6073) 2023-04-25 11:47:03 +02:00
कारतोफ्फेलस्क्रिप्ट™ c7b1920943
ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070) 2023-04-24 14:47:13 +02:00
Iván Ovejero 57aab63c10
refactor: Integrate consistent-type-imports in FE packages (no-changelog) (#6060) 
* 👕 Move `consistent-type-imports` to top level

* 👕 Apply lintfixes

* 👕 Apply more lintfixes

* 👕 More lintfixes

* 👕 More lintfixes
 2023-04-24 12:18:24 +02:00
Michael Kret 0e93fe064e
refactor(core): Forbid raw enums (no-changelog) 2023-04-21 14:23:15 +03:00
Iván Ovejero 62751b5a0b
refactor: Add lint rule no-unused-param-in-catch-clause (#5868) 
👕 Add lint rule `no-unused-param-in-catch-clause`
 2023-03-31 16:44:08 +02:00
Iván Ovejero d548161632
feat(core): Security audit (#5034) 
* ✨ Implement security audit

* ⚡ Use logger

* 🧪 Fix test

* ⚡ Switch logger with stdout

* 🎨 Set new logo

* ⚡ Fill out Public API schema

* ✏️ Fix typo

* ⚡ Break dependency cycle

* ⚡ Add security settings values

* 🧪 Test security settings

* ⚡ Add publicly accessible instance warning

* ⚡ Add metric to CLI command

* ✏️ Fix typo

* 🔥 Remove unneeded path alias

* 📘 Add type import

* 🔥 Remove inferrable output type

* ⚡ Set description at correct level

* ⚡ Rename constant for consistency

* ⚡ Sort URLs

* ⚡ Rename local var

* ⚡ Shorten name

* ✏️ Improve phrasing

* ⚡ Improve naming

* ⚡ Fix casing

* ✏️ Add docline

* ✏️ Relocate comment

* ⚡ Add singular/plurals

* 🔥 Remove unneeded await

* ✏️ Improve test description

* ⚡ Optimize with sets

* ⚡ Adjust post master merge

* ✏️ Improve naming

* ⚡ Adjust in spy

* 🧪 Fix outdated instance test

* 🧪 Make diagnostics check consistent

* ⚡ Refactor `getAllExistingCreds`

* ⚡ Create helper `getNodeTypes`

* 🐛 Fix `InternalHooksManager` call

* 🚚 Rename `execution` to `nodes` risk

* ⚡ Add options to CLI command

* ⚡ Make days configurable

* :revert: Undo changes to `BaseCommand`

* ⚡ Improve CLI command UX

* ⚡ Change no-report return value

Empty array to trigger empty state on FE.

* ⚡ Add empty check to `reportInstanceRisk`

* 🧪 Extend Jest `expect`

* 📘 Augment `jest.Matchers`

* 🧪 Set extend as setup file

* 🔧 Override lint rule for `.d.ts`

* ⚡ Use new matcher

* ⚡ Update check

* 📘 Improve typings

* ⚡ Adjust instance risk check

* ✏️ Rename `execution` → `nodes` in Public API schema

* ✏️ Add clarifying comment

* ✏️ Fix typo

* ⚡ Validate categories in CLI command

* ✏️ Improve naming

* ✏️ Make audit reference consistent

* 📘 Fix typing

* ⚡ Use `finally` in CLI command
 2023-01-05 13:28:40 +01:00
Iván Ovejero 0b47f9ce4e
refactor: Lint for no interpolation in regular string (#5060) (no-changelog) 
* ✨ Create rule `no-interpolation-in-regular-string`

* 👕 Enable rule

* ⚡ Run rule (no issues) and add exception

* ⚡ Simplify regex

To account for expressions and to make it less expensive
 2022-12-29 14:24:19 +01:00
Iván Ovejero d9b98fc8be
refactor: Lint for no unneeded backticks (#5057) (no-changelog) 
* ✨ Create rule `no-unneeded-backticks`

* 👕 Enable rule

* ⚡ Run rule on `cli`

* ⚡ Run rule on `core`

* ⚡ Run rule on `workflow`

* ⚡ Rule rule on `design-system`

* ⚡ Run rule on `node-dev`

* ⚡ Run rule on `editor-ui`

* ⚡ Run rule on `nodes-base`
 2022-12-29 12:20:43 +01:00
कारतोफ्फेलस्क्रिप्ट™ 17f13b3b6e
ci: Setup eslint-import-resolver-typescript for improved TS linting (#4996) 
* Setup stricter linting for typescript

* make `import/no-unresolved` an error everywhere

* use prettier to format `.vscode/settings.default.json`

* address PR comments
 2022-12-22 09:55:39 +01:00
Iván Ovejero 7b819ad5a1
refactor: Disable ESLint indent rule (no-changelog) (#4828) 
* 👕 Disable ESLint `indent` rule

* 🔥 Remove redundant rule
 2022-12-06 16:07:26 +01:00
Iván Ovejero cfd32d2642
refactor: Phase out TSLint in nodes-base (no-changelog) (#4798) 
* 🔥 Remove TSLint scripts

* 🔥 Remove TSLint config

* 🔥 Remove TSLint exceptions

* 👕 Adjust lint config

* ✏️ Add story numbers
 2022-12-02 15:25:21 +01:00
कारतोफ्फेलस्क्रिप्ट™ 53d2526cd1
ci: Fix linting by ignoring eslintrc and jest.config again (no-changelog) (#4613) 
ci: Fix linting on by ignoring eslintrc and jest.config (no-changelog)
 2022-11-15 19:56:50 +01:00
कारतोफ्फेलस्क्रिप्ट™ 13659d036f
ci: Ensure that eslint runs on all frontend code (no-changelog) (#4602) 
* ensure that eslint runs on all frontend code

* remove tslint from `design-system`

* enable prettier and eslint-prettier for `design-system`

* Delete tslint.json

* use a single editorconfig for the repo

* enable prettier for all code in `design-system`

* more linting fixes on design-system

* ignore coverage for git and prettier

* lintfix on editor-ui
 2022-11-15 18:20:54 +01:00
Iván Ovejero 52f38df867
refactor: Remove unused vars to fix build (no-changelog) (#4584) 
* 🔥 Remove unused vars to fix build

* 👕 Make unused vars severity conditional
 2022-11-11 16:07:50 +01:00
Michael Kret 479644a499
refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523) 
* ⚡ rule and fixes

* ⚡ clean up
 2022-11-08 15:28:21 +01:00
Iván Ovejero ec5ef0c50d
refactor(core): clear @ts-ignore from workflow and core packages (#4467) 
* 📘 Clear all `@ts-ignore` comments from workflow package

* 👕 Default to error with package-level overrides

* refactor(core): clear all `@ts-ignore` comments from core package (#4473)

👕 Clear all `@ts-ignore` comments from core package

* ✏️ Update comment
 2022-10-31 12:45:34 +01:00
Iván Ovejero 641d904ee4
refactor: set ESLint to warn on ts-ignore comment (#4465) 
👕 Set `ban-ts-comment` to warn on @ts-ignore
 2022-10-28 10:35:31 +02:00
कारतोफ्फेलस्क्रिप्ट™ 99157cf581
feat: setup nightly tests for postgres and mysql schemas (#4441) 
* feat: unify Jest config

* feat: simplify DB setup for tests

* feat: setup nightly tests for postgres and mysql schemas
 2022-10-25 22:06:03 +02:00
Michael Kret 1d57b10942
refactor(core): fix for no-uncaught-json-parse warnings 2022-10-21 21:52:43 +03:00
Michael Kret 9d6a2c32d7
refactor(core): fixes n8n-local-rules/no-json-parse-json-stringify warnings (#4407) 
* 🔨 fixes

* 🔨 set rule to error
 2022-10-21 17:24:58 +02:00
Iván Ovejero 6a1838d8c1
refactor: lint for inefficient deep clones (#4378) 
* 👕 Create rule `no-json-parse-json-stringify`

* 🧪 Add tests

* 👕 Enable new rule

* 👕 FIx unrelated lint issue
 2022-10-19 09:36:25 +02:00
Iván Ovejero 64fffa0579
fix(lint): Set no-unused-vars to warn (#4228) 
* 👕 Set `no-unused-vars` to `warn`

* 👕 Fix lint issue in `master`

* ✏️ Fix plugin name
 2022-09-29 12:47:07 +02:00
कारतोफ्फेलस्क्रिप्ट™ bc42073e28
ci: Use eslint-plugin-diff only on the CI (#4194) 2022-09-26 14:43:52 +02:00
Mike Arvela 31391a5b19
feat(eslint-config): add custom eslint rule 'no-uncaught-json-parse' (#4087) 
feat(eslint-config): add custom eslint rule 'no-uncaugh-json-parse'

Co-authored-by: Iván Ovejero <[email protected]>
 2022-09-26 11:08:59 +03:00
Iván Ovejero a2441b8e3f
refactor(ci): Lint PR diffs only (#4137) 
* ✨ Set up `eslint-plugin-diff`

* 🔧 Fix setup

* ⬆️ Upgrade `checkout` and `setup-node`

* 🔧 Fix YAML

* 🧪 Verify `eslint-plugin-diff` behavior

* Revert "🧪 Verify `eslint-plugin-diff` behavior"

This reverts commit 1fcc6c8299.

* ✏️ Fix comment
 2022-09-21 10:24:39 +02:00
कारतोफ्फेलस्क्रिप्ट™ 69eb97999d
fix(eslint): setup eslint to run on every package - N8N-4553 (#4050) 
* fix(eslint): setup eslint to run on every package

Also, unify eslint config and dependencies into a private package in the workspace.
 2022-09-12 11:41:50 +02:00