mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity
5860 commits 1140 branches 1610 tags 412 MiB
Commit graph

43 commits

Author SHA1 Message Date
Iván Ovejero 6dcdb30bf4
refactor: Apply more nodelinting rules (#3324) 
* ✏️ Alphabetize lint rules

* 🔥 Remove duplicates

* ⚡ Update `lintfix` script

* 👕 Apply `node-param-operation-without-no-data-expression` (#3329)

* 👕 Apply `node-param-operation-without-no-data-expression`

* 👕 Add exceptions

* 👕 Apply `node-param-description-weak` (#3328)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-value-duplicate` (#3331)

* 👕 Apply `node-param-description-miscased-json` (#3337)

* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-type-options-missing-from-limit` (#3336)

* Rule workig as intended

* ✏️ Uncomment rules

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-name-duplicate` (#3338)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-wrong-for-simplify` (#3334)

* ⚡ fix

* ⚡ exceptions

* ⚡ changed rule ignoring from file to line

* 👕 Apply `node-param-resource-without-no-data-expression` (#3339)

* 👕 Apply `node-param-display-name-untrimmed` (#3341)

* 👕 Apply `node-param-display-name-miscased-id` (#3340)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-resource-with-plural-option` (#3342)

* 👕 Apply `node-param-description-wrong-for-upsert` (#3333)

* ⚡ fix

* ⚡ replaced record with contact in description

* ⚡ fix

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-option-description-identical-to-name` (#3343)

* 👕 Apply `node-param-option-name-containing-star` (#3347)

* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348)

* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345)

* ⚡ fix

* ⚡ exceptions

* 👕 Apply node-param-display-name-wrong-for-simplify (#3344)

* Rule working as intended

* Uncomented other rules

* 👕 Undo and add exceptions

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* ⚡ Alphabetize lint rules

* ⚡ Restore `lintfix` script

Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
 2022-05-20 23:47:24 +02:00
Iván Ovejero 63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules (#3243) 
* ✏️ Alphabetize rules

* 🔖 Update version

* ⚡ Update lintfix command

* ⚡ Run baseline lintfix

* 📦 Update package-lock.json

* 👕 Apply `node-param-description-untrimmed` (#3200)

* Removing unneeded backticks (#3249)

* 👕 Apply node-param-description-wrong-for-return-all (#3253)

* 👕 Apply node-param-description-missing-limit (#3252)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-description-excess-final-period (#3250)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-description-unencoded-angle-brackets (#3256)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-description-url-missing-protocol (#3258)

* 👕 Apply `node-param-description-miscased-id` (#3254)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-description-wrong-for-limit (#3257)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261)

* 👕 Apply rule

* ⚡ Restore lintfix script

* ⚡ Restore lintfix script

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
 2022-05-06 23:01:25 +02:00
Iván Ovejero 0448feec56
refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules (#3174) 
* ⚡ Initial setup

* 👕 Update `.eslintignore`

* 👕 Autofix node-param-default-missing (#3173)

* 🔥 Remove duplicate key

* 👕 Add exceptions

* 📦 Update package-lock.json

* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176)

* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177)

* 👕 Apply `node-class-description-outputs-wrong` (#3178)

* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179)

* 👕 Apply `node-param-default-wrong-for-collection` (#3180)

* 👕 Apply node-param-default-wrong-for-boolean (#3181)

* Autofixed default missing

* Autofixed booleans, worked well

* ⚡ Fix params

* ⏪ Undo exempted autofixes

* 📦 Update package-lock.json

* 👕 Apply node-class-description-missing-subtitle (#3182)

* ⚡ Fix missing comma

* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184)

* 👕 Add exception for `node-class-description-missing-subtitle`

* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185)

* 👕 Apply `node-param-collection-type-unsorted-items` (#3186)

* Missing coma

* 👕 Apply `node-param-default-wrong-for-simplify` (#3187)

* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190)

* 👕 Apply `node-param-description-empty-string` (#3189)

* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191)

* Rule looks good

* Add whitespace rule in eslint config

* :zao: fix

* 👕 Apply `node-param-description-identical-to-display-name` (#3193)

* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195)

* ⏪ Revert ":zao: fix"

This reverts commit ef8a76f3df.

* 👕 Apply `node-param-description-missing-for-simplify`  (#3196)

* 👕 Apply `node-param-description-missing-final-period` (#3194)

* Rule working as intended

* Add rule to eslint

* 👕 Apply node-param-description-missing-for-return-all (#3197)

* ⚡ Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
 2022-04-22 18:29:51 +02:00
Michael Kret 0081d02b97
fix(Postgres Node): Fix issue with columns containing spaces (#2989) 
* 🔨 fixed error when column name containes spaces

* ⚡ added lock fille to commit

* 🔨 fix for column names wraped in square braces

* 🔨 added lock file

* 🔨 fix for update key not included in update columns

* ⚡ Revert imports

Co-authored-by: Ricardo Espinoza <ricardo@n8n.io>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2022-04-19 11:48:41 +02:00
Omar Ajoue d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials (#3105) 
* Centralized error throwing for encryption key

* Unifying the error message used by cli and core packages

* Improvements to error messages to make it more DRY

* Removed unnecessary throw

* Throwing error when credential does not exist to simplify node behavior (#3112)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2022-04-15 08:00:47 +02:00
Iván Ovejero 027dfb2f0a
⚡ Enable esModuleInterop compiler option and upgrade to TypeScript 4.6 (#3106) 
* ⚡ Enable `esModuleInterop` for /core

* ⚡ Adjust imports in /core

* ⚡ Enable `esModuleInterop` for /cli

* ⚡ Adjust imports in /cli

* ⚡ Enable `esModuleInterop` for /nodes-base

* ⚡ Adjust imports in /nodes-base

* ⚡ Make imports consistent

* ⬆️ Upgrade TypeScript to 4.6 (#3109)

* ⬆️ Upgrade TypeScript to 4.6

* 📦 Update package-lock.json

* 🔧 Avoid erroring on untyped errors

* 📘 Fix type error

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2022-04-08 23:32:08 +02:00
Iván Ovejero 2b74b6238e
⚡ Deprecate step size and node color (#2586) 
* 🔥 Deprecate numberStepSize

* 🔥 Deprecate color in non-FA nodes

* ⚡ Minor node name fixes

* 📦 Update package-lock.json

* ⏪ Restore Merge node color

* 👕 Fix lint
 2021-12-23 13:30:35 +01:00
Iván Ovejero 0764c49dcf
🔥 Remove line breaks from param descriptions (#2473) 
* 🔥 Remove line breaks from param descriptions

* 🔥 Remove more line breaks

* 🎨 Fix spacing for list item in tooltip

* ⚡ Apply multiline with <p> tags

* ⚡ Improve <code> and <a> tags

* ✏️ Improve grammar and spelling

* ⚡ Add missing <p> tags

* ✏️ Make "multiple" phrasing consistent

* ⚡ Fix unneeded quote escapes

* ⚡ Encode angle brackets

* ⚡ Fix typo and copy-paste artifact
 2021-11-25 18:10:06 +01:00
Iván Ovejero f03833ff25
⚡ Open edit window for SQL query fields (#2188) 2021-09-11 12:58:48 +02:00
Omar Ajoue 7ce7285f7a
⚡ Load credentials from the database (#1741) 
* Changes to types so that credentials can be always loaded from DB

This first commit changes all return types from the execute functions
and calls to get credentials to be async so we can use await.

This is a first step as previously credentials were loaded in memory and
always available. We will now be loading them from the DB which requires
turning the whole call chain async.

* Fix updated files

* Removed unnecessary credential loading to improve performance

* Fix typo

* ⚡ Fix issue

* Updated new nodes to load credentials async

* ⚡ Remove not needed comment

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2021-08-20 18:57:30 +02:00
Mutasem Aldmour 276eaea4bf
⚡ Clean up node description (#1883) 
Co-authored-by: Jan <janober@users.noreply.github.com>
 2021-07-03 14:40:16 +02:00
Iván Ovejero 77483f991d
⚡ Replace PNG icons with SVG and optimize (#1890) 
* 🎨 Replace PNG icons with SVG icons

* ⚡ Fix size of bitbucket icon

* ⚡ Optimize svgs

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2021-06-12 21:00:37 +02:00
Harshil Agrawal 440971673c
⚡ Add and update codex files (#1834) 
* ✨ Add and update codex files

* 🔨 Fix codex format

* 🔨 Fix codex format for remaining files
 2021-05-28 14:54:52 -05:00
Omar Ajoue fc54f7c82b
✨ Add query parameters for CrateDB, PostgresDB, TimescaleDB and QuestDB (Parametrized Queries) (#1577) 
* Adding support to ParameterizedQuery on Postgres Node

* Created another parameter to toggle on replacement so it's clear to users what is happening.

* Fixed lint issues

* ⚡ Formatting

* Improvements to questDB node so it is more consistent

* Fixed lint issues

* Fixed typing issue

* ⚡ Apply suggestions BHesseldieck

Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>

* Standardized output for postgres and postgres-like nodes

This changes the behavior of CrateDB, Postgres, QuestDB and TimescaleDB
nodes.

The Execute Query operation used to execute multiple queries but return
the result from only one of the queries.

This change causes the node output to containt results from all queries
that ran, making the behavior more consistent across all n8n.

* Fixing lint issues

* ⚡ Minor improvements

* ⚡ Fix breaking changes files

Co-authored-by: Gustavo Arjones <gustavo.arjones@ank.app>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Jan <janober@users.noreply.github.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
 2021-04-30 17:35:34 -05:00
Omar Ajoue 41669c0e0f
✨ Add options to run queries as transactions (#1612) 
* add multi return

* add independently and transaction to query

* pgInsert normal and transaction

* independently for pgInsert

* normal, transaction and independently for pgUpdate

* cleanup

* implement it in other nodes

* multiple fixes

* add optional returning support

* clean up Postgres functions

* fix other postgres based dbs

* Added option to run queries as a transaction to Postgres

This commit allows users to configure Postgres, CrateDB, TimescaleDB and
QuestDB to run queries independently or as transactions as well as the
previous mode which is to execute multiple queries at once.

Previous behavior remains untouched so we only added new options.

* Standardize behavior across nodes that use postgres protocol

Also fixed unit tests.

* Added breaking change notice

* Added more information to breaking changes

* ⚡ Styling fixes

Co-authored-by: lublak <lublak.de@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2021-04-24 22:55:14 +02:00
Iván Ovejero 1d27a9e87e
✨ Improve node error handling (#1309) 
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

* ⚡ change return type of callback

* ⚡ add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

* ⚡ change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

* ✨ add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

* ⚡ add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

* ⚡ add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

* ✨ Replace current errors with custom errors (#1576)

* ⚡ Introduce NodeApiError in catch blocks

* ⚡ Introduce NodeOperationError in nodes

* ⚡ Add missing errors and remove incompatible

* ⚡ Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

* ✨ Add XML parsing to NodeApiError

* ⚡ Simplify error handling in Rekognition node

* ⚡ Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

* ⚡ Find property in parsed XML

* ⚡ Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

* ⚡ Add custom errors to latest contributions

* 👕 Fix linting issues

* ⚡ Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

* ⚡ Apply feedback to A nodes

* ⚡ Apply feedback to missed A node

* ⚡ Apply feedback to B-D nodes

* ⚡ Apply feedback to E-F nodes

* ⚡ Apply feedback to G nodes

* ⚡ Apply feedback to H-L nodes

* ⚡ Apply feedback to M nodes

* ⚡ Apply feedback to P nodes

* ⚡ Apply feedback to R nodes

* ⚡ Apply feedback to S nodes

* ⚡ Apply feedback to T nodes

* ⚡ Apply feedback to V-Z nodes

* ⚡ Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

* ⚡ Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
 2021-04-16 18:33:36 +02:00
Harshil Agrawal a503c0e86b
⚡ Add new codex files and fix previous files (#1608) 
* ✨ Add new codex files and fixed previous files

* 🔨 Minor fix

* 🔨 Minor fix
 2021-04-10 10:18:10 +02:00
Omar Ajoue f225bbbb84
✨ Add type casting to postgres queries (#1600) 
* 538 add support for casting types in postgres

* Add typing to postgres insert nodes and removed unnecessary field from crate db

* Added placeholder and description for types in postgres

* Adding tests to insert and changes suggested by Ben

* ⚡ Minor improvement

Co-authored-by: mutdmour <mutdmour@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2021-04-03 16:53:47 +02:00
Harshil Agrawal f258f3ca33
✨ Add Node Codex (#1335) 
* ✨ Add Node Codex 📇

* ⚡Add codex files for new nodes

* ⚡ Change category for Affinity

* 🔨 Fix credential documentation link

* ⚡Improve styling

* ⚡Add blogposts

Co-authored-by: Amudhan <sm.amudhan@live.com>
 2021-01-14 13:56:07 +01:00
Jan Oberhauser 546b79bea0 👕 Fix lint issue 2020-10-22 18:00:28 +02:00
Jan Oberhauser 40c2acd77b 👕 Fix lint issue 2020-10-22 15:46:03 +02:00
Jan Oberhauser 6f576b3da9 ⚡ Add Schema to Postgres-Update #996 2020-09-29 21:59:30 +02:00
Jan Oberhauser 88b0147292 ⚡ Add allowUnauthorizedCerts to Postgres-Node 2020-08-25 17:02:01 +02:00
Rupenieks 6a8d22d2fa ⚡ Fixed return values from CrateDB update function 2020-08-02 20:23:53 +01:00
Jan Oberhauser df3077b5d2 👕 Fix lint issue 2020-07-14 13:59:37 +02:00
Jan Oberhauser 2a344fbb14 🔀 Merge branch 'master' into questdb-integration 2020-07-10 10:52:56 +02:00
Ben Hesseldieck a00fedb351
🎨 Extract postgres functionality (#737) 
* 🎉 executeQuery function extracted

* 🚧 add prettierrc to gitignore

* 🚧 insert function extracted

* ⚡ extract update function

* 💡 fix function docs

* 💡 add in code documentation

* 🎨 fix format

* 🎨 fix format
 2020-07-10 10:48:19 +02:00
Ben Hesseldieck 3bf34cffa9 🎨 fix format 2020-07-09 17:16:45 +02:00
smamudhan e07da55a1a
Typographical changes to ensure consistency with docs (#740) 
* Updated Dropdown Descriptions to match documentation

* Removed full stops and hyphens in field descriptions

* Removed hyphen on description on line 267

* Fixed typographical errors for Github node

* Fixed typo for Zoom Credentials

* Changed Postgres node description to match Postgres docs (https://github.com/n8n-io/n8n-docs/pull/30)

* Changed Rocketchat displayname to RocketChat

* Fixed typographical errors (and matched with docs) for Trello node descriptions

* Updated Jira node descriptions to match docs
 2020-07-09 14:33:05 +02:00
Ben Hesseldieck cdc42f5558 💡 add in code documentation 2020-07-08 15:12:54 +02:00
Ben Hesseldieck 10a26ee75d 💡 fix function docs 2020-07-08 14:39:44 +02:00
Ben Hesseldieck 2fea79f5f1 ⚡ extract update function 2020-07-08 14:36:40 +02:00
Ben Hesseldieck 0108538fcc 🚧 insert function extracted 2020-07-08 12:01:16 +02:00
Ben Hesseldieck 80aa0bd5dd 🚧 add prettierrc to gitignore 2020-07-08 09:32:21 +02:00
Ben Hesseldieck de707f039b 🎉 executeQuery function extracted 2020-07-07 18:31:38 +02:00
Jan Oberhauser a00c9e0efb 🐛 Fix issue that connections did not get closed 2020-04-08 08:43:16 +02:00
Jan Oberhauser 0d5723f50a ⚡ Small improvement to Postgres-Node 2020-03-18 09:26:40 +01:00
ricardo 5133f16e42 ⚡ Improvements to insert operation 2020-03-17 19:49:35 -04:00
Jan Oberhauser 24a3a02180 ⚡ Optimize integration icon images 2020-02-05 17:35:16 -08:00
Jan Oberhauser 03919a4c68 ⚡ Fix Postgres SSL support for existing none SSL connections 2020-01-14 17:20:41 -06:00
Kasra Rasaee 2c64aad2eb added basic ssl capability to postgres node 2020-01-10 10:21:45 +01:00
Jan Oberhauser 78af036231 ⚡ Close Postgres-Databank connection once node is done 2019-10-31 17:43:30 +01:00
Jan Oberhauser 3088a358f7 ✨ Add Postgres-Node 2019-08-21 18:44:10 +02:00