Iván Ovejero
dff8456382
refactor(core): Reorganize error hierarchy in core and workflow packages (no-changelog) ( #7820 )
...
Ensure all errors in `core` and `workflow` inherit from
`ApplicationError` so that we start normalizing all the errors we report
to Sentry
Follow-up to:
https://github.com/n8n-io/n8n/pull/7757#discussion_r1404338844
### `core` package
`ApplicationError`
- `FileSystemError` (abstract)
- `FileNotFoundError`
- `DisallowedFilepathError`
- `BinaryDataError` (abstract)
- `InvalidModeError`
- `InvalidManagerError`
- `InvalidExecutionMetadataError`
### `workflow` package
`ApplicationError`
- `ExecutionBaseError` (abstract)
- `WorkflowActivationError`
- `WorkflowDeactivationError`
- `WebhookTakenError`
- `WorkflowOperationError`
- `SubworkflowOperationError`
- `CliWorkflowOperationError`
- `ExpressionError`
- `ExpressionExtensionError`
- `NodeError` (abstract)
- `NodeOperationError`
- `NodeApiError`
- `NodeSSLError`
Up next:
- Reorganize errors in `cli`
- Flatten the hierarchy in `workflow` (do we really need
`ExecutionBaseError`?)
- Remove `ExecutionError` type
- Stop throwing plain `Error`s
- Replace `severity` with `level`
- Add node and credential types as `tags`
- Add workflow IDs and execution IDs as `extras`
2023-11-27 15:33:21 +01:00
कारतोफ्फेलस्क्रिप्ट™
35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) ( #7221 )
2023-10-27 14:17:52 +02:00
Val
bf74f09d69
feat(core): Add Tournament as the new default expression evaluator ( #6964 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-21 13:57:45 +01:00
Iván Ovejero
1197811a1e
fix(core)!: Allow syntax errors and expression errors to fail executions ( #6352 )
...
* fix: Unify expression error behavior for v1
* fix: Add `package.json` to `tsconfig.build.json`
* fix: Make `isFrontend` a constant
* fix: Use CommonJS require to read version
* fix: Use `JSON.parse()` and `fs.readFileSync()`
* feat(editor): Make WF name a link on /executions (#6354 )
* make wf name a link in exec view
* link color
* make wf name a link in exec view
* link color
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: Try restoring inclusions in tsconfig files
* fix: Try with copy
* refactor: Switch base branch and remove global toggle
* chore: Remove unrelated changes
* chore: Restore lockfile
* fix: Ensure all expression errors fail executions
* uncaught ExpressionErrors should not fail e2e tests
---------
Co-authored-by: romainminaud <romain.minaud@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-22 21:04:59 +02:00
कारतोफ्फेलस्क्रिप्ट™
da7ae2beef
fix(core): Prevent arbitrary code execution via expressions ( #6420 )
2023-06-14 13:15:27 +02:00
Iván Ovejero
06fa6f1fb3
ci: Expand ESLint to tests in BE packages (no-changelog) ( #6147 )
...
* 🔧 Adjust base ESLint config
* 🔧 Adjust `lint` and `lintfix` in `nodes-base`
* 🔧 Include `test` and `utils` in `nodes-base`
* 📘 Convert JS tests to TS
* 👕 Apply lintfixes
2023-05-02 10:37:19 +02:00
Val
39c871d514
test: Add expression transform tests ( #5497 ) (no-changelog)
...
test: add expression transform tests
2023-03-14 15:22:52 +00:00
Valya
287fa9cd06
test(core): Add basic expression tests (no-changelog) ( #5439 )
...
* test(core): add basic expression tests
* test: fix $if test not working properly
2023-02-10 10:05:34 +01:00
कारतोफ्फेलस्क्रिप्ट™
698d96a617
refactor: Setup typescript project references across workflow, core, and cli ( #4519 )
...
* refactor: use consistent folder structure across workflow, core, and cli
* setup typescript project references across workflow, core, and cli
2022-11-09 15:25:00 +01:00
Iván Ovejero
9089dbe942
perf(tooling): Upgrade to TypeScript 4.8 ( #4207 )
...
* ⬆️ Upgrade to TypeScript 4.8
* 🔥 Remove unneeded setting
* 📦 Update `package-lock.json`
* ⏪ Restore `skipLibCheck`
* 📦 Re-update `package-lock.json`
* ♻️ Apply feedback
* ♻️ Add check to new WhatsApp node
* 📦 Update `package-lock.json`
* Update package-lock.json
* ran `npm run lintfix`
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-10-05 13:36:09 +02:00
Mutasem Aldmour
679a443a0c
refactor: Add node IDs ( #3788 )
...
* update type
* add id to new nodes
* update paste/import behavior
* update duplicate/copy
* update duplicate workflow
* update import functions + templates
* add instance id on copy
* on download add instance id
* simplify for testing
* update telemetry events
* add ids to nodegraph
* not if same instance
* update spacing
* fix tests
* update tests
* add uuid
* fix tests
update tests
add uuid
fix ts issue
* fix telemetry event
* update workflow import
* update public api
* add sqlit migration
* on workflow update
* add psql migration
* add mysql migration
* revert to title
* fix telemetry bug
* remove console log
* remove migration logs
* fix copy/paste bug
* replace node index with node id
* remove console log
* address PR feedback
* address comment
* fix type issue
* fix select
* update schema
* fix ts issue
* update tel helpers
* fix eslint issues
2022-08-03 13:06:53 +02:00
Alex Grozav
d18a29d588
fix(core): Updated expressions allowlist and denylist. ( #3424 )
...
* feat: Updated expressions allowlist and denylist.
* test: Added unit tests for expression allow and deny list.
* feat: Updated riot-tmpl to be installed from n8n fork.
* fix: Added check for non-standard browser built-in.
* chore: Removed package-lock.json from branch.
* chore: Removed package-lock.json from branch.
* chore: Added jest-environment-jsdom@27
2022-06-17 22:09:37 -07:00
