Mutasem Aldmour
a2f628927d
feat(editor): Improve trigger panel ( #3509 )
...
* add panel
* add workflow activation hints
* support service trigger nodes
* update polling state
* support more views
* update when trigger panel shows
* update start/error nodes
* add cron/interval info box
* clean up start node
* fix up webhook views
* remove console log
* add listening state
* clean up loading state
* update loading state
* fix up animation
* update views
* add executions hint
* update views
* update accordian styling
* address more issues
* disable execute button if issues
* disable if it has issues
* add stop waiting button
* can activate workflow when dsiabled
* update el
* fix has issues
* add margin bttm
* update views
* close ndv
* add shake
* update copies
* add error when polling node is missing one
* update package lock
* hide switch
* hide binary data that's missing keys
* hide main bar if ndv is open
* remove waiting to execute
* change accordion bg color
* capitalize text
* disable trigger panel in read only views
* remove webhook title
* update webhook desc
* update component
* update webhook executions note
* update header
* update webhook url
* update exec help
* bring back waiting to execute for non triggers
* add transition fade
* set shake
* add helpful tooltip
* add nonactive text
* add inactive text
* hide trigger panel by default
* remove unused import
* update pulse animation
* handle empty values for options
* update text
* add flag for mock manual executions
* add overrides
* Add overrides
* update check
* update package lock; show button for others
* hide more info
* update other core nodes
* update service name
* remove panel from nodes
* update panel
* last tweaks
* add telemetry event
* add telemetry; address issues
* address feedback
* address feedback
* address feedback
* fix previous
* fix previous
* fix bug
* fix bug with webhookbased
* add extra break
* update telemetry
* update telemetry
* add telemetry req
* add info icon story; use icon component
* clean css; en.json
* clean en.json
* rename key
* add key
* sort keys alpha
* handle activation if active + add previous state to telemetry
* stop activation if active
* remove unnessary tracking
* remove unused import
* remove unused
* remove unnessary flag
* rewrite in ts
* move pulse to design system
* clean up
* clean up
* clean up
* disable tslint check
* disable tslint check
2022-06-20 12:39:24 -07:00
Iván Ovejero
70ae90fa3c
refactor: Apply more eslint-plugin-n8n-nodes-base
autofixable rules ( #3432 )
...
* ⚡ Update `lintfix` script
* 👕 Remove unneeded lint exceptions
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-description-miscased-url` (#3441 )
* 👕 Apply `rule node-param-placeholder-miscased-id` (#3443 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446 )
* 👕 Apply `node-param-min-value-wrong-for-limit` (#3442 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-wrong-for-dynamic-options` (#3454 )
* 🔨 fix
* ⚡ Fix `Assigned To` fields
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `rule node-param-default-wrong-for-number` (#3453 )
* 👕 Apply `node-param-default-wrong-for-string` (#3452 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-miscased` (#3449 )
* 🔨 fix
* 🔨 exceptions
* ⚡ review fixes
* 👕 Apply `node-param-description-lowercase-first-char` (#3451 )
* ⚡ fix
* ⚡ review fixes
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456 )
* Rule working as intended
* Add rule
* 🔥 Remove repetitions
* 👕 Add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Small fix for `node-param-description-wrong-for-dynamic-options`
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460 )
* 👕 Apply `node-param-description-line-break-html-tag` (#3462 )
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-options-type-unsorted-items` (#3459 )
* ⚡ fix
* 🔨 exceptions
* Add exception for Salesmate and Zoom
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Restore `lintfix` command
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
2022-06-03 19:23:49 +02:00
Iván Ovejero
63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base
autofixable rules ( #3243 )
...
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200 )
* Removing unneeded backticks (#3249 )
* 👕 Apply node-param-description-wrong-for-return-all (#3253 )
* 👕 Apply node-param-description-missing-limit (#3252 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258 )
* 👕 Apply `node-param-description-miscased-id` (#3254 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261 )
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-05-06 23:01:25 +02:00
Iván Ovejero
0448feec56
refactor: Apply eslint-plugin-n8n-nodes-base
autofixable rules ( #3174 )
...
* ⚡ Initial setup
* 👕 Update `.eslintignore`
* 👕 Autofix node-param-default-missing (#3173 )
* 🔥 Remove duplicate key
* 👕 Add exceptions
* 📦 Update package-lock.json
* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176 )
* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177 )
* 👕 Apply `node-class-description-outputs-wrong` (#3178 )
* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179 )
* 👕 Apply `node-param-default-wrong-for-collection` (#3180 )
* 👕 Apply node-param-default-wrong-for-boolean (#3181 )
* Autofixed default missing
* Autofixed booleans, worked well
* ⚡ Fix params
* ⏪ Undo exempted autofixes
* 📦 Update package-lock.json
* 👕 Apply node-class-description-missing-subtitle (#3182 )
* ⚡ Fix missing comma
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184 )
* 👕 Add exception for `node-class-description-missing-subtitle`
* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185 )
* 👕 Apply `node-param-collection-type-unsorted-items` (#3186 )
* Missing coma
* 👕 Apply `node-param-default-wrong-for-simplify` (#3187 )
* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190 )
* 👕 Apply `node-param-description-empty-string` (#3189 )
* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191 )
* Rule looks good
* Add whitespace rule in eslint config
* :zao: fix
* 👕 Apply `node-param-description-identical-to-display-name` (#3193 )
* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195 )
* ⏪ Revert ":zao: fix"
This reverts commit ef8a76f3df
.
* 👕 Apply `node-param-description-missing-for-simplify` (#3196 )
* 👕 Apply `node-param-description-missing-final-period` (#3194 )
* Rule working as intended
* Add rule to eslint
* 👕 Apply node-param-description-missing-for-return-all (#3197 )
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-04-22 18:29:51 +02:00
Iván Ovejero
4ae0f5b6fb
fix(editor): Fix i18n issues ( #3072 )
...
* 🐛 Fix `defaultLocale` watcher
* ⚡ Improve error handling for headers
* ✏️ Improve naming
* 🐛 Fix hiring banner check
* ⚡ Flatten base text keys
* ⚡ Fix miscorrected key
* ⚡ Implement pluralization
* ✏️ Update docs
* 🚚 Move headers fetching to `App.vue`
* fix hiring banner
* ⚡ Fix missing import
* ✏️ Alphabetize translations
* ⚡ Switch to async check
* feat(editor): Refactor Output Panel + fix i18n issues (#3097 )
* update main panel
* finish up tabs
* fix docs link
* add icon
* update node settings
* clean up settings
* add rename modal
* fix component styles
* fix spacing
* truncate name
* remove mixin
* fix spacing
* fix spacing
* hide docs url
* fix bug
* fix renaming
* refactor tabs out
* refactor execute button
* refactor header
* add more views
* fix error view
* fix workflow rename bug
* rename component
* fix small screen bug
* move items, fix positions
* add hover state
* show selector on empty state
* add empty run state
* fix binary view
* 1 item
* add vjs styles
* show empty row for every item
* refactor tabs
* add branch names
* fix spacing
* fix up spacing
* add run selector
* fix positioning
* clean up
* increase width of selector
* fix up spacing
* fix copy button
* fix branch naming; type issues
* fix docs in custom nodes
* add type
* hide items when run selector is shown
* increase selector size
* add select prepend
* clean up a bit
* Add pagination
* add stale icon
* enable stale data in execution run
* Revert "enable stale data in execution run"
8edb68dbff
* move metadata to its own state
* fix smaller size
* add scroll buttons
* update tabs on resize
* update stale data on rename
* remove metadata on delete
* hide x
* change title colors
* binary data classes
* remove duplicate css
* add colors
* delete unused keys
* use event bus
* update styles of pagination
* fix ts issues
* fix ts issues
* use chevron icons
* fix design with download button
* add back to canvas button
* add trigger warning disabled
* show trigger warning tooltip
* update button labels for triggers
* update node output message
* fix add-option bug
* add page selector
* fix pagination selector bug
* fix executions bug
* remove hint
* add json colors
* add colors for json
* add color json keys
* fix select options bug
* update keys
* address comments
* update name limit
* align pencil
* update icon size
* update radio buttons height
* address comments
* fix pencil bug
* change buttons alignment
* fully center
* change order of buttons
* add no output message in branch
* scroll to top
* change active state
* fix page size
* all items
* update expression background
* update naming
* align pencil
* update modal background
* add schedule group
* update schedule nodes messages
* use ellpises for last chars
* fix spacing
* fix tabs issue
* fix too far data bug
* fix executions bug
* fix table wrapping
* fix rename bug
* add padding
* handle unkown errors
* add sticky header
* ignore empty input, trim node name
* nudge lightness of color
* center buttons
* update pagination
* set colors of title
* increase table font, fix alignment
* fix pencil bug
* fix spacing
* use date now
* address pagination issues
* delete unused keys
* update keys sort
* fix prepend
* fix radio button position
* Revert "fix radio button position"
ae42781786
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2022-04-11 15:12:13 +02:00
Mutasem Aldmour
49bf786e5b
✨ Improve workflow activation ( #2692 )
...
* feat: activator disabled based on thiggers
* feat: tooltip over inactive switch
* feat: message for trigger types
* feat: deactivate on save if trigger is removed
* chore: refactor executions modal
* feat: calculate service name if possible
* feat: alert on activation
* chore: fix linting
* feat: always enable activator when active
* fix: adjust the alert
* feat: take disabled state into account
* feat: automatically save on activation
* feat: rely on nodes name and edit messages
* feat: isolate state for each activator instance
* feat: create activation modal component
* feat: activationModal checkbox and trigger message
* feat: add activation messages to node config
* chore: style activation modal
* chore: style fixes
* feat: refactor disabled state
* chore: refactor modal
* chore: refactor modal
* chore: tidy the node config
* chore: refactor and styling tweaks
* chore: minor fixes
* fix: check webhooks from ui nodes
* chore: remove saving prompt
* chore: explicit current workflow evaluation
* feat: add settings link to activation modal
* fix: immediately load executions on render
* feat: exclude error trigger from trigger nodes
* chore: add i18n keys
* fix: check localstorage more strictly
* fix: handle refresh in execution list
* remove unnessary event
* remove comment
* fix closing executions modal bugs
* update closing
* update translation key
* fix translation keys
* fix modal closing
* fix closing
* fix drawer closing
* close all modals when opening executions
* update key
* close all modals when opening workflow or new page
* delete unnessary comment
* clean up import
* clean up unnessary initial data
* clean up activator impl
* rewrite
* fix open modal bug
* simply remove error
* refactor activation logic
* fix i18n and such
* remove changes
* revert saving changes
* Revert "revert saving changes"
25c29d1055
* add translation
* fix new workflows saving
* clean up modal impl
* clean up impl
* refactor common code out
* remove active changes from saving
* refactor differently
* revert unnessary change
* set dirty false
* fix i18n bug
* avoid opening two modals
* fix tooltips
* add comment
* address other comments
* address comments
Co-authored-by: saintsebastian <tilitidam@gmail.com>
2022-01-21 18:00:00 +01:00
Oliver Trajceski
adc2515dee
✨ Improve Waiting Webhook call state in WF Canvas ( #2430 )
...
* N8N-2586 Improve Waiting Webhook call state in WF Canvas
* N8N-2586 Added watcher for showing Webhook's Node Tooltip on execution
* N8N-2586 Show helping tooltip for trigger node if wokrflow is running, it is a trigger node, if it is only one trigger node in WF
* N8N-2586 Rework/Move logic to computed property, Created getter for ActveTriggerNodesInWokrflow, Add style to trigger node's tooltip, remove comments
* N8N-2586 Added EventTriggerDescription prop in INodeTypeDescription Interface, Updated Logic for TriggerNode Tooltip based on the new prop
* N8N-2586 Add new use cases/watcher to show Trigger Nodes Tooltip / If has issues, if paused, if wokrlfow is running, Refactor Getter
* N8N-2586 Added z-index to tooltip, Added new Scenario for Tooltip if it is Draged&Droped on the WF
* N8N-2586 Refactor computed property for draged nodes
* N8N-2586 Fixed Conflicts
* N8N-2586 Fixed Tooltip
* N8N-2586 Dont show tooltip on core trigger nodes that execute automatically
* N8N-2586 Fixed Webhook tooltip when adding/deleting canvas during WF execution
* N8N-2586 Updated Logic, Simplify the code
* N8N-2586 Simplify Code
* N8N-2586 Added check for nodetype
* update dragging to use local state
* N8N-2586 Added eventTriggerDescription to Interval Node
* add comment, use new getter
* update to always check
Co-authored-by: Mutasem <mutdmour@gmail.com>
2021-11-25 23:33:41 +01:00
Iván Ovejero
766f74c782
🚚 Directorize and alphabetize nodes ( #2445 )
...
* 🚚 Directorize nodes
* ⚡ Alphabetize nodes and credentials
* 🔥 Remove unused node
* 🔥 Remove unused codex
* 🔥 Remove duplicate cred file references
* 🐛 Fix node file paths
* 🔥 Remove duplicate node reference
2021-11-17 17:30:14 +01:00