Commit graph

5868 commits

Author SHA1 Message Date
Ben Hesseldieck 97cd564f7b
feat(cli): User Management and Credentials sharing (#3602)
* 🎉 starting feature development

*  sharing/unsharing a credential (#3601)

* 🎉 initial design

*  sharing/unsharing of credentials

*  add tests for EE credentials controller

* 💪 implement review comments

* 🛠 refactor agent creation and credential role locking

* 👕 linting adjustments (#3691)

* 👕 Adjust rule `naming-convention`

* 👕 Fix `naming-convention` config value

* 👕 Disregard casing for EE-prefixed vars

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 🛠 refactor authAgents in tests (#3725)

* 🛠 refactor authAgent

* 🛠 refactor authAgent

* 🛠 refactor authAgent

* 🛠 refactor authAgent

* 👕 fix ts issue

* 🐘 add migration for mysql and postgres + add AuthAgent type

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* ️ refactor existing credentials routes (#3672)

* 🎉 initial design

*  sharing/unsharing of credentials

* ♻️ split credential update route into controller and service

* 🔥 remove credentials test that is no longer applicable

* ♻️ split credential creation route into controller and service

* ♻️ split single credential get

* ♻️ split delete credentials route

* ♻️ split get all credentials route

* 🔥 remove unused imports in credentials contoller

* 🔥 remove console.log

* :refactor: changes to credentials controller and service from review

 - removed credentials from service function names
 - made relations list optional
 - put allowGlobalOwner in options objects
 - check length of relations array so join doesn't happen if empty
 - update some comments to further explain rationale
 - remove unneeded `Object.assign`
 - remove non-null assertion from test

* ♻️ move filtered credentials selected fields to variable

* ♻️ remove unneeded merges in credentials service

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>

*  fix test

* 🐛 fix imports

* 👕 fix lint issue

* User Management: switch over to decorators to define routes (#3827)

* Add permissions details to credentials for User Management (#3863)

*  Open `GET /users`

*  Add permissions to cred service

* 🚚 Rename method

*  Refactor cred controller

* 🧪 Adjust test

* ✏️ Improve comment

* ✏️ Improve another comment

*  Account for multiple sharings

* 🐛 Fix access when user is editor

* 📘 Expand interface

* 📘 Relocate types

* 📘 Exempt cred entity with service-injected fields

* 📘 Adjust interface

* ♻️ Add permissions only in `GET /credentials`

* 🧪 Add expectations for `ownedBy`

* 🧪 Add sharing details test

* 🧪 Make `ownedBy` checks more granular

* 📘 Adjust interface

* 🚚 Rename cred getter

* ♻️ Refactor cred getter

* 🧪 Expand tests

* ♻️ Refactor to use guard

* 👕 Remove unneeded lint exception

* 🔥 Remove unneeded relation

* 🚚 Move relation to `GET /credentials/:id`

* 📘 Consolidate typings

* 🎨 Add multiline for readability

* 🔥 Remove unneeded type

* ✏️ Clarity comment

* ✏️ Make comments consistent

* 👕 Add exception to fix build

* 👕 Add more lint exceptions to fix build

* 🐛 Check for non-owner

* 📘 Improve typings

* 🧪 Temporarily skip tests

* 🔥 Remove `@ts-ignore`

* 👕 Move lint exceptions

* ♻️ Refactor cred service and controller

*  Simplify check

* ✏️ adjust naming to experimental

* ️ add credentialsSharing flag to settings

* 🛠 add helper to check if UM is also enabled as dependency for CredentialsSharing

* 👕 fix lint error

* 🐘 change name of credential role

* 🚧 WIP batch sharing

* 🚧 WIP use put for sharing

*  add tests for batch sharing, 🛠 implement review suggestions

*  expand credential sharing tests for User Management (#3931)

* 🧪 Expand cred sharing tests

*  Add recently added flags

*  fix and adjust tests for /credentials

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

*  User management v2 Front End (#3795)

* feat: Added responsive generic page view layout.

* feat: Added empty state.

* feat: Added credentials view empty state.

* test: Added unit tests for N8nActionBox

* feat: Added credentials list initial design.

* feat: Added credential actions. Started working on filters.

* feat: Updated InfoTip markup, added tests and changed stories to typescript.

* feat: Added credentials filtering by type. Added support for apply/reset filters.

* feat: Added credential sharing user select and user list. Added paywall component.

* feat: Updated credentials view permissions.

* feat: Added support for temporary sharing config for unsaved credentials.

* test: Fixed broken snapshots.

* feat: Added overflow styles to page-view-layout list.

* feat: Handled sharee specific views.

* feat: Integration between FE and BE to support real-world credential sharing scenario.

* feat: Added front end permissions table.

* feat: Refactored credential sharing flow. Updated design elements.

* feat: Added margin and padding auto spacer utilities.

* feat: Rehauled permissions to support instanceOwner role and action inheritance.

* feat: Updated credentials view to apply filters automatically.

* feat: Removed apply filters button and added active button state.

* test: Updated component snapshots.

* refactor: Renamed ResourceSharee to ResourceReader.

* feat: Credential sharing error handling, permissions improvement.

* feat: Updated permissions and error handling.

* chore: Removed console.log.

* 🛠 refactor enabling of credentialsSharing

* feat: Removed owner menu selector from credentials when sharing is disabled.

* refactor: Moved EE features into ee store module file.

* 🛠 add sharing info to GET credentials/:id

* fix: Fixed initial credential data loading for sharing.

* chore: Removed console.log.

* 🐛 owner can fetch any credential

* 🛠 refactor users test

* 👕 fix build type issue

* fix: Removed owner tag when credential sharing is disabled. Fixed small reactivity issue.

* chore: Removed console.log.

* 🚧 separate fetching credentials between EE and open

* fix: Fixed empty dropdown in users list.

* fix: Fixed error message and initialization when credential gets unshared.

*  add tests for fetching single credential

* Revert decorators based controllers

* ️ adjust credentials test route to also allow testing for sharees (#3999)

* ️ pull data if user is sharee

* fix: Removed sharedWith and ownedBy from credentialData on testing credentials.

Co-authored-by: Alex Grozav <alex@grozav.com>

* 📈 add BE analytics

* 💪 improve credential test

* ️ adjust tracking properties

* ️ removed roles from tracking

* 🐛 fix build by removing imports

* 🐛 fix missed merge conflict

* feat: User management P2 Front End bug bash and improvements (#4014)

* fix: Fixed type select size after reopening dropdown.

* fix: Fixed template cards.

* fix: Fixed card content size and copy input.

* fix: Fixed horizontal overflow.

* fix: Hiding el-tags scrollbar in select.

* fix: Added fallback credential icon. Added oAuth credential owner check.

* feat: Added disabled state to user select.

* feat: Added fallback scenario for non-existent credential types.

* feat: Adjusted credentials empty state to show that there are shared credentials.

* fix: Fixed time title.

* feat: Added actionable empty state when shared credentials are present.

* fix: Made action box x padding smaller

* feat: Repositioned owner tag for credential card.

* feat: Updated message box styling to use n8n css variables.

* feat: Added confirmation for deleting sharee.

* fix: Fixed deleted credential types. Fixed select in dropdown bug.

* fix: Various code improvements. Addressed PR review comments.

* fix: Fixed credential deletion errors.

* fix: Various code quality improvements.

* feat: N8N-4531 update cloud coming soon features (#4025)

* feat: Showing different upcoming feature messages and format for cloud.

* fix: Changed url format.

* fix: Updated how cloud deployment is determined.

* feat: N8N-4527 implementing credential sharing FE telemetry (#4023)

* feat: Added credential sharing telemetry.

* chore: Renamed computed function for consistency.

* refactor: Simplified subview telemetry sending.

* fix: Changed to callDebounced() helper.

* 📧 update email text

* fix: Adjusted feature coming soon margin.

* chore: Fixed type and line height for delete sharee confirmation modal.

* refactor(editor-ui): Update telemetry (#4040)

* 🔥 Remove `identify` from BE

*  Add `versionCli`

*  Add node creator ignore input

*  Move obfuscators to editor-ui

*  Refactor `ph-no-capture`

*  Pass `user_id` to manual exec props

* 🚚 Relocate class in `SettingsApiView`

*  Add `userId` to BE PH `identify` call

*  Revert " Add `userId` to BE PH `identify` call"

This reverts commit 895aaa45e5.

* Revert " Revert " Add `userId` to BE PH `identify` call""

This reverts commit b86a098c20.

* 🐛 Fix `Promise` handling in `track()` call

*  Restore `Db.collections` call

*  Set up PH payload to mirror RS

* 🔥 Remove excess `userId`

* 📘 Remove `userId` from interface

* 🔥 Remove unused ref and method

* fix: Fixed bug causing instanceOwner to become credential owner on update. (#4079)

* 🐛 fix test for credential shared with member

* 👕 fix lint issues

* delete conflicting migration. this data is already seeded in CreateUserManagement

* feat: Expand obfuscation to User Management credential sharing (#4070)

 Expand obfuscation

* feat: Added credential sharing infotip for instance owner.

* bring back the migration. add a check to avoid conflicts on inserts

* fix(cli): use a non-env config flag to detect of enterprise features are enabled (#4105)

* chore: Changed ampersand to and in translation.

* refactor(telemetry): Obfuscate code and JSON editors (#4118)

 Obfuscate code and JSON editors

* feat(editor): improve design and functionality of coming soon features (#4116)

* feat: Improved coming soon feature design and functionality.

* style: Removed empty line.

* chore: Removed unused translation.

* fix: fix telemetry for credential creates and updates (#4125)

fix telemetry for credential creates and updates

* feat: Display errors due to missing credentials in the correct node (#4124)

feat: Display errors due to invalid credentials in the correct node when missing permissions

* fix: remove duplicate header for coming soon features in cloud deployment

* telemetry: fix the payload for `User viewed credential tab`

* telemetry: add credential_id to 'User selected credential from node modal'

* feat: update empty states for coming soon features

* Update ActionBox.spec.ts.snap

* replace UserSharingsDetails with a subset of User properties

* rename the CreateCredentialsEditorRole to CreateCredentialsUserRole

* move IUser to the workflow package

* use IUser in the frontend as well

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Valya <68596159+valya@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2022-09-21 10:20:29 +02:00
कारतोफ्फेलस्क्रिप्ट™ 4d8c380bef
fix(node-dev): fix the custom node build command (#4148)
* fix(node-dev): fix the custom node build command

also
* wait for the build command to finish before logging the success message
* use module relative paths for looking up `tsconfig` and `tsc` using `require.resolve`

* copy over svg files as well

* copy over the static files before the compilation step

this makes sure that these files are also copied over with `--watch`
2022-09-21 09:36:44 +02:00
Ikko Ashimine e20982442b
refactor(nodes-base): Fix typo in Sentry.io node (#4102) 2022-09-21 09:19:06 +02:00
Jonathan Bennetts 3cfc5b55ab
fix(box Node): fix issue with response data not being returned (#4147) 2022-09-20 14:34:00 +01:00
Jonathan Bennetts 3e2e9e6009
fix(xero Node): fix line amount types being ignored when creating new invoices (#4146) 2022-09-20 14:33:29 +01:00
Omar Ajoue a8030dbda5
fix(expression): prevent calls to constructor to forbid arbitrary code execution (#4139)
* fix(expression): prevent calls to constructor to forbid arbitrary code execution
2022-09-20 10:41:37 +02:00
Iván Ovejero 479f78b3bc
refactor(telemetry): Fix metadata on personalization survey (#4123)
🐛 Fix metadata on personalization survey
2022-09-20 08:55:12 +02:00
iammordaty 5f4830b275
test(cli): Remove console.log (#4136) 2022-09-19 14:36:17 +02:00
Cornelius Suermann 90067f5c7e
docs(license): add common header to packages/cli/LICENSE.md (no-changelog) (#4134)
docs(license): add common header to packages/cli/LICENSE.md
2022-09-19 13:35:38 +02:00
Csaba Tuncsik 762e00570a
refactor(editor): Showing errors in input pane (#4059)
* refactor(editor): removing output error reporting from input panel

* refactor(editor): input panel error notification with linking back to the errored node

* fix(editor): switching to the correct node after backlinking from the error in a further node

* fix(editor): input pane error message font size and translation keys

* fix(editor): output error message layout

* fix(editor-ui): update input panel node error title translation

* fix(editor-ui): achieve proper update when changing node from input error link

* fix(editor-ui): adding local utility class to not break output error layout
2022-09-19 12:26:02 +02:00
Jan Oberhauser f8ef2e99fa refactor(Shopify Trigger Node): Remove console.log 2022-09-17 09:32:11 +02:00
Ricardo Espinoza 28ab4f66f0
fix(public-api): Create correct OAuth2 credential schema (#4111) 2022-09-16 10:12:59 -04:00
Ricardo Espinoza 0ab89ad5d6
fix(HTTP Node): fix instance crashing when batching enabled (#3902)
* 🐛 Fix instance crashing when batching enabled

* Add flag parsing for simple mode

* 🐛 Fix issue with simple flag

*  improvements

*  Improvements

* 🔥 Remove console.log

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2022-09-15 16:32:13 -04:00
Ricardo Espinoza 6c41b29ad2
fix(cli): Fix issue with n8n crashing when error in poll method (#4008)
* 🐛 Fix issue with n8n crashing when error in poll method

* Remove unnecessary imports and add async property

* Remove unnecessary imports

*  Move createErrorExecution to genericHelper

*  Improvements

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2022-09-15 16:16:54 -04:00
Jan Oberhauser d2835e1815 🔖 Release n8n@0.194.0 2022-09-15 14:36:26 +00:00
Jan Oberhauser f463c22d2d ⬆️ Set n8n-core@0.134.0, n8n-editor-ui@0.160.0, n8n-nodes-base@0.192.0 and n8n-workflow@0.116.0 on n8n 2022-09-15 14:36:25 +00:00
Jan Oberhauser 28d690ca6a 🔖 Release n8n-editor-ui@0.160.0 2022-09-15 14:34:42 +00:00
Jan Oberhauser 3b28239a43 ⬆️ Set n8n-design-system@0.34.0 and n8n-workflow@0.116.0 on n8n-editor-ui 2022-09-15 14:34:42 +00:00
Jan Oberhauser ce4c0b9cba 🔖 Release n8n-design-system@0.34.0 2022-09-15 14:34:34 +00:00
Jan Oberhauser be54f0a32a 🔖 Release n8n-nodes-base@0.192.0 2022-09-15 14:33:49 +00:00
Jan Oberhauser d87a05a9db ⬆️ Set n8n-core@0.134.0 and n8n-workflow@0.116.0 on n8n-nodes-base 2022-09-15 14:33:48 +00:00
Jan Oberhauser 7451b8f17c 🔖 Release n8n-node-dev@0.73.0 2022-09-15 14:33:39 +00:00
Jan Oberhauser e6be3d352b ⬆️ Set n8n-core@0.134.0 and n8n-workflow@0.116.0 on n8n-node-dev 2022-09-15 14:33:39 +00:00
Jan Oberhauser 3c436ed2b5 🔖 Release n8n-core@0.134.0 2022-09-15 14:33:28 +00:00
Jan Oberhauser 9ec2eacbd6 ⬆️ Set n8n-workflow@0.116.0 on n8n-core 2022-09-15 14:33:28 +00:00
Jan Oberhauser eb650419a0 🔖 Release n8n-workflow@0.116.0 2022-09-15 14:33:16 +00:00
Jan Oberhauser 76b0dd9de5 refactor(Merge Node): Change parameter names 2022-09-15 16:31:20 +02:00
Omar Ajoue 5130529066
fix: AWS credential testing issue (#4107) 2022-09-15 15:03:16 +02:00
Iván Ovejero 680d255df5
refactor(telemetry): Add personalization survey event to PostHog (#4093)
 Add personalization survey event to PH
2022-09-15 13:31:19 +02:00
Csaba Tuncsik ec2c55211c
refactor(design-system): merge n8n square button into n8n button (#4075)
* feat(design-system): button as square shape

* refactor(editor-ui): drop n8n-square-button in favor of n8n-button

* refactor(design-system): remove obsolete n8n-square-button

* fix(design-system): icon only square button icon position

* fix(design-system): icon only square button icon position

* chore(design-system): update button test snapshot

* fix(design-system): overriding default square button styles

* fix(editor-ui): using tertiary button variant in survey without local style overrides

* refactor(design-system): simplifying and partially merging icon-button and button

* fix(design-system): remove unused prop from icon-button

* fix(design-system): square button should have the old dimensions

* fix(design-system): square button update test snapshots
2022-09-15 11:41:12 +02:00
Iván Ovejero 98ed207607
feat(core, editor-ui): Introduce node deprecation (#4103)
 Introduce node deprecation
2022-09-15 10:52:24 +02:00
Mike Arvela f40ae501b4
fix(public-api): Fix error updating workflow with property not defined in the schema (#4089)
* fix(cli): catch errors on updating workflow

*  Don\'t allow additionalProperties in the workflow schema

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-09-14 11:40:45 -04:00
Alex Grozav 9a59d0a5d1
feat(Adalo Node): MVP Adalo node N8N-3263 (#3102)
*  Added Adalo node using declarative API.

* fix: Updated authentication headers.

* fix: Fixed node linting issues.

*  improvements

* fix: Fixed Adalo node pagination.

* fix: Fixed Adalo node linting issues.

Co-authored-by: Michael Kret <michael.k@radency.com>
2022-09-14 13:36:53 +03:00
Michael Kret f70e6d2345
fix(MongoDb Node): update mongo driver to 4.9.1 n8n-2622 (#4095) 2022-09-14 12:54:05 +03:00
कारतोफ्फेलस्क्रिप्ट™ 43c9f019bd
fix(cli): use absolute paths for loading custom nodes and credentials (#4099)
custom-node loading broke because of this change, as we started using relative paths for the files returned by `glob` #4082
2022-09-14 10:37:51 +02:00
freya a8127dfc05
test(core): WorkflowCredentials Test Suite 2022-09-14 09:19:44 +01:00
freya dd3ba96372
fix(core): update oauth endpoints to use instance base url 2022-09-14 09:05:31 +01:00
कारतोफ्फेलस्क्रिप्ट™ 461848fcc4
fix(cli,core): Address Dependabot warnings [N8N-4121] (#3883)
* feat(cli): upgrade passport

* feat(core): upgrade file-type

* force upgrade browserslist

* force upgrade ejs

* force upgrade globby and fork-ts-checker-webpack-plugin
2022-09-14 09:50:33 +02:00
Omar Ajoue 9e1fa4c045
fix: Issue with versioned nodes not loading properly (#4094) 2022-09-13 17:46:47 +02:00
OlegIvaniv ea2d18b66d
feat(editor): Implement HTML sanitization for Notification and Message components (#4081)
* feat(editor): Implement HTML sanitization when using `dangerouslyUseHTMLString` option of Notification and Message components

* 🐛 Implement mechanism to allow for A href actions from locale strings

* 🐛 Prevent link action default

* ♻️ Use `xss` library instead of `sanitize-html` to handle sanitization

* 🔥 Remove `onLinkClick` functionality of `$showMessage`
2022-09-13 17:39:47 +02:00
Michael Kret 381c09fa47
fix(core): Fix node renaming in expressions 2022-09-13 18:09:16 +03:00
OlegIvaniv 8c95d6ec53
feat(editor): Show input number for multi-input nodes (#4000)
* feat(editor): Show input number for multi-input nodes

*  Added multiple inputs detection logic to input panel

* 🐛 Fix a case where Input 1 and Input 2 are identical, do not display nodeIndex for single input nodes

* 🔥 Delete unused `MERGE_NODE_TYPE` constant

* ♻️ Get input names dynamically for multi-input nodes

Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2022-09-13 15:42:44 +02:00
freya 36ec81f624
fix(node): Google Cloud Storage linting rules 2022-09-13 12:41:08 +01:00
freya 1e963d8e1e
feat(GoogleCloudStorage Node): add GCS Node with Bucket and Object operations 2022-09-13 12:03:17 +01:00
Iván Ovejero 3a9c7acb04
refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many (#4064)
* 👕 Enable rule

* ⬆️ Upgrade linter

* 📦 Update `package-lock.json`

* 👕 Apply rule

* ✏️ Fix plurals

* ✏️ More typos

* ✏️ Final typos
2022-09-13 12:36:36 +02:00
Jonathan Bennetts 9f92a4d681
fix(googleBigQuery Node): fix empty response when creating records (#4056) 2022-09-13 08:55:58 +01:00
Csaba Tuncsik c4fd8ce28b
refactor(editor-ui): leverage the editor url in frontend (#4085)
* refactor(editor-ui): remove unused interfaces

* refactor(editor-ui): add urlBaseEditor setting to application state

* fix(editor-ui): webhook urls for test and production

* fix(editor-ui): jsPlumb Anchor interface
2022-09-13 09:54:23 +02:00
Michael Kret f1a569791d
feat(Merge Node): overhaul of merge node 2022-09-13 08:59:49 +03:00
कारतोफ्फेलस्क्रिप्ट™ b6c1187922
fix(cli): load nodes and credentials on windows using the correct file-path (#4084) 2022-09-12 18:48:50 +02:00
Jonathan Bennetts 3de0e228cb
fix(core): fix issue with returnJsonArray helper breaking nodes that return no data 2022-09-12 16:30:47 +01:00