Commit graph

30 commits

Author SHA1 Message Date
Iván Ovejero 1d27a9e87e
Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
lublak 5da61ef252
Replace some fallback values to match the value type (#1421) 2021-03-08 18:45:35 +01:00
Jan Oberhauser 2c834ef9c4 Minor improvements to Slack-Node 2021-01-25 14:56:59 +01:00
tumf 025272953e
Add message.delete in Slack nodes (#1377) 2021-01-25 14:56:37 +01:00
Jan Oberhauser 09f075cc5a Minor improvements to Slack:getPermalink 2021-01-23 12:17:38 +01:00
ricardo 39fd7dc8ce Small improvements to #1366 2021-01-22 15:23:50 -05:00
tumf 2bd05abc3e Add chat.getPermalink interface in Slack Nodes. 2021-01-22 13:22:33 +09:00
Iván Ovejero 46e9af9646
Move Slack params to other options (#1339)
*  Move Slack params to other options

*  Minor improvements to Slack Node

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-01-15 10:42:35 +01:00
Ricardo Espinoza 9b6f0ee3ee
Add Ephemeral Message support (#1302)
* Add postEphemeral on Slack node

*  Add ephemeral option to message:post

*  Small fix

Co-authored-by: davinerd <anathema@anche.no>
2021-01-07 08:26:17 +01:00
Ricardo Espinoza 532503b69f
Feature/slack node extended (#1239)
* Added reaction method to message

* Increased limit for channels on getChannels, removed unused fields in the code

* Using own operation for reactions

* Registering reaction fields and operations

* Added Operation "Reaction" to Slack.node.ts

* Fixing variable name for emoji

* now removing reaction on "remove" instead of "add"

* Using GET for reactions.get and passing arguments as query

* Added members operation

* Fixed typo in timestamp

* Added user.info and user.getPresence

* Fixed: wrong operation name

*  Improvements to #1238

*  Add field resolve data when retrieving channel members

*  Minor improvements to Slack-Node

Co-authored-by: Andreas Scherren <ascherren@brightfuture.de>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2020-12-13 10:47:52 +01:00
Ricardo Espinoza 1b724db3c2
Now private and public channels are loaded (#1222)
Fixes #1210
2020-12-02 12:54:19 +01:00
Ricardo Espinoza 1b0dda6ddc
🐛 Fix parameters when inviting a user in Slack #1175 & #1130 (#1202)
- User IDs parameter is not allow when creating a channel so it got removed.
- User field is not valid when inviting a user to a channel. Correct name should be users so it got renamed to it.
2020-11-24 09:09:00 +01:00
Jan Oberhauser 40c2acd77b 👕 Fix lint issue 2020-10-22 15:46:03 +02:00
Ricardo Espinoza 39c173a272
Feature/slack status change (#995)
* Added methods to set and get the user's status.

* Fixed set status message

* Improvements to #993

* 💄 small cosmetic change

Co-authored-by: Tobias Schulz-Hess <tobias+xps@schulz-hess.de>
Co-authored-by: Tobias Schulz-Hess <tobias.schulz-hess@xing.com>
2020-10-02 07:31:41 +02:00
Jan Oberhauser fe802c8f76 👕 Fix built issue by fixing lint issues 2020-10-01 15:18:47 +02:00
Jean Baptiste Noblot e863254272
👕 replace coma in semicolon when end of line (#802) 2020-07-30 11:35:36 +02:00
Jan Oberhauser fcfef158cb 🔀 Merge branch 'zoom' of https://github.com/MLH-Fellowship/n8n into MLH-Fellowship-zoom 2020-07-06 11:50:49 +02:00
Innokenty Lebedev fe56c8778d
🐛 Fix slack as_user (#708)
* Ignore as_user only when it is false

* Update as_user description
2020-07-05 11:19:13 +02:00
shraddha shaligram c282a25876 add files 2020-06-22 11:54:49 -07:00
shraddha shaligram b95e3464a4 add meeting functionality 2020-06-22 11:51:15 -07:00
Ricardo Espinoza 54a670c0de
🐛 Fixes issue #651 and #652 (#668)
* 🐛 Fixes issue #651 and #652

*  Added description to username field
2020-06-20 18:11:11 +02:00
Jan Oberhauser a6add045bd Fix some minor issues with OAuth2 2020-05-31 19:24:14 +02:00
Jan Oberhauser 147c50485c 🔀 Merge branch 'master' into oauth-support 2020-05-12 01:56:27 +02:00
ricardo 2d3f02e32c added interactive messages (buttons) 2020-05-05 13:22:08 -04:00
Jan Oberhauser ff7f0a5de5 Fix some issues with Slack-Node 2020-03-15 15:51:49 +01:00
Ricardo Espinoza ba22ab02d8 Added missing resources 2020-03-13 16:45:44 +01:00
Ricardo Espinoza fe36c9c76a setup 2020-03-05 18:26:44 -05:00
Jan Oberhauser 6246d0a08c 💄 Add subtitle to Slack-Node 2019-07-26 13:13:01 +02:00
Jan Oberhauser c6a55113e3 Update operation selection on Slack-Node 2019-07-14 18:43:58 +02:00
Jan Oberhauser 9cb9804eee Initial commit to release 2019-06-23 12:35:23 +02:00