mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-15 00:54:06 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
11883 commits 1052 branches 1593 tags 392 MiB
Commit graph

595 commits

Author SHA1 Message Date
Iván Ovejero 6a43710859
refactor(core): Remove license from execution repository (no-changelog) (#9726) 2024-06-13 11:43:21 +02:00
Iván Ovejero 797342343f
perf(core): Introduce concurrency control for main mode (#9453) 2024-06-12 15:05:43 +02:00
Ricardo Espinoza dda7901398
fix: Introduce HooksService (#8962) 2024-06-11 07:28:45 -04:00
कारतोफ्फेलस्क्रिप्ट™ 6ba789aa6d
ci: Remove unused WaitTracker mocking (no-changelog) (#9694) 2024-06-11 10:28:52 +02:00
Mutasem Aldmour 50bd5b9080
feat: Update NPS Value Survey (#9638) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
 2024-06-11 10:23:30 +02:00
Iván Ovejero aaa78435b0
refactor(core): Remove event bus channel (no-changelog) (#9663) 2024-06-11 10:02:23 +02:00
Iván Ovejero 817167cf4b
refactor(core): Merge event bus controllers and remove dead code (no-changelog) (#9688) 2024-06-10 17:38:02 +02:00
Iván Ovejero b8338e3610
refactor(core): Revamp crash recovery mechanism for main mode (#9613) 2024-06-07 16:19:59 +02:00
Cornelius Suermann 44ecab73d7
feat: Release floating entitlements on license:clear command (no-changelog) (#9603) 
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2024-06-07 13:13:31 +02:00
Danny Martini 6187cc5762
feat(core): Implement project:viewer role (#9611) 2024-06-06 11:55:48 +02:00
Iván Ovejero 411ffbda7f
fix(core): Ensure ID is a positive integer when fetching execution (#9629) 2024-06-05 13:05:07 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1563bf571d
refactor(core): Move curl endpoint to its own controller (no-changelog) (#9605) 2024-06-05 10:43:09 +02:00
Iván Ovejero 375b347b0f
refactor(core): Restore test for execution pagination in Public API (no-changelog) (#9621) 2024-06-05 10:14:01 +02:00
Danny Martini 202c91e7ed
feat(core): Allow transferring credentials from any project to any team project (#9563) 2024-06-04 13:54:48 +02:00
कारतोफ्फेलस्क्रिप्ट™ 08d9c9a787
fix(core): Start WaitTracker only in the main container (#9600) 2024-06-03 17:43:24 +02:00
Danny Martini d6db8cbf23
feat(core): Allow transferring workflows from any project to any team project (#9534) 2024-06-03 16:57:04 +02:00
कारतोफ्फेलस्क्रिप्ट™ 7be616e583
feat(core): Allow customizing rate limits on a per-route basis, and add rate limiting to more endpoints (#9522) 
Co-authored-by: Omar Ajoue <krynble@gmail.com>
 2024-06-03 11:20:51 +02:00
Danny Martini 8da0d6e9ba
fix(core): Fix type errors (no-changelog) (#9571) 2024-05-31 14:06:13 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5887ed6498
refactor(core): Extract all Auth-related User columns into a separate entity (#9557) 
Co-authored-by: Ricardo Espinoza <ricardo@n8n.io>
 2024-05-31 09:40:19 +02:00
कारतोफ्फेलस्क्रिप्ट™ 08902bf941
refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527) 2024-05-31 09:40:03 +02:00
Danny Martini a221215b87
test(core): Rename and combine all credential api tests (no-changelog) (#9550) 2024-05-30 18:01:38 +02:00
कारतोफ्फेलस्क्रिप्ट™ 596990bed7
ci: Fix vulnerable dev dependencies (no-changelog) (#9545) 2024-05-30 13:54:29 +02:00
Iván Ovejero dbaac82f79
fix(core): Set source control repository to track remote if ready (#9532) 2024-05-29 10:21:21 +02:00
कारतोफ्फेलस्क्रिप्ट™ ac4e0fbb47
fix(core): Block Public API related REST calls when Public API is not enabled (#9521) 2024-05-28 14:43:22 +02:00
Danny Martini e07de837b9
test(core): Align test names with route names (no-changelog) (#9518) 2024-05-27 20:41:34 +02:00
Iván Ovejero a58be175cc
fix(core): Prevent re-parsing of dynamically loaded options (#9503) 2024-05-24 11:00:15 +02:00
कारतोफ्फेलस्क्रिप्ट™ b585777c79
refactor(core): Use consistent CSRF state validation across oAuth controllers (#9104) 
Co-authored-by: Danny Martini <danny@n8n.io>
 2024-05-23 19:08:01 +02:00
Danny Martini 3b93aae6dc
feat(core): Print the name of the migration that cannot be reverted when using n8n db:revert (#9473) 2024-05-23 18:16:26 +02:00
Iván Ovejero 75408b0113
refactor: Remove skipped tests (no-changelog) (#9497) 2024-05-23 12:29:20 +02:00
Iván Ovejero 9bdc83a399
perf(core): Optimize executions filtering by metadata (#9477) 2024-05-22 17:20:01 +02:00
Iván Ovejero bc219e0499
refactor(core): Make execution status non-nullable (no-changelog) (#9483) 2024-05-22 16:56:05 +02:00
कारतोफ्फेलस्क्रिप्ट™ fc83005ba0
fix(core): Do not allow admins to delete the instance owner (#9489) 2024-05-22 16:23:40 +02:00
कारतोफ्फेलस्क्रिप्ट™ 88b9a4070b
fix(core): Do not allow admins to generate password-reset links for instance owner (#9488) 2024-05-22 16:13:56 +02:00
Iván Ovejero a217866cef
fix(core): Account for retry of execution aborted by pre-execute hook (#9474) 2024-05-22 15:22:07 +02:00
Omar Ajoue c1eef60ccd
test: Add tests for license manager reinit method (#9471) 2024-05-22 10:26:49 +01:00
Iván Ovejero d21ad15c1f
fix(core): Fix 431 for large dynamic node parameters (#9384) 2024-05-21 19:11:02 +02:00
Csaba Tuncsik 596c472ecc
feat: RBAC (#8922) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Valya Bullions <valya@n8n.io>
Co-authored-by: Danny Martini <danny@n8n.io>
Co-authored-by: Danny Martini <despair.blue@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: oleg <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Elias Meire <elias@meire.dev>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Ayato Hayashi <go12limchangyong@gmail.com>
 2024-05-17 10:53:15 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5025d209ca
fix(core): All calls to plainToInstance should exclude extraneous values (no-changelog) (#9338) 2024-05-08 15:49:41 +02:00
Milorad FIlipović cda062bde6
feat(editor): Remove AI Error Debugging (#9337) 2024-05-08 14:13:47 +02:00
Danny Martini 225fdbb379
fix(core): Report missing SAML attributes early with an actionable error message (#9316) 2024-05-07 10:27:44 +02:00
Iván Ovejero 7b925ab871
refactor(core): Rename ActiveWorkflowRunner to ActiveWorkflowManager (no-changelog) (#9280) 2024-05-06 17:54:05 +02:00
Iván Ovejero 22b6f90950
fix(core): Prevent occassional 429s on license init in multi-main setup (#9284) 2024-05-06 09:04:16 +02:00
Iván Ovejero 7bda92cc7c
refactor(core): Use logger for packages/cli messages (no-changelog) (#9302) 2024-05-03 15:24:27 +02:00
Alex Grozav cd9bc44bdd
feat: Add Ask AI to HTTP Request Node (#8917) 2024-05-02 13:52:15 +03:00
Danny Martini 1efeeccc5b
fix(core): Fix browser session refreshes not working (#9212) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-04-24 18:28:19 +02:00
Alex Grozav a3eea3ac5e
feat(editor): Refactor and unify executions views (no-changelog) (#8538) 2024-04-19 07:50:18 +02:00
Danny Martini 3eb5be5f5a
fix(core): Don't create multiple owners when importing credentials or workflows (#9112) 2024-04-12 17:25:59 +02:00
Danny Martini 3bb821f10e
fix(core): Don't revert irreversibble migrations (#9105) 2024-04-11 09:20:48 +02:00
Iván Ovejero a3b59843d5
refactor(core): Lint for cyclomatic complexity in BE packages (no-changelog) (#9111) 2024-04-10 14:02:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ 9403657e46
refactor(core): Remove unnecessary indirection in SAML code (no-changelog) (#9103) 2024-04-10 10:55:49 +02:00
कारतोफ्फेलस्क्रिप्ट™ a7108d14f9
fix(core): Some more browser-id related fixes (no-changelog) (#9102) 2024-04-10 10:37:23 +02:00
Iván Ovejero c2f4d7d796
fix(core): Fix isLeader check in WaitTracker constructor (#9100) 2024-04-09 15:50:10 +02:00
कारतोफ्फेलस्क्रिप्ट™ 28261047c3
feat(core): Prevent session hijacking (#9057) 2024-04-09 11:20:35 +02:00
Iván Ovejero 7bf0f900f1
fix(core): Remove binary data when deleting executions by filter (#9056) 2024-04-05 18:00:35 +02:00
Iván Ovejero 0c90c7c8c1
fix(API): Accept settings.executionOrder in workflow creation (#9072) 2024-04-05 17:49:14 +02:00
Iván Ovejero ff81de3313
fix(core): Ensure TTL safeguard for test webhooks applies only to multi-main setup (#9062) 2024-04-05 14:15:49 +02:00
कारतोफ्फेलस्क्रिप्ट™ ff77ef4b62
ci: Delete some duplicate code in cli tests (no-changelog) (#9049) 2024-04-05 13:47:49 +02:00
Iván Ovejero b8ab049932
refactor(core, editor): Remove legacy nodesAccess (no-changelog) (#9016) 2024-04-05 13:17:34 +02:00
Iván Ovejero 217b07d735
fix(core): Ensure only leader handles waiting executions (#9014) 2024-04-04 13:28:20 +02:00
कारतोफ्फेलस्क्रिप्ट™ 76b73a27a0
refactor(core): Delete all auth exclusion config and checks (no-changelog) (#9044) 2024-04-03 16:56:36 +02:00
कारतोफ्फेलस्क्रिप्ट™ 072c3db97d
refactor(core): Rename push sessionId to pushRef (#8905) 2024-04-03 13:43:14 +02:00
कारतोफ्फेलस्क्रिप्ट™ a6446fe057 feat(core): Rate-limit login endpoint to mitigate brute force password guessing attacks (#9028) 2024-04-03 12:15:19 +02:00
Iván Ovejero 260bc07ca9
fix(core): Assign credential ownership correctly in source control import (#8955) 2024-03-26 17:18:41 +01:00
कारतोफ्फेलस्क्रिप्ट™ 372d5c7d01
ci: Upgrade eslint, prettier, typescript, and some other dev tooling (no-changelog) (#8895) 
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2024-03-26 14:22:57 +01:00
Iván Ovejero ef45da95f1
test(core): Improve coverage for ActiveWorkflowRunner (no-changelog) (#8946) 2024-03-25 17:59:59 +01:00
Iván Ovejero 69807a5efb
refactor(core): Unify failed and error execution status (no-changelog) (#8943) 2024-03-25 17:52:07 +01:00
Iván Ovejero 079a1147d4
fix(core): Ensure the generic OAuth2 API credential uses the OAuth2 credential test (#8941) 2024-03-21 13:49:34 +01:00
Alex Grozav 948c383999
feat: Add AI Error Debugging using OpenAI (#8805) 2024-03-13 16:48:00 +02:00
कारतोफ्फेलस्क्रिप्ट™ 71f1b23771
feat(core): Update some packages to address CVE-2022-29622 (no-changelog) (#8877) 2024-03-13 12:47:36 +01:00
Danny Martini 11173a0114
fix: Ignore semver range when upgrading comunity packages (#8863) 2024-03-11 17:12:20 +00:00
Omar Ajoue c6f6254c0e
fix: Always register webhooks on startup (#8830) 2024-03-07 09:25:12 +00:00
Val 0e037add71
fix: PermissionChecker integration tests (no-changelog) (#8776) 2024-03-05 19:18:34 +01:00
कारतोफ्फेलस्क्रिप्ट™ 0818824a72
feat(core)!: Set the secure flag on issued cookies (#8812) 2024-03-05 18:57:41 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2b0e14e936
fix(core): Refactor push sessionid validation, and add unit tests (no-changelog) (#8815) 2024-03-05 18:57:29 +01:00
कारतोफ्फेलस्क्रिप्ट™ cdec7c9334
feat(core): Update hashing strategy for JWTs (#8810) 2024-03-05 15:06:29 +01:00
कारतोफ्फेलस्क्रिप्ट™ d1b48ddcac
fix(core): Remove sensitive data from User entity during serialization (no-changelog) (#8773) 2024-02-29 14:20:39 +01:00
कारतोफ्फेलस्क्रिप्ट™ db4a419c8d
refactor(core): Enforce authorization by default on all routes (no-changelog) (#8762) 2024-02-28 17:02:18 +01:00
कारतोफ्फेलस्क्रिप्ट™ 56c8791aff
refactor(core): Remove all legacy auth middleware code (no-changelog) (#8755) 2024-02-28 13:12:28 +01:00
Omar Ajoue 737170893d
feat: Allow instance owners and admins to edit all credentials (#8716) 
Co-authored-by: Danny Martini <despair.blue@gmail.com>
 2024-02-27 08:26:36 +00:00
Jan Oberhauser a29b41ec55
fix(core): Fix pairedItem issue with partial manual executions (#8575) 
Co-authored-by: Danny Martini <danny@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-02-23 11:43:08 +01:00
कारतोफ्फेलस्क्रिप्ट™ 059d281fd1
feat(core): Move execution permission checks earlier in the lifecycle (#8677) 2024-02-21 14:47:02 +01:00
Tomi Turtiainen 05e13a68ea
fix: Fix typeorm .save usage (no-changelog) (#8678) 2024-02-20 17:34:54 +02:00
कारतोफ्फेलस्क्रिप्ट™ b6c8a0c413
refactor(core): Reduce code duplication in DB config (no-changelog) (#8679) 2024-02-20 14:28:53 +01:00
Omar Ajoue a743a40376
feat(API): Add tag support to public API (#8588) 
Co-authored-by: Jesús Burgers <jesus.burgers@chakray.co.uk>
Co-authored-by: Jesús Burgers <43568066+jburgers-chakray@users.noreply.github.com>
 2024-02-09 15:10:03 +00:00
Cornelius Suermann cd151f1ba9
feat: Include totalUsers in usage metrics during license renewal (no-changelog) (#8598) 2024-02-09 14:15:05 +01:00
Omar Ajoue 7501ad8f3c
feat: Add support for AI log streaming (#8526) 
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-02-09 09:41:01 +00:00
कारतोफ्फेलस्क्रिप्ट™ 8e392cfc1d
feat(core): Migrate to n8n's typeorm fork (#8590) 2024-02-08 15:13:29 +01:00
कारतोफ्फेलस्क्रिप्ट™ 40eee3aa49
ci(core): Avoid slow bcrypt calls in tests (no-changelog) (#8570) 2024-02-07 17:56:02 +01:00
Iván Ovejero dc068ce2e6
build: Fix outdated import to fix build (no-changelog) (#8558) 2024-02-06 10:45:30 +01:00
Iván Ovejero c4e39451db
refactor(core): Continue breaking dependency cycles (no-changelog) (#8545) 2024-02-06 10:08:46 +01:00
Iván Ovejero dc5ec8f946
refactor(core): Streamline flows in multi-main mode (no-changelog) (#8446) 2024-02-05 09:26:55 +01:00
Iván Ovejero 92f939f827
fix(core): Fix workflow tagging failure due to unique constraint check (#8505) 2024-02-02 12:36:55 +01:00
कारतोफ्फेलस्क्रिप्ट™ 5832d3ca46
fix(core): Fix PermissionChecker.check, and add additional unit tests (#8528) 2024-02-02 12:21:53 +01:00
कारतोफ्फेलस्क्रिप्ट™ d2d0ae6c5d
ci: Fix DB tests (no-changelog) (#8513) 2024-01-31 17:36:50 +01:00
कारतोफ्फेलस्क्रिप्ट™ 839dd96c7d
refactor(core): Move all code related to onServerStarted into InternalHooks (no-changelog) (#8500) 2024-01-31 13:29:17 +01:00
Iván Ovejero dac511b710
refactor(core): Modernize credentials controllers and services (no-changelog) (#8488) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-01-31 09:48:48 +01:00
कारतोफ्फेलस्क्रिप्ट™ 121a55b691
feat(core): Remove own execution-process mode (#8490) 2024-01-30 12:51:40 +01:00
Iván Ovejero 9e93980957
fix(core): Prevent calling internal hook email event if emailing is disabled (#8462) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-01-29 16:15:30 +01:00
Iván Ovejero db48bdd6d1
fix(core): Handle zero execution statistics on metrics collection during license renewal (#8463) 2024-01-26 17:50:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ c70fa66e76
refactor(core): Use DI for WorkflowRunner (no-changelog) (#8372) 2024-01-26 13:49:39 +01:00
कारतोफ्फेलस्क्रिप्ट™ 7c49004018
refactor(core): Use DI for eventBus code - Part 1 (no-changelog) (#8434) 2024-01-26 12:21:15 +01:00
कारतोफ्फेलस्क्रिप्ट™ d6deceacde
refactor(core): Remove roleId indirection (no-changelog) (#8413) 2024-01-24 13:38:57 +01:00
Iván Ovejero c0bc94c78f
refactor(core): Finish removing UserManagementHelper (no-changelog) (#8418) 2024-01-23 13:58:31 +01:00
Iván Ovejero a0a1830696
feat(core): Email recipients on resource shared (#8408) 2024-01-23 12:03:59 +01:00
Danny Martini ae06fdeb62
fix(core): Fix update workflow cli command being unable to activate all workflows (#8412) 
Co-authored-by: Daniel Schröder <daniel.schroeder@skriptfabrik.com>
 2024-01-23 10:59:06 +01:00
Iván Ovejero 49b52c4f1d
refactor(core): Bring active executions into executions controller (no-changelog) (#8371) 2024-01-23 09:48:50 +01:00
कारतोफ्फेलस्क्रिप्ट™ 913c8c6b0c
feat(core): Upgrade oclif (no-changelog) (#8381) 2024-01-22 18:25:36 +01:00
Cornelius Suermann d597c2ab29
feat: Extend collection of usage metrics during license renewal (no-changelog) (#8369) 
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2024-01-22 12:29:28 +01:00
Iván Ovejero f35d4fcbd8
refactor(core): Simplify OrchestrationService (no-changelog) (#8364) 2024-01-22 11:16:29 +01:00
Danny Martini 07e6705256
feat(core): Custom session timeout and refresh configuration (#8342) 2024-01-22 09:54:13 +01:00
Iván Ovejero 749ac2b407
fix(core): Adjust starter node priority for manual executions with pinned activators (#8386) 2024-01-19 10:18:04 +01:00
Tomi Turtiainen 99457019f7
feat: Nudge users to become template creators if eligible (#8357) 2024-01-17 19:07:34 +02:00
Tomi Turtiainen 9a1cc56806
fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-01-17 17:08:50 +02:00
Iván Ovejero 2eb829a6b4
refactor(core): Use DI in execution services (no-changelog) (#8358) 2024-01-17 15:42:19 +01:00
Iván Ovejero 771d2fa341
test(core): Fix cleanup in test teardown script (no-changelog) (#8361) 2024-01-17 14:01:56 +01:00
कारतोफ्फेलस्क्रिप्ट™ 7cdbb424e3
refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) (#8348) 2024-01-17 10:16:13 +01:00
Iván Ovejero d4c93b1607
fix(core): Prevent issues with missing or mismatching encryption key (#8332) 2024-01-16 18:25:53 +01:00
Iván Ovejero 7bb2d1799e
refactor(core): Consolidate executions controllers (no-changelog) (#8349) 2024-01-16 16:52:21 +01:00
कारतोफ्फेलस्क्रिप्ट™ 64ceb16af6
refactor(core): Use DI in PermissionChecker (no-changelog) (#8344) 2024-01-16 14:15:29 +01:00
Omar Ajoue e1acb5911a
refactor: Make execution IDs mandatory in BE (#8299) 
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2024-01-16 09:53:17 +00:00
Iván Ovejero 0f4f472a72
refactor(core): Eliminate dead Redis code (no-changelog) (#8292) 2024-01-16 09:31:45 +01:00
Iván Ovejero 5fbd7971e0
fix(core): Account for immediate confirmation request during test webhook creation (#8329) 2024-01-16 09:17:41 +01:00
Ricardo Espinoza 3c2a4000ae
refactor(core): Use DI for LDAP code (no-changelog) (#8248) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-01-15 09:01:48 -05:00
Iván Ovejero 1a0e285553
feat(core): Implement inter-main communication for test webhooks in multi-main setup (#8267) 2024-01-12 11:48:58 +01:00
Omar Ajoue 8a7c629ea1
fix: Store workflow settings when saving an execution (#8288) 2024-01-10 14:20:37 +00:00
Iván Ovejero 5032bf0e34
fix(core): Fix test webhook deregistration (#8247) 2024-01-09 16:02:32 +01:00
Iván Ovejero 0dabe5c74e
fix: Fix user reinvites on FE and BE (#8261) 2024-01-09 13:52:34 +01:00
Tomi Turtiainen 3b996a7da0
feat(core): Validate shutdown handlers on startup (#8260) 2024-01-08 17:46:45 +02:00
Tomi Turtiainen 8affdf680d
fix: Hide cred setup button from canvas (no-changelog) (#8255) 2024-01-08 13:59:04 +02:00
Iván Ovejero 90c065e999
refactor(core): Convert workflows controller to DI (no-changelog) (#8253) 2024-01-08 12:54:23 +01:00
Iván Ovejero f2939568cf
perf(core): Optimize workflow activation errors (#8242) 
At https://github.com/n8n-io/n8n/pull/8213 we introduced Redis hashes
for workflow ownership and manual webhooks...

- to remove clutter from multiple related keys at the top level,
- to improve performance by preventing serializing-deserializing, and
- to guarantee atomicity during concurrent updates in multi-main setup.

Workflow activation errors can also benefit from this. Added test
coverage as well.

To test manually, create a workflow with a trigger with an invalid
credential, edit the workflow's `active` column to `true`, and restart.
The activation error should show as a red triangle on canvas and in the
workflow list.
 2024-01-05 13:06:42 +01:00
Iván Ovejero f53c482939
perf(core): Improve caching service (#8213) 
Story: https://linear.app/n8n/issue/PAY-1188

- Implement Redis hashes on the caching service, based on Micha's work
in #7747, adapted from `node-cache-manager-ioredis-yet`. Optimize
workflow ownership lookups and manual webhook lookups with Redis hashes.
- Simplify the caching service by removing all currently unused methods
and options: `enable`, `disable`, `getCache`, `keys`, `keyValues`,
`refreshFunctionEach`, `refreshFunctionMany`, `refreshTtl`, etc.
- Remove the flag `N8N_CACHE_ENABLED`. Currently some features on
`master` are broken with caching disabled, and test webhooks now rely
entirely on caching, for multi-main setup support. We originally
introduced this flag to protect against excessive memory usage, but
total cache usage is low enough that we decided to drop this setting.
Apparently this flag was also never documented.
- Overall caching service refactor: use generics, reduce branching, add
discriminants for cache kinds for better type safety, type caching
events, improve readability, remove outdated docs, etc. Also refactor
and expand caching service tests.

Follow-up to: https://github.com/n8n-io/n8n/pull/8176

---------

Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
 2024-01-05 11:52:44 +01:00
Iván Ovejero 22a5f5258d
feat(core): Cache test webhook registrations (#8176) 
In a multi-main setup, we have the following issue. The user's client
connects to main A and runs a test webhook, so main A starts listening
for a webhook call. A third-party service sends a request to the test
webhook URL. The request is forwarded by the load balancer to main B,
who is not listening for this webhook call. Therefore, the webhook call
is unhandled.

To start addressing this, cache test webhook registrations, using Redis
for queue mode and in-memory for regular mode. When the third-party
service sends a request to the test webhook URL, the request is
forwarded by the load balancer to main B, who fetches test webhooks from
the cache and, if it finds a match, executes the test webhook. This
should be transparent - test webhook behavior should remain the same as
so far.

Notes:
- Test webhook timeouts are not cached. A timeout is only relevant to
the process it was created in, so another process retrieving from Redis
a "foreign" timeout will be unable to act on it. A timeout also has
circular references, so `cache-manager-ioredis-yet` is unable to
serialize it.
- In a single-main scenario, the timeout remains in the single process
and is cleared on test webhook expiration, successful execution, and
manual cancellation - all as usual.
- In a multi-main scenario, we will need to have the process who
received the webhook call send a message to the process who created the
webhook directing this originating process to clear the timeout. This
will likely be implemented via execution lifecycle hooks and Redis
channel messages checking session ID. This implementation is out of
scope for this PR and will come next.
- Additional data in test webhooks is not cached. From what I can tell,
additional data is not needed for test webhooks to be executed.
Additional data also has circular references, so
`cache-manager-ioredis-yet` is unable to serialize it.

Follow-up to: #8155
 2024-01-03 16:58:33 +01:00
कारतोफ्फेलस्क्रिप्ट™ cfe9525dd4
fix(core): Better input validation for the changeRole endpoint (#8189) 
also refactored the code to
1. stop passing around `scope === 'global'`, since this code can be used
only for changing globalRole.
2. leak less details when input validation fails.

## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
 2024-01-03 09:33:35 +01:00
Iván Ovejero 40c1eeeddd
refactor(core): Continue moving typeorm operators to repositories (no-changelog) (#8186) 
Follow-up to: #8163
 2024-01-02 17:53:24 +01:00
Tomi Turtiainen e126ed74f3
feat(core): Add user.profile.beforeUpdate hook (#8144) 
Add `user.profile.beforeUpdate` hook so we can prevent user email change
if it overlaps with other users email.
 2024-01-02 10:15:12 +02:00
Iván Ovejero ece48d6a13
refactor(core): Unify workflow controllers (no-changelog) (#8175) 
Combine EE workflows controller into main workflows controller,
protecting paid functionality behind feature flag checks.
 2023-12-29 14:23:58 +01:00
Iván Ovejero 4bad43dd66
refactor(core): Move typeorm operators from WaitTracker to ExecutionRepository (no-changelog) (#8163) 
Follow-up to: #8145

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-12-28 19:22:09 +01:00
Iván Ovejero e418d42450
refactor(core): Move typeorm operators from various sources into repositories (no-changelog) (#8174) 
Follow-up to: #8165
 2023-12-28 13:14:10 +01:00
कारतोफ्फेलस्क्रिप्ट™ c84d3c3bbf
refactor(core): Extract ActiveWebhooks out of ActiveWorkflowRunner (no-changelog) (#8171) 
## Summary
This PR continues refactoring webhooks code for better modularity.
Continued from #8069 to bring back `ActiveWebhooks`, but this time
actually handling active webhook calls in this class.

## Review / Merge checklist
- [x] PR title and summary are descriptive
 2023-12-28 10:04:32 +01:00
Iván Ovejero 639afcd7a5
refactor(core): Simplify state in test webhooks (no-changelog) (#8155) 
This PR simplifies state in test webhooks so that it can be cached
easily. Caching this state will allow us to start using Redis for manual
webhooks, to support manual webhooks to work in multi-main setup.

- [x] Convert `workflowWebhooks` to a getter - no need to optimize for
deactivation
- [x] Remove array from value in `TestWebhooks.webhookUrls`
- [x] Consolidate `webhookUrls` and `registeredWebhooks`
 2023-12-28 09:28:12 +01:00
Iván Ovejero 2c6ffb0153
fix(core): Minor improvements to multi-main setup (no-changelog) (#8012) 
- Move webhook, poller and trigger activation logs closer to activation
event
- Enrich response of `/debug/multi-main-setup`
- Ensure workflow updates broadcast activation state changes only if
state changed
- Fix bug on workflow activation after leadership change
- Ensure debug controller is not available in production

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
 2023-12-27 16:55:01 +01:00
कारतोफ्फेलस्क्रिप्ट™ f69ddcd796
refactor(core): Use Dependency Injection for all Controller classes (no-changelog) (#8146) 
## Review / Merge checklist
- [x] PR title and summary are descriptive
 2023-12-27 11:50:43 +01:00
Iván Ovejero a59d78de18
refactor(core): Move more typeorm operators to repositories (no-changelog) (#8143) 
Follow-up to #8139
 2023-12-22 16:20:30 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4007163651
refactor(core): Delete unused code, and fix typings in tests (no-changelog) (#8142) 2023-12-22 15:41:29 +01:00
Tomi Turtiainen 3a881be6c2
feat(core): Unify application components shutdown (#8097) 
## Summary

Add `ShutdownService` and `OnShutdown` decorator for more unified way to
shutdown different components. Use this new way in the following
components:

- HTTP(S) server
- Pruning service
- Push connection
- License

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-12-22 12:39:58 +02:00
कारतोफ्फेलस्क्रिप्ट™ 021add0f39
refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) (#8101) 
This is a continuation of migrating all rest endpoints to decorated controller classes
 2023-12-22 11:28:42 +01:00
Iván Ovejero 9ac8825a67
refactor(core): Move error execution creation to execution service (no-changelog) (#8006) 
Continue breaking down legacy helpers.

Note: `getUserById` is unused.
 2023-12-21 14:15:46 +01:00
Omar Ajoue 5ffff1bb22
fix: Stop binary data restoration from preventing execution from finishing (#8082) 
In the case of a filesystem failure to rename the binary files as part
of the execution's cleanup process, the execution would fail to be saved
and would never finish. This catch prevents it.

## Summary
Whenever an execution is wrapping u to save the data, if it uses binary
data n8n will try to find possibly misallocated files and place them in
the right folder. If this process fails, the execution fails to finish.

Given the execution has already finished at this point, and we cannot
handle the binary data errors more gracefully, all we can do at this
point is log the message as it's a filesystem issue. The rest of the
execution saving process should remain as normal.



## Related tickets and issues
https://linear.app/n8n/issue/HELP-430



## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2023-12-21 09:40:39 +00:00
Iván Ovejero 9dc491c3a5
refactor(core): Improve test-webhooks (no-changelog) (#8069) 
Remove duplication, improve readability, and expand tests for
`TestWebhooks.ts` - in anticipation for storing test webhooks in Redis.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-12-19 17:32:02 +01:00