Commit graph

841 commits

Author SHA1 Message Date
Michael Kret a0dd17e115
fix(core): Better error message in Webhook node when using the POST method 2023-05-02 17:27:05 +03:00
Michael Auerswald 25fe14be56
fix(core): Remove SAML config metadataUrl if XML metadata is set directly (#6143)
remove metadataUrl if metadata is set directly
2023-05-02 11:22:34 +02:00
Michael Auerswald 839a56a682
fix(core): Fix canceled execution status (#6142) 2023-05-02 10:37:35 +02:00
Michael Auerswald c0b1cddc91
fix(core): Improve saml endpoints and audit events (#6107)
* update saml endpoints and login audit

* fix(core): Skip auth for controllers/routes that don't use the `Authorized` decorator

* fix linting

* lint fix

* add tests and fix endpoint permission

* add hook test

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-04-28 18:11:33 +02:00
Ricardo Espinoza 5974af1903
fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121)
only take into account users that active for the first time
2023-04-28 10:56:24 +02:00
कारतोफ्फेलस्क्रिप्ट™ 59aee2270b
fix(core): Skip auth for controllers/routes that don't use the Authorized decorator, or use Authorized('none') (#6106) 2023-04-27 12:51:55 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6335e0938d
fix(editor): Make the frontend work again when NODE_FUNCTION_ALLOW_EXTERNAL is set (no-changelog) (#6058) 2023-04-25 18:18:46 +02:00
Iván Ovejero 88724bb056
ci: Enforce no unused imports (no-changelog) (#6073) 2023-04-25 11:47:03 +02:00
Michael Auerswald f3b4701863
feat(core): Manage version control settings (#6079)
* expand VersionControlPreferences

* use Authorized decorator for vc endpoints instead of middleware

* validate preferences with class-validator

* cleanup

* cleanup
2023-04-24 17:13:25 +02:00
Ricardo Espinoza 13ef3c1d20
feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007)
* add instanceId to n8n.ready hook

* Set instanceId during configuration method
2023-04-24 09:12:00 -04:00
कारतोफ्फेलस्क्रिप्ट™ 308a94311f
refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041) 2023-04-24 13:17:08 +02:00
Jimw383 03be725cef
SSO/SAML : add Base URL to redirects in acsHandler (#5923)
add Base URL to redirects in acsHandler

I modified the redirections to include the base URL of the instance so that the redirects remain correct even if the instance is accessed from a subdirectory.

Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2023-04-24 12:36:50 +02:00
Cornelius Suermann eaf7090919
fix(core): Skip license activation when instance was already activated (#6064) 2023-04-24 11:46:04 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1eeadc6114
refactor(core): Setup decorator based RBAC (no-changelog) (#5787) 2023-04-24 11:45:31 +02:00
Ricardo Espinoza 8a38624cbc
feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940)
* Add userActivated migration

* Fix migration logic

* Remove duplication when retrieving the activated users

* Fix bug updating settings in mysql

* Make userSettings type conform with naming convention

* Disable naming convention rule only in IDatabaseCollections interface

* Fix down method in Postgres migration

* Reset '{}' to NULL when reversing migration
2023-04-21 11:15:08 -04:00
Cornelius Suermann ab12d3e327
feat(core): Add license:info command (#6047)
* feat(core): Add license:info command

* revert changes to start.ts

* revert changes to start.ts

* fix typo
2023-04-21 17:10:10 +02:00
Michael Auerswald ac245fdb8d
refactor(editor): Consolidate IN8nUISettings interface (#6055)
* consolidate IN8nUISettings

* cleanup
2023-04-21 13:30:57 +02:00
Michael Kret 0e93fe064e
refactor(core): Forbid raw enums (no-changelog) 2023-04-21 14:23:15 +03:00
Michael Auerswald da31925083
refactor(core): Sort variables files under variables folder (#6051)
sort variables files under variables folder
2023-04-21 13:08:16 +02:00
Michael Auerswald 71ed1f410c
feat(core): Add SSH key generation (#6006)
* basic prefs and ssh key generation

* review change

* cleanup save

* lint fix
2023-04-19 17:46:10 +02:00
कारतोफ्फेलस्क्रिप्ट™ c87262a312
docs: Stop assuming the user's gender in code comments (no-changelog) (#6015) 2023-04-19 16:00:49 +02:00
Jan Oberhauser 62f993c84f
feat(core): Add support for digestAuth to httpRequest and declarative style (#5676)
feat(core): Add support to digestAuth to httpRequest and declarative style
2023-04-19 13:44:41 +02:00
कारतोफ्फेलस्क्रिप्ट™ fe058aa8ee
fix(core): Use tablePrefix in the CreateVariables migration (no-changelog) (#6011) 2023-04-19 12:42:46 +02:00
Michael Auerswald 33299ca61a
feat(core): Add versionControl feature flag (#6000)
add versionControl feature flag
2023-04-18 13:29:26 +02:00
Val 1bb987140a
feat: Add variables feature (#5602)
* feat: add variables db models and migrations

* feat: variables api endpoints

* feat: add $variables to expressions

* test: fix ActiveWorkflowRunner tests failing

* test: a different fix for the tests broken by $variables

* feat: variables licensing

* fix: could create one extra variable than licensed for

* feat: Add Variables UI page and $vars global property (#5750)

* feat: add support for row slot to datatable

* feat: add variables create, read, update, delete

* feat: add vars autocomplete

* chore: remove alert

* feat: add variables autocomplete for code and expressions

* feat: add tests for variable components

* feat: add variables search and sort

* test: update tests for variables view

* chore: fix test and linting issue

* refactor: review changes

* feat: add variable creation telemetry

* fix: Improve variables listing and disabled case, fix resource sorting (no-changelog) (#5903)

* fix: Improve variables disabled experience and fix sorting

* fix: update action box margin

* test: update tests for variables row and datatable

* fix: Add ee controller to base controller

* fix: variables.ee routes not being added

* feat: add variables validation

* fix: fix vue-fragment bug that breaks everything

* chore: Update lock

* feat: Add variables input validation and permissions (no-changelog) (#5910)

* feat: add input validation

* feat: handle variables view for non-instance-owner users

* test: update variables tests

* fix: fix data-testid pattern

* feat: improve overflow styles

* test: fix variables row snapshot

* feat: update sorting to take newly created variables into account

* fix: fix list layout overflow

* fix: fix adding variables on page other than 1. fix validation

* feat: add docs link

* fix: fix default displayName function for resource-list-layout

* feat: improve vars expressions ux, cm-tooltip

* test: fix datatable test

* feat: add MATCH_REGEX validation rule

* fix: overhaul how datatable pagination selector works

* feat: update  completer description

* fix: conditionally update usage syntax based on key validation

* test: update datatable snapshot

* fix: fix variables-row button margins

* fix: fix pagination overflow

* test: Fix broken test

* test: Update snapshot

* fix: Remove duplicate declaration

* feat: add custom variables icon

---------

Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-04-18 12:41:55 +02:00
Michael Auerswald 4c994faec1
fix(core): Improve SAML connection test result views (#5981)
* improve test result views

* refactor

* lint fix
2023-04-14 15:49:10 +02:00
Omar Ajoue 49d838f628
fix(core): Fix broken API permissions in public API (#5978) 2023-04-14 11:05:42 +02:00
Iván Ovejero 1a8a9f8ddb
fix(core): Fix lint on SAML controller (no-changelog) (#5967)
* 👕 Fix lint on SAML controller

* 📘 Type request properly

* Update requests.ts

* 🚚 Move type to module

Assuming ACS falls under configuration.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-04-13 14:14:55 +02:00
Michael Auerswald 8474cd386d
fix(core): Skip SAML onboarding for users with first- and lastname (#5966)
skip onboarding for users with first- and lastname
2023-04-13 10:09:50 +02:00
कारतोफ्फेलस्क्रिप्ट™ 10f8c35dbb
refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) (#5953)
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-04-12 10:59:14 +02:00
Ricardo Espinoza 725393dae6
feat(editor): Add user activation survey (#5677)
*  Add user activation survey

* Fix typo

* Avoid showing the modal when there is a modal view

* Allow to redirect to specific execution

* Improve structure

* Handle errors when sharing feedback

* update withFeatureFlag function

* Fix linting issue

* Set user activation flag on workflowExecutionCompleted event

* Revert update user settings functionality

* Remove unnecessary changes

* fix linting issue

* account for new functionality in tests

* Small improvements

* keep once instace of the model open between tabs

* Add sorting to GET /executions

* type parameters for GET /executions


a

* Add constant for local store key

* Add execution mode filtering

* fix linting issue

* Do not override settings when setting isOnboarded true

* Add update user settings endpoint

* improvements

* revert changes to /GET executions

* Fix typo

* Add userActivated flag to user store

* Add E2E test

* Fix linting issue

* Update pnpm-lock

* Revert unnecessary change

* Centralize user's settings update

* Remove unused ref in userActivationSurvey modal

* Use aliased imports

* Use createEventBus function in component

* Fix tests
2023-04-11 12:43:47 -04:00
Michael Auerswald 3e382ef85e
fix(core): Fix issue where sub workflows would display as running forever after failure to start (#5905)
* fixed recovery / status for early return in main mode

* mark non-data returning executions in own mode as failed

* improve error handling
2023-04-06 11:36:11 +02:00
कारतोफ्फेलस्क्रिप्ट™ 2881ee9ecc
fix(core): App should not crash with a custom rest endpoint (#5911)
fixes #5880
2023-04-06 11:35:05 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6689451e8c
fix(core): Do not execute workflowExecuteBefore hook when resuming executions from a waiting state (#5727) 2023-04-06 10:18:19 +02:00
कारतोफ्फेलस्क्रिप्ट™ e7aaa9425a
fix(core): Make WorkflowStatistics tests pass on all databases (no-changelog) (#5909) 2023-04-05 14:51:43 +02:00
Csaba Tuncsik 04f8600bbd
feat(editor): SSO onboarding (#5756)
* feat(editor): SSO onboarding

* fix(editor): add SAML onboarding page

* fix(editor): submit user name on SAML onboarding
2023-04-04 18:18:16 +02:00
Omar Ajoue 2b06673b2e
refactor: Upsert workflow statistics to suppress unnecessary error messages (#5863) 2023-04-04 18:11:21 +02:00
Csaba Tuncsik f4e59499fc
feat(editor): SSO setup (#5736)
* feat(editor): SSO settings page

* feat(editor): SSO settings page

* feat(editor): SSO settings page

* feat(editor): SSO settings page

* feat(editor): SSO settings page

* feat(editor): SSO settings page

* Merge remote-tracking branch 'origin/master' into pay-170-sso-set-up-page

# Conflicts:
#	packages/cli/src/sso/saml/routes/saml.controller.ee.ts

* feat(editor): Prevent SSO settings page route

* feat(editor): some UI improvements

* fix(editor): SSO settings saml config optional chaining

* fix return values saml controller

* fix(editor): drop dompurify

* fix(editor): save xml as is

* return authenticationMethod with settings

* fix(editor): add missing prop to server

* chore(editor): code formatting

* fix ldap/saml enable toggle endpoint

* fix missing import

* prevent faulty ldap setting from breaking startup

* remove sso fake-door from users page

* fix(editor): update SSO settings route permissions + unit testing

* fix(editor): update vite config for test

* fix(editor): add paddings to SSO settings page buttons, add translation

* fix(editor): fix saml unit test

* fix(core): Improve saml test connection function (#5899)

improve-saml-test-connection return

---------

Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
2023-04-04 14:28:29 +02:00
Alex Grozav df2ea0f5ec
fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860)
* fix: add optional chaining for isArtificalRecoveredEventItem

* fix: fix isArtificalRecoveredEventItem typo
2023-04-03 16:04:59 +03:00
कारतोफ्फेलस्क्रिप्ट™ ddbfcc7d93
fix(core): Use table-prefixes in queries in import commands (#5887) 2023-04-03 14:32:49 +02:00
कारतोफ्फेलस्क्रिप्ट™ e47190b560
fix(core): Fix the issue of nodes not loading when run via npx (#5888) 2023-04-03 12:14:41 +02:00
OlegIvaniv d9f1e1e1ed
test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884)
test(editor): Fix failing licensing related specs
2023-04-03 09:49:55 +02:00
Iván Ovejero 62751b5a0b
refactor: Add lint rule no-unused-param-in-catch-clause (#5868)
👕 Add lint rule `no-unused-param-in-catch-clause`
2023-03-31 16:44:08 +02:00
Michael Auerswald 83aef17120
feat(core): Read ephemeral license from environment and clean up ee flags (#5808)
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-03-31 13:51:38 +02:00
Michael Kret 085660d7d7
fix(core): Fix curl import error when no data 2023-03-31 14:01:21 +03:00
कारतोफ्फेलस्क्रिप्ट™ 5bcab8fcbe
fix(core): Password reset should pass in the correct values to external hooks (#5842) 2023-03-30 16:44:39 +02:00
कारतोफ्फेलस्क्रिप्ट™ 41cdee7bc7
refactor(core): Switch Tags queries from QueryBuilder to Repository API (no-changelog) (#5819)
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-03-30 16:25:51 +02:00
Michael Auerswald fa5bc814b0
fix(core): Deactivate active workflows during import (#5840)
* deactivate imported workflows

* improve test

* fix for combined import (and test)

* cleanup
2023-03-30 15:33:30 +02:00
Michael Auerswald 2216455760
feat(core): Prevent non owners password reset when saml is enabled (#5788)
* prevent non owners from pw reset when saml is enabled

* improve tests

* change error type
2023-03-30 12:44:53 +02:00
Val 744c3fd211
fix(core): Waiting workflows not stopping (#5811)
fix: Waiting workflows not stopping
2023-03-30 10:12:29 +01:00