Commit graph

9250 commits

Author SHA1 Message Date
Marcus ddfb24b325
fix(Postgres Trigger Node): Improve triggerMode property names and descriptions (no-changelog) (#6517)
💄update TiggerMode names and descriptions
2023-06-22 17:46:46 +02:00
Marcus 4a4bcbca29
fix(Edit Image Node): Fix transparent operation (#6513)
fix missing transparent operation
2023-06-22 17:46:01 +02:00
कारतोफ्फेलस्क्रिप्ट™ d255b094dd
fix(core): Fix import:credential on postgres (no-changelog) (#6515)
Since we switched to string ids, we don't need to update the `_seq` values for postgres.

We removed this bit for the `import:workflow` [here](https://github.com/n8n-io/n8n/pull/6345/files#diff-ff45b1d8db8d3dc67d19aa34e4d066e4156ddcd311c0b8d75a3d082009065197L230), but missed updating this file.
2023-06-22 16:54:05 +02:00
Iván Ovejero beedfb609c
feat(editor): SQL editor overhaul (#6282)
* Draft setup
*  Implemented expression evaluation in Postgres node, minor SQL editor UI improvements, minor refacring
*  Added initial version of expression preview for SQL editor
*  Linking npm package for codemirror sql grammar instead of a local file
*  Moving expression editor wrapper elements to the component
*  Using expression preview in SQL editor
* Use SQL parser skipping whitespace
*  Added support for custom skipped segments specification
*  Fixing highlight problems with dots and expressions that resolve to zero
* 👕 Fixing linting error
*  Added current item support
*  Added expression support to more nodes with sql editor
*  Added expression support for other nodes
*  Implemented different SQL dialect support
* 🐛 Fixing hard-coded parameter names for editors
*  Fixing preview for nested queries, updating query when input data changes, adding keyboard shortcut to toggle comments
*  Adding a custom automcomplete notice for different editors
*  Updating SQL autocomplete notice
*  Added unit tests for SQL editor
*  Using latest grammar
* 🐛 Fixing code node editor rendering
* 💄 SQL preview dropdown matches editor width. Removing unnecessary css
*  Addressing PR review feedback
* 👌 Addressing PR review feedback pt2
* 👌 Added path alias for utils in nodes-base package
* 👌 Addressing more PR review feedback
*  Adding tests for `getResolvables` utility function
* Fixing lodash imports
* 👌 Better focus handling, adding more plugins to the editor, other minor imrovements
*  Not showing SQL autocomplete suggestions inside expressions
*  Using npm package for sql grammar
*  Removing autocomplete notice, adding line highlight on syntax error
* 👌 Addressing code review feedback
---------
Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2023-06-22 16:47:28 +02:00
Michael Kret d431117c9e
feat(HTTP Request Node): Notice about dev console (#6516) 2023-06-22 16:30:04 +03:00
github-actions[bot] f32d5f637e
🚀 Release 0.234.0 (#6509)
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-06-22 09:58:30 +02:00
कारतोफ्फेलस्क्रिप्ट™ 8dc828b704
fix(core): Fix the db:revert command (no-changelog) (#6506) 2023-06-22 09:06:31 +02:00
कारतोफ्फेलस्क्रिप्ट™ 42a9e20e32
fix(core): Add additional path-traversal guards on res.sendFile calls (no-changelog) (#6505) 2023-06-21 22:20:47 +02:00
Jon 772ed7ff10
fix(Zendesk Node): Fix issue with group assignment not working (#6501) 2023-06-21 16:19:29 +01:00
Omar Ajoue 044c710a8e
fix: Make MySQL migration for nano id change compatible with version 5.7 (#6498)
* fix: Make migration for MySQL compatible with version 5.7

* fix: Correct syntax

* fix: Syntax for primary key creation

* fix: Remove unnecessary constraint statement

* fix: Name columns for sqlite migration to prevent issues

* ci: Always run DB tests with table-prefix and alt-schema

* add tablePrefix to migrations (mysql not fixed)

* fix character_set on mysql migrations

* fix mysql collation version difference

* cater for mariadb collations

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2023-06-21 17:10:47 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5bf83f8bf6
fix(core): Use correct scopes-separator when generating authorization urls (#6502) 2023-06-21 15:19:38 +02:00
Ricardo Espinoza 6ab350209d
feat(core): Add GET /users endpoints to public API (#6360) 2023-06-21 13:22:00 +02:00
कारतोफ्फेलस्क्रिप्ट™ 25b92169ae
fix(core): Fix OAuth2 callback for grantType=clientCredentials (#6500)
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
2023-06-21 12:25:27 +02:00
Jon 1cf36e1ed6
docs(DebugHelper Node): Update codex for debughelper (no-changelog) (#6499) 2023-06-21 10:53:56 +01:00
agobrech fc7261aca6
feat(core): Add PKCE for OAuth2 (#6324)
* Remove authorization header when empty

* Import pkce

* Add OAuth2 with new grant type to Twitter

* Add pkce logic auto assign authorization code if pkce not defined

* Add pkce to ui and interfaces

* Fix scopes for Oauth2 twitter

* Deubg + pass it through header

* Add debug console, add airtable cred

* Remove all console.logs, make PKCE in th body only when it exists

* Remove invalid character ~

* Remove more console.logs

* remove body inside query

* Remove useless grantype check

* Hide oauth2 twitter waiting for overhaul

* Remove redundant header removal

* Remove more console.logs

* Add comment for code verifier

* Remove uneeded scopes

* Restore client id in callback

* Revert "Add OAuth2 with new grant type to Twitter"

This reverts commit 1c3b331aa1.

* Remove oauth2 from twitter

* Remove properties linked to oauth2

* Fix lodash imports

* remove redundant check

* remove redundant codeVerifier

* patch pkce-challenge to avoid generating `code_verifier` with `~`

* store `codeVerifier` on the DB like `csrfSecret`

* remove unrelated changes

---------

Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-21 10:54:32 +02:00
Jan Oberhauser 4b0e0b7970
fix(core): Fix pairedItem for alwaysOutputData & multi identical resolve (#6405) 2023-06-21 10:38:28 +03:00
Michael Auerswald c3ba0123ad
feat: Migrate integer primary keys to nanoids (#6345)
* first commit for postgres migration

* (not working)

* sqlite migration

* quicksave

* fix tests

* fix pg test

* fix postgres

* fix variables import

* fix execution saving

* add user settings fix

* change migration to single lines

* patch preferences endpoint

* cleanup

* improve variable import

* cleanup unusued code

* Update packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts

Co-authored-by: Omar Ajoue <krynble@gmail.com>

* address review notes

* fix var update/import

* refactor: Separate execution data to its own table (#6323)

* wip: Temporary migration process

* refactor: Create boilerplate repository methods for executions

* fix: Lint issues

* refactor: Added search endpoint to repository

* refactor: Make the execution list work again

* wip: Updating how we create and update executions everywhere

* fix: Lint issues and remove most of the direct access to execution model

* refactor: Remove includeWorkflowData flag and fix more tests

* fix: Lint issues

* fix: Fixed ordering of executions for FE, removed transaction when saving execution and removed unnecessary update

* refactor: Add comment about missing feature

* refactor: Refactor counting executions

* refactor: Add migration for other dbms and fix issues found

* refactor: Fix lint issues

* refactor: Remove unnecessary comment and auto inject repo to internal hooks

* refactor: remove type assertion

* fix: Fix broken tests

* fix: Remove unnecessary import

* Remove unnecessary toString() call

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* fix: Address comments after review

* refactor: Remove unused import

* fix: Lint issues

* fix: Add correct migration files

---------

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* remove null values from credential export

* fix: Fix an issue with queue mode where all running execution would be returned

* fix: Update n8n node to allow for workflow ids with letters

* set upstream on set branch

* remove typo

* add nodeAccess to credentials

* fix unsaved run check for undefined id

* fix(core): Rename version control feature to source control (#6480)

* rename versionControl to sourceControl

* fix source control tooltip wording

---------

Co-authored-by: Romain Minaud <romain.minaud@gmail.com>

* fix(editor): Pay 548 hide the set up version control button (#6485)

* feat(DebugHelper Node): Fix and include in main app (#6406)

* improve node a bit

* fixing continueOnFail() ton contain error in json

* improve pairedItem

* fix random data returning object results

* fix nanoId length typo

* update pnpm-lock file

---------

Co-authored-by: Marcus <marcus@n8n.io>

* fix(editor): Remove setup source control CTA button

* fix(editor): Remove setup source control CTA button

---------

Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>

* fix(editor): Update source control docs links (#6488)

* feat(DebugHelper Node): Fix and include in main app (#6406)

* improve node a bit

* fixing continueOnFail() ton contain error in json

* improve pairedItem

* fix random data returning object results

* fix nanoId length typo

* update pnpm-lock file

---------

Co-authored-by: Marcus <marcus@n8n.io>

* feat(editor): Replace root events with event bus events (no-changelog) (#6454)

* feat: replace root events with event bus events

* fix: prevent cypress from replacing global with globalThis in import path

* feat: remove emitter mixin

* fix: replace component events with event bus

* fix: fix linting issue

* fix: fix breaking expression switch

* chore: prettify ndv e2e suite code

* fix(editor): Update source control docs links

---------

Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>

* fix tag endpoint regex

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-06-20 19:13:18 +02:00
Milorad FIlipović da330f0648
fix(editor): Fix resource mapper dropdown width and disabled styling (#6493)
* fix(editor): Fix resource mapper dropdown width and disabled styling
* 💄 Tweaking the color for disabled dropdowns
2023-06-20 18:51:51 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1b084bc56b
fix(core): Improve the error returned to users on SSL issues (#6494) 2023-06-20 17:54:05 +02:00
कारतोफ्फेलस्क्रिप्ट™ 7a95e08bfd
fix(HTTP Request Node): "Ignore SSL issues" should also ignore legacy renegotiation issues (#6492) 2023-06-20 17:38:37 +02:00
greyliath f2154fba60
feat(Stripe Trigger Node): Add action required trigger for payment intents (#6490) 2023-06-20 16:16:25 +01:00
Csaba Tuncsik 58e4e56302
build: Check test files (#6455)
* build: Check test files

* build: update test file checker glob pattern

* build: ignore changed files in test folders

* build: fix  gh workflow

* build: update gh events in workflow

* build: fix gh workflow

* build: fix gh workflow action script path

* build: fix gh workflow script

* build: fix gh workflow script

* build: fix gh workflow script

* build: fix gh workflow script

* build: fix gh workflow script

* build: update gh actions

* build: update gh actions

* build: test change file without test

* Revert "build: test change file without test"

This reverts commit 73f5c544c5.

* build: test change file that already has test

* build: fix action script

* Revert "build: test change file that already has test"

This reverts commit 21be611abf.

* build: update script

* build: test checking with test file change

* Revert "build: test checking with test file change"

This reverts commit 995b64f6ba.

* build: change file with no testable content

* build: use typescript to traverse a file

* Revert "build: change file with no testable content"

This reverts commit 05974b67c7.

* build: change file with no testable content

* Revert "build: change file with no testable content"

This reverts commit 187cc57291.

* build: change file with testable content

* Revert "build: change file with testable content"

This reverts commit ce716119b7.

* build: add vue file without test

* Revert "build: add vue file without test"

This reverts commit 756f28a373.

* build: add vue file with test

* Revert "build: add vue file with test"

This reverts commit 8022b112fc.

* build: gather all missing tests at once

* build: allow job to fail

* build: update error message
2023-06-20 13:35:04 +02:00
Alex Grozav 0154a97773
feat(editor): Replace root events with event bus events (no-changelog) (#6454)
* feat: replace root events with event bus events

* fix: prevent cypress from replacing global with globalThis in import path

* feat: remove emitter mixin

* fix: replace component events with event bus

* fix: fix linting issue

* fix: fix breaking expression switch

* chore: prettify ndv e2e suite code
2023-06-20 13:00:53 +03:00
Michael Auerswald 18f588444f
feat(DebugHelper Node): Fix and include in main app (#6406)
* improve node a bit

* fixing continueOnFail() ton contain error in json

* improve pairedItem

* fix random data returning object results

* fix nanoId length typo

* update pnpm-lock file

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-06-20 10:47:15 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6ccab3eaaa
feat(Webhook Node): Stream binary response in lastNode.firstEntryBinary mode (#6463) 2023-06-19 13:54:56 +02:00
Csaba Tuncsik 8b50625fb1
fix(editor): Update git repo URL validation to prevent using https protocol (#6475) 2023-06-19 12:17:45 +02:00
romainminaud d9f646511a
fix(editor): Remove tooltip about SMTP being required to invite user (no-changelog) (#6474)
remove unneccesary tooltip
2023-06-19 12:14:55 +02:00
Jon e0f109fa7e
feat: Add support for large files with declarative nodes (#6461) 2023-06-19 08:41:16 +01:00
कारतोफ्फेलस्क्रिप्ट™ 9978e2760b
fix(core): Fix the url sent in the password-reset emails (#6466) 2023-06-17 10:23:22 +02:00
कारतोफ्फेलस्क्रिप्ट™ 16e0df553c
fix(HTML Node): Prevent XSS in execution-data preview (#6432) 2023-06-16 17:42:13 +02:00
कारतोफ्फेलस्क्रिप्ट™ 4ec755513a
fix(Snowflake Node): Upgrade snowflake-sdk to address CVE-2023-34232 (no-changelog) (#6458)
[GH Advisory](https://github.com/advisories/GHSA-h53w-7qw7-vh5c)
2023-06-16 17:04:21 +02:00
Chris Wu 1111c915f2
refactor(core): Replace lodash's "soft-deprecated" individual packages with lodash to resolve CVE (no-changelog) (#6450)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-16 16:26:35 +02:00
Milorad FIlipović 16f707d5c4
fix(editor): Remove $if, $min and $max from code node autocomplete (#6460)
fix(editor): Remove `$if`, $min` and `$max` from code node autocomplete
2023-06-16 15:36:08 +02:00
Milorad FIlipović ad9fd12615
fix(editor): Fix DNV header disappearing when scrolling the code editor content (#6459)
* fix(editor): Fix DNV header disappearing when scrolling the code editor content
*  Using flex to lay out NDV instead of hard-coded height values
2023-06-16 15:35:56 +02:00
Alex Grozav 3e5f7adcbf
feat: Remove vue-fragment (no-changelog) (#6456)
* feat: remove vue-fragment (no-changelog)

* Update pnpm-lock.yaml

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-16 14:25:12 +03:00
Iván Ovejero 6a7d1aedb1
ci: Prevent e2e failure on commented type review (no-changelog) (#6452) 2023-06-16 12:17:04 +02:00
Jon 529f0e4996
fix(LinkedIn Node): Remove unsupported description from image posts (#6446) 2023-06-16 10:13:54 +01:00
Jan Oberhauser ffd13f4541
fix(Split In Batches Node): Add "done" context to allow simple reset (#6437)
* fix(Split In Batches Nodes): Make "noItemsLeft" work as expected

*  Simplified things and just added "done" context
2023-06-16 11:06:46 +02:00
Michael Kret fddc69ee2c
feat(Gmail Node): Add reply to email (#6453)
Co-authored-by: Matthias Stallmann <feelgood.interface@gmail.com>
2023-06-16 11:44:37 +03:00
Alex Grozav bbe493896c
fix: Remove Vue.component usage and refactor plugins into Vue Plugins (no-changelog) (#6445)
* fix: remove Vue.component usage and refactor plugins into Vue Plugins system (no-changelog)

* fix linting issues

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-16 10:30:57 +03:00
Csaba Tuncsik 5819be5ced
fix(editor): Show confirm on pull only when http response status is 409 (#6451)
* fix(editor): add docs link to translation

* fix(editor): show confirm on pull only when http response status is 409
2023-06-16 08:34:14 +02:00
Tom ee10ac8da9
fix(editor): Update data pinning tooltip to match current behaviour (#6436) 2023-06-16 06:25:52 +02:00
Alex Grozav 618b1aba30
feat: Replace Vue.delete with native alternative (no-changelog) (#6444)
* feat: replace Vue.delete with native alternative (no-changelog)

* fix: fix linting issues
2023-06-15 18:27:35 +03:00
Michael Kret 1dbca44025
feat(Item Lists Node): Improvements (#6190) 2023-06-15 16:52:39 +03:00
Jon ae56ac9a9a
fix: Add .gitattributes to preserve line endings (no-changelog) (#6442) 2023-06-15 14:31:35 +01:00
Alex Grozav 596cf07e42
feat: Replace all Vue.set usages with direct assignment and spread operator (no-changelog) (#6280)
* refactor: replace all Vue.set usages with direct assignment and spread operator

* chore: fix linting issue

* fix: fix updateNodeAtIndex function

* fix: various post-refactoring fixes

* fix: refactor recently added Vue.set directive
2023-06-15 15:30:05 +03:00
Alex Grozav c2afed4ca1
fix: Fix randomly failing scheduler node e2e tests (no-changelog) (#6430)
* fix: fix randomly failing scheduler node e2e tests (no-changelog)

* chore: rename variable name

* fix: update all cy.request calls to use backend base url

* fix: add back mistkenly removed workflowId code

* fix: remove unnecessary .then

* fix: update how workflowId is retrieved
2023-06-15 14:40:23 +03:00
agobrech 109442f38f
feat(AwsS3 Node): Small overhaul of the node with multipart uploading (#6017)
* Create new version for S3

* Update S3 to new aws s3 methods

* Switch from SAOP to Rest api

* Add multipart request

* Seperate stream into chunks and send the multipart

* Fix chunk into buffer

* Fix wrong sha256 mismatch

* Add abort multipart on error

* Complete multipart and list parts

* Change format to xml and add a minmum size of 5MB for each part

* Fix returned data for uploading a file

* Remove console.logs

* Seperate needed headers and multipart headers

* Throw error on aborting, remove console.logs

* Remove soap request from generic function

* Keep buffer

* Add unit test for V2

* fix upload file content body

* removed unused import

* Fix bug where the object was too smal and used only one part

* Fix naming for bucket name

* Fix issue with file name not returning data

* Add parent name

* Remove console.logs

* Add content type

* fix headears for other upload mode

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-06-15 13:19:22 +02:00
Csaba Tuncsik da105f468b
fix(editor): Update version control docs links (#6440)
* fix(editor): Update version control setup docs link

* fix(editor): add setup version control docs link to other places

* fix(editor): making docs link reactive
2023-06-15 12:09:27 +02:00
Michael Auerswald d3b78e291e
fix(editor): Show execution error as message (#6431)
show execution error as message
2023-06-15 11:52:21 +02:00