Commit graph

1030 commits

Author SHA1 Message Date
Alex Grozav a71f3622e2
fix: prevent sending multiple telemetry events on credential filters reset (#4159) 2022-09-21 14:27:25 +03:00
Alex Grozav 3df5ea5ebd
fix(editor): fix pin data button active state (#4157)
fix: fix pin data button active state
2022-09-21 13:21:08 +03:00
Mutasem Aldmour 40ebbeaefc
fix(editor): fix broken output panel for wait node executions (#4156) 2022-09-21 11:51:20 +02:00
Mutasem Aldmour e2cdb2e5d7
feat(personalization): update personalizaton survey (#4154)
update personalizaiton survey
2022-09-21 11:49:25 +02:00
Ben Hesseldieck 97cd564f7b
feat(cli): User Management and Credentials sharing (#3602)
* 🎉 starting feature development

*  sharing/unsharing a credential (#3601)

* 🎉 initial design

*  sharing/unsharing of credentials

*  add tests for EE credentials controller

* 💪 implement review comments

* 🛠 refactor agent creation and credential role locking

* 👕 linting adjustments (#3691)

* 👕 Adjust rule `naming-convention`

* 👕 Fix `naming-convention` config value

* 👕 Disregard casing for EE-prefixed vars

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 🛠 refactor authAgents in tests (#3725)

* 🛠 refactor authAgent

* 🛠 refactor authAgent

* 🛠 refactor authAgent

* 🛠 refactor authAgent

* 👕 fix ts issue

* 🐘 add migration for mysql and postgres + add AuthAgent type

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* ️ refactor existing credentials routes (#3672)

* 🎉 initial design

*  sharing/unsharing of credentials

* ♻️ split credential update route into controller and service

* 🔥 remove credentials test that is no longer applicable

* ♻️ split credential creation route into controller and service

* ♻️ split single credential get

* ♻️ split delete credentials route

* ♻️ split get all credentials route

* 🔥 remove unused imports in credentials contoller

* 🔥 remove console.log

* :refactor: changes to credentials controller and service from review

 - removed credentials from service function names
 - made relations list optional
 - put allowGlobalOwner in options objects
 - check length of relations array so join doesn't happen if empty
 - update some comments to further explain rationale
 - remove unneeded `Object.assign`
 - remove non-null assertion from test

* ♻️ move filtered credentials selected fields to variable

* ♻️ remove unneeded merges in credentials service

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>

*  fix test

* 🐛 fix imports

* 👕 fix lint issue

* User Management: switch over to decorators to define routes (#3827)

* Add permissions details to credentials for User Management (#3863)

*  Open `GET /users`

*  Add permissions to cred service

* 🚚 Rename method

*  Refactor cred controller

* 🧪 Adjust test

* ✏️ Improve comment

* ✏️ Improve another comment

*  Account for multiple sharings

* 🐛 Fix access when user is editor

* 📘 Expand interface

* 📘 Relocate types

* 📘 Exempt cred entity with service-injected fields

* 📘 Adjust interface

* ♻️ Add permissions only in `GET /credentials`

* 🧪 Add expectations for `ownedBy`

* 🧪 Add sharing details test

* 🧪 Make `ownedBy` checks more granular

* 📘 Adjust interface

* 🚚 Rename cred getter

* ♻️ Refactor cred getter

* 🧪 Expand tests

* ♻️ Refactor to use guard

* 👕 Remove unneeded lint exception

* 🔥 Remove unneeded relation

* 🚚 Move relation to `GET /credentials/:id`

* 📘 Consolidate typings

* 🎨 Add multiline for readability

* 🔥 Remove unneeded type

* ✏️ Clarity comment

* ✏️ Make comments consistent

* 👕 Add exception to fix build

* 👕 Add more lint exceptions to fix build

* 🐛 Check for non-owner

* 📘 Improve typings

* 🧪 Temporarily skip tests

* 🔥 Remove `@ts-ignore`

* 👕 Move lint exceptions

* ♻️ Refactor cred service and controller

*  Simplify check

* ✏️ adjust naming to experimental

* ️ add credentialsSharing flag to settings

* 🛠 add helper to check if UM is also enabled as dependency for CredentialsSharing

* 👕 fix lint error

* 🐘 change name of credential role

* 🚧 WIP batch sharing

* 🚧 WIP use put for sharing

*  add tests for batch sharing, 🛠 implement review suggestions

*  expand credential sharing tests for User Management (#3931)

* 🧪 Expand cred sharing tests

*  Add recently added flags

*  fix and adjust tests for /credentials

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

*  User management v2 Front End (#3795)

* feat: Added responsive generic page view layout.

* feat: Added empty state.

* feat: Added credentials view empty state.

* test: Added unit tests for N8nActionBox

* feat: Added credentials list initial design.

* feat: Added credential actions. Started working on filters.

* feat: Updated InfoTip markup, added tests and changed stories to typescript.

* feat: Added credentials filtering by type. Added support for apply/reset filters.

* feat: Added credential sharing user select and user list. Added paywall component.

* feat: Updated credentials view permissions.

* feat: Added support for temporary sharing config for unsaved credentials.

* test: Fixed broken snapshots.

* feat: Added overflow styles to page-view-layout list.

* feat: Handled sharee specific views.

* feat: Integration between FE and BE to support real-world credential sharing scenario.

* feat: Added front end permissions table.

* feat: Refactored credential sharing flow. Updated design elements.

* feat: Added margin and padding auto spacer utilities.

* feat: Rehauled permissions to support instanceOwner role and action inheritance.

* feat: Updated credentials view to apply filters automatically.

* feat: Removed apply filters button and added active button state.

* test: Updated component snapshots.

* refactor: Renamed ResourceSharee to ResourceReader.

* feat: Credential sharing error handling, permissions improvement.

* feat: Updated permissions and error handling.

* chore: Removed console.log.

* 🛠 refactor enabling of credentialsSharing

* feat: Removed owner menu selector from credentials when sharing is disabled.

* refactor: Moved EE features into ee store module file.

* 🛠 add sharing info to GET credentials/:id

* fix: Fixed initial credential data loading for sharing.

* chore: Removed console.log.

* 🐛 owner can fetch any credential

* 🛠 refactor users test

* 👕 fix build type issue

* fix: Removed owner tag when credential sharing is disabled. Fixed small reactivity issue.

* chore: Removed console.log.

* 🚧 separate fetching credentials between EE and open

* fix: Fixed empty dropdown in users list.

* fix: Fixed error message and initialization when credential gets unshared.

*  add tests for fetching single credential

* Revert decorators based controllers

* ️ adjust credentials test route to also allow testing for sharees (#3999)

* ️ pull data if user is sharee

* fix: Removed sharedWith and ownedBy from credentialData on testing credentials.

Co-authored-by: Alex Grozav <alex@grozav.com>

* 📈 add BE analytics

* 💪 improve credential test

* ️ adjust tracking properties

* ️ removed roles from tracking

* 🐛 fix build by removing imports

* 🐛 fix missed merge conflict

* feat: User management P2 Front End bug bash and improvements (#4014)

* fix: Fixed type select size after reopening dropdown.

* fix: Fixed template cards.

* fix: Fixed card content size and copy input.

* fix: Fixed horizontal overflow.

* fix: Hiding el-tags scrollbar in select.

* fix: Added fallback credential icon. Added oAuth credential owner check.

* feat: Added disabled state to user select.

* feat: Added fallback scenario for non-existent credential types.

* feat: Adjusted credentials empty state to show that there are shared credentials.

* fix: Fixed time title.

* feat: Added actionable empty state when shared credentials are present.

* fix: Made action box x padding smaller

* feat: Repositioned owner tag for credential card.

* feat: Updated message box styling to use n8n css variables.

* feat: Added confirmation for deleting sharee.

* fix: Fixed deleted credential types. Fixed select in dropdown bug.

* fix: Various code improvements. Addressed PR review comments.

* fix: Fixed credential deletion errors.

* fix: Various code quality improvements.

* feat: N8N-4531 update cloud coming soon features (#4025)

* feat: Showing different upcoming feature messages and format for cloud.

* fix: Changed url format.

* fix: Updated how cloud deployment is determined.

* feat: N8N-4527 implementing credential sharing FE telemetry (#4023)

* feat: Added credential sharing telemetry.

* chore: Renamed computed function for consistency.

* refactor: Simplified subview telemetry sending.

* fix: Changed to callDebounced() helper.

* 📧 update email text

* fix: Adjusted feature coming soon margin.

* chore: Fixed type and line height for delete sharee confirmation modal.

* refactor(editor-ui): Update telemetry (#4040)

* 🔥 Remove `identify` from BE

*  Add `versionCli`

*  Add node creator ignore input

*  Move obfuscators to editor-ui

*  Refactor `ph-no-capture`

*  Pass `user_id` to manual exec props

* 🚚 Relocate class in `SettingsApiView`

*  Add `userId` to BE PH `identify` call

*  Revert " Add `userId` to BE PH `identify` call"

This reverts commit 895aaa45e5.

* Revert " Revert " Add `userId` to BE PH `identify` call""

This reverts commit b86a098c20.

* 🐛 Fix `Promise` handling in `track()` call

*  Restore `Db.collections` call

*  Set up PH payload to mirror RS

* 🔥 Remove excess `userId`

* 📘 Remove `userId` from interface

* 🔥 Remove unused ref and method

* fix: Fixed bug causing instanceOwner to become credential owner on update. (#4079)

* 🐛 fix test for credential shared with member

* 👕 fix lint issues

* delete conflicting migration. this data is already seeded in CreateUserManagement

* feat: Expand obfuscation to User Management credential sharing (#4070)

 Expand obfuscation

* feat: Added credential sharing infotip for instance owner.

* bring back the migration. add a check to avoid conflicts on inserts

* fix(cli): use a non-env config flag to detect of enterprise features are enabled (#4105)

* chore: Changed ampersand to and in translation.

* refactor(telemetry): Obfuscate code and JSON editors (#4118)

 Obfuscate code and JSON editors

* feat(editor): improve design and functionality of coming soon features (#4116)

* feat: Improved coming soon feature design and functionality.

* style: Removed empty line.

* chore: Removed unused translation.

* fix: fix telemetry for credential creates and updates (#4125)

fix telemetry for credential creates and updates

* feat: Display errors due to missing credentials in the correct node (#4124)

feat: Display errors due to invalid credentials in the correct node when missing permissions

* fix: remove duplicate header for coming soon features in cloud deployment

* telemetry: fix the payload for `User viewed credential tab`

* telemetry: add credential_id to 'User selected credential from node modal'

* feat: update empty states for coming soon features

* Update ActionBox.spec.ts.snap

* replace UserSharingsDetails with a subset of User properties

* rename the CreateCredentialsEditorRole to CreateCredentialsUserRole

* move IUser to the workflow package

* use IUser in the frontend as well

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Valya <68596159+valya@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2022-09-21 10:20:29 +02:00
Iván Ovejero 479f78b3bc
refactor(telemetry): Fix metadata on personalization survey (#4123)
🐛 Fix metadata on personalization survey
2022-09-20 08:55:12 +02:00
Csaba Tuncsik 762e00570a
refactor(editor): Showing errors in input pane (#4059)
* refactor(editor): removing output error reporting from input panel

* refactor(editor): input panel error notification with linking back to the errored node

* fix(editor): switching to the correct node after backlinking from the error in a further node

* fix(editor): input pane error message font size and translation keys

* fix(editor): output error message layout

* fix(editor-ui): update input panel node error title translation

* fix(editor-ui): achieve proper update when changing node from input error link

* fix(editor-ui): adding local utility class to not break output error layout
2022-09-19 12:26:02 +02:00
Jan Oberhauser 28d690ca6a 🔖 Release n8n-editor-ui@0.160.0 2022-09-15 14:34:42 +00:00
Jan Oberhauser 3b28239a43 ⬆️ Set n8n-design-system@0.34.0 and n8n-workflow@0.116.0 on n8n-editor-ui 2022-09-15 14:34:42 +00:00
Csaba Tuncsik ec2c55211c
refactor(design-system): merge n8n square button into n8n button (#4075)
* feat(design-system): button as square shape

* refactor(editor-ui): drop n8n-square-button in favor of n8n-button

* refactor(design-system): remove obsolete n8n-square-button

* fix(design-system): icon only square button icon position

* fix(design-system): icon only square button icon position

* chore(design-system): update button test snapshot

* fix(design-system): overriding default square button styles

* fix(editor-ui): using tertiary button variant in survey without local style overrides

* refactor(design-system): simplifying and partially merging icon-button and button

* fix(design-system): remove unused prop from icon-button

* fix(design-system): square button should have the old dimensions

* fix(design-system): square button update test snapshots
2022-09-15 11:41:12 +02:00
Iván Ovejero 98ed207607
feat(core, editor-ui): Introduce node deprecation (#4103)
 Introduce node deprecation
2022-09-15 10:52:24 +02:00
OlegIvaniv ea2d18b66d
feat(editor): Implement HTML sanitization for Notification and Message components (#4081)
* feat(editor): Implement HTML sanitization when using `dangerouslyUseHTMLString` option of Notification and Message components

* 🐛 Implement mechanism to allow for A href actions from locale strings

* 🐛 Prevent link action default

* ♻️ Use `xss` library instead of `sanitize-html` to handle sanitization

* 🔥 Remove `onLinkClick` functionality of `$showMessage`
2022-09-13 17:39:47 +02:00
OlegIvaniv 8c95d6ec53
feat(editor): Show input number for multi-input nodes (#4000)
* feat(editor): Show input number for multi-input nodes

*  Added multiple inputs detection logic to input panel

* 🐛 Fix a case where Input 1 and Input 2 are identical, do not display nodeIndex for single input nodes

* 🔥 Delete unused `MERGE_NODE_TYPE` constant

* ♻️ Get input names dynamically for multi-input nodes

Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2022-09-13 15:42:44 +02:00
Csaba Tuncsik c4fd8ce28b
refactor(editor-ui): leverage the editor url in frontend (#4085)
* refactor(editor-ui): remove unused interfaces

* refactor(editor-ui): add urlBaseEditor setting to application state

* fix(editor-ui): webhook urls for test and production

* fix(editor-ui): jsPlumb Anchor interface
2022-09-13 09:54:23 +02:00
कारतोफ्फेलस्क्रिप्ट™ 69eb97999d
fix(eslint): setup eslint to run on every package - N8N-4553 (#4050)
* fix(eslint): setup eslint to run on every package

Also, unify eslint config and dependencies into a private package in the workspace.
2022-09-12 11:41:50 +02:00
कारतोफ्फेलस्क्रिप्ट™ 9267e8fb12
fix(typescript): Use consistent typescript configs - N8N-4552 (#4049)
fix(typescript): Use consistent typescript configs

make all packages inherit tsconfig from the root tsconfig
skips building tests. reformat all tsconfigs with prettier.
2022-09-09 18:00:18 +02:00
कारतोफ्फेलस्क्रिप्ट™ 799676b24d
feat(typescript): Setup Typescript incremental builds (#3876) 2022-09-09 15:24:23 +02:00
Jan Oberhauser d9084b1e24 🔖 Release n8n-core@0.133.3, n8n-editor-ui@0.159.4, n8n-node-dev@0.72.1, n8n-nodes-base@0.191.3 and n8n@0.193.5 2022-09-07 16:40:10 +02:00
Csaba Tuncsik b26545d94c
fix(editor): use correct attribute on button to make it full width (#4048) 2022-09-07 09:53:04 +02:00
Csaba Tuncsik 0acac355e1
fix(editor): Wrong popup title when "Click To Copy" on OAuth2 Redirect Url credentials (#4043)
fix(editor): use toast title only when oauth redirect url copied to clipboard
2022-09-07 09:52:25 +02:00
Iván Ovejero 772836abc7
fix(editor-ui): Disable editing in Function nodes in executions view (#4041)
🐛 Disable editing in Function nodes in executions view
2022-09-07 09:18:18 +02:00
Jan Oberhauser ac32b680a8 🔖 Release n8n-editor-ui@0.159.3 2022-09-06 14:44:23 +02:00
Jan Oberhauser 5c0fb89169 ⬆️ Set n8n-design-system@0.33.1 and n8n-workflow@0.115.1 on n8n-editor-ui 2022-09-06 14:43:47 +02:00
Milorad FIlipović 88c15a9d7b
🐛 Fixing email submission for invited users who opted to be contacted (#4032)
fix(editor): Fixing email submission for invited users who opted to be contacted on signup
2022-09-06 12:16:37 +02:00
OlegIvaniv 287533e6c8
feat(editor): Use i18n component instead od v-html for localization
* feat(editor): Export i18n instance and bind it to Vue instance

* feat(editor): Audit usage of v-html and replace with alternatives where possible

* 🔀 Fix conflicted element in RunDataTable

* ♻️ Refactor issues elements with the new TitledList component

* 🐛 Fixing unknown node modal dialog content rendering

Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2022-09-05 16:36:22 +02:00
Aaron Delasy 49c85a1df8
fix: correct all the spelling typos (#3960)
* Improve code health
Fix TS typos in local variables
Fix CSS typos in local styles
Fix typos in comments
Fix typos in strings

* Fix order of n8n setup sections in CONTRIBUTING.md
2022-09-02 16:13:17 +02:00
Jan Oberhauser 12c9ea0946 🔖 Release n8n-editor-ui@0.159.2 2022-09-01 18:05:26 +02:00
Iván Ovejero c8743ff6ca
fix(core): Fix disabled parent output in partial execution (#3946)
🐛 Skip disabled parent in partial execution
2022-09-01 15:43:48 +02:00
Iván Ovejero ee519b0c08
refactor(editor-ui): Create first PH experiment (#3969) 2022-09-01 10:05:22 +02:00
Jan Oberhauser 20dbb3da2d 🔖 Release n8n-editor-ui@0.159.1 2022-08-31 18:44:58 +02:00
Mutasem Aldmour bee3840050
fix(editor): fix bug where col headers don't show (#3985)
fix bug where col headers dont show
2022-08-31 17:58:43 +02:00
Jan Oberhauser c78350ac11 🔖 Release n8n-editor-ui@0.159.0 2022-08-31 14:47:28 +00:00
Jan Oberhauser c7db31a2db ⬆️ Set n8n-design-system@0.33.0 and n8n-workflow@0.115.0 on n8n-editor-ui 2022-08-31 14:47:28 +00:00
कारतोफ्फेलस्क्रिप्ट™ b428e9fb9f
feat(design-system,editor-ui): upgrade some of the frontend dev dependencies (#3978) 2022-08-31 15:47:33 +02:00
Mutasem Aldmour 8fc9f07f39
feat(editor): limit when to show mapping tooltip (#3976)
* limit when to show mapping tooltip

* refactor tooltip pos

* update tooltip pos

* update var name
2022-08-31 10:51:26 +02:00
कारतोफ्फेलस्क्रिप्ट™ 15d5ac6f3c
fix(npm): improve .npmignore to reduce the size of the published packages (#3970)
| package | gzipped (before) | unpacked (before) | gzipped (after) | unpacked (after) |
| --- | --- | --- | --- | --- |
| cli | 367.7 kB | 2.3 MB | 165.5 kB | 1.0 MB |
| core | 65.4 kB | 450.6 kB | 26.5 kB | 164.9 kB |
| design-system | 180.9 kB | 660.2 kB | 117.6 kB | 449.2 kB |
| editor-ui | 3.5 MB | 12.4 MB | 3.5 MB | 12.4 MB |
| node-dev | 13.5 kB | 44.7 kB | 10.6 kB | 35.3 kB |
| nodes-base | 3.0 MB | 24.3 MB | 2.0 MB | 15.2 MB |
| workflow | 101.4 kB | 827.7 kB | 28.8 kB | 165.7 kB |
2022-08-30 13:43:47 +02:00
Ben Hesseldieck fc2ff35c41
fix(editor): sending data as query on DELETE method (#3972)
* 🐛 fix sending data as query on DELETE method

* 👕 add type to imports

* 💪 enhance test
2022-08-30 11:54:50 +02:00
Milorad FIlipović 0e8cb74ab3
💄 Added instance ID to about modal and restyled credentials docs link (#3903)
feat(editor): Added instance ID to about modal and restyled credentials docs link

* 💄 Use Notice component instead of Callout in CredentialConfig, remove unused imports
* 💄 Use css var for n8n-notice component and override it for credential configs to get rid of additional margins
*  Update n8n-notice snapshots

Co-authored-by: Oleg Ivaniv <oleg@n8n.io>
2022-08-30 11:10:17 +02:00
Cornelius Suermann 3939d52851
docs(license): Introduce n8n Enterprise License (#3945) 2022-08-29 22:08:42 +02:00
Jan Oberhauser 56783dac21 🔖 Release n8n-editor-ui@0.158.2 2022-08-25 16:09:29 +02:00
Iván Ovejero 93c26dac28
fix(editor): Fix feature flag check when PH is unavailable (#3944)
🐛 Fix feature flag check when PH is unavailable
2022-08-25 15:11:37 +02:00
Mutasem Aldmour a21dbdc45b
fix(editor): fix mapping bug when val is null (#3942) 2022-08-25 12:54:46 +02:00
Jan Oberhauser 0b3bb6f7ee 🔖 Release n8n-editor-ui@0.158.1 2022-08-25 11:57:34 +02:00
Mutasem Aldmour c51d25ce52
refactor: Update expression colors (#3941) 2022-08-25 11:30:18 +02:00
Jan Oberhauser 7025e279d3 🔖 Release n8n-editor-ui@0.158.0 2022-08-24 14:20:45 +00:00
Jan Oberhauser b4214657c3 ⬆️ Set n8n-design-system@0.32.0 and n8n-workflow@0.114.0 on n8n-editor-ui 2022-08-24 14:20:44 +00:00
maxtkacz cc5d9a296c
refactor(editor): Add G2 review link to Value Survey (#3920)
Replaced survey link in success toast ("submitted") of Value Survey with a link to fill out a G2 review.
2022-08-24 16:00:20 +02:00
Mutasem Aldmour ce076dca48
feat(editor): mapping expressions from input table (#3864)
* implement tree render

* update styles

* implement slots

* fix recursive tree rendering

* make not recursive

* Revert "make not recursive"

f064fc14f4

* enable dragging

* fix dragging name

* fix col bug

* update values and styles

* update style

* update colors

* update design

* add hover state

* add dragging behavior

* format file

* update pill text

* add depth field

* typo

* add avg height

* update event name

* update expr at distance

* add right margin always

* add space

* handle long values

* update types

* update messages

* update keys styling

* update spacing size

* fix hover bug

* update switch spacing

* fix wrap issue

* update spacing issues

* remove br

* update hoverable

* reduce event

* replace tree

* update prop name

* update tree story

* update tree

* refactor run data

* add unit tests

* add test for nodeclass

* remove number check

* bring back hook

* address review comments

* update margin

* update tests

* address max's feedback

* update tslint issues

* if empty, remove min width

* update spacing back
2022-08-24 14:47:42 +02:00
Iván Ovejero db02a379d9
fix(editor): Check for PostHog before feature flag call (#3928)
* 🐛 Check for PH before feature flag call

* 🔥 Remove logging
2022-08-24 10:48:13 +02:00
Iván Ovejero a85d565ffc
refactor(editor): Fix capitalization on credential reconnect button (#3926)
✏️ Fix capitalization
2022-08-23 17:37:24 +02:00