Commit graph

23 commits

Author SHA1 Message Date
Iván Ovejero 1d27a9e87e
Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Harshil Agrawal a503c0e86b
Add new codex files and fix previous files (#1608)
*  Add new codex files and fixed previous files

* 🔨 Minor fix

* 🔨 Minor fix
2021-04-10 10:18:10 +02:00
Harshil Agrawal f258f3ca33
Add Node Codex (#1335)
*  Add Node Codex 📇

* Add codex files for new nodes

*  Change category for Affinity

* 🔨 Fix credential documentation link

* Improve styling

* Add blogposts

Co-authored-by: Amudhan <sm.amudhan@live.com>
2021-01-14 13:56:07 +01:00
Jan 1501175b81
Add support for custom AWS endpoints (#1312)
* Setup custom endpoints properties in AWS credentials type

* Update AWS nodes to use new endpoints (if specified)

* Fix a few error scenarios cases where message was being obscured

* Extend usage of URL API to validate user inputted endpoints

https://nodejs.org/docs/latest-v12.x/api/url.html

* Add support to custom endpoints for SES

Forgot to add this in my earlier commits…

* Fix incorrect Amazon SES endpoint placeholder value

* Fixed signing problems with path being ignored. Standardized to avoid future problems

* Linting fix

*  Make parameters optinal (wip)

* Make sure that we fallback to correct URL without errors if custom endpoints are not used

Co-authored-by: Luis Ramos <luis@ramos.dev>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2021-01-07 14:16:52 +01:00
Jan Oberhauser 40c2acd77b 👕 Fix lint issue 2020-10-22 15:46:03 +02:00
Ricardo Espinoza 979a849940
🐛 Fix issue when uploading files via S3 (#1011) 2020-10-04 22:01:37 +02:00
Jan Oberhauser fe802c8f76 👕 Fix built issue by fixing lint issues 2020-10-01 15:18:47 +02:00
Denis Palashevskii 2f9bab571d Trim whitespaces in AWS credentials 2020-09-02 00:29:56 +04:00
Denis Palashevskii 0cf3b069a9 Revert AWS S3 node to its original state 2020-08-18 17:11:20 +04:00
Denis Palashevskii 77eb0f4955 Create generic S3 node 2020-08-18 16:56:53 +04:00
Denis Palashevskii a3c5a971e5 Add support for custom endpoint URL scheme (both HTTP and HTTPS) 2020-08-05 15:22:57 +04:00
Denis Palashevskii 4b22df31ad Add support for custom S3 endpoint in AWS S3 node 2020-08-05 14:40:45 +04:00
smamudhan 725d2d16fc
Fixed typos and grammatical errors (#791)
* 🐛 Fixed typos and grammatical errors

* 🐛 Made changes based on Tanay's feedback
2020-07-24 12:56:41 +02:00
Jan Oberhauser f60c802b19 Small fixes like image optimization 2020-04-26 23:12:51 +02:00
Jan bbf84cafac
🔀 Merge pull request #502 from RicardoE105/feature/aws-s3
🐛 fixes bug with additional fields
2020-04-22 19:38:44 +02:00
ricardo dcaed7eee3 🐛 fixes bug with additional fields 2020-04-22 12:22:41 -05:00
Jan Oberhauser b24537b4a9 Change one default value 2020-04-22 11:20:26 +02:00
ricardo bedc7f88e4 Small improvements 2020-04-21 23:13:30 -05:00
ricardo ed52b67329 improvements 2020-04-20 19:33:38 -05:00
ricardo bfbc4df555 Small fix 2020-04-20 14:22:30 -05:00
Jan Oberhauser fa8c7787a0 Fix an issue with S3-Node 2020-04-20 20:44:22 +02:00
ricardo ad4a4c1e59 Use xml2js to create xml 2020-04-20 12:14:13 -05:00
ricardo 611c79204c AWS S3 Integration 2020-04-15 18:42:43 -04:00