Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
61e26804ba
refactor(core): Remove linting exceptions in nodes-base ( #4794 )
...
* ⚡ enabled array-type
* ⚡ await-thenable on
* ⚡ ban-types on
* ⚡ default-param-last on
* ⚡ dot-notation on
* ⚡ member-delimiter-style on
* ⚡ no-duplicate-imports on
* ⚡ no-empty-interface on
* ⚡ no-floating-promises on
* ⚡ no-for-in-array on
* ⚡ no-invalid-void-type on
* ⚡ no-loop-func on
* ⚡ no-shadow on
* ⚡ ban-ts-comment re enabled
* ⚡ @typescript-eslint/lines-between-class-members on
* address my own comment
* @typescript-eslint/return-await on
* @typescript-eslint/promise-function-async on
* @typescript-eslint/no-unnecessary-boolean-literal-compare on
* @typescript-eslint/no-unnecessary-type-assertion on
* prefer-const on
* @typescript-eslint/prefer-optional-chain on
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Iván Ovejero
0d9eeea024
refactor(core): Introduce overload for record-type node parameter (no-changelog) ( #4648 )
...
* 📘 Set up overload
* 🔥 Remove inferrable record assertions
* 👕 Fix semicolon
* 👕 Fix another semicolon
2022-11-18 16:29:44 +01:00
Iván Ovejero
0565194473
refactor(core): Introduce overload for number-type node parameter (no-changelog) ( #4644 )
...
* 📘 Set up overloads
* 📘 Add temporary assertion
* 🔥 Remove inferrable number assertions
* ✏️ Add ticket ref
2022-11-18 15:26:22 +01:00
Iván Ovejero
3a9c7acb04
refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many ( #4064 )
...
* 👕 Enable rule
* ⬆️ Upgrade linter
* 📦 Update `package-lock.json`
* 👕 Apply rule
* ✏️ Fix plurals
* ✏️ More typos
* ✏️ Final typos
2022-09-13 12:36:36 +02:00
Iván Ovejero
d4f858db92
refactor(nodes-base): Apply lint rule node-param-operation-option-action-wrong-for-get-many ( #4055 )
...
* 👕 Apply `node-param-operation-option-action-wrong-for-get-many`
* 🔥 Remove `package-lock.json`
* 📦 Re-add `package-lock.json`
* ⚡ master update
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-09-08 17:10:13 +02:00
Iván Ovejero
ca8c2d6577
refactor(nodes-base): Apply lint rule node-param-option-name-wrong-for-get-many ( #4051 )
...
* ⬆️ Upgrade linter
* 📦 Update `package-lock.json`
* 👕 Substitute rule
* 👕 Apply lintfix for `node-param-option-name-wrong-for-get-many`
* 👕 Restore lint exceptions
2022-09-07 16:51:14 +02:00
Michael Kret
91d7e16c81
n8n-3867-progressively-apply-prettier-to-all ( #3873 )
...
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
Iván Ovejero
6f95121fac
refactor: Add action to all operations on all nodes ( #3655 )
...
* 👕 Add `action` to `INodePropertyOptions`
* 👕 Apply `node-param-operation-option-without-action`
* ✏️ Fix add/remove phrasing
* ✏️ Fix email template phrasing
* ✏️ Fix add/remove phrasing
* ✏️ Fix custom fields phrasing
* ✏️ Fix job report phrasing
* ✏️ Fix query phrasing
* ✏️ Various phrasing fixes
* ✏️ Fix final phrasings
* ✏️ Remove `conversation`
* ✏️ Fix plural
2022-07-10 23:50:51 +03:00
Iván Ovejero
88dea330b9
refactor: Apply more eslint-plugin-n8n-nodes-base rules ( #3534 )
...
* ⚡ Update `lintfix` script
* ⚡ Run baseline `lintfix`
* 🔥 Remove unneeded exceptions (#3538 )
* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`
* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`
* ⚡ Update version
* 👕 Apply `node-param-placeholder-missing` (#3542 )
* 👕 Apply `filesystem-wrong-cred-filename` (#3543 )
* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-class-description-empty-string` (#3546 )
* 👕 Apply `node-class-description-icon-not-svg` (#3548 )
* 👕 Apply `filesystem-wrong-node-filename` (#3549 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Expand lintings to credentials (#3550 )
* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552 )
* ⚡ fix
* ⚡ Minor fixes
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541 )
* ⚡ Add new lint rule, node-param-description-wrong-for-dynamic-multi-options
* ⚡ Fix with updated linting rules
* ⚡ Minor fixes
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-boolean-without-whether` (#3553 )
* ⚡ fix
* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537 )
* 👕 Add exceptions
* 👕 Add exception
* ✏️ Alphabetize rules
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-06-20 07:54:01 -07:00
Iván Ovejero
70ae90fa3c
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3432 )
...
* ⚡ Update `lintfix` script
* 👕 Remove unneeded lint exceptions
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-description-miscased-url` (#3441 )
* 👕 Apply `rule node-param-placeholder-miscased-id` (#3443 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446 )
* 👕 Apply `node-param-min-value-wrong-for-limit` (#3442 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-wrong-for-dynamic-options` (#3454 )
* 🔨 fix
* ⚡ Fix `Assigned To` fields
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `rule node-param-default-wrong-for-number` (#3453 )
* 👕 Apply `node-param-default-wrong-for-string` (#3452 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-miscased` (#3449 )
* 🔨 fix
* 🔨 exceptions
* ⚡ review fixes
* 👕 Apply `node-param-description-lowercase-first-char` (#3451 )
* ⚡ fix
* ⚡ review fixes
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456 )
* Rule working as intended
* Add rule
* 🔥 Remove repetitions
* 👕 Add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Small fix for `node-param-description-wrong-for-dynamic-options`
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460 )
* 👕 Apply `node-param-description-line-break-html-tag` (#3462 )
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-options-type-unsorted-items` (#3459 )
* ⚡ fix
* 🔨 exceptions
* Add exception for Salesmate and Zoom
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Restore `lintfix` command
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
2022-06-03 19:23:49 +02:00
Iván Ovejero
6dcdb30bf4
refactor: Apply more nodelinting rules ( #3324 )
...
* ✏️ Alphabetize lint rules
* 🔥 Remove duplicates
* ⚡ Update `lintfix` script
* 👕 Apply `node-param-operation-without-no-data-expression` (#3329 )
* 👕 Apply `node-param-operation-without-no-data-expression`
* 👕 Add exceptions
* 👕 Apply `node-param-description-weak` (#3328 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-value-duplicate` (#3331 )
* 👕 Apply `node-param-description-miscased-json` (#3337 )
* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-type-options-missing-from-limit` (#3336 )
* Rule workig as intended
* ✏️ Uncomment rules
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-duplicate` (#3338 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-simplify` (#3334 )
* ⚡ fix
* ⚡ exceptions
* ⚡ changed rule ignoring from file to line
* 👕 Apply `node-param-resource-without-no-data-expression` (#3339 )
* 👕 Apply `node-param-display-name-untrimmed` (#3341 )
* 👕 Apply `node-param-display-name-miscased-id` (#3340 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-resource-with-plural-option` (#3342 )
* 👕 Apply `node-param-description-wrong-for-upsert` (#3333 )
* ⚡ fix
* ⚡ replaced record with contact in description
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-description-identical-to-name` (#3343 )
* 👕 Apply `node-param-option-name-containing-star` (#3347 )
* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348 )
* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345 )
* ⚡ fix
* ⚡ exceptions
* 👕 Apply node-param-display-name-wrong-for-simplify (#3344 )
* Rule working as intended
* Uncomented other rules
* 👕 Undo and add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Alphabetize lint rules
* ⚡ Restore `lintfix` script
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
2022-05-20 23:47:24 +02:00
Iván Ovejero
63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3243 )
...
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200 )
* Removing unneeded backticks (#3249 )
* 👕 Apply node-param-description-wrong-for-return-all (#3253 )
* 👕 Apply node-param-description-missing-limit (#3252 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258 )
* 👕 Apply `node-param-description-miscased-id` (#3254 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261 )
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-05-06 23:01:25 +02:00
Iván Ovejero
0448feec56
refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules ( #3174 )
...
* ⚡ Initial setup
* 👕 Update `.eslintignore`
* 👕 Autofix node-param-default-missing (#3173 )
* 🔥 Remove duplicate key
* 👕 Add exceptions
* 📦 Update package-lock.json
* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176 )
* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177 )
* 👕 Apply `node-class-description-outputs-wrong` (#3178 )
* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179 )
* 👕 Apply `node-param-default-wrong-for-collection` (#3180 )
* 👕 Apply node-param-default-wrong-for-boolean (#3181 )
* Autofixed default missing
* Autofixed booleans, worked well
* ⚡ Fix params
* ⏪ Undo exempted autofixes
* 📦 Update package-lock.json
* 👕 Apply node-class-description-missing-subtitle (#3182 )
* ⚡ Fix missing comma
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184 )
* 👕 Add exception for `node-class-description-missing-subtitle`
* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185 )
* 👕 Apply `node-param-collection-type-unsorted-items` (#3186 )
* Missing coma
* 👕 Apply `node-param-default-wrong-for-simplify` (#3187 )
* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190 )
* 👕 Apply `node-param-description-empty-string` (#3189 )
* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191 )
* Rule looks good
* Add whitespace rule in eslint config
* :zao: fix
* 👕 Apply `node-param-description-identical-to-display-name` (#3193 )
* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195 )
* ⏪ Revert ":zao: fix"
This reverts commit ef8a76f3df👕 Apply `node-param-description-missing-for-simplify` (#3196 )
* 👕 Apply `node-param-description-missing-final-period` (#3194 )
* Rule working as intended
* Add rule to eslint
* 👕 Apply node-param-description-missing-for-return-all (#3197 )
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-04-22 18:29:51 +02:00
Anuj Kapoor
214dd5061e
✨ Add Syncromsp node ( #2477 )
...
* Init Node
* Added get customer details api for syncomsp-node
* Fixed formatting bug 🐛
* Updated description for query params, and removed redundant condition in router
* Changed default value for page parameter
* 🚢 Added tickets API
* 🚢 Added contacts API
* 🚢 Added RMM Alerts API
* Add customer API
* Updates post code review
* Rename SyncroMspAPI.credentials.ts to SyncroMspApi.credentials.ts
* added create and delete method to customers module
* fix liniting issue
* Added Update method to customer module
* Code Review Changes
* 🚢 Added CRUD for contacts endpoint
* 🚢 Added CRUD for RMM Alert endpoint
* Added options for status field
* 🐛 fix linting issues
* Init Node
* Added get customer details api for syncomsp-node
* Fixed formatting bug 🐛
* Updated description for query params, and removed redundant condition in router
* Changed default value for page parameter
* 🚢 Added tickets API
* 🚢 Added contacts API
* 🚢 Added RMM Alerts API
* Updates post code review
* Add customer API
* added create and delete method to customers module
* fix liniting issue
* Added Update method to customer module
* Rename SyncroMspAPI.credentials.ts to SyncroMspApi.credentials.ts
* Code Review Changes
* 🚢 Added CRUD for contacts endpoint
* 🚢 Added CRUD for RMM Alert endpoint
* Added options for status field
* 🐛 fix linting issues
* 🚢 Added CRUD for ticket endpoint
* :tag: update get customer module
* :tag: update get customer module
* Minor bug fixes
* Changed response for ticket update
* 👕 Fix lint issue
* Alphabetically ordered all options
* 🐛 Fixed build issue
* 🐛 Fixed Server.ts build issue, rebased from master
* ⚡ Fix node issues
* ⚡ Fix more issues
* ⚡ Fixed all operations with the standard convention
* 👕 Fix lint
* Fix reviewed changes
* update border color
* ⚡ minor fixes
* minor fixes
* Added fallback when port in use
* ⚡ Minor Fixes
* ⚡ Hide addtional paramerts when return all is active
* ⚡ Fix issues with Tickets
* ⚡ Fix issues with Rmm
* ⚡ Fix issues with Customer
* 👕 Fix lint
* ⚡ Fix issues with Contact
* 👕 Fixed formatting issue
* ⚡ Return 404 in ID not found
* 👕 Fixed formatting issue
* ⚡ Improvements
* ⚡ Improvements
* ⚡ Improvements
* ⚡ Add credentials verification
* ⚡ Improvements
* ⚡ Improvements
* ⚡ Additional improvements
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-01-07 18:19:24 +01:00
