Commit graph

9 commits

Author SHA1 Message Date
Iván Ovejero 1732324965
fix(core): amend typing for jsonParse() options (#4423)
* 📘 Amend typing for `jsonParse()` options

* ✏️ Update rule message and description

* 🔀 Cherrypick Adi's work

* 🐛 Account for falsy fallback values

* ♻️ Use `else if`

*  Add explicit error message as type

*  Consolidate utils tests

* ♻️ Use optional chaining

* 🔥 Remove patchy type error

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-10-24 12:48:16 +02:00
Michael Kret 1d57b10942
refactor(core): fix for no-uncaught-json-parse warnings 2022-10-21 21:52:43 +03:00
Michael Kret 9d6a2c32d7
refactor(core): fixes n8n-local-rules/no-json-parse-json-stringify warnings (#4407)
* 🔨 fixes

* 🔨 set rule to error
2022-10-21 17:24:58 +02:00
Iván Ovejero 6a1838d8c1
refactor: lint for inefficient deep clones (#4378)
* 👕 Create rule `no-json-parse-json-stringify`

* 🧪 Add tests

* 👕 Enable new rule

* 👕 FIx unrelated lint issue
2022-10-19 09:36:25 +02:00
Iván Ovejero 64fffa0579
fix(lint): Set no-unused-vars to warn (#4228)
* 👕 Set `no-unused-vars` to `warn`

* 👕 Fix lint issue in `master`

* ✏️ Fix plugin name
2022-09-29 12:47:07 +02:00
कारतोफ्फेलस्क्रिप्ट™ bc42073e28
ci: Use eslint-plugin-diff only on the CI (#4194) 2022-09-26 14:43:52 +02:00
Mike Arvela 31391a5b19
feat(eslint-config): add custom eslint rule 'no-uncaught-json-parse' (#4087)
feat(eslint-config): add custom eslint rule 'no-uncaugh-json-parse'

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-09-26 11:08:59 +03:00
Iván Ovejero a2441b8e3f
refactor(ci): Lint PR diffs only (#4137)
*  Set up `eslint-plugin-diff`

* 🔧 Fix setup

* ⬆️ Upgrade `checkout` and `setup-node`

* 🔧 Fix YAML

* 🧪 Verify `eslint-plugin-diff` behavior

* Revert "🧪 Verify `eslint-plugin-diff` behavior"

This reverts commit 1fcc6c8299.

* ✏️ Fix comment
2022-09-21 10:24:39 +02:00
कारतोफ्फेलस्क्रिप्ट™ 69eb97999d
fix(eslint): setup eslint to run on every package - N8N-4553 (#4050)
* fix(eslint): setup eslint to run on every package

Also, unify eslint config and dependencies into a private package in the workspace.
2022-09-12 11:41:50 +02:00