Commit graph

6155 commits

Author SHA1 Message Date
Omar Ajoue c65deb2949
feat: check for cred when updating workflow and remove credential_usage table (#4350) (no-changelog)
* feat: check for cred when updating workflow and remove credential_usage table
2022-10-26 10:49:43 -03:00
Iván Ovejero e8935de3b2
feat(core, editor): introduce workflow caller policy (#4368)
*  Create env `N8N_WORKFLOW_CALLER_POLICY_DEFAULT_OPTION`

* 👕 Adjust BE settings interface

* 👕 Adjust FE settings interface

*  Send policy along with settings

*  Enforce policy

*  Create `SubworkflowOperationError`

*  Add policy to Vuex store

*  Add setting to FE

*  Trim caller IDs on BE

*  Hide new UI behind `isWorkflowSharingEnabled`

* ✏️ Copy updates

* 👕 Fix lint
2022-10-26 14:59:54 +02:00
Michael Auerswald dd3c59677b
fix(API): validate excecutions and workflow filter parameters (#4424)
* typeorm queries with AND for filter, schema validation
* validate filters
* replace json.parse with jsonParse()
* limited fields further
* limited workflow fields further
* removes date filter fields and fix waitTill filter
* simplified filter name arrays
2022-10-26 13:30:35 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1f610b90f6
feat: use ES2022 native error chaining to improve error reporting (#4431)
feat: use ES2022 native error chaining
2022-10-26 11:55:39 +02:00
Iván Ovejero 3a9684df9f
fix(core): fix canvas node execution skipping parent nodes (#4438)
🔥 Remove pindata check
2022-10-26 10:13:33 +02:00
Milorad FIlipović d833345092
feat(editor): implement executions preview via the new executions tab in node view (#4311)
*  Added main header tabs with current workflow execution count
*  feat(editor): header tab navigation (no-changelog) (#4244)
*  Adding current workflow execution list to the Vuex store
*  Updating current workflow executions after running a workflow from the node view
*  Keeping the tab view content alive when switching tabs in main header
*  Updating main header controls to work with current workflow regardless of active tab
* 🐛 Fixing a bug with previous WF executions still visible after creating a new WF
*  Updating saved status when new WF is created
*  Implemented initial version of execution perview
*  Keeping the WF view alive when switching to executions tab in new navigation
*  Implemented executions landing page
*  Simplifying node view navigation
*  Updating executions view zoom and selection to work with the new layout
*  Using N8nRadioButtons component for main header tabs
* 💄 Implementing executions page states. Minor refactoring.
*  Merge conflict fixes and pieces of code that were left behind
*  Fixing layout and scrolling changes introduced after sync with master branch
*  Removing keep-alive from node view which broke template opening and some more leftover code
* ✔️ Fixing linting errors
* ✔️ One more lint error
*  Implemented executions preview using iframes
*  Fixing zoom menu positioning in iframe and adding different loading types to workflow preview
*  Fixing navigation to and from WF templates and template loading
*  Updating and fixing navigation to and from node view
* 👌 Addressing previous PR comments
* 🐛 Fixing infinite loading when saving a new workflow
* 🐛 Handling opening already opened WF when not on Node view
*  Implemented empty states for executions view
*  Adding execute button shake flag to the store so it doesn't mess up navigation by modifying route params
* 💄 Started adding new styles to execution sidebar
* 💄 Adding hover style for execution list
*  Added ExecutionsCard component and added executions helper mixin
* ✔️ Fixing leftover conflict
* ✔️ One more conflict
*  Implemented retry execution menu and manual execution icon. Other minor updates
*  Implemented executions filtering
* 💄 Updating running executions details in preview
*  Added info accordion to executions sidebar
*  Implemented auto-refresh for executions sidebar
* 💄 Adding running execution landing page, minor fixes
* 💄 General refactoring
* ✔️ Adding leftover conflict changes
* ✔️ Updating `InfoTip` component test snapshots
* ✔️ Fixing linting error
* ✔️ Fixing lint errors in vuex store module
* 👌 Started addressing review feedback
*  Updating executions preview behaviour when filters are applied
* 🐛 Fixing a bug where nodes and connections disappear if something is saved from executions view before loading WF in the main NodeView
* 🐛 Fixing pasting in executions view and wrong workflow activator state
*  Improved workflow switching and navigation, updated error message when trying to paste into execution
*  Some more navigation updates
* 💄 Fixing tab centering, execution filter button layout, added auto-refresh checkbox
* 🐛 Fixing a bug when saving workflow using save button
* 💄 Addressing design feedback, added delete execution button
*  Moving main execution logic to the root executions view
*  Implemented execution delete function
*  Updating how switching tabs for new unsaved workflows work
*  Remembering active execution when switching tabs
* 💄 Addressing design feedback regarding info accordion
* 💄 Updating execution card styling
*  Resetting executions when creating new workflow
* Fixing lint error
*  Hiding executions preview is active execution is not in the results. Updated execution list spacing
*  Fixing navigation to and from templates and executions
*  Implemented execution lazy loading and added new background to execution preview
* 💄 Disabling import when on executions tab
*  Handling opening executions from different workflow
*  Updating active execution on route change
*  Updating execution tab detection
*  Simplifying and updating navigation. Adding new route for new workflows
*  Updating workflow saving logic to work with new routes
* 🐛 Fixing a bug when returning to executions from different workflow
* 💄 Updating executions info accordion and node details view modal in execution preview
* 💄 Updating workflow activated modal to point to new executions view
*  Implemented opening new executions view from execution modal
*  Handling jsplumb init errors, updating unknown executions style
*  Updating main sidebar after syncing branch
*  Opening new trigger menu from executions view
* 💄 Updating sidebar resize behaviour
* ✔️ Fixing lint errors
*  Loading executions when mounting executions view
*  Resetting execution data when creating a new workflow
* 💄 Minor wording updates
*  Not reloading node view when new workflows are saved
* Removing leftover console log
* 🐛 Fixed a bug with save dialog not appearing when leaving executions tab
*  Updating manual execution settings detection in info accordion
* 💄 Addressing UI issues found during bug bash
* Fixing workflow saving logic
*  Preventing navigation if clicked tab is already opened
*  Updating lazy loading behaviour
*  Updating delete executions flow
*  Added retry executions button to the execution preview
*  Adding empty execution state, updating trigger detection logic, removing listeners when node view is not active
* 💄 Cosmetic code improvements
*  Trying the performance fix for nodeBase
*  Removing the `NodeBase`fix
* 🐛 Fixing a bug when saving the current workflow
* 👌 Addressing code review feedback
2022-10-26 10:02:56 +02:00
कारतोफ्फेलस्क्रिप्ट™ 99157cf581
feat: setup nightly tests for postgres and mysql schemas (#4441)
* feat: unify Jest config

* feat: simplify DB setup for tests

* feat: setup nightly tests for postgres and mysql schemas
2022-10-25 22:06:03 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5c9b40117a
refactor: rename NodeVersionedType to VersionedNodeType and move it to the workflow package (#4443) 2022-10-25 21:33:12 +02:00
Iván Ovejero adef6d7083
fix(editor): upgrade and make testing consistent in editor-ui and design-system (#4434)
* 📦 Update `package-lock.json`

* 📦 Make versions consistent in design-system

* 📦 Make lib versions consistent in editor-ui

* 🔧 Make vite configs consistent

* fix(design-system): updating vue2-bring-avatars alias

Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2022-10-25 13:46:25 +02:00
Iván Ovejero 07adc2d2dc
fix(core): revert blocking workflow update on interim change (#4437)
 Revert "feat(core): block workflow update on interim change (#4397)"

This reverts commit cddd012a2f.
2022-10-25 13:45:47 +02:00
Michael Auerswald b296fb06f3
fix(Email Trigger (IMAP) Node): backport V2 mark-seen-after-processing to V1 (#4435)
backport V2 mark-seen-after-processing to V1
2022-10-25 12:53:06 +02:00
OlegIvaniv 3143292a68
refactor(editor): do not add onDragOver event listeners on NodeItem mount (#4433) 2022-10-25 11:09:50 +02:00
Iván Ovejero cddd012a2f
feat(core): block workflow update on interim change (#4397)
*  Add `updatedAt` to store

*  Set `updatedAt` in store

* 👕 Update FE types

* 👕 Update BE types

*  Set `updatedAt` on workflow open

*  Add endpoint check

*  Add first update check

* 🔥 Remove log

*  Simplify check

*  Make `makeWorkflow` more flexible

* 🗃️ Make `updatedAt` default consistent

* 🧪 Adjust tests checking for `updatedAt`

* 🧪 Add tests for interim changes block

* ✏️ Remove unneeded quotes

*  Simplify without using `-1`

* 👕 Simplify interfaces

* 🐛 Fix calls to `setWorkflowUpdatedAt` setter

* :track: Move update to API call

*  Restrict check to multiple users only

* 🧪 Add more tests

* 🐛 Account for activation outside of canvas

* ✏️ Add warning comment

* 🔥 Remove unneeded check

*  Revert to `new Date()` for `-1`

* 🐛 Fix display for never updated
2022-10-25 09:08:06 +02:00
Iván Ovejero 77233f2370
fix(core): fix predefinedCredentialType in node graph item (#4379)
* 🐛 Fix predefined cred in node graph item

* 🔥 Remove logging
2022-10-25 09:07:26 +02:00
Iván Ovejero d2b97c0713
refactor(core): apply lint rule node-class-description-non-core-color-present (#4426)
* 👕 Enable rule `node-class-description-non-core-color-present`

* 👕 Apply rule to remove deprecated `color`

* ✏️ Fix unrelated typos

* ✏️ Fix another unrelated typo

Co-authored-by: Michael Kret <michael.k@radency.com>
2022-10-25 09:06:54 +02:00
Csaba Tuncsik 408bd96815
feat(editor): add readonly state for nodes (#4299)
* fix(editor): add types to Node.vue component props

* fix(editor): some cleanup in NodeView

* fix(editor): fix some boolean usage

* feat(editor): check foreign credentials

* fix(editor): passing readOnly to inputs

* fix(editor): add types to component and solve property mutation

* fix(editor): add types to component and solve property mutation

* fix(editor): component property type

* fix(editor): component property type

* fix(editor): default prop values

* fix(editor): fix FixedCollectionParameter.vue
2022-10-24 20:17:25 +02:00
Michael Auerswald 1f4eaeb3ae
fix(core): set JWT authentication token sameSite policy to lax (#4425)
set authentication token sameSite policy to lax
2022-10-24 15:05:30 +02:00
Iván Ovejero 5745027cee
fix(core): fix single-node execution failing in main mode (#4421)
* 🐛 Fix Manual Trigger group

* 🐛 Account for single-node execution
2022-10-24 15:03:41 +02:00
Iván Ovejero 1732324965
fix(core): amend typing for jsonParse() options (#4423)
* 📘 Amend typing for `jsonParse()` options

* ✏️ Update rule message and description

* 🔀 Cherrypick Adi's work

* 🐛 Account for falsy fallback values

* ♻️ Use `else if`

*  Add explicit error message as type

*  Consolidate utils tests

* ♻️ Use optional chaining

* 🔥 Remove patchy type error

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-10-24 12:48:16 +02:00
Nicholas Penree d7c8fefe19
docs(Execute Workflow Trigger Node): correct documentation link (no-changelog) (#4404) 2022-10-24 10:49:58 +01:00
Nicholas Penree 66037d57bf
docs(Manual Trigger Node): correct documentation link (no-changelog) (#4405) 2022-10-24 10:45:42 +01:00
Jonathan Bennetts 4b13b3398d
feat(Write Binary File Node): add option to append to a file (#4386) 2022-10-24 10:41:43 +01:00
Deborah 1d9d02b887
docs(Compare Datasets Node): fix docs link (no-changelog) (#4422) 2022-10-24 10:39:59 +01:00
Deborah b5403d99f2
docs(Schedule Trigger Node): fix docs link (no-changelog) (#4419) 2022-10-24 10:35:44 +01:00
Mutasem Aldmour 127f988400
refactor(editor): create ndv store (#4409)
* refactor ndv module out

* update active node in root state

* simplify

* fix conflict

* fix dragging
2022-10-24 11:35:03 +02:00
Mutasem Aldmour f6733cff9d
feat(editor): improve nodes panel search (#4399)
* feat(editor): add relevance sort to nodes panel

* handle locales
2022-10-24 11:34:35 +02:00
OlegIvaniv cdec0f1d88
ci(core): fix node-dev Build.ts linting (#4418)
* fix(core): fix linting node-dev Build.ts linting

* fix: use jsonParse helper for parsing of tsconfig

* 🏷️ Change output type for jsonParse
2022-10-24 11:21:27 +02:00
Michael Auerswald 1a37f0003f
fix(Email Trigger (IMAP) Node): improve connection handling and credentials (#4393)
* adds EmailReadImapV2 with fixes
2022-10-24 11:06:43 +02:00
Mutasem Aldmour 779b0d58f7
fix(editor): stop rendering expressions as html (#4420)
* fix(editor): don't render expr as html

* fix highlight bug
2022-10-24 10:48:33 +02:00
Michael Kret 91bd3c6567
fix(core): update to imports in helpers 2022-10-24 11:04:05 +03:00
OlegIvaniv 8a4b9722c5
refactor(editor): migrate FormInput to Composition API (#4406)
♻️ Refactor N8nFormInput to use composition API and make labels accesible
2022-10-24 09:39:22 +02:00
Michael Kret 1d57b10942
refactor(core): fix for no-uncaught-json-parse warnings 2022-10-21 21:52:43 +03:00
Michael Kret ca9eca9ae9
fix(TheHive Node): fixes for node issues 2022-10-21 19:46:31 +03:00
Michael Kret 2f4649cdf4
fix(InvoiceNinja Node): added support for v5 2022-10-21 19:45:54 +03:00
Bram Kn 8f25da52b1
feat(HTTP Request Node): add option for raw json header & query (#4408)
* http node headers and query JSON parameter options added

* Query and Header added to option processing

* remove old set headers.

*  Small improvements

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-10-21 12:29:20 -04:00
Michael Kret 9d6a2c32d7
refactor(core): fixes n8n-local-rules/no-json-parse-json-stringify warnings (#4407)
* 🔨 fixes

* 🔨 set rule to error
2022-10-21 17:24:58 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5eebd91ba7
fix(API): reduce code duplication between DB entities (#4351) 2022-10-21 12:29:25 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5eb1eb88e4
fix(core): delete some of the redundant code in core (#4359) 2022-10-21 11:38:56 +02:00
Jan Oberhauser 2e69e2c953 🔖 Release n8n@0.199.0 2022-10-21 05:48:05 +00:00
Jan Oberhauser 1e07c241ea ⬆️ Set n8n-core@0.139.0, n8n-editor-ui@0.165.0, n8n-nodes-base@0.197.0 and n8n-workflow@0.121.0 on n8n 2022-10-21 05:48:04 +00:00
Jan Oberhauser 38d91912bb 🔖 Release n8n-editor-ui@0.165.0 2022-10-21 05:46:07 +00:00
Jan Oberhauser 1c3f163287 ⬆️ Set n8n-design-system@0.39.0 and n8n-workflow@0.121.0 on n8n-editor-ui 2022-10-21 05:46:06 +00:00
Jan Oberhauser 1dce153f81 🔖 Release n8n-design-system@0.39.0 2022-10-21 05:45:53 +00:00
Jan Oberhauser c6a9477fab 🔖 Release n8n-nodes-base@0.197.0 2022-10-21 05:45:10 +00:00
Jan Oberhauser e63ef8870a ⬆️ Set n8n-core@0.139.0 and n8n-workflow@0.121.0 on n8n-nodes-base 2022-10-21 05:45:10 +00:00
Jan Oberhauser 2599018297 🔖 Release n8n-node-dev@0.78.0 2022-10-21 05:45:03 +00:00
Jan Oberhauser 325aaea85e ⬆️ Set n8n-core@0.139.0 and n8n-workflow@0.121.0 on n8n-node-dev 2022-10-21 05:45:03 +00:00
Jan Oberhauser 887f7f0021 🔖 Release n8n-core@0.139.0 2022-10-21 05:44:56 +00:00
Jan Oberhauser 27d018445b ⬆️ Set n8n-workflow@0.121.0 on n8n-core 2022-10-21 05:44:56 +00:00
Jan Oberhauser faab9d66dc 🔖 Release n8n-workflow@0.121.0 2022-10-21 05:44:49 +00:00