Commit graph

11158 commits

Author SHA1 Message Date
Milorad FIlipović 90e825f743
fix(editor): Fix value syncing in SQL and HTML editor (#6848) 2023-08-04 10:50:47 +02:00
कारतोफ्फेलस्क्रिप्ट™ a5667e6c42
fix(core): Update packages to address CVE-2023-2142 and CVE-2020-28469 (#6844)
GH Advisories:
[ CVE-2023-2142](https://github.com/advisories/GHSA-x77j-w7wf-fjmw)
[CVE-2020-28469](https://github.com/advisories/GHSA-ww39-953v-wcq6)

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-08-03 16:31:55 +02:00
Nihaal Sangha 6ec7033bb7
fix(core): Fix source control name and email being switched (#6839) 2023-08-03 15:19:54 +02:00
Val 371bfa0f48
fix: Auth.api user limit test expecting incorrect status (#6836)
fix: auth.api user limit test expecting incorrect status
2023-08-03 13:03:26 +01:00
कारतोफ्फेलस्क्रिप्ट™ 732416f52f
fix(core): Fix property existence checks on AugmentObject (#6842)
Fixes https://community.n8n.io/t/code-node-returns-full-item-object-on-node-all/28823
2023-08-03 12:19:30 +02:00
Iván Ovejero e4f041815a
perf(core): Cache roles (#6803)
* refactor: Create `RoleService`

* refactor: Refactor to use service

* refactor: Move `getUserRoleForWorkflow`

* refactor: Clear out old `RoleService`

* refactor: Consolidate utils into service

* refactor: Remove unused methods

* test: Add tests

* refactor: Remove redundant return types

* refactor: Missing utility

* chore: Remove commented out bit

* refactor: Make `Db.collections.Repository` inaccessible

* chore: Cleanup

* feat: Prepopulate cache

* chore: Remove logging

* fix: Account for tests where roles are undefined

* fix: Restore `prettier.prettierPath`

* test: Account for cache enabled and disabled

* fix: Restore `Role` in `Db.collections`

* refactor: Simplify by removing `orFail`

* refactor: Rename for clarity

* refactor: Use `cacheKey` for readability

* refactor: Validate role before creation

* refacator: Remove redundant `cache` prefix

* ci: Lint fix

* test: Fix e2e
2023-08-03 08:58:36 +02:00
Iván Ovejero f93270abd5
ci: Parallelize ci-master (no-changelog) (#6819)
* ci: Parallelize `ci-master` (no-changelog)

* ci: Move notify-on-failure to own job

* ci: Fix syntax

* ci: Dry run by adding branch

* ci: Fix job reference

* ci: Ensure full lint

* ci: Restore `CI_LINT_MASTER`

* ci: Remove env from top level

* ci: Add matrix strategy

* ci: Remove excess quotes

* ci: Remove excess key

* ci: Try with `run_install`

* Revert "ci: Try with `run_install`"

This reverts commit e5778c5735.

* ci: Add missing strategy

* ci: Remove temp branch

* test: Comment out test (from other PR)
2023-08-02 17:38:35 +02:00
Michael Auerswald 659ca26fe7
fix(core): Change VariablesService to DI and use caching (#6827)
* support redis cluster

* cleanup, fix config schema

* set default prefix to bull

* initial commit

* improve logging

* improve types and refactor

* list support and refactor

* fix redis service and tests

* add comment

* add redis and cache prefix

* use injection

* lint fix

* clean schema comments

* improve naming, tests, cluster client

* merge master

* cache returns unknown instead of T

* update cache service, tests and doc

* remove console.log

* VariablesService as DI, add caching, fix tests

* do not cache null or undefined values

* import fix

* more DI and remove collections

* fix merge

* lint fix

* rename to ~Cached

* fix test for CI

* fix ActiveWorkflowRunner test
2023-08-02 14:51:09 +02:00
Mutasem Aldmour 41d8a18d47
fix: Fix horizontal overflow for dialogs (#6830)
fix: horizental overflow for dialogs
2023-08-02 14:45:58 +02:00
Alex Grozav 50b00e2185
fix: Fix double hiring banner logging (no-changelog) (#6829)
fix: fix double hiring banner logging (no-changelog)
2023-08-02 14:37:49 +03:00
Alex Grozav fb755db9bd
fix: Fix replacing node empty string value with default value (no-changelog) (#6832)
fix: fix replacing node empty string value with default value
2023-08-02 14:19:01 +03:00
Alex Grozav 848e9b1172
fix: Fix saving workflow sharing (no-changelog) (#6828)
fix: fix saving workflow sharing
2023-08-02 14:17:14 +03:00
Michael Auerswald 3cad60e918
feat(core): Make Redis available for backend communication (#6719)
* support redis cluster

* cleanup, fix config schema

* set default prefix to bull

* initial commit

* improve logging

* improve types and refactor

* list support and refactor

* fix redis service and tests

* add comment

* add redis and cache prefix

* use injection

* lint fix

* clean schema comments

* improve naming, tests, cluster client

* merge master

* cache returns unknown instead of T

* update cache service, tests and doc

* remove console.log

* do not cache null or undefined values

* fix merge

* lint fix
2023-08-02 12:51:25 +02:00
Milorad FIlipović 4ac4b850dd
fix(editor): Fix redo when adding node on connection (#6833)
* fix(editor): Fix redo when adding node on connection
*  Adding tests for pushed nodes
* ✔️ Updating drag command for dragging nodes on the canvas
* 👌 Handling drag end with a command  option
2023-08-02 12:48:55 +02:00
कारतोफ्फेलस्क्रिप्ट™ 0ac3d47f26
ci: Fix linting (no-changelog) (#6831) 2023-08-02 11:05:24 +02:00
कारतोफ्फेलस्क्रिप्ट™ f718c2291f
fix(Code Node): Consistent redirection of stdout for JS and Python sandboxes (#6818)
Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 17:47:43 +02:00
कारतोफ्फेलस्क्रिप्ट™ 34df8b6238
refactor: Consolidate tsconfig and eslintrc files (no-changelog) (#6816)
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2023-08-01 17:32:43 +02:00
कारतोफ्फेलस्क्रिप्ट™ 31d8f478ee
refactor(core): Parse Webhook request bodies on-demand (#6394)
Also,
1. Consistent CORS support ~on all three webhook types~ waiting webhooks never supported CORS. I'll fix that in another PR
2. [Fixes binary-data handling when request body is text, json, or xml](https://linear.app/n8n/issue/NODE-505/webhook-binary-data-handling-fails-for-textplain-files).
3. Reduced number of middleware that each request has to go through.
4. Removed the need to maintain webhook endpoints in the auth-exception list.
5. Skip all middlewares (apart from `compression`) on Webhook routes. 
6. move `multipart/form-data` support out of individual nodes
7. upgrade `formidable`
8. fix the filenames on binary-data in webhooks nodes
9. add unit tests and integration tests for webhook request handling, and increase test coverage
2023-08-01 17:32:30 +02:00
OlegIvaniv 369a2e9796
fix(editor): Improve displaying and hiding of connections actions (#6823)
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-08-01 17:17:06 +02:00
Mutasem Aldmour 31a4cfc969
fix: Handle subtitle errors when pasting workflow (#6826) 2023-08-01 17:15:43 +02:00
Alex Grozav 88156deb5c
fix: Fix RLC and select dropdown styling and functionality (no-changelog) (#6809)
* fix: fix RLC and select dropdown styling and functionality

* fix: change setTimeout to nextTick

* fix: fix resource locator padding
2023-08-01 17:58:25 +03:00
Iván Ovejero 24ce141815
refactor: Clear unused ESLint directives from nodes-base (no-changelog) (#6812)
* refactor: Clear unused ESLint directives from nodes-base (no-changelog)

* removed unused disable directives

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 15:32:33 +02:00
Mutasem Aldmour 52aafe0737
fix: Remove tag animation (#6821) 2023-08-01 14:04:16 +02:00
Mutasem Aldmour 7525cfe2dc
fix: Fix all modal sizes (#6820) 2023-08-01 13:52:33 +02:00
Mutasem Aldmour 1d72225cb0
refactor: Clean up executions modal (#6822)
chore: Clean up executions modal
2023-08-01 13:51:49 +02:00
Iván Ovejero 2df0c2c473
refactor: Clear unused ESLint directives from FE packages (no-changelog) (#6811) 2023-08-01 13:47:55 +02:00
Iván Ovejero dec19585bc
refactor: Enforce expanded sensitive inputs rules (no-changelog) (#6815)
* refactor: Enforce expanded sensitive inputs rules (no-changelog)

* refactor: Add extra exemption

* fix: Add setting to `sessionToken` fields

* fix: Restore for `hidden` fields

* fix: More edge case exemptions

* fix: One more
2023-08-01 13:08:25 +02:00
Iván Ovejero f5134adde5
ci: Fix lint to fix build (no-changelog) (#6817) 2023-08-01 11:57:29 +02:00
Michael Kret 491378de77
fix(Postgres Trigger Node): Imposible to cancell execution manually (#6709) 2023-08-01 12:56:54 +03:00
Iván Ovejero fce8cc4275
fix(Linear Node): Fix issue creation priority (#6813) 2023-08-01 10:58:37 +02:00
Iván Ovejero 803b1521fa
fix: Correct typos in Taiga and ServiceNow nodes (#6814) 2023-08-01 09:59:15 +02:00
Jon 46a41c1c91
feat(Facebook Graph API Node): Add support for v16 and v17 (#6808) 2023-08-01 08:43:07 +01:00
Jon 7832e9c12d
docs: Update quick start video (no-changelog) (#6806) 2023-07-31 16:58:05 +01:00
कारतोफ्फेलस्क्रिप्ट™ 53e58b408a
fix(core): Fix loading of scoped-community packages (#6807)
fix(code): Fix loading of scoped-community packages
2023-07-31 17:55:16 +02:00
कारतोफ्फेलस्क्रिप्ट™ b7ca27afcf
refactor(core): Delete more redundant code across migrations (Part 1) (no-changelog) (#6691) 2023-07-31 17:35:53 +02:00
Michael Auerswald 7b27fa5898
fix(core): Serialize BigInts (#6805)
* workaround for non-serializable BigInt

* refactor
2023-07-31 16:53:30 +02:00
Csaba Tuncsik 651cf34da6
fix(editor): Remove additional margin on tooltip (#6802)
fix(editor): Remove additional margin on tooltip (Element UI+ tooltip has a default 12px offset, the old had 0)
2023-07-31 15:10:23 +02:00
कारतोफ्फेलस्क्रिप्ट™ 37a365fe9f
ci: Downgrade prettier (no-changelog) (#6804)
* ci: downgrade prettier (no-changelog)

* remove indent rule from editor
2023-07-31 14:55:03 +02:00
Michael Kret f6bf9e9887
fix(core): Restrict read/write file paths access (#6582) 2023-07-31 15:20:39 +03:00
Alex Grozav 7cd45885bf
fix: Fix tags overflow handler in workflows header (#6784)
* fix: fix tags container overflowing

* fix: fix intersection observer error
2023-07-31 15:17:05 +03:00
कारतोफ्फेलस्क्रिप्ट™ dc295ac5bf
fix(core): Add missing primary key on the execution_data table on postgres (#6797) 2023-07-31 12:35:42 +02:00
Csaba Tuncsik 3d6f5a24af
test(editor): Add canvas actions E2E tests (#6723) (#6790)
* test(editor): Add canvas actions E2E tests (#6723)

* test(editor): Add canvas actions E2E tests

* test(editor): Open category items in node creator when category dropped on canvas

* test(editor): Have new position counted only once in drag

* test(editor): rename test

(cherry picked from commit 052d82b220)

* test: fix drag positioning
2023-07-31 12:32:08 +02:00
Jon 749468e4fa
fix(Todoist Node): Fix issue with section id being ignored (#6799) 2023-07-31 11:25:34 +01:00
OlegIvaniv 3801130c7b
test(editor): Do not chain invoke calls after assertions in 24-ndv-paired-item e2e spec (no-changelog) (#6800)
* test(editor): Do not chaing invoke calls after assertions in 24-ndv-paired-item e2e spec

* Do not chaing realHover after assertion

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

* Remove .only

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-07-31 11:55:22 +02:00
Alex Grozav c9f3acc848
fix(editor): Prevent text edit dialog from re-opening in same tick (#6781)
* fix: prevent reopenning textedit dialog in same tick

* fix: add same logic for code edit dialog

* fix: remove stop modifier

* fix: blur input field when closing modal, removing default element-plus behaviour
2023-07-31 12:41:30 +03:00
Iván Ovejero ffae8edce3
refactor(core): Cache workflow ownership (#6738)
* refactor: Set up ownership service

* refactor: Specify cache keys and values

* refactor: Replace util with service calls

* test: Mock service in tests

* refactor: Use dependency injection

* test: Write tests

* refactor: Apply feedback from Omar and Micha

* test: Fix tests

* test: Fix missing spot

* refactor: Return user entity from cache

* refactor: More dependency injection!
2023-07-31 11:37:09 +02:00
Iván Ovejero 72523462ea
refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
Michael Kret 11567f946b
feat(core): Credentials for popular SecOps services, Part 1 (#6775) 2023-07-31 11:26:38 +03:00
OlegIvaniv 50b0dc21fd
fix(editor): Fix code node highlight error (#6791)
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-07-28 18:31:57 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6fb8a9ee39
ci: Fix linting issues (no-changelog) (#6788)
* ci: Fix linting (no-changelog)

* lintfix for nodes-base as well
2023-07-28 18:28:17 +02:00