Commit graph

128 commits

Author SHA1 Message Date
oleg ef5b7cf9b7
feat(core): Implement Dynamic Parameters within regular nodes used as AI Tools (#10862) 2024-10-02 13:31:22 +02:00
Michael Kret 4a63cff5ec
fix(Postgres Node): Falsy query parameters ignored (#10960) 2024-09-26 16:09:13 +01:00
कारतोफ्फेलस्क्रिप्ट™ 6a35812f92
ci: Setup biome and pre-commit hooks for formatting (no-changelog) (#10795)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Test Master / Lint (push) Blocked by required conditions
Test Master / Notify Slack on failure (push) Blocked by required conditions
Benchmark Docker Image CI / build (push) Waiting to run
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
2024-09-17 15:10:22 +03:00
Iván Ovejero 05e609d714
build: Upgrade nodelinter to 1.16.2 (no-changelog) (#10779) 2024-09-12 16:53:36 +02:00
Ricardo Espinoza c4eb3746d7
refactor: Use NodeConnectionType consistently across the code base (no-changelog) (#10595) 2024-08-29 09:55:53 -04:00
कारतोफ्फेलस्क्रिप्ट™ be52176585
refactor(core): Allow custom types on getCredentials (no-changelog) (#10567) 2024-08-27 15:23:58 +02:00
Michael Kret ce46bf516a
fix(Google Sheets Node): Better error when column to match on is empty (#10442)
Co-authored-by: Shireen Missi <shireen@n8n.io>
2024-08-16 15:59:59 +01:00
Shireen Missi 519fc4d753
fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217) 2024-07-31 08:39:37 +01:00
Jon 4d37b9669f
docs: Update add options text (no-changelog) (#10049) 2024-07-29 13:27:23 +01:00
Michael Kret 00ec253337
fix(Postgres Node): Option to treat query parameters enclosed in single quotas as text (#10214) 2024-07-29 14:48:11 +03:00
Jon 2eba57774b
docs: Update credential urls (no-changelog) (#10193) 2024-07-25 17:22:46 +01:00
कारतोफ्फेलस्क्रिप्ट™ 85aa560a5d
refactor(core): Centralize SSH Tunnel management (#9906)
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-07-04 12:29:44 +02:00
Iván Ovejero 44ea4c73eb
refactor: Remove unused lint directives (no-changelog) (#9842) 2024-06-24 12:13:18 +02:00
Michael Kret 870412f093
feat(core): Node hints improvements (no-changelog) (#9387)
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-05-22 13:35:29 +03:00
aya e896889394
feat(Postgres Node): Add option IS NOT NULL and hide value input fields (#9241) 2024-05-02 10:08:57 +01:00
Michael Kret 08e35027f1
fix(Postgres Node): Convert js arrays to postgres type, if column type is ARRAY (#9160) 2024-04-18 12:58:04 +03:00
Michael Kret 58518b684b
feat(Postgres Node): Options keepAlive and keepAliveInitialDelayMillis (#9067) 2024-04-09 18:41:51 +03:00
कारतोफ्फेलस्क्रिप्ट™ 7012577fce
fix(Postgres Trigger Node): closeFunction errors should not prevent a workflow from being deactivated (#8738) 2024-02-26 14:33:00 +01:00
कारतोफ्फेलस्क्रिप्ट™ 457cac4cf9
fix(Postgres Node): Close connection pool only if it's not already closed or closing (#8690) 2024-02-21 11:27:21 +01:00
Tomi Turtiainen 9a1cc56806
fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Elias Meire bed04ec122
fix(Postgres Node): Stop marking autogenerated columns as required (#8230)
## Summary

Postgres columns can be
- [generated as
identity](https://www.postgresqltutorial.com/postgresql-tutorial/postgresql-identity-column/)
- [generated by a custom
expression](https://www.postgresql.org/docs/current/ddl-generated-columns.html)

In these 2 cases, the column is not required when inserting a new row.
This PR makes sure these types of column are not marked required in n8n.

### How to test

1. Create a Postgres table with all types of generated columns:
for version >= 10
  ```sql
  CREATE TABLE "public"."test_table" (
      "id" int8 NOT NULL DEFAULT nextval('test_table_id_seq'::regclass),
      "identity_id" bigint GENERATED ALWAYS AS IDENTITY,
      "id_plus" numeric GENERATED ALWAYS AS (id + 5) STORED,
      "title" varchar NOT NULL,
      "created_at" timestamp DEFAULT now(),
      PRIMARY KEY ("id")
  )
  ```
  Before 10 you have to use serial or bigserial types:
  ```sql
  CREATE TABLE distributors (
     did    serial not null primary key,
     name   varchar(40) NOT NULL CHECK (name <> '')
);
  ```
2. Add a postgres node to canvas and try to insert data without the
generated columns
3. Should successfully insert

More info in Linear/Github issue ⬇️ 

## Related tickets and issues
- fixes #7084
-
https://linear.app/n8n/issue/NODE-816/rmc-not-all-id-fields-should-be-required
-
https://linear.app/n8n/issue/NODE-681/postgres-cant-map-automatically-if-database-requires-a-field

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-05 12:37:33 +01:00
Elias Meire 048b588852
fix: Make params panel double width for all SQL nodes (#8236)
## Summary

Make params panel double width for all SQL nodes

<img width="1445" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/422e7c6c-90c9-4cf0-832b-fab7679275d3">


## Related tickets and issues

https://linear.app/n8n/issue/NODE-986/make-all-sql-nodes-have-a-double-width-params-pane

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
2024-01-05 12:31:11 +01:00
Elias Meire 071e6d6b6e
feat(editor): Add fullscreen view to code editor (#8084)
## Summary

<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe">

1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed

It should work the same way for HTML/SQL/JSON editors

⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals

## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node



## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 17:23:24 +01:00
Iván Ovejero 0ca2759d75
refactor: Optimize SVG icons for nodes (#8195)
Running `svgo` to optimize icon size for nodes.
2024-01-02 17:40:08 +01:00
Jon 09a5729305
fix(Postgres Trigger Node): Increase manual trigger timeout from 30 to 60 seconds (#8015) 2023-12-13 13:04:16 +00:00
Michael Kret 435392cbfe
fix(Postgres Node): Do not include id column in upsert fields selection if it's not unique (#7975)
## Summary
Do not include id column in upsert fields selection if it's not unique
Forum:
https://community.n8n.io/t/postgres-node-insert-or-update-unique-column-name/32520
2023-12-11 17:34:24 +02:00
Jon 97e39c39d9
docs: Replace references to set node (no-changelog) (#7973)
## Summary
This replaces the set node references with edit fields.

Ref: https://n8nio.slack.com/archives/C036PA5D42D/p1702040900165709
2023-12-11 10:10:03 +00:00
Iván Ovejero e77fd5d286
refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914)
Ensure all errors in `nodes-base` are `ApplicationError` or children of
it and contain no variables in the message, to continue normalizing all
the backend errors we report to Sentry. Also, skip reporting to Sentry
errors from user input and from external APIs. In future we should
refine `ApplicationError` to more specific errors.

Follow-up to: [#7877](https://github.com/n8n-io/n8n/pull/7877)

- [x] Test workflows:
https://github.com/n8n-io/n8n/actions/runs/7084627970
- [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-05 11:17:08 +01:00
Iván Ovejero 62c096710f
refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Michael Kret 77039044eb
fix(core): Pg-promise de-initialization fix (#7417)
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/postgres-node-called-end-on-pool-more-than-once/30585/1
2023-10-12 12:10:14 +03:00
Michael Kret e2c3c7aceb
fix(core): Missing pairing info (#7326)
Github issue / Community forum post (link here to close automatically):
2023-10-10 18:36:20 +03:00
Michael Kret 763d4514fa
fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300)
Github issue / Community forum post (link here to close automatically):
2023-09-29 13:27:31 +03:00
Michael Kret 3a474552b2
feat(Set Node): Overhaul (#6348)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/pull/6348

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-09-19 13:16:35 +03:00
कारतोफ्फेलस्क्रिप्ट™ 92af1314fe
fix(Postgres Node): Fix automatic column mapping (#7121)
NODE-757
2023-09-06 16:32:50 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6aa7b93473
refactor(core): Deprecate prepareOutputData (no-changelog) (#7091) 2023-09-05 12:59:02 +02:00
Michael Kret 58e55ba669
fix(Postgres Node): Tunnel doesn't always close (#7087) 2023-09-04 13:26:02 +03:00
Michael Kret 9dd5f0e579
fix(Postgres Node): Connection pool of the database object has been destroyed (#7074)
Github issue / Community forum post (link here to close automatically):
2023-09-01 22:19:10 +03:00
Michael Kret 176ccd62bc
fix(Postgres Node): Empty return data fix for Postgres and MySQL (#7016) 2023-08-25 18:38:09 +03:00
Jon 0e075c9cb5
fix: Fix issue with key formatting introduced in 1.2.0 (#6896) 2023-08-09 16:23:35 +01:00
Jon db21a8db75
fix: Fix issue with key based credentials not being read correctly (#6824) 2023-08-09 12:30:53 +01:00
Iván Ovejero 24ce141815
refactor: Clear unused ESLint directives from nodes-base (no-changelog) (#6812)
* refactor: Clear unused ESLint directives from nodes-base (no-changelog)

* removed unused disable directives

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 15:32:33 +02:00
Michael Kret 491378de77
fix(Postgres Trigger Node): Imposible to cancell execution manually (#6709) 2023-08-01 12:56:54 +03:00
Michael Kret 4cae091cfb
fix(Postgres Node): Arrays in query replacement fix (#6718) 2023-07-25 15:34:45 +03:00
कारतोफ्फेलस्क्रिप्ट™ 250175d066
fix(Postgres Node): For select queries, empty result should be be replaced with {"success":true} (#6703)
* fix(Postgres Node): For select queries, empty result should be be replaced with `{"success":true}`

*  less checks

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-07-19 16:15:43 +02:00
Michael Kret aaa9ee3949
fix(Postgres Node): Upsert does not fetch columns when schema other then public (#6643) 2023-07-12 13:26:46 +03:00
कारतोफ्फेलस्क्रिप्ट™ e57e85edf7
refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) 2023-07-12 11:15:38 +02:00
Jon 3b12864460 feat: Add missing input panels to some trigger nodes (#6518) 2023-07-04 21:05:01 +02:00
Marcus ddfb24b325
fix(Postgres Trigger Node): Improve triggerMode property names and descriptions (no-changelog) (#6517)
💄update TiggerMode names and descriptions
2023-06-22 17:46:46 +02:00
Iván Ovejero beedfb609c
feat(editor): SQL editor overhaul (#6282)
* Draft setup
*  Implemented expression evaluation in Postgres node, minor SQL editor UI improvements, minor refacring
*  Added initial version of expression preview for SQL editor
*  Linking npm package for codemirror sql grammar instead of a local file
*  Moving expression editor wrapper elements to the component
*  Using expression preview in SQL editor
* Use SQL parser skipping whitespace
*  Added support for custom skipped segments specification
*  Fixing highlight problems with dots and expressions that resolve to zero
* 👕 Fixing linting error
*  Added current item support
*  Added expression support to more nodes with sql editor
*  Added expression support for other nodes
*  Implemented different SQL dialect support
* 🐛 Fixing hard-coded parameter names for editors
*  Fixing preview for nested queries, updating query when input data changes, adding keyboard shortcut to toggle comments
*  Adding a custom automcomplete notice for different editors
*  Updating SQL autocomplete notice
*  Added unit tests for SQL editor
*  Using latest grammar
* 🐛 Fixing code node editor rendering
* 💄 SQL preview dropdown matches editor width. Removing unnecessary css
*  Addressing PR review feedback
* 👌 Addressing PR review feedback pt2
* 👌 Added path alias for utils in nodes-base package
* 👌 Addressing more PR review feedback
*  Adding tests for `getResolvables` utility function
* Fixing lodash imports
* 👌 Better focus handling, adding more plugins to the editor, other minor imrovements
*  Not showing SQL autocomplete suggestions inside expressions
*  Using npm package for sql grammar
*  Removing autocomplete notice, adding line highlight on syntax error
* 👌 Addressing code review feedback
---------
Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2023-06-22 16:47:28 +02:00
Deborah fecf62296b
docs: Fix Postgres trigger docs URL (#6403)
fix postgres trigger docs URL
2023-06-13 15:06:28 +01:00