कारतोफ्फेलस्क्रिप्ट™
bb2895689f
feat(editor): Overhaul document title management ( #10999 )
2024-09-30 10:57:25 +02:00
Ricardo Espinoza
26a653a79a
refactor(editor): Clean all instances of isDesktopDeployment ( #10884 )
2024-09-20 08:24:08 -04:00
Csaba Tuncsik
ed963011c9
fix(editor): Move projects and rbac files (no-changelog) ( #9651 )
2024-06-06 15:30:17 +02:00
Csaba Tuncsik
6955e8991c
fix(editor): Remove isOwner from IUser interface ( #8888 )
2024-03-18 11:39:15 +01:00
Alex Grozav
f5a4bfe40c
feat(editor): Migrate copyPaste mixin to composables (no-changelog) ( #8179 )
2023-12-29 12:13:24 +02:00
कारतोफ्फेलस्क्रिप्ट™
68cff4c59e
refactor(editor): Improve linting for component and prop names (no-changelog) ( #8169 )
2023-12-28 09:49:58 +01:00
कारतोफ्फेलस्क्रिप्ट™
753cbc1e96
refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) ( #7838 )
2023-11-28 12:15:08 +01:00
Alex Grozav
67a88914f2
feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component ( #7702 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2023-11-23 13:22:47 +02:00
Giulio Andreini
f1e7ef0117
fix(editor): Dark mode switch style fix and other tweaks (no-changelog) ( #7599 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-14 17:13:30 +01:00
Giulio Andreini
0746783e02
refactor(editor): Color palette updates, introduce dark mode ( #6980 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-01 13:33:36 +01:00
Inga
c599006b91
fix(editor): Open only one tab with plans page ( #7377 )
...
## Issue
In community edition, clicking on "View plans" button on "Settings" ->
"Usage and plan" page (e.g. http://127.0.0.1:5678/settings/usage ) opens
two new tabs with n8n pricing (one of them with UTM tracking, another
without).
This was introduced in #6317 , when click handler of "View plans" link
container [started
calling](https://github.com/n8n-io/n8n/pull/6317/files#diff-0bf26afac8a06e03b3d39d0668f22408859355b585a9ab420800c125e33f0691R109 )
`uiStore.goToUpgrade(...)` which opens n8n pricing in a new tab, while
browser opens another tab for the link URL.
The simplest fix, implemented in this PR, is to prevent default event
handling (so that, after `onViewPlans` is called, browser will not
attempt to process the click additionally as clicking on the link),
similarly to how it is prevented on some other pages. It only solves the
immediate problem of browser opening two new tabs on clicking "View
plans".
Note that **I didn't implement any tests for the changed behavior**,
because it was not covered by tests before, and I couldn't quite figure
out how to cover it now within the existing test approach (considering
that testing the fact that only one new tab is open will likely require
to write entirely new tests relying on puppeteer; as far as I can see,
no existing `editor-ui` tests are doing anything like that). I'll gladly
implement tests for the new behavior if you tell me how you would like
them to look.
The existing tests for `editor-ui` still pass; I didn't run tests for
other subpackages (see "additional contribution notes" below).
## Additional notes on the issue.
I'm not sure that the change in this PR is the correct long-term
solution for the issue, because the URLs for these two methods (custom
click handler for link container and default link handling) are slightly
different:
* Custom click handler calls `useTelemetryStore().track('User clicked
upgrade CTA', ...)`; then calls `sendUsageTelemetry('view_plans')` (it
feels weird that two calls to telemetry are made); then opens new tab
for `https://n8n.io/pricing?utm_campaign=open&source=usage_page ` (note
that prior to #7316 the second call to telemetry was done after the new
tab is opened, not before);
* Link itself refers to another page, with slightly different tracking
parameters:
`https://subscription.n8n.io/?instanceid=[REDACTED]&version=1.10.0&callback=http%3A%2F%2F127.0.0.1%3A5678%2Fsettings%2Fusage&source=usage_page `;
but this page redirects to `https://n8n.io/pricing/ `.
It is not clear which one of the two is the right way of doing things.
Although `goToUpgrade` is called in 20 places throughout `editor-ui`,
while `viewPlansUrl`, as far as I can see, is used for this button only.
Additionally, since Settings pages don't work without JS anyway, I can
only think of two separate scenarios where any tab would be opened:
* Left-clicking the link (or Ctrl-clicking, or pressing Space or Enter
when the link is focused, or tapping): previously, both custom click
handler was executed and link's `href` was opened; in this PR, only
custom click handler is executed (similarly to how it is done in the
other places where `goToUpgrade` is called);
* Right-clicking (or long tapping, or opening context menu in any other
way) and selecting "open link in new tab" (or similar): opens a new tab
for URL from the `href` attribute (and does not send any telemetry at
all).
I'd say that the better permanent solution would probably be to get rid
of one of these methods entirely, and only rely on another in all cases
(for me, as an outside contributor, the preferred way would be for
custom click handler to only send telemetry, while letting my browser
handle the actual navigation). However, that would be a large change,
much more than one line in this PR.
Additionally, other similar places where `goToUpgrade` is currently
called (directly or indirectly) would also need to be adapted for this
change.
## Additional contribution notes
As a first-time contributor, I've encountered several things I didn't
expect; I'm not sure if they should be expected or are issues:
1. Tests for the entire monorepo consume a lot of RAM; 20GB free RAM was
not enough, so I couldn't run tests for the entire monorepo and had to
only run them for `packages/editor-ui`;
2. Linting is very slow; `pnpm lint` in `packages/editor-ui` takes ten
minutes to complete;
3. It seems that types are not checked. Code OSS highlights numerous
errors in code files: for example, `'debug'` is incompatible with
`CloudUpdateLinkSourceType` expected by `goToUpgrade` here:
3e7a4d3b2c/packages/editor-ui/src/composables/useExecutionDebugging.ts (L128)
2023-10-13 14:14:26 +02:00
Ricardo Espinoza
1dfa052301
feat(editor): Support autologin for upgrade path ( #7316 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-06 13:16:27 +02:00
Mutasem Aldmour
7525cfe2dc
fix: Fix all modal sizes ( #6820 )
2023-08-01 13:52:33 +02:00
Alex Grozav
dd6a4c956a
feat(editor): Migrate Design System and Editor UI to Vue 3 ( #6476 )
...
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix(editor): Fix App loading & auth (#6768 )
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-07-28 09:51:07 +02:00
Ricardo Espinoza
dc58340eee
feat(editor): Change upgrade CTA on community editions (no-changelog) ( #6317 )
...
* Change upgrade CTA on community editions
* upgrade CTA event
* Send source as ref in when redirecting
* fix tests
* import correcty telemetryfunction
* aja
* remove useUpgradeLink composable
* remove composable from index.ts
* Add goToUpgrade to usage view
2023-06-05 13:39:04 -04:00
Iván Ovejero
d5c44987f4
refactor(editor): Add infix to Pinia stores (no-changelog) ( #6149 )
...
* ⚡ Add infix to Pinia stores
* ⚡ Fix paths in mocks
* 🐛 Fix import
2023-05-05 10:41:54 +02:00
Iván Ovejero
57aab63c10
refactor: Integrate consistent-type-imports in FE packages (no-changelog) ( #6060 )
...
* 👕 Move `consistent-type-imports` to top level
* 👕 Apply lintfixes
* 👕 Apply more lintfixes
* 👕 More lintfixes
* 👕 More lintfixes
2023-04-24 12:18:24 +02:00
Alex Grozav
a79c253345
feat: Add source to all View Plans links (no-changelog) ( #5097 )
...
feat: Add source to all View Plans links
2023-01-09 14:57:51 +02:00
Csaba Tuncsik
2e28f13a55
refactor(editor): Usage and plans page on Desktop ( #5051 )
...
* refactor(editor): Usage and plans page on Desktop apply Ivan's review
* fix(editor): Usage and plans page on Desktop apply Ivan's review
2022-12-29 09:42:38 +01:00
Csaba Tuncsik
26e2321a71
fix(editor): Usage and plans page on Desktop ( #5045 )
2022-12-28 17:07:34 +01:00
Csaba Tuncsik
d6bc760ab4
fix(editor): Transparentize tertiary button on Usage page ( #5033 )
2022-12-27 09:47:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
a12606828e
ci: Enforce code formatting on editor-ui (no-changelog) ( #5022 )
...
* ci: Enforce code formatting on editor-ui (no-changelog)
* pnpm format on all frontend code
2022-12-23 13:37:32 +01:00
Csaba Tuncsik
0da338f9b5
feat(editor): Add usage and plan pages ( #4819 )
...
* feat(editor): Usage and plan page (#4793 )
feat(editor): usage and plan page
* feat(editor): Update Usage and plan page (#4842 )
* feat(editor): usage and plan store
* feat(editor): usage and plan page updates
* feat(editor): usage and plan add buttons and alert
* tes(editor): usage and plan store
* tes(editor): usage remove refresh button and add link to view plans
* tes(editor): usage use info tip
* tes(editor): usage info style
* feat(editor): Get quotas data (#4866 )
feat(editor): get quotas data
* feat(editor): In-app experience (#4875 )
* feat: Add license quotas endpoint
* feat: Add trigger count to workflow activation process
* refactor: Get quotas from db
* feat: Add license information
* ✨ - finalised GET /license endpoint
* 🔨 - getActiveTriggerCount return 0 instead of null
* 🐛 - ignore manualTrigger when counting active triggers
* ✨ - add activation endpoint
* ✨ - added renew endpoint
* 🔨 - added return type interfaces
* 🔨 - handle license errors where methods are called
* 🔨 - rename function to match name from lib
* feat(editor): usage add plans buttons logic
* 🚨 - testing new License methods
* feat(editor): usage add more business logic
* chore(editor): code formatting
* 🚨 - added license api tests
* fix(editor): usage store
* fix(editor): usage update translations
* feat(editor): usage add license activation modal
* feat(editor): usage change subscription app url
* feat(editor): usage add contact us link
* feat(editor): usage fix modal width
* ✨ - Add renewal tracking metric
* ✨ - add license data to pulse event
* 🔨 - set default triggercount on entity model
* ✨ - add db migrations for mysql and postgres
* fix(editor): Usage api call data processing and error handling
* fix(editor): Usage fix activation query key
* 🚨 - add initDb to telemetry tests
* 🔨 - move getlicensedata to licenseservice
* 🔨 - return 403 instead of 404 to non owners
* 🔨 - move owner checking to middleware
* 🐛 - fixed incorrectly returned error from middleware
* 🐛 - using mock instead of test db for pulse tests
* fix(editor): Usage fix activation and add success messages
* fix(editor): Usage should not renew activation right after activation
* 🚨 - skipping failing pulse tests for now
* fix(editor): Usage add telemetry calls and apply design review outcomes
* feat(editor): Hide usage page according to BE flag
* feat(editor): Usage modify key activation flow
* feat(editor): Usage change subscription app url
* feat(editor): Usage add telemetry for manage plan
* feat(editor): Usage extend link url query params
* feat(editor): Usage add line chart if there is a workflow limit
* feat(editor): Usage remove query after key activation redirection
* fix(editor): Usage handle limit exceeded workflow chart, add focus to input when modal opened
* fix(editor): Usage activation can return router promise when removing query
* fix(editor): Usage and plan design review
* 🐛 - fix renew endpoint hanging issue
* 🐛 - fix license activation bug
* fix(editor): Usage proper translation for plans and/or editions
* fix(editor): Usage apply David's review results
* fix(editor): Usage page set as default and first under Settings
* fix(editor): Usage open subscription app in new tab
* fix(editor): Usage page having key query param a plan links
* test: Fix broken test
* fix(editor): Usage page address review
* 🧪 Flush promises on telemetry tests
* ⚡ Extract helper with `setImmediate`
* 🔥 Remove leftovers
* ⚡ Use Adi's helper
* refactor: Comment broken tests
* refactor: add Tenant id to settings
* feat: add environment to license endpoints
* refactor: Move license environment to general settings
* fix: fix routing bug
* fix(editor): Usage page some code review changes and formatting
* fix(editor): Usage page remove direct usage of reusable translation keys
* fix(editor): Usage page async await instead of then
* fix(editor): Usage page show some content only if network requests in component mounted were successful
* chore(editor): code formatting
* fix(editor): Usage checking license environment
* feat(editor): Improve license activation error messages (no-changelog) (#4958 )
* fix(editor): Usage changing activation error title
* remove unnecessary import
* fix(editor): Usage refactor notification showing
* fix(editor): Usage using notification directly in store actions
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: freyamade <freya@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
* fix(editor): Usage change mounted lifecycle logic
* fix(editor): Usage return after successful activation in mounted
* fix: remove console log
* test: fix tests related to settings (#4979 )
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: freyamade <freya@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2022-12-20 10:52:01 +01:00
