Alex Grozav
dd6a4c956a
feat(editor): Migrate Design System and Editor UI to Vue 3 ( #6476 )
...
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix(editor): Fix App loading & auth (#6768 )
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-07-28 09:51:07 +02:00
Iván Ovejero
3566c13afc
feat: Allow eslint-config to be externally consumable ( #6694 )
...
* feat: Allow `eslint-config` to be externally consumable
* refactor: Adjust import styles
2023-07-19 09:35:10 +02:00
Iván Ovejero
96144bd983
ci: Add rule dangerously-use-html-string-missing (no-changelog) ( #6299 )
2023-05-24 10:12:41 +02:00
Iván Ovejero
fe937a0ee3
ci: Forbid skipping tests (no-changelog) ( #6199 )
2023-05-24 09:45:37 +02:00
कारतोफ्फेलस्क्रिप्ट™
e046f656fe
feat(core): Remove all floating promises. Enforce @typescript-eslint/no-floating-promises ( #6281 )
2023-05-24 02:01:45 +02:00
कारतोफ्फेलस्क्रिप्ट™
4b5cbe7750
ci(editor): Enfore stricter linting rules from eslint-plugin-vue (no-changelog) ( #6242 )
2023-05-19 15:31:16 +02:00
कारतोफ्फेलस्क्रिप्ट™
ebb3aaf61e
refactor(editor): Drop vue-typed-mixins (no-changelog) ( #6257 )
2023-05-16 11:43:46 +02:00
Iván Ovejero
06fa6f1fb3
ci: Expand ESLint to tests in BE packages (no-changelog) ( #6147 )
...
* 🔧 Adjust base ESLint config
* 🔧 Adjust `lint` and `lintfix` in `nodes-base`
* 🔧 Include `test` and `utils` in `nodes-base`
* 📘 Convert JS tests to TS
* 👕 Apply lintfixes
2023-05-02 10:37:19 +02:00
Iván Ovejero
88724bb056
ci: Enforce no unused imports (no-changelog) ( #6073 )
2023-04-25 11:47:03 +02:00
कारतोफ्फेलस्क्रिप्ट™
c7b1920943
ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) ( #6070 )
2023-04-24 14:47:13 +02:00
Iván Ovejero
57aab63c10
refactor: Integrate consistent-type-imports in FE packages (no-changelog) ( #6060 )
...
* 👕 Move `consistent-type-imports` to top level
* 👕 Apply lintfixes
* 👕 Apply more lintfixes
* 👕 More lintfixes
* 👕 More lintfixes
2023-04-24 12:18:24 +02:00
Michael Kret
0e93fe064e
refactor(core): Forbid raw enums (no-changelog)
2023-04-21 14:23:15 +03:00
Iván Ovejero
946f7f38ba
ci: Fix catch clause lint rule ( #5875 )
...
🐛 Fix catch clause lint rule
2023-03-31 19:16:51 +02:00
Iván Ovejero
62751b5a0b
refactor: Add lint rule no-unused-param-in-catch-clause ( #5868 )
...
👕 Add lint rule `no-unused-param-in-catch-clause`
2023-03-31 16:44:08 +02:00
Iván Ovejero
d548161632
feat(core): Security audit ( #5034 )
...
* ✨ Implement security audit
* ⚡ Use logger
* 🧪 Fix test
* ⚡ Switch logger with stdout
* 🎨 Set new logo
* ⚡ Fill out Public API schema
* ✏️ Fix typo
* ⚡ Break dependency cycle
* ⚡ Add security settings values
* 🧪 Test security settings
* ⚡ Add publicly accessible instance warning
* ⚡ Add metric to CLI command
* ✏️ Fix typo
* 🔥 Remove unneeded path alias
* 📘 Add type import
* 🔥 Remove inferrable output type
* ⚡ Set description at correct level
* ⚡ Rename constant for consistency
* ⚡ Sort URLs
* ⚡ Rename local var
* ⚡ Shorten name
* ✏️ Improve phrasing
* ⚡ Improve naming
* ⚡ Fix casing
* ✏️ Add docline
* ✏️ Relocate comment
* ⚡ Add singular/plurals
* 🔥 Remove unneeded await
* ✏️ Improve test description
* ⚡ Optimize with sets
* ⚡ Adjust post master merge
* ✏️ Improve naming
* ⚡ Adjust in spy
* 🧪 Fix outdated instance test
* 🧪 Make diagnostics check consistent
* ⚡ Refactor `getAllExistingCreds`
* ⚡ Create helper `getNodeTypes`
* 🐛 Fix `InternalHooksManager` call
* 🚚 Rename `execution` to `nodes` risk
* ⚡ Add options to CLI command
* ⚡ Make days configurable
* :revert: Undo changes to `BaseCommand`
* ⚡ Improve CLI command UX
* ⚡ Change no-report return value
Empty array to trigger empty state on FE.
* ⚡ Add empty check to `reportInstanceRisk`
* 🧪 Extend Jest `expect`
* 📘 Augment `jest.Matchers`
* 🧪 Set extend as setup file
* 🔧 Override lint rule for `.d.ts`
* ⚡ Use new matcher
* ⚡ Update check
* 📘 Improve typings
* ⚡ Adjust instance risk check
* ✏️ Rename `execution` → `nodes` in Public API schema
* ✏️ Add clarifying comment
* ✏️ Fix typo
* ⚡ Validate categories in CLI command
* ✏️ Improve naming
* ✏️ Make audit reference consistent
* 📘 Fix typing
* ⚡ Use `finally` in CLI command
2023-01-05 13:28:40 +01:00
Iván Ovejero
0b47f9ce4e
refactor: Lint for no interpolation in regular string ( #5060 ) (no-changelog)
...
* ✨ Create rule `no-interpolation-in-regular-string`
* 👕 Enable rule
* ⚡ Run rule (no issues) and add exception
* ⚡ Simplify regex
To account for expressions and to make it less expensive
2022-12-29 14:24:19 +01:00
Iván Ovejero
d9b98fc8be
refactor: Lint for no unneeded backticks ( #5057 ) (no-changelog)
...
* ✨ Create rule `no-unneeded-backticks`
* 👕 Enable rule
* ⚡ Run rule on `cli`
* ⚡ Run rule on `core`
* ⚡ Run rule on `workflow`
* ⚡ Rule rule on `design-system`
* ⚡ Run rule on `node-dev`
* ⚡ Run rule on `editor-ui`
* ⚡ Run rule on `nodes-base`
2022-12-29 12:20:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
0333b053ee
fix: Fix the linting issue on master (no-changelog) ( #5013 )
...
* get rid of the "`parseForESLint` from parser `@typescript-eslint/parser` is invalid" errors
* fix the formatting issue
2022-12-22 09:42:07 -06:00
कारतोफ्फेलस्क्रिप्ट™
17f13b3b6e
ci: Setup eslint-import-resolver-typescript for improved TS linting ( #4996 )
...
* Setup stricter linting for typescript
* make `import/no-unresolved` an error everywhere
* use prettier to format `.vscode/settings.default.json`
* address PR comments
2022-12-22 09:55:39 +01:00
Iván Ovejero
0e4cda5763
refactor: Phase out TSLint in editor-ui (no-changelog) ( #4935 )
...
* 🔥 Remove `tslint.json`
* 🔥 Remove TSLint commands
* 🔥 Remove exceptions in `editor-ui`
* 🔥 Remove from `.npmignore`
* 🔥 Remove from `eslint-config`
* 🔥 Remove exception from `design-system`
* 🎨 Prettify
* 📦 Update pnpm-lock
* 🔥 Remove duplicate import
* 🔥 Remove exemption for `no-explicit-any`
* 👕 Inline `no-explicit-any` exemptions
2022-12-15 14:06:00 +01:00
Iván Ovejero
7b819ad5a1
refactor: Disable ESLint indent rule (no-changelog) ( #4828 )
...
* 👕 Disable ESLint `indent` rule
* 🔥 Remove redundant rule
2022-12-06 16:07:26 +01:00
Iván Ovejero
cfd32d2642
refactor: Phase out TSLint in nodes-base (no-changelog) ( #4798 )
...
* 🔥 Remove TSLint scripts
* 🔥 Remove TSLint config
* 🔥 Remove TSLint exceptions
* 👕 Adjust lint config
* ✏️ Add story numbers
2022-12-02 15:25:21 +01:00
कारतोफ्फेलस्क्रिप्ट™
ada73ed41d
ci: Fix linting issues on master (no-changelog) ( #4768 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-11-30 12:16:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
600b285a44
refactor: Migrate Vue slots to the new syntax ( #4603 )
...
Co-authored-by: Alex Grozav <alex@grozav.com>
2022-11-18 14:59:31 +01:00
कारतोफ्फेलस्क्रिप्ट™
53d2526cd1
ci: Fix linting by ignoring eslintrc and jest.config again (no-changelog) ( #4613 )
...
ci: Fix linting on by ignoring eslintrc and jest.config (no-changelog)
2022-11-15 19:56:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
13659d036f
ci: Ensure that eslint runs on all frontend code (no-changelog) ( #4602 )
...
* ensure that eslint runs on all frontend code
* remove tslint from `design-system`
* enable prettier and eslint-prettier for `design-system`
* Delete tslint.json
* use a single editorconfig for the repo
* enable prettier for all code in `design-system`
* more linting fixes on design-system
* ignore coverage for git and prettier
* lintfix on editor-ui
2022-11-15 18:20:54 +01:00
कारतोफ्फेलस्क्रिप्ट™
0148631d28
build: Upgrade some of the backend dev-tooling (no-changelog) ( #4589 )
...
* upgrade ts-node
* move tslint and typescript to a single place
* source-map-support should be loaded in the `n8n` bin script, and not in core
* upgrade jest
* Support only node.js 14, 16, or 18
2022-11-14 15:37:32 +01:00
Iván Ovejero
52f38df867
refactor: Remove unused vars to fix build (no-changelog) ( #4584 )
...
* 🔥 Remove unused vars to fix build
* 👕 Make unused vars severity conditional
2022-11-11 16:07:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
736777385c
feat: Switch from npm to pnpm ( #4429 )
2022-11-09 17:32:05 +01:00
Michael Kret
479644a499
refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ ( #4523 )
...
* ⚡ rule and fixes
* ⚡ clean up
2022-11-08 15:28:21 +01:00
Iván Ovejero
ec5ef0c50d
refactor(core): clear @ts-ignore from workflow and core packages ( #4467 )
...
* 📘 Clear all `@ts-ignore` comments from workflow package
* 👕 Default to error with package-level overrides
* refactor(core): clear all `@ts-ignore` comments from core package (#4473 )
👕 Clear all `@ts-ignore` comments from core package
* ✏️ Update comment
2022-10-31 12:45:34 +01:00
Iván Ovejero
641d904ee4
refactor: set ESLint to warn on ts-ignore comment ( #4465 )
...
👕 Set `ban-ts-comment` to warn on @ts-ignore
2022-10-28 10:35:31 +02:00
कारतोफ्फेलस्क्रिप्ट™
99157cf581
feat: setup nightly tests for postgres and mysql schemas ( #4441 )
...
* feat: unify Jest config
* feat: simplify DB setup for tests
* feat: setup nightly tests for postgres and mysql schemas
2022-10-25 22:06:03 +02:00
Iván Ovejero
1732324965
fix(core): amend typing for jsonParse() options ( #4423 )
...
* 📘 Amend typing for `jsonParse()` options
* ✏️ Update rule message and description
* 🔀 Cherrypick Adi's work
* 🐛 Account for falsy fallback values
* ♻️ Use `else if`
* ⚡ Add explicit error message as type
* ⚡ Consolidate utils tests
* ♻️ Use optional chaining
* 🔥 Remove patchy type error
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-10-24 12:48:16 +02:00
Michael Kret
1d57b10942
refactor(core): fix for no-uncaught-json-parse warnings
2022-10-21 21:52:43 +03:00
Michael Kret
9d6a2c32d7
refactor(core): fixes n8n-local-rules/no-json-parse-json-stringify warnings ( #4407 )
...
* 🔨 fixes
* 🔨 set rule to error
2022-10-21 17:24:58 +02:00
Iván Ovejero
6a1838d8c1
refactor: lint for inefficient deep clones ( #4378 )
...
* 👕 Create rule `no-json-parse-json-stringify`
* 🧪 Add tests
* 👕 Enable new rule
* 👕 FIx unrelated lint issue
2022-10-19 09:36:25 +02:00
Iván Ovejero
64fffa0579
fix(lint): Set no-unused-vars to warn ( #4228 )
...
* 👕 Set `no-unused-vars` to `warn`
* 👕 Fix lint issue in `master`
* ✏️ Fix plugin name
2022-09-29 12:47:07 +02:00
कारतोफ्फेलस्क्रिप्ट™
bc42073e28
ci: Use eslint-plugin-diff only on the CI ( #4194 )
2022-09-26 14:43:52 +02:00
Mike Arvela
31391a5b19
feat(eslint-config): add custom eslint rule 'no-uncaught-json-parse' ( #4087 )
...
feat(eslint-config): add custom eslint rule 'no-uncaugh-json-parse'
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-09-26 11:08:59 +03:00
Iván Ovejero
a2441b8e3f
refactor(ci): Lint PR diffs only ( #4137 )
...
* ✨ Set up `eslint-plugin-diff`
* 🔧 Fix setup
* ⬆️ Upgrade `checkout` and `setup-node`
* 🔧 Fix YAML
* 🧪 Verify `eslint-plugin-diff` behavior
* Revert "🧪 Verify `eslint-plugin-diff` behavior"
This reverts commit 1fcc6c8299✏️ Fix comment
2022-09-21 10:24:39 +02:00
कारतोफ्फेलस्क्रिप्ट™
69eb97999d
fix(eslint): setup eslint to run on every package - N8N-4553 ( #4050 )
...
* fix(eslint): setup eslint to run on every package
Also, unify eslint config and dependencies into a private package in the workspace.
2022-09-12 11:41:50 +02:00
