Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05👕 Fix severity
2023-01-27 12:22:44 +01:00
Iván Ovejero
cfd32d2642
refactor: Phase out TSLint in nodes-base (no-changelog) ( #4798 )
...
* 🔥 Remove TSLint scripts
* 🔥 Remove TSLint config
* 🔥 Remove TSLint exceptions
* 👕 Adjust lint config
* ✏️ Add story numbers
2022-12-02 15:25:21 +01:00
agobrech
67983e8f94
fix: Remove redundant await in node's api request functions without try/catch ( #4639 )
...
* 🐛 Remove useless await for actionNetwork
* 🔥 Remove useless await
* 🔥 Remove useless await keyword to other generic functions
2022-11-22 17:57:17 +01:00
Iván Ovejero
52f38df867
refactor: Remove unused vars to fix build (no-changelog) ( #4584 )
...
* 🔥 Remove unused vars to fix build
* 👕 Make unused vars severity conditional
2022-11-11 16:07:50 +01:00
agobrech
c7133ecd3f
fix(core): Deduplicate error handling in nodes ( #4319 )
...
* Fix issue with isAxios property
* 🥅 Deduplicate errors handeling improve errors for credentials
* 🎨 correctly throws error
2022-11-11 11:32:43 +01:00
Michael Kret
479644a499
refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ ( #4523 )
...
* ⚡ rule and fixes
* ⚡ clean up
2022-11-08 15:28:21 +01:00
Omar Ajoue
103f04e4eb
fix(AWS Nodes): Handle query string and body properly for AWS related requests ( #4039 )
2022-09-06 14:33:52 +02:00
agobrech
9017fd463f
🐛 Fix issue where the QS would be ignored ( #3967 )
2022-08-29 15:28:17 +02:00
agobrech
5285fc1de6
N8N-4134 Add AWS cred testing and http custom calls with credentials ( #3924 )
...
* ✨ Add Aws testing and http custom api
2022-08-23 19:02:32 +02:00
Michael Kret
0ecbb4a19d
refactor: Format nodes-base package (A-F) ( #3800 )
...
* 🔨 prettier formated nodes - A
* 🔨 prettier formated nodes - B
* ⚡ prettier formated nodes - C
* ⚡ prettier formated nodes - D
* ⚡ prettier formated nodes - E-F
* 🎨 Adjust nodes-base formatting command (#3805 )
* Format additional files in nodes A-F (#3811 )
* ⚡ fixes
* 🎨 Add Mindee to ignored dirs
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-08-01 22:47:55 +02:00
Basit Ali
ce79e6b74f
feat(All AWS Nodes): Enable support for AWS temporary credentials ( #2587 )
...
* Enable support for AWS temporary credentials
* 🔨 removed toggle from ui added sessionToken to other aws services that using sign function from aws4 module
* Update sign method for other AWS nodes
* Remove the unneeded additional `temporaryCredentials` checkbox
* Update description for session token
* ⚡ added missing session token to credentials test
* Update sign method for DynamoDB
* 🔨 added back toggle for hiding session token, fixed linter errors
* ⚡ wording fix
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-04-22 16:33:09 +02:00
Omar Ajoue
d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials ( #3105 )
...
* Centralized error throwing for encryption key
* Unifying the error message used by cli and core packages
* Improvements to error messages to make it more DRY
* Removed unnecessary throw
* Throwing error when credential does not exist to simplify node behavior (#3112 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-04-15 08:00:47 +02:00
Jan Oberhauser
1e34aca8bd
⚡ Fix build issue
2021-10-12 22:20:51 -05:00
Omar Ajoue
7ce7285f7a
⚡ Load credentials from the database ( #1741 )
...
* Changes to types so that credentials can be always loaded from DB
This first commit changes all return types from the execute functions
and calls to get credentials to be async so we can use await.
This is a first step as previously credentials were loaded in memory and
always available. We will now be loading them from the DB which requires
turning the whole call chain async.
* Fix updated files
* Removed unnecessary credential loading to improve performance
* Fix typo
* ⚡ Fix issue
* Updated new nodes to load credentials async
* ⚡ Remove not needed comment
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-08-20 18:57:30 +02:00
Iván Ovejero
b2e0bcea16
🐛 Remove circular references from error objects ( #1802 )
...
* ⚡ Add circular references removal
* 🔥 Remove unused flag from affected node
* 🔥 Remove unused exports
* 🔨 refactor removing circular references
* ⚡ Replace IRawErrorObject with JsonObject
* ⚡ Make error detection depth-first (#1800 )
* 👕 fix type
* 🔨 improve readability
* 📝 improve placeholder for circular reference
* ⚡ Turn marker into object to keep description
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
2021-06-12 17:15:23 +02:00
Iván Ovejero
1d27a9e87e
✨ Improve node error handling ( #1309 )
...
* Add path mapping and response error interfaces
* Add error handling and throwing functionality
* Refactor error handling into a single function
* Re-implement error handling in Hacker News node
* Fix linting details
* Re-implement error handling in Spotify node
* Re-implement error handling in G Suite Admin node
* 🚧 create basic setup NodeError
* 🚧 add httpCodes
* 🚧 add path priolist
* 🚧 handle statusCode in error, adjust interfaces
* 🚧 fixing type issues w/Ivan
* 🚧 add error exploration
* 👔 fix linter issues
* 🔧 improve object check
* 🚧 remove path passing from NodeApiError
* 🚧 add multi error + refactor findProperty method
* 👔 allow any
* 🔧 handle multi error message callback
* ⚡ change return type of callback
* ⚡ add customCallback to MultiError
* 🚧 refactor to use INode
* 🔨 handle arrays, continue search after first null property found
* 🚫 refactor method access
* 🚧 setup NodeErrorView
* ⚡ change timestamp to Date.now
* 📚 Add documentation for methods and constants
* 🚧 change message setting
* 🚚 move NodeErrors to workflow
* ✨ add new ErrorView for Nodes
* 🎨 improve error notification
* 🎨 refactor interfaces
* ⚡ add WorkflowOperationError, refactor error throwing
* 👕 fix linter issues
* 🎨 rename param
* 🐛 fix handling normal errors
* ⚡ add usage of NodeApiError
* 🎨 fix throw new error instead of constructor
* 🎨 remove unnecessary code/comments
* 🎨 adjusted spacing + updated status messages
* 🎨 fix tab indentation
* ✨ Replace current errors with custom errors (#1576 )
* ⚡ Introduce NodeApiError in catch blocks
* ⚡ Introduce NodeOperationError in nodes
* ⚡ Add missing errors and remove incompatible
* ⚡ Fix NodeOperationError in incompatible nodes
* 🔧 Adjust error handling in missed nodes
PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes
* 🔨 Adjust Strava Trigger node error handling
* 🔨 Adjust AWS nodes error handling
* 🔨 Remove duplicate instantiation of NodeApiError
* 🐛 fix strava trigger node error handling
* Add XML parsing to NodeApiError constructor (#1633 )
* 🐛 Remove type annotation from catch variable
* ✨ Add XML parsing to NodeApiError
* ⚡ Simplify error handling in Rekognition node
* ⚡ Pass in XML flag in generic functions
* 🔥 Remove try/catch wrappers at call sites
* 🔨 Refactor setting description from XML
* 🔨 Refactor let to const in resource loaders
* ⚡ Find property in parsed XML
* ⚡ Change let to const
* 🔥 Remove unneeded try/catch block
* 👕 Fix linting issues
* 🐛 Fix errors from merge conflict resolution
* ⚡ Add custom errors to latest contributions
* 👕 Fix linting issues
* ⚡ Refactor MongoDB helpers for custom errors
* 🐛 Correct custom error type
* ⚡ Apply feedback to A nodes
* ⚡ Apply feedback to missed A node
* ⚡ Apply feedback to B-D nodes
* ⚡ Apply feedback to E-F nodes
* ⚡ Apply feedback to G nodes
* ⚡ Apply feedback to H-L nodes
* ⚡ Apply feedback to M nodes
* ⚡ Apply feedback to P nodes
* ⚡ Apply feedback to R nodes
* ⚡ Apply feedback to S nodes
* ⚡ Apply feedback to T nodes
* ⚡ Apply feedback to V-Z nodes
* ⚡ Add HTTP code to iterable node error
* 🔨 Standardize e as error
* 🔨 Standardize err as error
* ⚡ Fix error handling for non-standard nodes
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Jan
1501175b81
✨ Add support for custom AWS endpoints ( #1312 )
...
* Setup custom endpoints properties in AWS credentials type
* Update AWS nodes to use new endpoints (if specified)
* Fix a few error scenarios cases where message was being obscured
* Extend usage of URL API to validate user inputted endpoints
https://nodejs.org/docs/latest-v12.x/api/url.html
* Add support to custom endpoints for SES
Forgot to add this in my earlier commits…
* Fix incorrect Amazon SES endpoint placeholder value
* Fixed signing problems with path being ignored. Standardized to avoid future problems
* Linting fix
* ⚡ Make parameters optinal (wip)
* Make sure that we fallback to correct URL without errors if custom endpoints are not used
Co-authored-by: Luis Ramos <luis@ramos.dev>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2021-01-07 14:16:52 +01:00
Denis Palashevskii
2f9bab571d
Trim whitespaces in AWS credentials
2020-09-02 00:29:56 +04:00
Denis Palashevskii
0cf3b069a9
Revert AWS S3 node to its original state
2020-08-18 17:11:20 +04:00
Denis Palashevskii
77eb0f4955
Create generic S3 node
2020-08-18 16:56:53 +04:00
Denis Palashevskii
a3c5a971e5
Add support for custom endpoint URL scheme (both HTTP and HTTPS)
2020-08-05 15:22:57 +04:00
Denis Palashevskii
4b22df31ad
Add support for custom S3 endpoint in AWS S3 node
2020-08-05 14:40:45 +04:00
ricardo
ed52b67329
⚡ improvements
2020-04-20 19:33:38 -05:00
Jan Oberhauser
fa8c7787a0
⚡ Fix an issue with S3-Node
2020-04-20 20:44:22 +02:00
ricardo
611c79204c
✨ AWS S3 Integration
2020-04-15 18:42:43 -04:00
