Commit graph

4 commits

Author SHA1 Message Date
Michael Kret 91d7e16c81
n8n-3867-progressively-apply-prettier-to-all (#3873)
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
Jonathan Bennetts 5ba4c27d8c
feat(Reddit Node): Add possibility to query saved posts (#3034)
* chore: add nvmrc with required node version

* feat: added saved posts to reddit node with credentials on User resource

* Changed Details order

* Fixed lint issue

* Moved saved posts to profile as it only works for the logged in user, This avoids the breaking change

* Removed .nvmrc

*  Improvements

Co-authored-by: Yassine Fathi <hi@m4tt72.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-03-27 10:57:45 +02:00
Iván Ovejero 1d27a9e87e
Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Iván Ovejero eb2f14d06d
Add Reddit Node (#1345)
* Set up initial scaffolding and auth

* Add grant type to credentials

* Add Account operations and OAuth2 request

* Add post submission functionality

* Refactor resources into resource descriptions

* Refactor request for no auth URL

* Refactor submission description for consistency

* Add listing resource

* Refactor My Account resource into details

* Add request for all items

* Add listings for specific subreddits

* Fix minor linting details

* Add subreddit resource

* Add All-Reddit and Subreddit resource descriptions

* Adjust display options for credentials

* Add subreddit search functionality

* Clean up auth parameter

* Add user resource with GET endpoint

* Add user description

* Add submission search and commenting functionality

* Clean up logging and comments

* Fix minor details

* Fix casing in properties

* Add dividers to execute() method

* Refactor per feedback

* Remove unused description

* Add punctuation to property descriptions

* Fix resources indentation

* Add resource dividers

* Remove deprecated sidebar option

* Make subreddit:get responses consistent

* Remove returnAll and limit from subreddit:get

* Flatten user:get response for about

* Rename comment target property

* Remove best property from post:getAll

* Enrich subreddit search by keyword operation

* Remove unneeded scopes

* Add endpoint documentation

* Add scaffolding for post comment

* Add all operations for postComment resource

* Add all operations for post resource

* Refactor subreddit:getAll

* Fix postComment:getAll

* Flatten responses for profile:get

*  Improvements

* Fix response traversal for postComment:add

* Flatten response for postComment:reply

* Fix subreddit:getAll with keyword search

* Fix pagination to enforce limit

* Wrap unauthenticated API call in try-catch block

* Add 404 error for empty array responses

* Revert "Fix pagination to enforce limit"

This reverts commit 72548d9523.

* Turn user:get (gilded) into listing

*  Small improvement

*  Improve Reddit-Node

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-02-04 09:37:03 +01:00