Iván Ovejero
62c096710f
refactor: Run lintfix (no-changelog) ( #7537 )
...
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Iván Ovejero
75541e91f2
refactor(core)!: Make getBinaryStream async ( #7247 )
...
Story: [PAY-846](https://linear.app/n8n/issue/PAY-846 ) | Related:
https://github.com/n8n-io/n8n/pull/7225
For the S3 backend for external storage of binary data and execution
data, the `getAsStream` method in the binary data manager interface used
by FS and S3 will need to become async. This is a breaking change for
nodes-base.
2023-09-25 16:59:45 +02:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473
refactor(core): Deprecate prepareOutputData (no-changelog) ( #7091 )
2023-09-05 12:59:02 +02:00
Jon
db21a8db75
fix: Fix issue with key based credentials not being read correctly ( #6824 )
2023-08-09 12:30:53 +01:00
Marcus
995d5cc470
fix(FTP Node): List recursive ignore . and .. to prevent infinite loops ( #6707 )
...
ignore . and .. to prevent infinite loop
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-07-21 11:07:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
be089331b3
fix(FTP Node): Use filename instead of remote filepath for downloaded binary data ( #6170 )
2023-05-05 14:32:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
b0cfd69f2b
fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) ( #5753 )
2023-03-23 15:11:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
7a4e9ef5fa
refactor: Remove n8n-core dependency in nodes-base (no-changelog) ( #5649 )
2023-03-09 18:13:15 +01:00
कारतोफ्फेलस्क्रिप्ट™
5eb0d52459
refactor: Unify binary-data assertion across all nodes (no-changelog) ( #5624 )
2023-03-06 17:33:32 +01:00
Michael Kret
bb4db58819
fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog)
2023-02-28 05:39:43 +02:00
Jonathan Bennetts
3af3db160b
fix: fix typo in error messages when a property does not exist ( #4310 )
2023-02-23 08:33:43 +00:00
agobrech
409a9ea357
fix: Add paired item to the most used nodes ( #5220 )
...
* PairedItem for N8n training
* Add paired item to ftp node
* Add paired item to rocketChat
* Add pairedItem to pushOver
* Add paired item to Matrix
* Add pairedItem to theHive
* Add paired item to Snowflake
* Add paired item to PhilipsHue
* Add pairedItem to supabase
* Add paired item to Odoo
* fix odoo & add paired item to grist
* add pairedItem to Linkedin
* add pairedItem Zulip
* add pairedItem PhatomBuster
* add pairedItem to TodoistV2
* Add pairedItem HomeAssistant
* Add pairedItem to DropContact
* Add pairedItem to Aws SES
* Add pairedItem to microsoftOutlook
* Add pairedItem to AwsS3
* Add pairedItem to Aws DynamoDB
* 🐛 fix Dropcontact enrich operation paired item support
* 🐛 fix Dropcontact insert/update operation paired items
* 🐛 fix Supabase paired item support
* 🐛 fix Supabase paired item support
* 🐛 fix N8nTrainingCustomerDatastore paired item support
* 🎨 remove unused imports
* 🐛 fix MicrosoftOutlook paired item support
* 🐛 fix AwsS3 paired item support
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-01-31 20:39:20 +01:00
कारतोफ्फेलस्क्रिप्ट™
448c295314
feat(FTP Node): Stream binary data for uploads and downloads ( #5296 )
2023-01-31 13:23:04 +01:00
Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
6608e69457
refactor(core): Remove linting exceptions in nodes-base (no-changelog) ( #4944 )
2023-01-13 18:11:56 +01:00
कारतोफ्फेलस्क्रिप्ट™
1acc7fea89
refactor(core): Add more overloads for string-type node parameters (no-changelog) ( #5101 )
...
* refactor(core): Add more overloads for string-type node parameter (no-changelog)
continued from https://github.com/n8n-io/n8n/pull/4797
* include binaryPropertyOutput
2023-01-06 15:09:32 +01:00
Michael Kret
61e26804ba
refactor(core): Remove linting exceptions in nodes-base ( #4794 )
...
* ⚡ enabled array-type
* ⚡ await-thenable on
* ⚡ ban-types on
* ⚡ default-param-last on
* ⚡ dot-notation on
* ⚡ member-delimiter-style on
* ⚡ no-duplicate-imports on
* ⚡ no-empty-interface on
* ⚡ no-floating-promises on
* ⚡ no-for-in-array on
* ⚡ no-invalid-void-type on
* ⚡ no-loop-func on
* ⚡ no-shadow on
* ⚡ ban-ts-comment re enabled
* ⚡ @typescript-eslint/lines-between-class-members on
* address my own comment
* @typescript-eslint/return-await on
* @typescript-eslint/promise-function-async on
* @typescript-eslint/no-unnecessary-boolean-literal-compare on
* @typescript-eslint/no-unnecessary-type-assertion on
* prefer-const on
* @typescript-eslint/prefer-optional-chain on
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Iván Ovejero
cfd32d2642
refactor: Phase out TSLint in nodes-base (no-changelog) ( #4798 )
...
* 🔥 Remove TSLint scripts
* 🔥 Remove TSLint config
* 🔥 Remove TSLint exceptions
* 👕 Adjust lint config
* ✏️ Add story numbers
2022-12-02 15:25:21 +01:00
Iván Ovejero
632f573021
refactor(core): Introduce overload for string-type node parameter (no-changelog) ( #4797 )
...
* 📘 Set up overload
* 🔥 Remove inferrable assertions
2022-12-02 12:53:59 +01:00
Iván Ovejero
0d9eeea024
refactor(core): Introduce overload for record-type node parameter (no-changelog) ( #4648 )
...
* 📘 Set up overload
* 🔥 Remove inferrable record assertions
* 👕 Fix semicolon
* 👕 Fix another semicolon
2022-11-18 16:29:44 +01:00
Michael Kret
479644a499
refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ ( #4523 )
...
* ⚡ rule and fixes
* ⚡ clean up
2022-11-08 15:28:21 +01:00
Jonathan Bennetts
5b0ff15e89
refactor: update ftp node codex to add to files category ( #4360 )
2022-10-18 08:39:19 +01:00
Iván Ovejero
9089dbe942
perf(tooling): Upgrade to TypeScript 4.8 ( #4207 )
...
* ⬆️ Upgrade to TypeScript 4.8
* 🔥 Remove unneeded setting
* 📦 Update `package-lock.json`
* ⏪ Restore `skipLibCheck`
* 📦 Re-update `package-lock.json`
* ♻️ Apply feedback
* ♻️ Add check to new WhatsApp node
* 📦 Update `package-lock.json`
* Update package-lock.json
* ran `npm run lintfix`
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-10-05 13:36:09 +02:00
Mike Arvela
6e8e4f5937
fix(nodes-base): fix and harmonize all primaryDocumentation links ( #4191 )
...
* fix(nodes-base): fix and harmonize all primaryDocumentation links
* feat(workflow, cli): expose documentation links to UI via node codex
* fix(editor-ui): link to correct node and credential documentation URLs
* config(nodes-base): update 'format' script to also format node descriptor json
* chore: fix outdated links to node reference documentation
2022-09-29 13:33:16 +03:00
agobrech
d82e87979d
feature: add database and non http credentials test
...
Add credential testing to Postgres, MySQL, MicrosoftSQL, Redis, FTP, SFTP, IMAP, RabbitMQ and MQTT
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2022-09-01 14:29:15 +02:00
Michael Kret
0ecbb4a19d
refactor: Format nodes-base package (A-F) ( #3800 )
...
* 🔨 prettier formated nodes - A
* 🔨 prettier formated nodes - B
* ⚡ prettier formated nodes - C
* ⚡ prettier formated nodes - D
* ⚡ prettier formated nodes - E-F
* 🎨 Adjust nodes-base formatting command (#3805 )
* Format additional files in nodes A-F (#3811 )
* ⚡ fixes
* 🎨 Add Mindee to ignored dirs
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-08-01 22:47:55 +02:00
Iván Ovejero
2a8043cd27
feat: Add item information to more node errors ( #3681 )
...
* ⚡ Add `itemIndex` to node-thrown errors
* ⚡ Add some missing item indexes
2022-07-12 17:51:01 +02:00
Iván Ovejero
6f95121fac
refactor: Add action to all operations on all nodes ( #3655 )
...
* 👕 Add `action` to `INodePropertyOptions`
* 👕 Apply `node-param-operation-option-without-action`
* ✏️ Fix add/remove phrasing
* ✏️ Fix email template phrasing
* ✏️ Fix add/remove phrasing
* ✏️ Fix custom fields phrasing
* ✏️ Fix job report phrasing
* ✏️ Fix query phrasing
* ✏️ Various phrasing fixes
* ✏️ Fix final phrasings
* ✏️ Remove `conversation`
* ✏️ Fix plural
2022-07-10 23:50:51 +03:00
Ricardo Espinoza
42d2959f47
fix: Fix issue with required optional parameters ( #3577 )
2022-06-23 10:44:25 -07:00
Iván Ovejero
88dea330b9
refactor: Apply more eslint-plugin-n8n-nodes-base rules ( #3534 )
...
* ⚡ Update `lintfix` script
* ⚡ Run baseline `lintfix`
* 🔥 Remove unneeded exceptions (#3538 )
* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`
* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`
* ⚡ Update version
* 👕 Apply `node-param-placeholder-missing` (#3542 )
* 👕 Apply `filesystem-wrong-cred-filename` (#3543 )
* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-class-description-empty-string` (#3546 )
* 👕 Apply `node-class-description-icon-not-svg` (#3548 )
* 👕 Apply `filesystem-wrong-node-filename` (#3549 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Expand lintings to credentials (#3550 )
* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552 )
* ⚡ fix
* ⚡ Minor fixes
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541 )
* ⚡ Add new lint rule, node-param-description-wrong-for-dynamic-multi-options
* ⚡ Fix with updated linting rules
* ⚡ Minor fixes
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-boolean-without-whether` (#3553 )
* ⚡ fix
* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537 )
* 👕 Add exceptions
* 👕 Add exception
* ✏️ Alphabetize rules
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-06-20 07:54:01 -07:00
Iván Ovejero
6dcdb30bf4
refactor: Apply more nodelinting rules ( #3324 )
...
* ✏️ Alphabetize lint rules
* 🔥 Remove duplicates
* ⚡ Update `lintfix` script
* 👕 Apply `node-param-operation-without-no-data-expression` (#3329 )
* 👕 Apply `node-param-operation-without-no-data-expression`
* 👕 Add exceptions
* 👕 Apply `node-param-description-weak` (#3328 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-value-duplicate` (#3331 )
* 👕 Apply `node-param-description-miscased-json` (#3337 )
* 👕 Apply `node-param-display-name-excess-inner-whitespace` (#3335 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-type-options-missing-from-limit` (#3336 )
* Rule workig as intended
* ✏️ Uncomment rules
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-duplicate` (#3338 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-simplify` (#3334 )
* ⚡ fix
* ⚡ exceptions
* ⚡ changed rule ignoring from file to line
* 👕 Apply `node-param-resource-without-no-data-expression` (#3339 )
* 👕 Apply `node-param-display-name-untrimmed` (#3341 )
* 👕 Apply `node-param-display-name-miscased-id` (#3340 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-resource-with-plural-option` (#3342 )
* 👕 Apply `node-param-description-wrong-for-upsert` (#3333 )
* ⚡ fix
* ⚡ replaced record with contact in description
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-description-identical-to-name` (#3343 )
* 👕 Apply `node-param-option-name-containing-star` (#3347 )
* 👕 Apply `node-param-display-name-wrong-for-update-fields` (#3348 )
* 👕 Apply `node-param-option-name-wrong-for-get-all` (#3345 )
* ⚡ fix
* ⚡ exceptions
* 👕 Apply node-param-display-name-wrong-for-simplify (#3344 )
* Rule working as intended
* Uncomented other rules
* 👕 Undo and add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Alphabetize lint rules
* ⚡ Restore `lintfix` script
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
2022-05-20 23:47:24 +02:00
Iván Ovejero
63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3243 )
...
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200 )
* Removing unneeded backticks (#3249 )
* 👕 Apply node-param-description-wrong-for-return-all (#3253 )
* 👕 Apply node-param-description-missing-limit (#3252 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258 )
* 👕 Apply `node-param-description-miscased-id` (#3254 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261 )
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-05-06 23:01:25 +02:00
Iván Ovejero
0448feec56
refactor: Apply eslint-plugin-n8n-nodes-base autofixable rules ( #3174 )
...
* ⚡ Initial setup
* 👕 Update `.eslintignore`
* 👕 Autofix node-param-default-missing (#3173 )
* 🔥 Remove duplicate key
* 👕 Add exceptions
* 📦 Update package-lock.json
* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176 )
* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177 )
* 👕 Apply `node-class-description-outputs-wrong` (#3178 )
* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179 )
* 👕 Apply `node-param-default-wrong-for-collection` (#3180 )
* 👕 Apply node-param-default-wrong-for-boolean (#3181 )
* Autofixed default missing
* Autofixed booleans, worked well
* ⚡ Fix params
* ⏪ Undo exempted autofixes
* 📦 Update package-lock.json
* 👕 Apply node-class-description-missing-subtitle (#3182 )
* ⚡ Fix missing comma
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184 )
* 👕 Add exception for `node-class-description-missing-subtitle`
* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185 )
* 👕 Apply `node-param-collection-type-unsorted-items` (#3186 )
* Missing coma
* 👕 Apply `node-param-default-wrong-for-simplify` (#3187 )
* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190 )
* 👕 Apply `node-param-description-empty-string` (#3189 )
* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191 )
* Rule looks good
* Add whitespace rule in eslint config
* :zao: fix
* 👕 Apply `node-param-description-identical-to-display-name` (#3193 )
* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195 )
* ⏪ Revert ":zao: fix"
This reverts commit ef8a76f3df👕 Apply `node-param-description-missing-for-simplify` (#3196 )
* 👕 Apply `node-param-description-missing-final-period` (#3194 )
* Rule working as intended
* Add rule to eslint
* 👕 Apply node-param-description-missing-for-return-all (#3197 )
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-04-22 18:29:51 +02:00
Omar Ajoue
d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials ( #3105 )
...
* Centralized error throwing for encryption key
* Unifying the error message used by cli and core packages
* Improvements to error messages to make it more DRY
* Removed unnecessary throw
* Throwing error when credential does not exist to simplify node behavior (#3112 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-04-15 08:00:47 +02:00
Iván Ovejero
027dfb2f0a
⚡ Enable esModuleInterop compiler option and upgrade to TypeScript 4.6 ( #3106 )
...
* ⚡ Enable `esModuleInterop` for /core
* ⚡ Adjust imports in /core
* ⚡ Enable `esModuleInterop` for /cli
* ⚡ Adjust imports in /cli
* ⚡ Enable `esModuleInterop` for /nodes-base
* ⚡ Adjust imports in /nodes-base
* ⚡ Make imports consistent
* ⬆️ Upgrade TypeScript to 4.6 (#3109 )
* ⬆️ Upgrade TypeScript to 4.6
* 📦 Update package-lock.json
* 🔧 Avoid erroring on untyped errors
* 📘 Fix type error
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-04-08 23:32:08 +02:00
Rhys Williams
39a6f41720
feat(FTP Node): Add option to recursively create directories on rename ( #3001 )
...
* Recursively Make Directories on SFTP Rename
* Linting
* ⚡ Improvement
* ⚡ Rename "Move" to "Create Directories"
* Change "Create Directories" description
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-04-01 14:48:45 +02:00
Ahsan Virani
224ef736de
🐛 Binary data handling fixes ( #2629 )
...
* Update node airtable
* Update nodenextcloud
* Update node spreadsheet
* Update node cortex, dropbox, editImage nodes
* Update node emailSend
* Update node ftp
* Update node googleDrive
* Update node googleDrive fix
* Update node youtube
* Update node htmlExtract
* Update node linkedIn
* Update node mailgun
* Update node matrix
* Update node pipedrive
* Update node readPdf
* Update node facebookGraphApi
* Update node httpRequest
* Update node nocoDB
* Update node httpRequest, respondToWebhook
* Update node signi4
* Update node slack
* Update node zulip
* cleanup
* fix generic funcs
* 🐛 Fix EditImage Node
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-01-03 22:42:42 +01:00
Iván Ovejero
766f74c782
🚚 Directorize and alphabetize nodes ( #2445 )
...
* 🚚 Directorize nodes
* ⚡ Alphabetize nodes and credentials
* 🔥 Remove unused node
* 🔥 Remove unused codex
* 🔥 Remove duplicate cred file references
* 🐛 Fix node file paths
* 🔥 Remove duplicate node reference
2021-11-17 17:30:14 +01:00
