Michael Auerswald
b6d8a0f985
fix(core): Remove circular refs from Code and push msg ( #5741 )
...
* remove circular refs from code items (and lint fixes)
* cleanup
---------
* add some tests
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-21 15:34:30 +01:00
Iván Ovejero
2ca959b383
refactor: Integrate consistent-type-imports
in BE packages (no-changelog) ( #5270 )
2023-01-27 14:56:56 +01:00
Csaba Tuncsik
e4785da2e1
fix(AWS DynamoDB Node): Add missing type assertion (no-changelog) ( #5003 )
...
fix(AWS DynamoDB Node): add type assertion
2022-12-22 10:27:14 +01:00
कारतोफ्फेलस्क्रिप्ट™
3b969d2cd1
fix(Move Binary Data Node): Stringify objects before encoding them in MoveBinaryData ( #4882 )
...
* stringify objects before encoding them objects in MoveBinaryData
* add fileSize and fileType on MoveBinaryData converted data
* show `view` option for text files as well
* improve how JSON binary data is shown in the UI
2022-12-11 14:10:54 +01:00
कारतोफ्फेलस्क्रिप्ट™
b2201d0c77
fix: Disable some error tracking ( #4579 )
...
* fix: remove error tracking for Circular reference in deepCopy
* fix: remove error tracking on crash detection
2022-11-10 21:44:31 +01:00
कारतोफ्फेलस्क्रिप्ट™
2425c10b2b
feat(API): Report unhandled app crashes to Sentry ( #4548 )
...
* SIGTERM/SIGINT should only be handled once
* move error-handling initialization to commands
* create a new `sleep` function in workflow utils
* detect crashes and report them to Sentry
2022-11-08 17:06:00 +01:00
कारतोफ्फेलस्क्रिप्ट™
41cb0eec6e
feat(API): Set up error tracking using Sentry ( #4394 )
...
* feat(cli): Setup error tracking using Sentry
* make error reporting available in the workflows package
* address some of the PR comments
* create a ErrorReporterProxy like LoggerProxy
* remove the `captureError` helper. use ErrorReporterProxy directly
* fix linting issues
* remove ErrorReporterProxy warnings in tests
* check for NODE_ENV === 'production' instead
* IErrorReporter -> ErrorReporter
* ErrorReporterProxy.getInstance() -> ErrorReporter
* allow capturing stacks in warnings as well
* make n8n debugging consistent with `npm start`
* IReportingOptions -> ReportingOptions
* use consistent signature for `error` and `warn`
* use Logger instead of console.log
2022-11-04 17:34:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
b282c7e5d9
fix(core): make deepCopy
backward compatible ( #4505 )
...
* fix(core): make `deepCopy` backward compatible
`JSON.parse(JSON.stringify())` uses `.toJSON` when available. so should `deepCopy`
* fix(core): prevent double quotes on luxon datetimes (#4508 )
* 🐛 Prevent double quotes on luxon datetimes
* ⚡ Generalize solution
* update the types in packages/workflow/src/utils.ts
* add `toJSON` check to NodeErrors.isTraversableObject as well
* move the toJSON check before the cyclic dependency check
* fix(core): keep backward compatibility in deepCopy by calling `toJSON` on objects that have it
* fix(core): updating deepCopy typings
* Revert "fix(core): updating deepCopy typings"
This reverts commit 100a0f1f3d
.
* fix(core): temporarily removing Date cloning from deepCopy
* fix(core): updating deepCopy types
* fix(core): updating deepCopy
* fix(core): updating deepCopy get prototype of object
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2022-11-02 17:44:12 +01:00
कारतोफ्फेलस्क्रिप्ट™
818f57dd63
refactor: remove console.warn from deepCopy
( #4471 )
...
Jan realized that this was logging way too much (as in, we have way too many circular references).
I've changed this to be reported to Sentry, which should hopefully get merged next week.
2022-10-28 16:10:56 +02:00
Csaba Tuncsik
ca60b0e203
fix(core): updating deepCopy to avoid max callstack with circular deps ( #4468 )
...
* fix(core): updating deepCopy to avoid max callstack in case of circular dep
* fix(core): show warning with path added to circular reference
2022-10-28 15:25:44 +02:00
Iván Ovejero
1732324965
fix(core): amend typing for jsonParse()
options ( #4423 )
...
* 📘 Amend typing for `jsonParse()` options
* ✏️ Update rule message and description
* 🔀 Cherrypick Adi's work
* 🐛 Account for falsy fallback values
* ♻️ Use `else if`
* ⚡ Add explicit error message as type
* ⚡ Consolidate utils tests
* ♻️ Use optional chaining
* 🔥 Remove patchy type error
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-10-24 12:48:16 +02:00
Michael Kret
1d57b10942
refactor(core): fix for no-uncaught-json-parse warnings
2022-10-21 21:52:43 +03:00
Csaba Tuncsik
1aa21ed3df
perf: update deepCopy ( #4364 )
...
* perf: update deepCopy
* fix: using deepCopy in core and cli packages
* fix: using deepCopy in editor
* chore: formatting
* fix: some micro optimisation in deepCopy
2022-10-18 13:33:31 +02:00
Iván Ovejero
1db4fa2bf8
feat(Code Node): create Code node ( #3965 )
...
* Introduce node deprecation (#3930 )
✨ Introduce node deprecation
* 🚧 Scaffold out Code node
* 👕 Fix lint
* 📘 Create types file
* 🚚 Rename theme
* 🔥 Remove unneeded prop
* ⚡ Override keybindings
* ⚡ Expand lintings
* ⚡ Create editor content getter
* 🚚 Ensure all helpers use `$`
* ✨ Add autocompletion
* ⚡ Filter out welcome note node
* ⚡ Convey error line number
* ⚡ Highlight error line
* ⚡ Restore logging from node
* ✨ More autocompletions
* ⚡ Streamline completions
* ✏️ Update placeholders
* ⚡ Update linter to new methods
* 🔥 Remove `$nodeItem` completions
* ⚡ Re-update placeholders
* 🎨 Fix formatting
* 📦 Update `package-lock.json`
* ⚡ Refresh with multi-line empty string
* ⚡ Account for syntax errors
* 🔥 Remove unneeded variant
* ⚡ Minor improvements
* ⚡ Add more autocompletions
* 🚚 Rename extension
* 🔥 Remove outdated comments
* 🚚 Rename field
* ✨ More autocompletions
* ⚡ Fix up error display when empty text
* 🔥 Remove logging
* ✨ More error validation
* 🐛 Fix `pairedItem` to `pairedItem()`
* ⚡ Add item to validation info
* 📦 Update `package-lock.json`
* ⚡ Leftover fixes
* ⚡ Set `insertNewlineAndIndent`
* 📦 Update `package-lock.json`
* 📦 Re-update `package-lock.json`
* 👕 Add lint exception
* 📘 Add type to mixin type
* Clean up comment
* ⚡ Refactor completion per new requirements
* ⚡ Adjust placeholders
* ⚡ Add `json` autocompletions for `$input`
* 🎨 Set border
* ⚡ Restore local completion source
* ⚡ Implement autocompletion for imports
* ⚡ Add `.*` to follow user typing on autocompletion
* 📘 Fix typings in autocompletions
* 👕 Add linting for use of `item()`
* 📦 Update `package-lock.json`
* 🐛 Fix for `$items(nodeName)[0]`
* ⚡ Filter down built-in modules list
* ⚡ Refactor error handling
* ⚡ Linter and validation improvements
* ⚡ Apply review feedback
* ♻️ More general refactorings
* ⚡ Add dot notation utility
* Customize input handler
* ⚡ Support `.json.` completions
* ⚡ Adjust placeholder
* ⚡ Sort imports
* 🔥 Remove blank rows addition
* ⚡ Add more error validation
* 📦 Update `package-lock.json`
* ⚡ Make date logging consistent
* 🔧 Adjust linting highlight range
* ⚡ Add line numbers to each item mode errors
* ⚡ Allow for links in error descriptions
* ⚡ More input validation
* ⚡ Expand linting to loops
* ⚡ Deprecate Function and Function Item nodes
* 🐛 Fix placeholder syntax
* 📘 Narrow down type
* 🚚 Rename using kebab-case
* 🔥 Remove `mapGetters`
* ✏️ Fix casing
* ⚡ Adjust import for type
* ✏️ Fix quotes
* 🐛 Fix `activeNode` reference
* ⚡ Use constant
* 🔥 Remove logging
* ✏️ Fix typo
* ⚡ Add missing `notice`
* ✏️ Add tags
* ✏️ Fix alias
* ✏️ Update copy
* 🔥 Remove wrong linting
* ✏️ Update copy
* ⚡ Add validation for `null`
* ⚡ Add validation for non-object and non-array
* ⚡ Add validation for non-array with json
* ✏️ Intentionally use wrong spelling
* ⚡ More validation
* ✏️ More copy updates
* ✏️ Placeholder updates
* ⏪ Restore spelling
* ⚡ Fix var name
* ✏️ More copy updates
* ⚡ Add luxon autocompletions
* ⚡ Make scrollable
* ⚡ Fix comma from merge conflict resolution
* 📦 Update `package-lock.json`
* 👕 Fix lint detail
* 🎨 Set font family
* ⚡ Bring in expressions fix
* ♻️ Address feedback
* ⚡ Exclude codemirror packages from render chunks
* 🐛 Fix placeholder not showing on first load
* feat(editor-ui): Replace `lezer` with `esprima` in client linter (#4192 )
* 🔥 Remove addition from misresolved conflict
* ⚡ Replace `lezer` with `esprima` in client linter
* ⚡ Add missing key
* 📦 Update `package-lock.json`
* ⚡ Match dependencies
* 📦 Update `package-lock.json`
* 📦 Re-update `package-lock.json`
* ⚡ Match whitespace
* 🐛 Fix selection
* ⚡ Expand validation
* 🔥 Remove validation
* ✏️ Update copy
* 🚚 Move to constants
* ⚡ More `null` validation
* ⚡ Support `all()` with index to access item
* ⚡ Gloss over n8n syntax error
* 🎨 Re-style diagnostic button
* 🔥 Remove `item` as `itemAlias`
* ⚡ Add linting for `item.json` in single item mode
* ⚡ Refactor to add label info descriptions
* ⚡ More autocompletions
* 👕 Fix lint
* ⚡ Simplify typings
* feat(nodes-base): Multiline autocompletion for `code-node-editor` (#4220 )
* ⚡ Simplify typings
* ⚡ Consolidate helpers in utils
* ⚡ Multiline autocompletion for standalone vars
* 🔥 Remove unneeded mixins
* ✏️ Update copy
* ✏️ Prep TODOs
* ⚡ Multiline completion for `$input.method` + `$input.item`
* 🔥 Remove unused method
* 🔥 Remove another unused method
* 🚚 Move luxon strings to helpers
* ⚡ Multiline autocompletion for methods output
* ⚡ Refactor to use optional chaining
* 👕 Fix lint
* ✏️ Update TODOs
* ⚡ Multiline autocompletion for `json` fields
* 📘 Add typings
* ⚡ De-duplicate callback to forEach
* 🐛 Fix autocompletions not working with leading whitespace
* 🌐 Apply i18n
* 👕 Fix lint
* :constructor: Second-period var usage completions
* 👕 Fix lint
* 👕 Add exception
* ⚡ Add completion telemetry
* 📘 Add typing
* ⚡ Major refactoring to organize
* 🐛 Fix multiline `.all()[index]`
* 🐛 Do not autoclose square brackets prior to `.json`
* 🐛 Fix accessor for multiline `jsonField` completions
* ⚡ Add completions for half-assignments
* 🐛 Fix `jsonField` completions for `x.json`
* ✏️ Improve comments
* 🐛 Fix `.json[field]` for multiline matches
* ⚡ Cleanup
* 📦 Update `package-lock.json`
* 👕 Fix lint
* 🐛 Rely on original value for custom matcher
* ⚡ Create `customMatcherJsonFieldCompletions` to simplify setup
* 🐛 Include selector in `customMatcherJsonField` completions
* ✏️ Make naming consistent
* ✏️ Add docline
* ⚡ Finish self-review cleanup
* 🔥 Remove outdated comment
* 📌 Pin luxon to major-minor
* ✏️ Fix typo
* 📦 Update `package-lock.json`
* 📦 Update `package-lock.json`
* 📦 Re-update `package-lock.json`
* ➕ Add `luxon` for Gmail node
* 📦 Update `package-lock.json`
* ⚡ Replace Function with Code in suggested nodes
* 🐛 Fix `$prevNode` completions
* ✏️ Update `$execution.mode` copy
* ⚡ Separate luxon getters from methods
* ⚡ Adjusting linter to tolerate `.binary`
* ⚡ Adjust top-level item keys check
* ⚡ Anticipate user expecting `item` to pre-exist
* ⚡ Add linting for legacy item access
* ⚡ Add hint for attempted `items` access
* ⚡ Add keybinding for toggling comments
* ✏️ Update copy of `all`, `first`, `last` and `itemMatching`
* 🐛 Make `input.all()` etc act on copies
* 📦 Update `package-lock.json`
* 🐛 Fix guard in `$input.last()`
* ♻️ Address Jan's feedback
* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`
* 📦 Update `package-lock.json`
* 🔥 Remove unneeded exceptions
* ⚡ Restore placeholder logic
* ⚡ Add placeholders to client
* ⚡ Account for shadow item
* ✏️ More completion info labels
* 👕 Fix lint
* ✏️ Update copy
* ✏️ Update copy
* ✏️ More copy updates
* 📦 Update `package-lock.json`
* ⚡ Add more validation
* ⚡ Add placheolder on first load
* Replace `Cmd` with `Mod`
* 📦 Update `package-lock.json`
2022-10-13 14:28:02 +02:00