Commit graph

64 commits

Author SHA1 Message Date
Chris Wu 1111c915f2
refactor(core): Replace lodash's "soft-deprecated" individual packages with lodash to resolve CVE (no-changelog) (#6450)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-16 16:26:35 +02:00
agobrech 3f5c606254
fix(HTTP Request Node): Correctly doesn't redirect on non GET method (#6132)
Fixed ingnored parameter for redirect
2023-05-04 09:55:35 +02:00
Cornelius Suermann af097ae22c
fix(HTTP Request Node): Add description for 'Specify Body' option (#6114)
* fix(HTTP Request Node): Add description for 'Specify Body' option

* disable linting for node-param-description-miscased-json
2023-04-27 17:33:38 +02:00
Michael Kret 983e6e124e
fix(HTTP Request Node): Always lowercase headers 2023-04-27 13:36:02 +03:00
Jan Oberhauser b351c62659
fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991) 2023-04-18 11:48:38 +02:00
Michael Kret 0b48088296
feat(core): Support for google service account in HTTP node 2023-04-14 13:39:52 +03:00
कारतोफ्फेलस्क्रिप्ट™ e79679c023
fix(HTTP Request Node): Show detailed error message in the UI again (#5959) 2023-04-12 14:58:05 +02:00
agobrech f7e610b15c
feat(HTTP Request Node): Follow redirects by default (#5895)
* Redirect as default behaviour

* Remove console.logs

* Move logic to one single variable

* Revert "Redirect as default behaviour"

This reverts commit 5b2221b800297865224384eb7f417d72b0d2bbc1.

* Redirect as default behaviour inside node structure

* Add default behaviour
2023-04-05 15:37:14 +02:00
कारतोफ्फेलस्क्रिप्ट™ a260c05fa8
fix(core): Improve axios error handling in nodes (#5891) 2023-04-03 18:37:22 +02:00
Michael Kret b29cf9a249
fix(HTTP Request Node): Support for dot notation in JSON body 2023-03-31 19:31:03 +03:00
agobrech 199a91b398
fix(HTTP Request Node): Add streaming to binary response (#5701)
Revert "fix(HTTP Request Node): Remove streaming response  (#5663)"

This reverts commit 8a21fefbc6.
2023-03-21 15:03:47 +01:00
agobrech 8a21fefbc6
fix(HTTP Request Node): Remove streaming response (#5663)
Remove useStream option from requestOptions
2023-03-10 11:54:26 +01:00
कारतोफ्फेलस्क्रिप्ट™ 7a4e9ef5fa
refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649) 2023-03-09 18:13:15 +01:00
agobrech ce0d9d2bed
feat(HTTP Request Node): Move from Binary Buffer to Binary streaming (#5610)
*  Change from binary buffer to binary streaming

* Remove console.logs

* Import Readable from the correct lib

* stream response

* parametersToKeyValue doesn't need to be async anymore

* Fix bodyParameter reduce method

* parametersToKeyValue doesn't need to be async anymore

* handle streaming responses

* send `Content-Length` and `Content-Type` on binary requests

* Add new helper function for binary data

* Add binary function to helpers interface

* Fix bug in error handler

* Fix issue with wrongfully assigned headers to body

* Fix test workflow

* Remove console.logs

* Remove unnecsessary type

* Remove concat dependency already imported in workflow package

* Update pnpm-lock file

* Small fixes, asyncronous error message

* reset the lockfile

* Remove buffer check and simplify error handling

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-09 15:38:54 +01:00
कारतोफ्फेलस्क्रिप्ट™ 5eb0d52459
refactor: Unify binary-data assertion across all nodes (no-changelog) (#5624) 2023-03-06 17:33:32 +01:00
कारतोफ्फेलस्क्रिप्ट™ 3c57062571
refactor: Fix some typos (no-changelog) (#5616) 2023-03-03 18:49:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4e244937c9
refactor: catch doesn't need to have a param (no-changelog) (#5614) 2023-03-03 18:18:49 +01:00
Michael Kret bb4db58819
fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog) 2023-02-28 05:39:43 +02:00
Jonathan Bennetts 3af3db160b
fix: fix typo in error messages when a property does not exist (#4310) 2023-02-23 08:33:43 +00:00
feelgood-interface af703371fc
fix(HTTP Request Node): Ignore empty body for auto detect json (#5215) 2023-02-16 11:00:06 +00:00
Michael Kret 2150ea0e79
test(HTTP Request Node): Unit tests (no-changelog) 2023-02-09 12:25:26 +02:00
Iván Ovejero b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) (#5267)
* 👕 Enable `consistent-type-imports` for nodes-base

* 👕 Apply to nodes-base

*  Undo unrelated changes

* 🚚 Move to `.eslintrc.js` in nodes-base

*  Revert "Enable `consistent-type-imports` for nodes-base"

This reverts commit 529ad72b05.

* 👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret 8f49f494ae
fix(HTTP Request Node): Bug - node requires string instead of json 2023-01-19 11:34:36 +02:00
Michael Kret 8dbe6159d0
fix(HTTP Request Node): Response format to text is ignored for JSON responses 2023-01-18 15:31:39 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1acc7fea89
refactor(core): Add more overloads for string-type node parameters (no-changelog) (#5101)
* refactor(core): Add more overloads for string-type node parameter (no-changelog)

continued from https://github.com/n8n-io/n8n/pull/4797

* include binaryPropertyOutput
2023-01-06 15:09:32 +01:00
Iván Ovejero d9b98fc8be
refactor: Lint for no unneeded backticks (#5057) (no-changelog)
*  Create rule `no-unneeded-backticks`

* 👕 Enable rule

*  Run rule on `cli`

*  Run rule on `core`

*  Run rule on `workflow`

*  Rule rule on `design-system`

*  Run rule on `node-dev`

*  Run rule on `editor-ui`

*  Run rule on `nodes-base`
2022-12-29 12:20:43 +01:00
Jan Oberhauser afc529799d
fix(core): Do not send credentials to browser console (#5031) 2022-12-23 23:25:59 +01:00
Michael Kret 61e26804ba
refactor(core): Remove linting exceptions in nodes-base (#4794)
*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Iván Ovejero cfd32d2642
refactor: Phase out TSLint in nodes-base (no-changelog) (#4798)
* 🔥 Remove TSLint scripts

* 🔥 Remove TSLint config

* 🔥 Remove TSLint exceptions

* 👕 Adjust lint config

* ✏️ Add story numbers
2022-12-02 15:25:21 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2425c10b2b
feat(API): Report unhandled app crashes to Sentry (#4548)
* SIGTERM/SIGINT should only be handled once

* move error-handling initialization to commands

* create a new `sleep` function in workflow utils

* detect crashes and report them to Sentry
2022-11-08 17:06:00 +01:00
Ricardo Espinoza 39d4bb2639
fix(HTTP Request Node): use the data in "Put Output in Field" field (#4487)
🐛 Use the data in "Put Output in Field" field
;
2022-11-04 10:50:38 -04:00
Jan Oberhauser 02fe545967 fix(HTTP Request Node): Fix sending previously selected credentials also on V2 (#4457) 2022-10-27 14:40:14 +02:00
Jan Oberhauser 44ad249827
fix(HTTP Request Node): Fix sending previously selected credentials (#4457) 2022-10-27 13:55:04 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5c9b40117a
refactor: rename NodeVersionedType to VersionedNodeType and move it to the workflow package (#4443) 2022-10-25 21:33:12 +02:00
Michael Kret 1d57b10942
refactor(core): fix for no-uncaught-json-parse warnings 2022-10-21 21:52:43 +03:00
Bram Kn 8f25da52b1
feat(HTTP Request Node): add option for raw json header & query (#4408)
* http node headers and query JSON parameter options added

* Query and Header added to option processing

* remove old set headers.

*  Small improvements

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-10-21 12:29:20 -04:00
Ricardo Espinoza 61b9909ac3
fix(HTTP Request Node): avoid error when response doesn't include content-type (#4365)
* 🐛 Fix bug when response doesn't include content type

*  Improve autodetect response format

*  Make content-type match more specific

*  Improve list of content-types to download
2022-10-20 11:42:55 -04:00
Jonathan Bennetts aa6c786041
fix(HTTP Request Node): fix oauth credentials not working properly for some predefined credentials (#4277) 2022-10-11 08:49:51 +01:00
Ricardo Espinoza f37d6ba03b
feat(HTTP Request Node): Redesign and add the ability to import cURL commands (#3860)
*  Initial commit

* 👕 Fix linting issue

*  Add import button

*  Remove ligh versioning

*  Improvements

*  Improvements

* 🔥 Remove HttpRequest2 file used for testing

* 🐛 Fix building issue

*  Small improvement

* 👕 Fix linting issue

* 🔥 Remove HttpRequest2 from loader

*  Update package-lock.json

*  Improvements

*  Small change

* 🐛 Fix issue retrieving splitIntoItems

* 🐛 Fix issue retrieving neverError parameter

* 🐛 Fix issue with displayOptions

*  Improvements

*  Improvements

*  Improvements

*  Improvements

*  Move cURL section to its own component

*  Improvements

*  Improvements

*  Add fix for  batching in all versions

*  Add notice to cURL modal

* 🔥 Remove comments

*  Improvements

*  Type curl-to-json endpoint

*  Fix typo

* 🔥 Remove console.logs

*  Fix typo in curl-to-json endpoint

*  Improvements

*  Improvements

*  Update package-lock.json

*  Rename import modal constant

*  Add return types to methods

*  Add CSS modules to ImportParameter component

*  Rename ImportParameter component to use kebab-case

*  Improvements

*  update package-lock.json

*  Fix linting issues

* Fix issue with css reference in ImportParameter component

*  Small improvements

*  Rename redirects to redirect

*  Allow to set multiple parameters on valueChanged

* 👕 Fix linting issue

* 🐛 Add mistakenly removed openExistingCredentials

*  Improve curl regex

*  Keep  headers as defined in the cURL command

*  Account for all protocols supported by cURL

*  Add tests

* 🔥 Remove unnecessary lines

*  Add more testing

*  Add noDataExpression to dependent fields

* 🐛 Fix bug not handling multipart-form data correctly

*  Change error messages

* 🐛 Fix response format string for empty values

* Fix typo
2022-09-29 17:28:02 -04:00
Mike Arvela 6e8e4f5937
fix(nodes-base): fix and harmonize all primaryDocumentation links (#4191)
* fix(nodes-base): fix and harmonize all primaryDocumentation links

* feat(workflow, cli): expose documentation links to UI via node codex

* fix(editor-ui): link to correct node and credential documentation URLs

* config(nodes-base): update 'format' script to also format node descriptor json

* chore: fix outdated links to node reference documentation
2022-09-29 13:33:16 +03:00
Ricardo Espinoza 0ab89ad5d6
fix(HTTP Node): fix instance crashing when batching enabled (#3902)
* 🐛 Fix instance crashing when batching enabled

* Add flag parsing for simple mode

* 🐛 Fix issue with simple flag

*  improvements

*  Improvements

* 🔥 Remove console.log

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2022-09-15 16:32:13 -04:00
Aaron Delasy 49c85a1df8
fix: correct all the spelling typos (#3960)
* Improve code health
Fix TS typos in local variables
Fix CSS typos in local styles
Fix typos in comments
Fix typos in strings

* Fix order of n8n setup sections in CONTRIBUTING.md
2022-09-02 16:13:17 +02:00
Ricardo Espinoza 3163742fd7
fix(Raindrop Node): Fix issue refreshing OAuth2 credentials
🐛 Fix issue refreshing access token
2022-09-02 11:48:04 +02:00
Michael Kret 91d7e16c81
n8n-3867-progressively-apply-prettier-to-all (#3873)
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
Michael Kret 945e25a77c
feat(Shopify Node): Add OAuth support (#3389)
*  wip

*  Add includeAccessTokenInHeader option to OAuth2

* 🔨 fixed build error, fixed trigger node when using token auth

* 🔨 fixed trigger when using oauth2

* 🔨 changed default auth method to access token

*  Improvements

*  Improvements

*  Improvements

*  Rename includeAccessTokenInHeader to keyToIncludeInAccessTokenHeader

*  Assign values to only header property

* 🔥 Remove unreachable code

*  Add keyToIncludeInAccessTokenHeader when isN8nRequest

*  Add CC grant type when isN8nRequest

Co-authored-by: Ricardo Espinoza <ricardo@n8n.io>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
2022-07-15 10:36:01 +02:00
Iván Ovejero 2a8043cd27
feat: Add item information to more node errors (#3681)
*  Add `itemIndex` to node-thrown errors

*  Add some missing item indexes
2022-07-12 17:51:01 +02:00
Iván Ovejero acdb4d92c8
fix(HTTP Request Node): Make all OAuth2 credentials work with HTTP Request Node (#3503) 2022-06-25 21:14:08 -07:00
Iván Ovejero 88dea330b9
refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3534)
*  Update `lintfix` script

*  Run baseline `lintfix`

* 🔥 Remove unneeded exceptions (#3538)

* 🔥 Remove exceptions for `node-param-default-wrong-for-simplify`

* 🔥 Remove exceptions for `node-param-placeholder-miscased-id`

*  Update version

* 👕 Apply `node-param-placeholder-missing` (#3542)

* 👕 Apply `filesystem-wrong-cred-filename` (#3543)

* 👕 Apply `node-param-description-missing-from-dynamic-options` (#3545)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-class-description-empty-string` (#3546)

* 👕 Apply `node-class-description-icon-not-svg` (#3548)

* 👕 Apply `filesystem-wrong-node-filename` (#3549)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Expand lintings to credentials (#3550)

* 👕 Apply `node-param-multi-options-type-unsorted-items` (#3552)

*  fix

*  Minor fixes

Co-authored-by: Michael Kret <michael.k@radency.com>

* 👕 Apply `node-param-description-wrong-for-dynamic-multi-options` (#3541)

*  Add new lint rule, node-param-description-wrong-for-dynamic-multi-options

*  Fix with updated linting rules

*  Minor fixes

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply `node-param-description-boolean-without-whether` (#3553)

*  fix

* Update packages/nodes-base/nodes/Clockify/ProjectDescription.ts

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

* 👕 Apply node-param-display-name-wrong-for-dynamic-multi-options (#3537)

* 👕 Add exceptions

* 👕 Add exception

* ✏️ Alphabetize rules

*  Restore `lintfix` command

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-06-20 07:54:01 -07:00
Jan Oberhauser 2ebcf4bb91 👕 Fix lint issue 2022-06-14 06:24:49 -07:00
Michael Kret 7346da0b34
fix(HTTP Request Node): Fix issue with requests that return null (#3498)
*  fix

*   Remove null values at node level

* 🔥 Remove unused imports

*  Small change

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-06-13 13:25:09 -07:00