Iván Ovejero
0448feec56
refactor: Apply eslint-plugin-n8n-nodes-base
autofixable rules ( #3174 )
...
* ⚡ Initial setup
* 👕 Update `.eslintignore`
* 👕 Autofix node-param-default-missing (#3173 )
* 🔥 Remove duplicate key
* 👕 Add exceptions
* 📦 Update package-lock.json
* 👕 Apply `node-class-description-inputs-wrong-trigger-node` (#3176 )
* 👕 Apply `node-class-description-inputs-wrong-regular-node` (#3177 )
* 👕 Apply `node-class-description-outputs-wrong` (#3178 )
* 👕 Apply `node-execute-block-double-assertion-for-items` (#3179 )
* 👕 Apply `node-param-default-wrong-for-collection` (#3180 )
* 👕 Apply node-param-default-wrong-for-boolean (#3181 )
* Autofixed default missing
* Autofixed booleans, worked well
* ⚡ Fix params
* ⏪ Undo exempted autofixes
* 📦 Update package-lock.json
* 👕 Apply node-class-description-missing-subtitle (#3182 )
* ⚡ Fix missing comma
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3184 )
* 👕 Add exception for `node-class-description-missing-subtitle`
* 👕 Apply `node-param-default-wrong-for-multi-options` (#3185 )
* 👕 Apply `node-param-collection-type-unsorted-items` (#3186 )
* Missing coma
* 👕 Apply `node-param-default-wrong-for-simplify` (#3187 )
* 👕 Apply `node-param-description-comma-separated-hyphen` (#3190 )
* 👕 Apply `node-param-description-empty-string` (#3189 )
* 👕 Apply `node-param-description-excess-inner-whitespace` (#3191 )
* Rule looks good
* Add whitespace rule in eslint config
* :zao: fix
* 👕 Apply `node-param-description-identical-to-display-name` (#3193 )
* 👕 Apply `node-param-description-missing-for-ignore-ssl-issues` (#3195 )
* ⏪ Revert ":zao: fix"
This reverts commit ef8a76f3df
.
* 👕 Apply `node-param-description-missing-for-simplify` (#3196 )
* 👕 Apply `node-param-description-missing-final-period` (#3194 )
* Rule working as intended
* Add rule to eslint
* 👕 Apply node-param-description-missing-for-return-all (#3197 )
* ⚡ Restore `lintfix` command
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2022-04-22 18:29:51 +02:00
Omar Ajoue
d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials ( #3105 )
...
* Centralized error throwing for encryption key
* Unifying the error message used by cli and core packages
* Improvements to error messages to make it more DRY
* Removed unnecessary throw
* Throwing error when credential does not exist to simplify node behavior (#3112 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-04-15 08:00:47 +02:00
Iván Ovejero
2b74b6238e
⚡ Deprecate step size and node color ( #2586 )
...
* 🔥 Deprecate numberStepSize
* 🔥 Deprecate color in non-FA nodes
* ⚡ Minor node name fixes
* 📦 Update package-lock.json
* ⏪ Restore Merge node color
* 👕 Fix lint
2021-12-23 13:30:35 +01:00
Iván Ovejero
a783288338
⚡ Enforce type checking in all node params ( #2509 )
2021-12-03 09:44:16 +01:00
Iván Ovejero
0764c49dcf
🔥 Remove line breaks from param descriptions ( #2473 )
...
* 🔥 Remove line breaks from param descriptions
* 🔥 Remove more line breaks
* 🎨 Fix spacing for list item in tooltip
* ⚡ Apply multiline with <p> tags
* ⚡ Improve <code> and <a> tags
* ✏️ Improve grammar and spelling
* ⚡ Add missing <p> tags
* ✏️ Make "multiple" phrasing consistent
* ⚡ Fix unneeded quote escapes
* ⚡ Encode angle brackets
* ⚡ Fix typo and copy-paste artifact
2021-11-25 18:10:06 +01:00
Omar Ajoue
7ce7285f7a
⚡ Load credentials from the database ( #1741 )
...
* Changes to types so that credentials can be always loaded from DB
This first commit changes all return types from the execute functions
and calls to get credentials to be async so we can use await.
This is a first step as previously credentials were loaded in memory and
always available. We will now be loading them from the DB which requires
turning the whole call chain async.
* Fix updated files
* Removed unnecessary credential loading to improve performance
* Fix typo
* ⚡ Fix issue
* Updated new nodes to load credentials async
* ⚡ Remove not needed comment
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-08-20 18:57:30 +02:00
Iván Ovejero
1d27a9e87e
✨ Improve node error handling ( #1309 )
...
* Add path mapping and response error interfaces
* Add error handling and throwing functionality
* Refactor error handling into a single function
* Re-implement error handling in Hacker News node
* Fix linting details
* Re-implement error handling in Spotify node
* Re-implement error handling in G Suite Admin node
* 🚧 create basic setup NodeError
* 🚧 add httpCodes
* 🚧 add path priolist
* 🚧 handle statusCode in error, adjust interfaces
* 🚧 fixing type issues w/Ivan
* 🚧 add error exploration
* 👔 fix linter issues
* 🔧 improve object check
* 🚧 remove path passing from NodeApiError
* 🚧 add multi error + refactor findProperty method
* 👔 allow any
* 🔧 handle multi error message callback
* ⚡ change return type of callback
* ⚡ add customCallback to MultiError
* 🚧 refactor to use INode
* 🔨 handle arrays, continue search after first null property found
* 🚫 refactor method access
* 🚧 setup NodeErrorView
* ⚡ change timestamp to Date.now
* 📚 Add documentation for methods and constants
* 🚧 change message setting
* 🚚 move NodeErrors to workflow
* ✨ add new ErrorView for Nodes
* 🎨 improve error notification
* 🎨 refactor interfaces
* ⚡ add WorkflowOperationError, refactor error throwing
* 👕 fix linter issues
* 🎨 rename param
* 🐛 fix handling normal errors
* ⚡ add usage of NodeApiError
* 🎨 fix throw new error instead of constructor
* 🎨 remove unnecessary code/comments
* 🎨 adjusted spacing + updated status messages
* 🎨 fix tab indentation
* ✨ Replace current errors with custom errors (#1576 )
* ⚡ Introduce NodeApiError in catch blocks
* ⚡ Introduce NodeOperationError in nodes
* ⚡ Add missing errors and remove incompatible
* ⚡ Fix NodeOperationError in incompatible nodes
* 🔧 Adjust error handling in missed nodes
PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes
* 🔨 Adjust Strava Trigger node error handling
* 🔨 Adjust AWS nodes error handling
* 🔨 Remove duplicate instantiation of NodeApiError
* 🐛 fix strava trigger node error handling
* Add XML parsing to NodeApiError constructor (#1633 )
* 🐛 Remove type annotation from catch variable
* ✨ Add XML parsing to NodeApiError
* ⚡ Simplify error handling in Rekognition node
* ⚡ Pass in XML flag in generic functions
* 🔥 Remove try/catch wrappers at call sites
* 🔨 Refactor setting description from XML
* 🔨 Refactor let to const in resource loaders
* ⚡ Find property in parsed XML
* ⚡ Change let to const
* 🔥 Remove unneeded try/catch block
* 👕 Fix linting issues
* 🐛 Fix errors from merge conflict resolution
* ⚡ Add custom errors to latest contributions
* 👕 Fix linting issues
* ⚡ Refactor MongoDB helpers for custom errors
* 🐛 Correct custom error type
* ⚡ Apply feedback to A nodes
* ⚡ Apply feedback to missed A node
* ⚡ Apply feedback to B-D nodes
* ⚡ Apply feedback to E-F nodes
* ⚡ Apply feedback to G nodes
* ⚡ Apply feedback to H-L nodes
* ⚡ Apply feedback to M nodes
* ⚡ Apply feedback to P nodes
* ⚡ Apply feedback to R nodes
* ⚡ Apply feedback to S nodes
* ⚡ Apply feedback to T nodes
* ⚡ Apply feedback to V-Z nodes
* ⚡ Add HTTP code to iterable node error
* 🔨 Standardize e as error
* 🔨 Standardize err as error
* ⚡ Fix error handling for non-standard nodes
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Harshil Agrawal
a503c0e86b
⚡ Add new codex files and fix previous files ( #1608 )
...
* ✨ Add new codex files and fixed previous files
* 🔨 Minor fix
* 🔨 Minor fix
2021-04-10 10:18:10 +02:00
Harshil Agrawal
f258f3ca33
✨ Add Node Codex ( #1335 )
...
* ✨ Add Node Codex 📇
* ⚡ Add codex files for new nodes
* ⚡ Change category for Affinity
* 🔨 Fix credential documentation link
* ⚡ Improve styling
* ⚡ Add blogposts
Co-authored-by: Amudhan <sm.amudhan@live.com>
2021-01-14 13:56:07 +01:00
Jan Oberhauser
40c2acd77b
👕 Fix lint issue
2020-10-22 15:46:03 +02:00
Jan Oberhauser
12b93a5b52
⚡ Small improvements to Bannerbear-Node
2020-05-07 00:44:39 +02:00
ricardo
b95a7e8ee8
⚡ improvements
2020-05-05 19:36:12 -04:00
Jan Oberhauser
f60c802b19
⚡ Small fixes like image optimization
2020-04-26 23:12:51 +02:00
ricardo
413edbefda
✨ Bannerbear Node
2020-04-26 14:56:50 -05:00