Commit graph

837 commits

Author SHA1 Message Date
Jan Oberhauser ff839514a6 ⬆️ Set n8n-workflow@0.90.0 on n8n-editor-ui 2022-03-13 11:18:33 +00:00
Michael Kret e8500e6937
feat: Add new expression variables and support for luxon
* 🔨 scaffolding for  and

* 🔨 added autocomplete

* 🔨 N8N-2961-New-expression-variables

* 🔨 added luxon DateTime to expressions and Functions node, replased  with , clean up

* 🔨 added  and , fixed  return values

* 🔨 added tests for new variables

* 🔨 removed unnecessary import

* 🔨 return type fix

* 🔨 working on review, wip

* 🔨 working on review, improved errors, wip

* 🔨 fixed disappearing error message box

* 🔨 excluded variables from function node, added jmespath setup

* :hamer: added $jmsepath to function nodes

* 🔨 replacing proxy with data when using jmespath

* 🔨 renamed function

* 🔨 updated tips to function nodes

* 🔨 fixes for errors messages

* 🔨 review fixes

* 🔨 removed $input and $() from autocomplete

*  removed comments

*  Remove unused code

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-03-13 10:34:44 +01:00
Oliver Trajceski 6065f6879c
refactor(editor): Replace 'Workflows' help menu item with 'Course'
* N8N-3110 Replace Workflows help menu item with course

* N8N-3110 Re-order props in en.json

* N8N-3110 Update URL Link for courses
2022-03-12 11:03:38 +01:00
Jan Oberhauser 9bb0ea17b7 🔖 Release n8n-editor-ui@0.133.0 2022-03-07 09:49:55 +00:00
Jan Oberhauser cd87469fcb ⬆️ Set n8n-design-system@0.13.0 and n8n-workflow@0.89.0 on n8n-editor-ui 2022-03-07 09:49:55 +00:00
Jan Oberhauser f04e6ac43e 🐛 Fix some i18n line break issues 2022-03-05 20:11:34 +01:00
Oliver Trajceski f4e3255b24
🐛 Fix issue that ctrl + o did behave wrong on workflow templates page (#2934)
* N8N-3094 Workflow Templates cmd-o acts on the Preview/Iframe

* N8N-3094 Workflow Templates cmd-o acts on the Preview/Iframe

* disable shortcuts for preview

Co-authored-by: Mutasem <mutdmour@gmail.com>
2022-03-04 18:04:04 +01:00
Iván Ovejero 2ec711aeb5
Allow to disable hiring banner (#2902)
*  Add flag

*  Adjust interfaces

*  Adjust store module

*  Adjust frontend settings

*  Adjust frontend display
2022-03-04 17:53:01 +01:00
Mutasem Aldmour 3bc06ee5c0
🐛 Fix credentials list load issue (#2931)
* always fetch credentials

* only fetch credentials once
2022-03-04 17:39:52 +01:00
Mutasem Aldmour c3f3e98718
🐛 Fix issue with tooltips getting displayed behind node details view
* fix tooltips z-index

* move all element ui components

* update package lock
2022-03-04 17:34:24 +01:00
Oliver Trajceski 3513aa128a
🐛 Fix that some keyboard shortcuts did no longer work
* N8N-3057 Fixed Keyboard shortcuts no longer working on / Fixed callDebounced function

* N8N-3057 Update Debounce Function

* N8N-3057 Refactor callDebounce function

* N8N-3057 Update Dobounce Function
2022-03-04 17:28:03 +01:00
Jan Oberhauser 3529196be1 🔖 Release n8n-editor-ui@0.132.1 2022-03-01 11:43:44 +01:00
Oliver Trajceski e94e353770
🐛 Fix n8n Select Component (#2903)
* N8N-3028 Dropdown Invisible - Fixed N8N-Select Component

* N8N-3028 Remove :popper-append-to-body props from n8n-select in ParameterInput component
2022-03-01 11:18:32 +01:00
Jan Oberhauser 8fc5283020 🔖 Release n8n-editor-ui@0.132.0 2022-02-28 10:06:05 +00:00
Jan Oberhauser 9e0ab52efd ⬆️ Set n8n-design-system@0.12.0 and n8n-workflow@0.88.0 on n8n-editor-ui 2022-02-28 10:06:05 +00:00
Oliver Trajceski cfa91cda27
Add Templates (#2720)
* Templates Bugs / Fixed Various Bugs / Multiply Api Request, Carousel Gradient, Core Nodes Filters ...

* Updated MainSidebar Paddings

* N8N-Templates Bugfixing - Remove Unnecesairy Icon (Shape), Refatctor infiniteScrollEnabled Prop + updated infiniterScroll functinality

* N8N-2853 Fixed Carousel Arrows Bug after Cleaning the SearchBar

* fix telemetry init

* fix search tracking issues

* N8N-2853 Created FilterTemplateNode Constant Array, Filter PlayButton and WebhookRespond from Nodes, Added Box for showing more nodes inside TemplateList, Updated NewWorkflowButton to primary, Fixed Markdown issue with Code

* N8N-2853 Removed Placeholder if Workflows Or Collections are not found, Updated the Logic

* fix telemetry events

* clean up session id

* update user inserted event

* N8N-2853 Fixed Categories to Moving if the names are long

* Add todos

* Update Routes on loading

* fix spacing

* Update Border Color

* Update Border Readius

* fix filter fn

* fix constant, console error

* N8N-2853 PR Fixes, Refactoring, Removing unnecesairy code ..

* N8N-2853 PR Fixes - Editor-ui Fixes, Refactoring, Removing Dead Code ...

* N8N-2853 Refactor Card to LongCard

* clean up spacing, replace css var

* clean up spacing

* set categories as optional in node

* replace vars

* refactor store

* remove unnesssary import

* fix error

* fix templates view to start

* add to cache

* fix coll view data

* fix categories

* fix category event

* fix collections carousel

* fix initial load and search

* fix infinite load

* fix query param

* fix scrolling issues

* fix scroll to top

* fix search

* fix collections search

* fix navigation bug

* rename view

* update package lock

* rename workflow view

* rename coll view

* update routes

* add wrapper component

* set session id

* fix search tracking

* fix session tracking

* remove deleted mutation

* remove check for unsupported nodes

* refactor filters

* lazy load template

* clean up types

* refactor infinte scroll

* fix end of search

* Fix spacing

* fix coll loading

* fix types

* fix coll view list

* fix navigation

* rename types

* rename state

* fix search responsiveness

* fix coll view spacing

* fix search view spacing

* clean up views

* set background color

* center page not vert

* fix workflow view

* remove import

* fix background color

* fix background

* clean props

* clean up imports

* refactor button

* update background color

* fix spacing issue

* rename event

* update telemetry event

* update endpoints, add loading view, check for endpoint health

* remove conolse log

* N8N-2853 Fixed Menu Items Padding

* replace endpoints

* fix type issues

* fix categories

* N8N-2853 Fixed ParameterInput Placeholder after ElementUI Upgrade

* update createdAt

*  Fix placeholder in creds config modal

* ✏️ Adjust docstring to `credText` placeholder version

* N8N-2853 Optimized

* N8N-2853 Optimized code

*  Add deployment type to FE settings

*  Add deployment type to interfaces

* N8N-2853 Removed Animated prop from components

*  Add deployment type to store module

*  Create hiring banner

*  Display hiring banner

*  Undo unrelated change

* N8N-2853 Refactor TemplateFilters

*  Fix indentation

* N8N-2853 Reorder items / TemplateList

* 👕 Fix lint

* N8N-2853 Refactor TemplateFilters Component

* N8N-2853 Reorder TemplateList

* refactor template card

* update timeout

* fix removelistener

* fix spacing

* split enabled from offline

* add spacing to go back

* N8N-2853 Fixed Screens for Tablet & Mobile

* N8N-2853 Update Stores Order

* remove image componet

* remove placeholder changes

* N8N-2853 Fixed Chinnese Placeholders for El Select Component that comes from the Library Upgrade

* N8N-2853 Fixed Vue Agile Console Warnings

* N8N-2853 Update Collection Route

* ✏️ Update jobs URL

* 🚚 Move logging to root component

*  Refactor `deploymentType` to `isInternalUser`

*  Improve syntax

* fix cut bug in readonly view

* N8N-3012 Fixed Details section in templates with lots of description, Fixed Mardown Block with overflox-x

* N8N-3012 Increased Font-size, Spacing and Line-height of the Categories Items

* N8N-3012 Fixed Vue-agile client width error on resize

* only delay redirect for root path

* N8N-3012 Fixed Carousel Arrows that Disappear

* N8N-3012 Make Loading Screen same color as Templates

* N8N-3012 Markdown renders inline block as block code

* add offline warning

* hide log from workflow iframe

* update text

* make search button larger

* N8N-3012 Categories / Tags extended all the way in details section

* load data in cred modals

* remove deleted message

* add external hook

* remove import

* update env variable description

* fix markdown width issue

* disable telemetry for demo, add session id to template pages

* fix telemetery bugs

* N8N-3012 Not found Collections/Wokrkflow

* N8N-3012 Checkboxes change order when categories are changed

* N8N-3012 Refactor SortedCategories inside TemplateFilters component

* fix firefox bug

* add telemetry requirements

* add error check

* N8N-3012 Update GoBackButton to check if Route History is present

* N8N-3012 Fixed WF Nodes Icons

* hide workflow screenshots

* remove unnessary mixins

* rename prop

* fix design a bit

* rename data

* clear workspace on destroy

* fix copy paste bug

* fix disabled state

* N8N-3012 Fixed Saving/Leave without saving Modal

* fix telemetry issue

* fix telemetry issues, error bug

* fix error notification

* disable workflow menu items on templates

* fix i18n elementui issue

* Remove Emit - NodeType from HoverableNodeIcon component

* TechnicalFixes: NavigateTo passed down as function should be helper

* TechnicalFixes: Update NavigateTo function

* TechnicalFixes: Add FilterCoreNodes directly as function

* check for empty connecitions

* fix titles

* respect new lines

* increase categories to be sliced

* rename prop

* onUseWorkflow

* refactor click event

* fix bug, refactor

* fix loading story

* add default

* fix styles at right level of abstraction

* add wrapper with width

* remove loading blocks component

* add story

* rename prop

* fix spacing

* refactor tag, add story

* move margin to container

* fix tag redirect, remove unnessary check

* make version optional

* rename view

* move from workflows to templates store

* remove unnessary change

* remove unnessary css

* rename component

* refactor collection card

* add boolean to prevent shrink

* clean up carousel

* fix redirection bug on save

* remove listeners to fix multiple listeners bug

* remove unnessary types

* clean up boolean set

* fix node select bug

* rename component

* remove unnessary class

* fix redirection bug

* remove unnessary error

* fix typo

* fix blockquotes, pre

* refactor markdown rendering

* remove console log

* escape markdown

* fix safari bug

* load active workflows to fix modal bug

* ⬆️ Update package-lock.json file

*  Add n8n version as header

Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-02-28 10:57:44 +01:00
Iván Ovejero db2af7effb
🐛 Fix placeholder display in creds config modal (#2857)
*  Fix placeholder in creds config modal

* ✏️ Adjust docstring to `credText` placeholder version
2022-02-24 17:20:24 +01:00
Michael Kret d85934a855
🐛 Fix issue with running n8n under subfolder (#2816) 2022-02-24 17:17:24 +01:00
Ahsan Virani 8fc1095d1e
🐛 Swallow telemetry error and only log in warn and debug mode (#2858)
* catch nodegraph errors

* use loglevel config for telemetry

* Use getByNameAndVersion instead of getByName

* remove any usage of nodeTypes.getByName method

* deprecate getByName method
2022-02-24 17:15:30 +01:00
Jan Oberhauser 0232a80b8f Improve copy 2022-02-21 13:40:31 +01:00
Jan Oberhauser e68d1b8517 🔖 Release n8n-editor-ui@0.131.0 2022-02-20 09:42:06 +00:00
Jan Oberhauser 6f9095eba0 ⬆️ Set n8n-workflow@0.87.0 on n8n-editor-ui 2022-02-20 09:42:05 +00:00
sirdavidoff 68c356c17c
Copy tweaks (#2780)
* Update en.json

* More copy tweaks and addressed PR comments

* 🔥 Remove empty strings from base text

*  Adjust `$showMessage` signature type

* 🔥 Remove message from Vue components

* ✏️ Fix typo

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-02-18 16:26:44 +01:00
Jan Oberhauser 4193999b83 🔖 Release n8n-editor-ui@0.130.0 2022-02-13 09:55:38 +00:00
Manuel 78babf9b9a
Fix that fixedCollection leaves empty arrays (#2792)
When deleting the single option inside of an option type,
an empty array was left behind and will be:
- shown as empty heading in UI
- leave an empty array in JSON
2022-02-12 12:02:20 +01:00
Jan Oberhauser 7fc430c70a 🐛 Deactivate unwanted list autofill #2798 2022-02-12 11:25:39 +01:00
Jan Oberhauser 11336fdbae Sort nodes in expression editor relative to current node position 2022-02-12 10:32:39 +01:00
Jan Oberhauser 3e92fae954 🐛 Fix monaco editor resize as suggested in #2800 2022-02-12 08:43:32 +01:00
Anuj Kapoor 1b69148d9a
Add /workflows/demo route (#2745)
*  added /workflows/demo route

*  suggested improvements

*  added n8n version in postmessage

*  updated zoom menu styling

*  updated component padding for zoomToFit

*  suggested improvements

*  moved getFixedNodeList to canvasHelpers

* 📝 removed unused import and rebased from master
2022-02-11 09:18:39 +01:00
Mutasem Aldmour b4e3f27c9f
Fix icon types (#2784) 2022-02-08 13:33:59 +01:00
Jan Oberhauser 3fd4a40500 🔖 Release n8n-editor-ui@0.129.0 2022-02-06 11:01:03 +00:00
Jan Oberhauser c1846d89e4 ⬆️ Set n8n-design-system@0.11.0 and n8n-workflow@0.86.0 on n8n-editor-ui 2022-02-06 11:01:02 +00:00
Jan Oberhauser 0da398b0e4
Nodes as JSON and authentication redesign (#2401)
*  change FE to handle new object type

* 🚸 improve UX of handling invalid credentials

* 🚧 WIP

* 🎨 fix typescript issues

* 🐘 add migrations for all supported dbs

* ✏️ add description to migrations

*  add credential update on import

*  resolve after merge issues

* 👕 fix lint issues

*  check credentials on workflow create/update

* update interface

* 👕 fix ts issues

*  adaption to new credentials UI

* 🐛 intialize cache on BE for credentials check

* 🐛 fix undefined oldCredentials

* 🐛 fix deleting credential

* 🐛 fix check for undefined keys

* 🐛 fix disabling edit in execution

* 🎨 just show credential name on execution view

* ✏️  remove TODO

*  implement review suggestions

*  add cache to getCredentialsByType

*  use getter instead of cache

* ✏️ fix variable name typo

* 🐘 include waiting nodes to migrations

* 🐛 fix reverting migrations command

*  update typeorm command

*  create db:revert command

* 👕 fix lint error

*  Add optional authenticate method to credentials

*  Simplify code and add authentication support to MattermostApi

* 👕 Fix lint issue

*  Add support to own-mode

* 👕 Fix lint issue

*  Add support for predefined auth types bearer and headerAuth

*  Make sure that DateTime Node always returns strings

*  Add support for moment types to If Node

*  Make it possible for HTTP Request Node to use all credential types

*  Add basicAuth support

* Add a new dropcontact node

*  First basic implementation of mainly JSON based nodes

*  Add fixedCollection support, added value parameter and
expression support for value and property

* Improvements to #2389

*  Add credentials verification

*  Small improvement

*  set default time to 45 seconds

*  Add support for preSend and postReceive methods

*  Add lodash merge and set depedency to workflow

* 👕 Fix lint issue

*  Improvements

*  Improvements

*  Improvements

*  Improvements

*  Improvements

* 🐛 Set siren and language correctly

*  Add support for requestDefaults

*  Add support for baseURL to httpRequest

*  Move baseURL to correct location

*  Add support for options loading

* 🐛 Fix error with fullAccess nodes

*  Add credential test functionality

* 🐛 Fix issue with OAuth autentication and lint issue

*  Fix build issue

* 🐛 Fix issue that url got always overwritten to empty

*  Add pagination support

*  Code fix required after merge

*  Remove not needed imports

*  Fix credential test

*  Add expression support for request properties and $self
support on properties

*  Rename $self to $value

* 👕 Fix lint issue

*  Add example how to send data in path

*  Make it possible to not sent in dot notation

*  Add support for postReceive:rootProperty

*  Fix typo

*  Add support for postReceive:set

*  Some fixes

*  Small improvement

* ;zap: Separate RoutingNode code

*  Simplify code and fix bug

*  Remove unused code

*  Make it possible to define "request" and "requestProperty" on
options

* 👕 Fix lint issue

*  Change $credentials variables name

*  Enable expressions and access to credentials in requestDefaults

*  Make parameter option loading use RoutingNode.makeRoutingRequest

*  Allow requestOperations overwrite on LoadOptions

*  Make it possible to access current node parameters in loadOptions

*  Rename parameters variable to make future proof

*  Make it possible to use offset-pagination with body

*  Add support for queryAuth

*  Never return more items than requested

*  Make it possible to overwrite requestOperations on parameter
and option level

* 👕 Fix lint issue

*  Allow simplified auth also with regular nodes

*  Add support for receiving binary data

* 🐛 Fix example node

*  Rename property "name" to "displayName" in loadOptions

*  Send data by default as "query" if nothing is set

*  Rename $self to $parent

*  Change to work with INodeExecutionData instead of IDataObject

*  Improve binaryData handling

*  Property design improvements

*  Fix property name

* 🚨 Add some tests

*  Add also test for request

*  Improve test and fix issues

*  Improvements to loadOptions

*  Normalize loadOptions with rest of code

*  Add info text

*  Add support for $value in postReceive

* 🚨 Add tests for RoutingNode.runNode

*  Remove TODOs and make url property optional

*  Fix bug and lint issue

* 🐛 Fix bug that not the correct property got used

* 🚨 Add tests for CredentialsHelper.authenticate

*  Improve code and resolve expressions also everywhere for
loadOptions and credential test requests

*  Make it possible to define multiple preSend and postReceive
actions

*  Allow to define tests on credentials

*  Remove test data

* ⬆️ Update package-lock.json file

*  Remove old not longer used code

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: PaulineDropcontact <pauline@dropcontact.io>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-02-05 22:55:43 +01:00
Jan Oberhauser f23098e38b 🐛 Fix frontend issue with remote option load 2022-02-05 16:59:44 +01:00
Jan Oberhauser 9dbe2449fb Fix editor issue with unknown nodeTypes 2022-02-05 16:52:13 +01:00
Jan Oberhauser ff74feefe4 Fix node-versioning issues in editor-UI 2022-02-05 12:57:48 +01:00
Iván Ovejero fc550ecbcb
Remove fibers to support Node LTS 16 (#2672)
* 🔥 Remove fibers lib

* 📦 Update package-lock.json

* 📦 Update package-lock.json

* ✏️ Mention recommended version

*  Update node version in Docker images

* ⬆️ bump uuid and flatted

* 📦 Update package-lock.json

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-02-04 19:13:26 +01:00
Michael Kret 92d3c1949e
🔨 Changed NDV opening behavior on node duplication N8N-2896 (#2749)
* 🔨 changed NDV opening behavior on node duplication

* 🔨 deleted commented lines

*  on duplication node will be selected
2022-02-03 23:25:36 +01:00
Mutasem Aldmour 7bdb7e2a25
Support telemetry page (#2756)
* support telemetry page events

* add log level to FE settings

* add debug logging

* fix types

* state fix

* move call
2022-02-03 23:24:01 +01:00
Jan Oberhauser 26de462f25 🔖 Release n8n-editor-ui@0.128.0 2022-01-30 14:08:33 +00:00
Jan Oberhauser 4251b6468b ⬆️ Set n8n-design-system@0.10.0 and n8n-workflow@0.85.0 on n8n-editor-ui 2022-01-30 14:08:33 +00:00
Michael Kret aa3cbe5358
Add default polling interval (Poll trigger nodes) N8N-2874 (#2730)
*  added default polling interval to Poll trigger nodes

*  added default value to polling triger
2022-01-30 14:56:39 +01:00
Michael Kret 6d6f3acd97
Add parameter hints for node parameters N8N-2841 (#2704)
* 🔨 base functionality done

* :fix: changes accordingly to review

* :fix: replaced div with n8n-text

* :fix: return wrong deleted color variable

* add mock examples for testing

* add slack node test param

* 🔨 changed font size of hint, added top margin

* 🔨 updated comments and function name

* 🔨 updated parameterHint to hint

* 🔨 updated text color, set compact to true, changed inputLabelHint to hint

* 🔨 updated components styles

* 🔨 replaced mini with xsmall

* :fix: fixed line height

* :fix: changed line height to 1.25

* :hummer: removed mock data

* 🔨 changed xsmall line-height

*  update to merge hint

Co-authored-by: Mutasem <mutdmour@gmail.com>
2022-01-28 07:55:25 +01:00
fabian wohlgemuth ebd4aa4c31
Improve wording in "Save your Changes" modal (#2718) 2022-01-27 21:18:45 +01:00
Jan Oberhauser 6a77969cff 🐛 Fix issue that default values did not get send for credential
testing
2022-01-24 17:37:07 +01:00
Jan Oberhauser 2d7e00e85c 🔖 Release n8n-editor-ui@0.127.0 2022-01-22 17:57:27 +00:00
Jan Oberhauser 90bb5fa7bc ⬆️ Set n8n-workflow@0.84.0 on n8n-editor-ui 2022-01-22 17:57:27 +00:00
fabian wohlgemuth 88809936ee
🐛 Fix string for "Filter by tags"
* Creating locale string for openWorkflow.filterWorkflows & use it in the Open Workflow modal

* Fix: Use filterWorkflows label in placeholder location
2022-01-22 18:18:19 +01:00
Jan Oberhauser b23a87c7f4 🐛 Fix issue that binary data did not get displayed full height&width 2022-01-22 11:02:27 +01:00
Mutasem Aldmour 49bf786e5b
Improve workflow activation (#2692)
* feat: activator disabled based on thiggers

* feat: tooltip over inactive switch

* feat: message for trigger types

* feat: deactivate on save if trigger is removed

* chore: refactor executions modal

* feat: calculate service name if possible

* feat: alert on activation

* chore: fix linting

* feat: always enable activator when active

* fix: adjust the alert

* feat: take disabled state into account

* feat: automatically save on activation

* feat: rely on nodes name and edit messages

* feat: isolate state for each activator instance

* feat: create activation modal component

* feat: activationModal checkbox and trigger message

* feat: add activation messages to node config

* chore: style activation modal

* chore: style fixes

* feat: refactor disabled state

* chore: refactor modal

* chore: refactor modal

* chore: tidy the node config

* chore: refactor and styling tweaks

* chore: minor fixes

* fix: check webhooks from ui nodes

* chore: remove saving prompt

* chore: explicit current workflow evaluation

* feat: add settings link to activation modal

* fix: immediately load executions on render

* feat: exclude error trigger from trigger nodes

* chore: add i18n keys

* fix: check localstorage more strictly

* fix: handle refresh in execution list

* remove unnessary event

* remove comment

* fix closing executions modal bugs

* update closing

* update translation key

* fix translation keys

* fix modal closing

* fix closing

* fix drawer closing

* close all modals when opening executions

* update key

* close all modals when opening workflow or new page

* delete unnessary comment

* clean up import

* clean up unnessary initial data

* clean up activator impl

* rewrite

* fix open modal bug

* simply remove error

* refactor activation logic

* fix i18n and such

* remove changes

* revert saving changes

* Revert "revert saving changes"

25c29d1055

* add translation

* fix new workflows saving

* clean up modal impl

* clean up impl

* refactor common code out

* remove active changes from saving

* refactor differently

* revert unnessary change

* set dirty false

* fix i18n bug

* avoid opening two modals

* fix tooltips

* add comment

* address other comments

* address comments

Co-authored-by: saintsebastian <tilitidam@gmail.com>
2022-01-21 18:00:00 +01:00