mirror of
https://github.com/n8n-io/n8n.git
synced 2025-01-11 12:57:29 -08:00
4b014286cf
all commands sent between main instance and workers need to contain a server id to prevent senders from reacting to their own messages, causing loops this PR makes sure all sent messages contain a sender id by default as part of constructing a sending redis client. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
125 lines
4.1 KiB
TypeScript
125 lines
4.1 KiB
TypeScript
import Container from 'typedi';
|
|
import config from '@/config';
|
|
import { LoggerProxy } from 'n8n-workflow';
|
|
import { getLogger } from '@/Logger';
|
|
import { OrchestrationService } from '@/services/orchestration.service';
|
|
import type { RedisServiceWorkerResponseObject } from '@/services/redis/RedisServiceCommands';
|
|
import { eventBus } from '@/eventbus';
|
|
import { RedisService } from '@/services/redis.service';
|
|
import { mockInstance } from '../../integration/shared/utils';
|
|
import { handleWorkerResponseMessage } from '../../../src/services/orchestration/handleWorkerResponseMessage';
|
|
import { handleCommandMessage } from '../../../src/services/orchestration/handleCommandMessage';
|
|
|
|
const os = Container.get(OrchestrationService);
|
|
|
|
let queueModeId: string;
|
|
|
|
function setDefaultConfig() {
|
|
config.set('executions.mode', 'queue');
|
|
}
|
|
|
|
const workerRestartEventbusResponse: RedisServiceWorkerResponseObject = {
|
|
senderId: 'test',
|
|
workerId: 'test',
|
|
command: 'restartEventBus',
|
|
payload: {
|
|
result: 'success',
|
|
},
|
|
};
|
|
|
|
describe('Orchestration Service', () => {
|
|
beforeAll(async () => {
|
|
mockInstance(RedisService);
|
|
LoggerProxy.init(getLogger());
|
|
jest.mock('ioredis', () => {
|
|
const Redis = require('ioredis-mock');
|
|
if (typeof Redis === 'object') {
|
|
// the first mock is an ioredis shim because ioredis-mock depends on it
|
|
// https://github.com/stipsan/ioredis-mock/blob/master/src/index.js#L101-L111
|
|
return {
|
|
Command: { _transformer: { argument: {}, reply: {} } },
|
|
};
|
|
}
|
|
// second mock for our code
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
return function (...args: any) {
|
|
return new Redis(args);
|
|
};
|
|
});
|
|
jest.mock('../../../src/services/redis/RedisServicePubSubPublisher', () => {
|
|
return jest.fn().mockImplementation(() => {
|
|
return {
|
|
init: jest.fn(),
|
|
publishToEventLog: jest.fn(),
|
|
publishToWorkerChannel: jest.fn(),
|
|
destroy: jest.fn(),
|
|
};
|
|
});
|
|
});
|
|
jest.mock('../../../src/services/redis/RedisServicePubSubSubscriber', () => {
|
|
return jest.fn().mockImplementation(() => {
|
|
return {
|
|
subscribeToCommandChannel: jest.fn(),
|
|
destroy: jest.fn(),
|
|
};
|
|
});
|
|
});
|
|
setDefaultConfig();
|
|
queueModeId = config.get('redis.queueModeId');
|
|
});
|
|
|
|
afterAll(async () => {
|
|
jest.mock('../../../src/services/redis/RedisServicePubSubPublisher').restoreAllMocks();
|
|
jest.mock('../../../src/services/redis/RedisServicePubSubSubscriber').restoreAllMocks();
|
|
await os.shutdown();
|
|
});
|
|
|
|
test('should initialize', async () => {
|
|
await os.init();
|
|
expect(os.redisPublisher).toBeDefined();
|
|
expect(os.redisSubscriber).toBeDefined();
|
|
expect(queueModeId).toBeDefined();
|
|
});
|
|
|
|
test('should handle worker responses', async () => {
|
|
const response = await handleWorkerResponseMessage(
|
|
JSON.stringify(workerRestartEventbusResponse),
|
|
);
|
|
expect(response.command).toEqual('restartEventBus');
|
|
});
|
|
|
|
test('should handle command messages from others', async () => {
|
|
jest.spyOn(LoggerProxy, 'warn');
|
|
const responseFalseId = await handleCommandMessage(
|
|
JSON.stringify({
|
|
senderId: 'test',
|
|
command: 'reloadLicense',
|
|
}),
|
|
);
|
|
expect(responseFalseId).toBeDefined();
|
|
expect(responseFalseId!.command).toEqual('reloadLicense');
|
|
expect(responseFalseId!.senderId).toEqual('test');
|
|
expect(LoggerProxy.warn).toHaveBeenCalled();
|
|
jest.spyOn(LoggerProxy, 'warn').mockRestore();
|
|
});
|
|
|
|
test('should reject command messages from iteslf', async () => {
|
|
jest.spyOn(eventBus, 'restart');
|
|
const response = await handleCommandMessage(
|
|
JSON.stringify({ ...workerRestartEventbusResponse, senderId: queueModeId }),
|
|
);
|
|
expect(response).toBeDefined();
|
|
expect(response!.command).toEqual('restartEventBus');
|
|
expect(response!.senderId).toEqual(queueModeId);
|
|
expect(eventBus.restart).not.toHaveBeenCalled();
|
|
jest.spyOn(eventBus, 'restart').mockRestore();
|
|
});
|
|
|
|
test('should send command messages', async () => {
|
|
jest.spyOn(os.redisPublisher, 'publishToCommandChannel');
|
|
await os.getWorkerIds();
|
|
expect(os.redisPublisher.publishToCommandChannel).toHaveBeenCalled();
|
|
jest.spyOn(os.redisPublisher, 'publishToCommandChannel').mockRestore();
|
|
});
|
|
});
|