mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-10 14:44:05 -08:00
b282c7e5d9
* fix(core): make `deepCopy` backward compatible
`JSON.parse(JSON.stringify())` uses `.toJSON` when available. so should `deepCopy`
* fix(core): prevent double quotes on luxon datetimes (#4508)
* 🐛 Prevent double quotes on luxon datetimes
* ⚡ Generalize solution
* update the types in packages/workflow/src/utils.ts
* add `toJSON` check to NodeErrors.isTraversableObject as well
* move the toJSON check before the cyclic dependency check
* fix(core): keep backward compatibility in deepCopy by calling `toJSON` on objects that have it
* fix(core): updating deepCopy typings
* Revert "fix(core): updating deepCopy typings"
This reverts commit 100a0f1f3d.
* fix(core): temporarily removing Date cloning from deepCopy
* fix(core): updating deepCopy types
* fix(core): updating deepCopy
* fix(core): updating deepCopy get prototype of object
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
97 lines
2.2 KiB
TypeScript
97 lines
2.2 KiB
TypeScript
import { jsonParse, deepCopy } from '../src/utils';
|
|
|
|
describe('jsonParse', () => {
|
|
it('parses JSON', () => {
|
|
expect(jsonParse('[1, 2, 3]')).toEqual([1, 2, 3]);
|
|
expect(jsonParse('{ "a": 1 }')).toEqual({ a: 1 });
|
|
});
|
|
|
|
it('optionally throws `errorMessage', () => {
|
|
expect(() => {
|
|
jsonParse('', { errorMessage: 'Invalid JSON' });
|
|
}).toThrow('Invalid JSON');
|
|
});
|
|
|
|
it('optionally returns a `fallbackValue`', () => {
|
|
expect(jsonParse('', { fallbackValue: { foo: 'bar' } })).toEqual({ foo: 'bar' });
|
|
});
|
|
});
|
|
|
|
describe('deepCopy', () => {
|
|
it('should deep copy an object', () => {
|
|
const serializable = {
|
|
x: 1,
|
|
y: 2,
|
|
toJSON: () => 'x:1,y:2',
|
|
};
|
|
const object = {
|
|
deep: {
|
|
props: {
|
|
list: [{ a: 1 }, { b: 2 }, { c: 3 }],
|
|
},
|
|
arr: [1, 2, 3],
|
|
},
|
|
serializable,
|
|
arr: [
|
|
{
|
|
prop: {
|
|
list: ['a', 'b', 'c'],
|
|
},
|
|
},
|
|
],
|
|
func: () => {},
|
|
date: new Date(1667389172201),
|
|
undef: undefined,
|
|
nil: null,
|
|
bool: true,
|
|
num: 1,
|
|
};
|
|
const copy = deepCopy(object);
|
|
expect(copy).not.toBe(object);
|
|
expect(copy.arr).toEqual(object.arr);
|
|
expect(copy.arr).not.toBe(object.arr);
|
|
expect(copy.date).toBe('2022-11-02T11:39:32.201Z');
|
|
expect(copy.serializable).toBe(serializable.toJSON());
|
|
expect(copy.deep.props).toEqual(object.deep.props);
|
|
expect(copy.deep.props).not.toBe(object.deep.props);
|
|
});
|
|
|
|
it('should avoid max call stack in case of circular deps', () => {
|
|
const object: Record<string, any> = {
|
|
deep: {
|
|
props: {
|
|
list: [{ a: 1 }, { b: 2 }, { c: 3 }],
|
|
},
|
|
arr: [1, 2, 3],
|
|
},
|
|
arr: [
|
|
{
|
|
prop: {
|
|
list: ['a', 'b', 'c'],
|
|
},
|
|
},
|
|
],
|
|
func: () => {},
|
|
date: new Date(1667389172201),
|
|
undef: undefined,
|
|
nil: null,
|
|
bool: true,
|
|
num: 1,
|
|
};
|
|
|
|
object.circular = object;
|
|
object.deep.props.circular = object;
|
|
object.deep.arr.push(object);
|
|
|
|
const copy = deepCopy(object);
|
|
expect(copy).not.toBe(object);
|
|
expect(copy.arr).toEqual(object.arr);
|
|
expect(copy.arr).not.toBe(object.arr);
|
|
expect(copy.date).toBe('2022-11-02T11:39:32.201Z');
|
|
expect(copy.deep.props.circular).toBe(copy);
|
|
expect(copy.deep.props.circular).not.toBe(object);
|
|
expect(copy.deep.arr.slice(-1)[0]).toBe(copy);
|
|
expect(copy.deep.arr.slice(-1)[0]).not.toBe(object);
|
|
});
|
|
});
|