mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 09:04:07 -08:00
c85faff4f1
* ✨ Make it possible to dynamically load node packages * ⚡ Fix comment * ✨ Make possible to dynamically install nodes from npm * Created migration for sqlite regarding community nodes * Saving to db whenever a package with nodes is installed * Created endpoint to fetch installed packages * WIP - uninstall package with nodes * Fix lint issues * Updating nodes via API * Lint and improvement fixes * Created community node helpers and removed packages taht do not contain nodes * Check for package updates when fetching installed packages * Blocked access to non-owner and preventing incorrect install of packages * Added auto healing process * Unit tests for helpers * Finishing tests for helpers * Improved unit tests, refactored more helpers and created integration tests for GET * Implemented detection of missing packages on init and added warning to frontend settings * Add check for banned packages and fix broken tests * Create migrations for other db systems * Updated with latest changes from master * Fixed conflict errors * Improved unit tests, refactored more helpers and created integration tests for GET * Implemented detection of missing packages on init and added warning to frontend settings * 🔥 Removing access check for the Settings sidebar item * ✨ Added inital community nodes settings screen * ⚡Added executionMode flag to settings * ✨ Implemented N8N-callout component * 💄Updating Callout component template propery names * 💄 Updating Callout component styling. * 💄Updating Callout component sizing and colors. * ✔️ Updating Callout component test snapshots after styling changes * ✨ Updating the `ActionBox` component so it supports callouts and conditional button rendering * 💄 Removing duplicate callout theme validation in the `ActionBox` component. Adding a selection control for it in the storybook. * ✨ Added warning message if instance is in the queue mode. Updated colors based on the new design. * ⚡ Added a custom permission support to router * 🔨 Implemented UM detection as a custom permission. * 👌Updating route permission logic. * ✨ Implemented installed community packages list in the settings view * 👌 Updating settings routes rules and community nodes setting view. * Allow installation of packages that failed to load * 👌 Updating `ActionBox`, `CommuntyPackageCard` components and settings loading logic. * 👌 Fixing community nodes loading state and sidebar icon spacing. * ✨ Implemented loading skeletons for community package cards * 👌 Handling errrors while loading installed package list. Updating spacing. * 👌 Updating community nodes error messages. * Added disable flag * 🐛 Fixing a community nodes update detection bug when there are missing packages. (#3497) * ✨ Added front-end support for community nodes feature flag * ✨ Implemented community package installation modal dialog * 💄 Community nodes installation modal updates: Moved links to constants and used them in translations, disabling inputs in loading state. * ✨ Implemented community packages install flow * Standardize error codes (#3501) * Standardize error: 400 for request issues such as invalid package name and 500 for installation problems * Fix http status code for when package is not found * ✨ Implemented community package installation modal dialog * 💄 Community nodes installation modal updates: Moved links to constants and used them in translations, disabling inputs in loading state. * ✨ Implemented community packages install flow * ✨ Updated error handling based on the response codes * ✨ Implemented community package installation modal dialog * ✨ Implemented community package uninstall flow. * ✨ Finished update confirm modal UI * 💄 Replaced community nodes tooltip image with the one exported from figma. * ✨ Implemented community package update process * ✨ Updating community nodes list after successful package update * 🔒 Updating public API setting route to use new access rules. Updating express app definition in community nodes tests * ✨ Implemented community package installation modal dialog * 💄 Community nodes installation modal updates: Moved links to constants and used them in translations, disabling inputs in loading state. * ✨ Implemented community packages install flow * ✨ Updated error handling based on the response codes * Change output for installation request * Improve payload for update requests * 👌 Updating community nodes install modal UI * 👌 Updating community nodes confirm modal logic * 👌 Refactoring community nodes confirm modal dialog * 👌 Separating community nodes components loading states * 💄 Updating community nodes install modal spacing. * Fix behavior for installing already installed packages * 💡 Commenting community nodes install process * 🔥 Removing leftover commits of deleted Vue mutations * ✨ Updated node list to identify community nodes and handle node name clash * ✨ Implemented missing community node dialog. * 💄 Updating n8n-tabs component to support tooltips * ✨ Updating node details with community node details. * 🔨 Using back-end response when updating community packages * 👌 Updating tabs component and refactoring community nodes store mutations * 👌 Adding community node flag to node type descriptions and using it to identify community nodes * 👌 Hiding unnecessary elements from missing node details panel. * 👌 Updating missing node type descriptions for custom and community nodes * 👌 Updating community node package name detection logic * 👌 Removing communityNode flag from node description * ✨ Adding `force` flag to credentials fetching (#3527) * ✨ Adding `force` flag to credentials fetching which can be used to skip check when loading credentials * ✨ Forcing credentials loading when opening nodeView * 👌 Minor updates to community nodes details panel * tests for post endpoint * duplicate comments * Add Patch and Delete enpoints tests * 🔒 Using `pageCategory`prop to assemble the list of settings routes instead of hard-coded array (#3562) * 📈 Added front-end telemetry events for community nodes * 📈 Updating community nodes telemetry events * 💄 Updating community nodes settings UI elements based on product/design review * 💄 Updating node view & node details view for community nodes based on product/design feedback * 💄 Fixing community node text capitalisation * ✨ Adding community node install error message under the package name input field * Fixed and improved tests * Fix lint issue * feat: Migrated to npm release of riot-tmpl fork. * 📈 Updating community nodes telemetry events based on the product review * 💄 Updating community nodes UI based on the design feedback * 🔀 Merging recent node draggable panels changes * Implement self healing process * Improve error messages for package name requirement and disk space * 💄 Removing front-end error message override since appropriate response is available from the back-end * Fix lint issues * Fix installed node name * 💄 Removed additional node name parsing * 📈 Updating community nodes telemetry events * Fix postgres migration for cascading nodes when package is removed * Remove postman mock for banned packages * 📈 Adding missing telemetry event for community node documentation click * 🐛 Fixing community nodes UI bugs reported during the bug bash * Fix issue with uninstalling packages not reflecting UI * 🐛 Fixing a missing node type bug when trying to run a workflow. * Improve error detection for installing packages * 💄 Updating community nodes components styling and wording based on the product feedback * Implement telemetry be events * Add author name and email to packages * Fix telemetry be events for community packages * 📈 Updating front-end telemetry events with community nodes author data * 💄 Updating credentials documentation link logic to handle community nodes credentials * 🐛 Fixing draggable panels logic * Fix duplicate wrong import * 💄 Hiding community nodes credentials documentation links when they don't contain an absolute URL * Fix issue with detection of missing packages * 💄 Adding the `Docs` tab to community nodes * 💄 Adding a failed loading indicator to community nodes list * Prevent n8n from crashing on startup * Refactor and improve code quality * ⚡ Remove not needed depenedency Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Milorad Filipović <milorad@n8n.io> Co-authored-by: Milorad FIlipović <miloradfilipovic19@gmail.com> Co-authored-by: agobrech <ael.gobrecht@gmail.com> Co-authored-by: Alex Grozav <alex@grozav.com>
317 lines
9.7 KiB
TypeScript
317 lines
9.7 KiB
TypeScript
/* eslint-disable import/no-cycle */
|
|
import express = require('express');
|
|
import { LoggerProxy, PublicInstalledPackage } from 'n8n-workflow';
|
|
import { getLogger } from '../Logger';
|
|
|
|
import { ResponseHelper, LoadNodesAndCredentials, Push, InternalHooksManager } from '..';
|
|
import { NodeRequest } from '../requests';
|
|
import { RESPONSE_ERROR_MESSAGES } from '../constants';
|
|
import {
|
|
matchMissingPackages,
|
|
matchPackagesWithUpdates,
|
|
executeCommand,
|
|
checkPackageStatus,
|
|
hasPackageLoadedSuccessfully,
|
|
removePackageFromMissingList,
|
|
parsePackageName,
|
|
} from '../CommunityNodes/helpers';
|
|
import { getAllInstalledPackages, searchInstalledPackage } from '../CommunityNodes/packageModel';
|
|
import { isAuthenticatedRequest } from '../UserManagement/UserManagementHelper';
|
|
import config = require('../../config');
|
|
import { NpmUpdatesAvailable } from '../Interfaces';
|
|
|
|
export const nodesController = express.Router();
|
|
|
|
/**
|
|
* Initialize Logger if needed
|
|
*/
|
|
nodesController.use((req, res, next) => {
|
|
try {
|
|
LoggerProxy.getInstance();
|
|
} catch (error) {
|
|
LoggerProxy.init(getLogger());
|
|
}
|
|
next();
|
|
});
|
|
|
|
nodesController.use((req, res, next) => {
|
|
if (!isAuthenticatedRequest(req) || req.user.globalRole.name !== 'owner') {
|
|
res.status(403).json({ status: 'error', message: 'Unauthorized' });
|
|
return;
|
|
}
|
|
next();
|
|
});
|
|
|
|
nodesController.use((req, res, next) => {
|
|
if (config.getEnv('executions.mode') === 'queue' && req.method !== 'GET') {
|
|
res.status(400).json({
|
|
status: 'error',
|
|
message: 'Package management is disabled when running in "queue" mode',
|
|
});
|
|
return;
|
|
}
|
|
next();
|
|
});
|
|
|
|
nodesController.post(
|
|
'/',
|
|
ResponseHelper.send(async (req: NodeRequest.Post) => {
|
|
const { name } = req.body;
|
|
let parsedPackageName;
|
|
try {
|
|
parsedPackageName = parsePackageName(name);
|
|
} catch (error) {
|
|
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
|
|
throw new ResponseHelper.ResponseError(error.message, undefined, 400);
|
|
}
|
|
|
|
// Only install packages that haven't been installed
|
|
// or that have failed loading
|
|
const installedPackageInstalled = await searchInstalledPackage(parsedPackageName.packageName);
|
|
const loadedPackage = hasPackageLoadedSuccessfully(name);
|
|
if (installedPackageInstalled && loadedPackage) {
|
|
throw new ResponseHelper.ResponseError(
|
|
`Package "${parsedPackageName.packageName}" is already installed. For updating, click the corresponding button.`,
|
|
undefined,
|
|
400,
|
|
);
|
|
}
|
|
|
|
const packageStatus = await checkPackageStatus(name);
|
|
if (packageStatus.status !== 'OK') {
|
|
throw new ResponseHelper.ResponseError(
|
|
`Package "${name}" has been banned from n8n's repository and will not be installed`,
|
|
undefined,
|
|
400,
|
|
);
|
|
}
|
|
|
|
try {
|
|
const installedPackage = await LoadNodesAndCredentials().loadNpmModule(
|
|
parsedPackageName.packageName,
|
|
parsedPackageName.version,
|
|
);
|
|
|
|
if (!loadedPackage) {
|
|
removePackageFromMissingList(name);
|
|
}
|
|
|
|
// Inform the connected frontends that new nodes are available
|
|
installedPackage.installedNodes.forEach((nodeData) => {
|
|
const pushInstance = Push.getInstance();
|
|
pushInstance.send('reloadNodeType', {
|
|
name: nodeData.name,
|
|
version: nodeData.latestVersion,
|
|
});
|
|
});
|
|
|
|
void InternalHooksManager.getInstance().onCommunityPackageInstallFinished({
|
|
user_id: req.user.id,
|
|
input_string: name,
|
|
package_name: parsedPackageName.packageName,
|
|
success: true,
|
|
package_version: parsedPackageName.version,
|
|
package_node_names: installedPackage.installedNodes.map((nodeData) => nodeData.name),
|
|
package_author: installedPackage.authorName,
|
|
package_author_email: installedPackage.authorEmail,
|
|
});
|
|
|
|
return installedPackage;
|
|
} catch (error) {
|
|
let statusCode = 500;
|
|
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
|
|
const errorMessage = error.message as string;
|
|
if (
|
|
errorMessage.includes(RESPONSE_ERROR_MESSAGES.PACKAGE_VERSION_NOT_FOUND) ||
|
|
errorMessage.includes(RESPONSE_ERROR_MESSAGES.PACKAGE_DOES_NOT_CONTAIN_NODES) ||
|
|
errorMessage.includes(RESPONSE_ERROR_MESSAGES.PACKAGE_NOT_FOUND)
|
|
) {
|
|
statusCode = 400;
|
|
}
|
|
|
|
void InternalHooksManager.getInstance().onCommunityPackageInstallFinished({
|
|
user_id: req.user.id,
|
|
input_string: name,
|
|
package_name: parsedPackageName.packageName,
|
|
success: false,
|
|
package_version: parsedPackageName.version,
|
|
failure_reason: errorMessage,
|
|
});
|
|
throw new ResponseHelper.ResponseError(
|
|
`Error loading package "${name}": ${errorMessage}`,
|
|
undefined,
|
|
statusCode,
|
|
);
|
|
}
|
|
}),
|
|
);
|
|
|
|
// Install new credentials/nodes from npm
|
|
nodesController.get(
|
|
'/',
|
|
ResponseHelper.send(async (): Promise<PublicInstalledPackage[]> => {
|
|
const packages = await getAllInstalledPackages();
|
|
|
|
if (packages.length === 0) {
|
|
return packages;
|
|
}
|
|
|
|
let pendingUpdates: NpmUpdatesAvailable | undefined;
|
|
try {
|
|
// Command succeeds when there are no updates.
|
|
// NPM handles this oddly. It exits with code 1 when there are updates.
|
|
// More here: https://github.com/npm/rfcs/issues/473
|
|
await executeCommand('npm outdated --json', { doNotHandleError: true });
|
|
} catch (error) {
|
|
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
|
|
if (error.code === 1) {
|
|
// Updates available
|
|
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
|
|
pendingUpdates = JSON.parse(error.stdout);
|
|
}
|
|
}
|
|
let hydratedPackages = matchPackagesWithUpdates(packages, pendingUpdates);
|
|
try {
|
|
if (config.get('nodes.packagesMissing')) {
|
|
// eslint-disable-next-line prettier/prettier
|
|
hydratedPackages = matchMissingPackages(hydratedPackages, config.get('nodes.packagesMissing'));
|
|
}
|
|
} catch (error) {
|
|
// Do nothing if setting is missing
|
|
}
|
|
return hydratedPackages;
|
|
}),
|
|
);
|
|
|
|
// Uninstall credentials/nodes from npm
|
|
nodesController.delete(
|
|
'/',
|
|
ResponseHelper.send(async (req: NodeRequest.Delete) => {
|
|
const { name } = req.body;
|
|
if (!name) {
|
|
throw new ResponseHelper.ResponseError(
|
|
RESPONSE_ERROR_MESSAGES.PACKAGE_NAME_NOT_PROVIDED,
|
|
undefined,
|
|
400,
|
|
);
|
|
}
|
|
// This function also sanitizes the package name by throwing errors.
|
|
parsePackageName(name);
|
|
|
|
const installedPackage = await searchInstalledPackage(name);
|
|
|
|
if (!installedPackage) {
|
|
throw new ResponseHelper.ResponseError(
|
|
RESPONSE_ERROR_MESSAGES.PACKAGE_NOT_INSTALLED,
|
|
undefined,
|
|
400,
|
|
);
|
|
}
|
|
|
|
try {
|
|
void (await LoadNodesAndCredentials().removeNpmModule(name, installedPackage));
|
|
|
|
// Inform the connected frontends that the node list has been updated
|
|
installedPackage.installedNodes.forEach((installedNode) => {
|
|
const pushInstance = Push.getInstance();
|
|
pushInstance.send('removeNodeType', {
|
|
name: installedNode.type,
|
|
version: installedNode.latestVersion,
|
|
});
|
|
});
|
|
|
|
void InternalHooksManager.getInstance().onCommunityPackageDeleteFinished({
|
|
user_id: req.user.id,
|
|
package_name: name,
|
|
package_version: installedPackage.installedVersion,
|
|
package_node_names: installedPackage.installedNodes.map((nodeData) => nodeData.name),
|
|
package_author: installedPackage.authorName,
|
|
package_author_email: installedPackage.authorEmail,
|
|
});
|
|
} catch (error) {
|
|
throw new ResponseHelper.ResponseError(
|
|
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions, @typescript-eslint/no-unsafe-member-access
|
|
`Error removing package "${name}": ${error.message}`,
|
|
undefined,
|
|
500,
|
|
);
|
|
}
|
|
}),
|
|
);
|
|
|
|
// Update a package
|
|
nodesController.patch(
|
|
'/',
|
|
ResponseHelper.send(async (req: NodeRequest.Update) => {
|
|
const { name } = req.body;
|
|
if (!name) {
|
|
throw new ResponseHelper.ResponseError(
|
|
RESPONSE_ERROR_MESSAGES.PACKAGE_NAME_NOT_PROVIDED,
|
|
undefined,
|
|
400,
|
|
);
|
|
}
|
|
|
|
const parsedPackageData = parsePackageName(name);
|
|
const packagePreviouslyInstalled = await searchInstalledPackage(name);
|
|
|
|
if (!packagePreviouslyInstalled) {
|
|
throw new ResponseHelper.ResponseError(
|
|
RESPONSE_ERROR_MESSAGES.PACKAGE_NOT_INSTALLED,
|
|
undefined,
|
|
400,
|
|
);
|
|
}
|
|
|
|
try {
|
|
const newInstalledPackage = await LoadNodesAndCredentials().updateNpmModule(
|
|
parsedPackageData.packageName,
|
|
packagePreviouslyInstalled,
|
|
);
|
|
|
|
const pushInstance = Push.getInstance();
|
|
|
|
// Inform the connected frontends that new nodes are available
|
|
packagePreviouslyInstalled.installedNodes.forEach((installedNode) => {
|
|
pushInstance.send('removeNodeType', {
|
|
name: installedNode.type,
|
|
version: installedNode.latestVersion,
|
|
});
|
|
});
|
|
|
|
newInstalledPackage.installedNodes.forEach((nodeData) => {
|
|
pushInstance.send('reloadNodeType', {
|
|
name: nodeData.name,
|
|
version: nodeData.latestVersion,
|
|
});
|
|
});
|
|
|
|
void InternalHooksManager.getInstance().onCommunityPackageUpdateFinished({
|
|
user_id: req.user.id,
|
|
package_name: name,
|
|
package_version_current: packagePreviouslyInstalled.installedVersion,
|
|
package_version_new: newInstalledPackage.installedVersion,
|
|
package_node_names: newInstalledPackage.installedNodes.map((node) => node.name),
|
|
package_author: newInstalledPackage.authorName,
|
|
package_author_email: newInstalledPackage.authorEmail,
|
|
});
|
|
|
|
return newInstalledPackage;
|
|
} catch (error) {
|
|
packagePreviouslyInstalled.installedNodes.forEach((installedNode) => {
|
|
const pushInstance = Push.getInstance();
|
|
pushInstance.send('removeNodeType', {
|
|
name: installedNode.type,
|
|
version: installedNode.latestVersion,
|
|
});
|
|
});
|
|
throw new ResponseHelper.ResponseError(
|
|
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions, @typescript-eslint/no-unsafe-member-access
|
|
`Error updating package "${name}": ${error.message}`,
|
|
undefined,
|
|
500,
|
|
);
|
|
}
|
|
}),
|
|
);
|