mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-10 22:54:05 -08:00
1d27a9e87e
* Add path mapping and response error interfaces * Add error handling and throwing functionality * Refactor error handling into a single function * Re-implement error handling in Hacker News node * Fix linting details * Re-implement error handling in Spotify node * Re-implement error handling in G Suite Admin node * 🚧 create basic setup NodeError * 🚧 add httpCodes * 🚧 add path priolist * 🚧 handle statusCode in error, adjust interfaces * 🚧 fixing type issues w/Ivan * 🚧 add error exploration * 👔 fix linter issues * 🔧 improve object check * 🚧 remove path passing from NodeApiError * 🚧 add multi error + refactor findProperty method * 👔 allow any * 🔧 handle multi error message callback * ⚡ change return type of callback * ⚡ add customCallback to MultiError * 🚧 refactor to use INode * 🔨 handle arrays, continue search after first null property found * 🚫 refactor method access * 🚧 setup NodeErrorView * ⚡ change timestamp to Date.now * 📚 Add documentation for methods and constants * 🚧 change message setting * 🚚 move NodeErrors to workflow * ✨ add new ErrorView for Nodes * 🎨 improve error notification * 🎨 refactor interfaces * ⚡ add WorkflowOperationError, refactor error throwing * 👕 fix linter issues * 🎨 rename param * 🐛 fix handling normal errors * ⚡ add usage of NodeApiError * 🎨 fix throw new error instead of constructor * 🎨 remove unnecessary code/comments * 🎨 adjusted spacing + updated status messages * 🎨 fix tab indentation * ✨ Replace current errors with custom errors (#1576) * ⚡ Introduce NodeApiError in catch blocks * ⚡ Introduce NodeOperationError in nodes * ⚡ Add missing errors and remove incompatible * ⚡ Fix NodeOperationError in incompatible nodes * 🔧 Adjust error handling in missed nodes PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes * 🔨 Adjust Strava Trigger node error handling * 🔨 Adjust AWS nodes error handling * 🔨 Remove duplicate instantiation of NodeApiError * 🐛 fix strava trigger node error handling * Add XML parsing to NodeApiError constructor (#1633) * 🐛 Remove type annotation from catch variable * ✨ Add XML parsing to NodeApiError * ⚡ Simplify error handling in Rekognition node * ⚡ Pass in XML flag in generic functions * 🔥 Remove try/catch wrappers at call sites * 🔨 Refactor setting description from XML * 🔨 Refactor let to const in resource loaders * ⚡ Find property in parsed XML * ⚡ Change let to const * 🔥 Remove unneeded try/catch block * 👕 Fix linting issues * 🐛 Fix errors from merge conflict resolution * ⚡ Add custom errors to latest contributions * 👕 Fix linting issues * ⚡ Refactor MongoDB helpers for custom errors * 🐛 Correct custom error type * ⚡ Apply feedback to A nodes * ⚡ Apply feedback to missed A node * ⚡ Apply feedback to B-D nodes * ⚡ Apply feedback to E-F nodes * ⚡ Apply feedback to G nodes * ⚡ Apply feedback to H-L nodes * ⚡ Apply feedback to M nodes * ⚡ Apply feedback to P nodes * ⚡ Apply feedback to R nodes * ⚡ Apply feedback to S nodes * ⚡ Apply feedback to T nodes * ⚡ Apply feedback to V-Z nodes * ⚡ Add HTTP code to iterable node error * 🔨 Standardize e as error * 🔨 Standardize err as error * ⚡ Fix error handling for non-standard nodes Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
295 lines
8.1 KiB
TypeScript
295 lines
8.1 KiB
TypeScript
// import { google } from 'googleapis';
|
|
|
|
// import {
|
|
// IHookFunctions,
|
|
// IWebhookFunctions,
|
|
// } from 'n8n-core';
|
|
|
|
// import {
|
|
// IDataObject,
|
|
// INodeTypeDescription,
|
|
// INodeType,
|
|
// IWebhookResponseData,
|
|
// NodeOperationError,
|
|
// } from 'n8n-workflow';
|
|
|
|
// import { getAuthenticationClient } from './GoogleApi';
|
|
|
|
|
|
// export class GoogleDriveTrigger implements INodeType {
|
|
// description: INodeTypeDescription = {
|
|
// displayName: 'Google Drive Trigger',
|
|
// name: 'googleDriveTrigger',
|
|
// icon: 'file:googleDrive.png',
|
|
// group: ['trigger'],
|
|
// version: 1,
|
|
// subtitle: '={{$parameter["owner"] + "/" + $parameter["repository"] + ": " + $parameter["events"].join(", ")}}',
|
|
// description: 'Starts the workflow when a file on Google Drive got changed.',
|
|
// defaults: {
|
|
// name: 'Google Drive Trigger',
|
|
// color: '#3f87f2',
|
|
// },
|
|
// inputs: [],
|
|
// outputs: ['main'],
|
|
// credentials: [
|
|
// {
|
|
// name: 'googleApi',
|
|
// required: true,
|
|
// }
|
|
// ],
|
|
// webhooks: [
|
|
// {
|
|
// name: 'default',
|
|
// httpMethod: 'POST',
|
|
// responseMode: 'onReceived',
|
|
// path: 'webhook',
|
|
// },
|
|
// ],
|
|
// properties: [
|
|
// {
|
|
// displayName: 'Resource Id',
|
|
// name: 'resourceId',
|
|
// type: 'string',
|
|
// default: '',
|
|
// required: true,
|
|
// placeholder: '',
|
|
// description: 'ID of the resource to watch, for example a file ID.',
|
|
// },
|
|
// ],
|
|
// };
|
|
|
|
// // @ts-ignore (because of request)
|
|
// webhookMethods = {
|
|
// default: {
|
|
// async checkExists(this: IHookFunctions): Promise<boolean> {
|
|
// // const webhookData = this.getWorkflowStaticData('node');
|
|
|
|
// // if (webhookData.webhookId === undefined) {
|
|
// // // No webhook id is set so no webhook can exist
|
|
// // return false;
|
|
// // }
|
|
|
|
// // // Webhook got created before so check if it still exists
|
|
// // const owner = this.getNodeParameter('owner') as string;
|
|
// // const repository = this.getNodeParameter('repository') as string;
|
|
// // const endpoint = `/repos/${owner}/${repository}/hooks/${webhookData.webhookId}`;
|
|
|
|
// // try {
|
|
// // await githubApiRequest.call(this, 'GET', endpoint, {});
|
|
// // } catch (error) {
|
|
// // if (error.message.includes('[404]:')) {
|
|
// // // Webhook does not exist
|
|
// // delete webhookData.webhookId;
|
|
// // delete webhookData.webhookEvents;
|
|
|
|
// // return false;
|
|
// // }
|
|
|
|
// // // Some error occured
|
|
// // throw e;
|
|
// // }
|
|
|
|
// // If it did not error then the webhook exists
|
|
// // return true;
|
|
// return false;
|
|
// },
|
|
// async create(this: IHookFunctions): Promise<boolean> {
|
|
// const webhookUrl = this.getNodeWebhookUrl('default');
|
|
|
|
// const resourceId = this.getNodeParameter('resourceId') as string;
|
|
|
|
// const credentials = this.getCredentials('googleApi');
|
|
|
|
// if (credentials === undefined) {
|
|
// throw new NodeOperationError(this.getNode(), 'No credentials got returned!');
|
|
// }
|
|
|
|
// const scopes = [
|
|
// 'https://www.googleapis.com/auth/drive',
|
|
// 'https://www.googleapis.com/auth/drive.appdata',
|
|
// 'https://www.googleapis.com/auth/drive.photos.readonly',
|
|
// ];
|
|
|
|
// const client = await getAuthenticationClient(credentials.email as string, credentials.privateKey as string, scopes);
|
|
|
|
// const drive = google.drive({
|
|
// version: 'v3',
|
|
// auth: client,
|
|
// });
|
|
|
|
|
|
// const accessToken = await client.getAccessToken();
|
|
// console.log('accessToken: ');
|
|
// console.log(accessToken);
|
|
|
|
// const asdf = await drive.changes.getStartPageToken();
|
|
// // console.log('asdf: ');
|
|
// // console.log(asdf);
|
|
|
|
|
|
|
|
|
|
// const response = await drive.changes.watch({
|
|
// //
|
|
// pageToken: asdf.data.startPageToken,
|
|
// requestBody: {
|
|
// id: 'asdf-test-2',
|
|
// address: webhookUrl,
|
|
// resourceId,
|
|
// type: 'web_hook',
|
|
// // page_token: '',
|
|
// }
|
|
// });
|
|
|
|
// console.log('...response...CREATE');
|
|
// console.log(JSON.stringify(response, null, 2));
|
|
|
|
|
|
|
|
|
|
|
|
// // const endpoint = `/repos/${owner}/${repository}/hooks`;
|
|
|
|
// // const body = {
|
|
// // name: 'web',
|
|
// // config: {
|
|
// // url: webhookUrl,
|
|
// // content_type: 'json',
|
|
// // // secret: '...later...',
|
|
// // insecure_ssl: '1', // '0' -> not allow inscure ssl | '1' -> allow insercure SSL
|
|
// // },
|
|
// // events,
|
|
// // active: true,
|
|
// // };
|
|
|
|
|
|
// // let responseData;
|
|
// // try {
|
|
// // responseData = await githubApiRequest.call(this, 'POST', endpoint, body);
|
|
// // } catch (error) {
|
|
// // if (error.message.includes('[422]:')) {
|
|
// // throw new NodeOperationError(this.getNode(), 'A webhook with the identical URL exists already. Please delete it manually on Github!');
|
|
// // }
|
|
|
|
// // throw e;
|
|
// // }
|
|
|
|
// // if (responseData.id === undefined || responseData.active !== true) {
|
|
// // // Required data is missing so was not successful
|
|
// // throw new NodeOperationError(this.getNode(), 'Github webhook creation response did not contain the expected data.');
|
|
// // }
|
|
|
|
// // const webhookData = this.getWorkflowStaticData('node');
|
|
// // webhookData.webhookId = responseData.id as string;
|
|
// // webhookData.webhookEvents = responseData.events as string[];
|
|
|
|
// return true;
|
|
// },
|
|
// async delete(this: IHookFunctions): Promise<boolean> {
|
|
// const webhookUrl = this.getNodeWebhookUrl('default');
|
|
|
|
// const resourceId = this.getNodeParameter('resourceId') as string;
|
|
|
|
// const credentials = this.getCredentials('googleApi');
|
|
|
|
// if (credentials === undefined) {
|
|
// throw new NodeOperationError(this.getNode(), 'No credentials got returned!');
|
|
// }
|
|
|
|
// const scopes = [
|
|
// 'https://www.googleapis.com/auth/drive',
|
|
// 'https://www.googleapis.com/auth/drive.appdata',
|
|
// 'https://www.googleapis.com/auth/drive.photos.readonly',
|
|
// ];
|
|
|
|
// const client = await getAuthenticationClient(credentials.email as string, credentials.privateKey as string, scopes);
|
|
|
|
// const drive = google.drive({
|
|
// version: 'v3',
|
|
// auth: client,
|
|
// });
|
|
|
|
// // Remove channel
|
|
// const response = await drive.channels.stop({
|
|
// requestBody: {
|
|
// id: 'asdf-test-2',
|
|
// address: webhookUrl,
|
|
// resourceId,
|
|
// type: 'web_hook',
|
|
// }
|
|
// });
|
|
|
|
|
|
// console.log('...response...DELETE');
|
|
// console.log(JSON.stringify(response, null, 2));
|
|
|
|
|
|
|
|
// // const webhookData = this.getWorkflowStaticData('node');
|
|
|
|
// // if (webhookData.webhookId !== undefined) {
|
|
// // const owner = this.getNodeParameter('owner') as string;
|
|
// // const repository = this.getNodeParameter('repository') as string;
|
|
// // const endpoint = `/repos/${owner}/${repository}/hooks/${webhookData.webhookId}`;
|
|
// // const body = {};
|
|
|
|
// // try {
|
|
// // await githubApiRequest.call(this, 'DELETE', endpoint, body);
|
|
// // } catch (error) {
|
|
// // return false;
|
|
// // }
|
|
|
|
// // // Remove from the static workflow data so that it is clear
|
|
// // // that no webhooks are registred anymore
|
|
// // delete webhookData.webhookId;
|
|
// // delete webhookData.webhookEvents;
|
|
// // }
|
|
|
|
// return true;
|
|
// },
|
|
// },
|
|
// };
|
|
|
|
|
|
|
|
// async webhook(this: IWebhookFunctions): Promise<IWebhookResponseData> {
|
|
// const bodyData = this.getBodyData();
|
|
|
|
// console.log('');
|
|
// console.log('');
|
|
// console.log('GOT WEBHOOK CALL');
|
|
// console.log(JSON.stringify(bodyData, null, 2));
|
|
|
|
|
|
|
|
// // Check if the webhook is only the ping from Github to confirm if it workshook_id
|
|
// if (bodyData.hook_id !== undefined && bodyData.action === undefined) {
|
|
// // Is only the ping and not an actual webhook call. So return 'OK'
|
|
// // but do not start the workflow.
|
|
|
|
// return {
|
|
// webhookResponse: 'OK'
|
|
// };
|
|
// }
|
|
|
|
// // Is a regular webhoook call
|
|
|
|
// // TODO: Add headers & requestPath
|
|
// const returnData: IDataObject[] = [];
|
|
|
|
// returnData.push(
|
|
// {
|
|
// body: bodyData,
|
|
// headers: this.getHeaderData(),
|
|
// query: this.getQueryData(),
|
|
// }
|
|
// );
|
|
|
|
// return {
|
|
// workflowData: [
|
|
// this.helpers.returnJsonArray(returnData)
|
|
// ],
|
|
// };
|
|
// }
|
|
// }
|