mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 17:14:05 -08:00
f53c482939
Story: https://linear.app/n8n/issue/PAY-1188 - Implement Redis hashes on the caching service, based on Micha's work in #7747, adapted from `node-cache-manager-ioredis-yet`. Optimize workflow ownership lookups and manual webhook lookups with Redis hashes. - Simplify the caching service by removing all currently unused methods and options: `enable`, `disable`, `getCache`, `keys`, `keyValues`, `refreshFunctionEach`, `refreshFunctionMany`, `refreshTtl`, etc. - Remove the flag `N8N_CACHE_ENABLED`. Currently some features on `master` are broken with caching disabled, and test webhooks now rely entirely on caching, for multi-main setup support. We originally introduced this flag to protect against excessive memory usage, but total cache usage is low enough that we decided to drop this setting. Apparently this flag was also never documented. - Overall caching service refactor: use generics, reduce branching, add discriminants for cache kinds for better type safety, type caching events, improve readability, remove outdated docs, etc. Also refactor and expand caching service tests. Follow-up to: https://github.com/n8n-io/n8n/pull/8176 --------- Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
80 lines
3.6 KiB
TypeScript
80 lines
3.6 KiB
TypeScript
import { Worker } from '@/commands/worker';
|
|
import * as Config from '@oclif/config';
|
|
import config from '@/config';
|
|
import { Telemetry } from '@/telemetry';
|
|
import { ExternalSecretsManager } from '@/ExternalSecrets/ExternalSecretsManager.ee';
|
|
import { BinaryDataService } from 'n8n-core';
|
|
import { CacheService } from '@/services/cache/cache.service';
|
|
import { RedisServicePubSubPublisher } from '@/services/redis/RedisServicePubSubPublisher';
|
|
import { RedisServicePubSubSubscriber } from '@/services/redis/RedisServicePubSubSubscriber';
|
|
import { MessageEventBus } from '@/eventbus/MessageEventBus/MessageEventBus';
|
|
import { LoadNodesAndCredentials } from '@/LoadNodesAndCredentials';
|
|
import { CredentialTypes } from '@/CredentialTypes';
|
|
import { NodeTypes } from '@/NodeTypes';
|
|
import { InternalHooks } from '@/InternalHooks';
|
|
import { PostHogClient } from '@/posthog';
|
|
import { RedisService } from '@/services/redis.service';
|
|
import { OrchestrationHandlerWorkerService } from '@/services/orchestration/worker/orchestration.handler.worker.service';
|
|
import { OrchestrationWorkerService } from '@/services/orchestration/worker/orchestration.worker.service';
|
|
import { MultiMainSetup } from '@/services/orchestration/main/MultiMainSetup.ee';
|
|
|
|
import { mockInstance } from '../../shared/mocking';
|
|
|
|
const oclifConfig: Config.IConfig = new Config.Config({ root: __dirname });
|
|
|
|
beforeAll(async () => {
|
|
config.set('executions.mode', 'queue');
|
|
config.set('binaryDataManager.availableModes', 'filesystem');
|
|
mockInstance(Telemetry);
|
|
mockInstance(PostHogClient);
|
|
mockInstance(InternalHooks);
|
|
mockInstance(CacheService);
|
|
mockInstance(ExternalSecretsManager);
|
|
mockInstance(BinaryDataService);
|
|
mockInstance(MessageEventBus);
|
|
mockInstance(LoadNodesAndCredentials);
|
|
mockInstance(CredentialTypes);
|
|
mockInstance(NodeTypes);
|
|
mockInstance(RedisService);
|
|
mockInstance(RedisServicePubSubPublisher);
|
|
mockInstance(RedisServicePubSubSubscriber);
|
|
mockInstance(MultiMainSetup);
|
|
});
|
|
|
|
test('worker initializes all its components', async () => {
|
|
const worker = new Worker([], oclifConfig);
|
|
|
|
jest.spyOn(worker, 'init');
|
|
jest.spyOn(worker, 'initLicense').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initBinaryDataService').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initExternalHooks').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initExternalSecrets').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initEventBus').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initOrchestration');
|
|
jest
|
|
.spyOn(OrchestrationWorkerService.prototype, 'publishToEventLog')
|
|
.mockImplementation(async () => {});
|
|
jest
|
|
.spyOn(OrchestrationHandlerWorkerService.prototype, 'initSubscriber')
|
|
.mockImplementation(async () => {});
|
|
jest.spyOn(RedisServicePubSubPublisher.prototype, 'init').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initQueue').mockImplementation(async () => {});
|
|
|
|
await worker.init();
|
|
|
|
expect(worker.queueModeId).toBeDefined();
|
|
expect(worker.queueModeId).toContain('worker');
|
|
expect(worker.queueModeId.length).toBeGreaterThan(15);
|
|
expect(worker.initLicense).toHaveBeenCalledTimes(1);
|
|
expect(worker.initBinaryDataService).toHaveBeenCalledTimes(1);
|
|
expect(worker.initExternalHooks).toHaveBeenCalledTimes(1);
|
|
expect(worker.initExternalSecrets).toHaveBeenCalledTimes(1);
|
|
expect(worker.initEventBus).toHaveBeenCalledTimes(1);
|
|
expect(worker.initOrchestration).toHaveBeenCalledTimes(1);
|
|
expect(OrchestrationHandlerWorkerService.prototype.initSubscriber).toHaveBeenCalledTimes(1);
|
|
expect(OrchestrationWorkerService.prototype.publishToEventLog).toHaveBeenCalledTimes(1);
|
|
expect(worker.initQueue).toHaveBeenCalledTimes(1);
|
|
|
|
jest.restoreAllMocks();
|
|
});
|