mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-12 23:54:07 -08:00
a18081d749
* ✨ Inicial setup * ⚡ Add authentication handler * ⚡ Add GET /users route * ⚡ Improvements * 👕 Fix linting issues * ⚡ Add GET /users/:identifier endpoint * ⚡ Add POST /users endpoint * ⚡ Add DELETE /users/:identifier endpoint * ⚡ Return error using express native functions * 👕 Fix linting issue * ⚡ Possibility to add custom middleware * ⚡ Refactor POST /users * ⚡ Refactor DELETE /users * ⚡ Improve cleaning function * ⚡ Refactor GET /users and /users/:identifier * ⚡ Add API spec to route * ⚡ Add raw option to response helper * 🐛 Fix issue adding custom middleware * ⚡ Enable includeRole parameter in GET /users/:identifier * ⚡ Fix linting issues after merge * ⚡ Add missing config variable * ⚡ General improvements ⚡ asasas * ⚡ Add POST /users tests * Debug public API tests * Fix both sets of tests * ⚡ Improvements * ⚡ Load api versions dynamically * ⚡ Add endpoints to UM to create/delete an API Key * ⚡ Add index to apiKey column * 👕 Fix linting issue * ⚡ Clean open api spec * ⚡ Improvements * ⚡ Skip tests * 🐛 Fix bug with test * ⚡ Fix issue with the open api spec * ⚡ Fix merge issue * ⚡ Move token enpoints from /users to /me * ⚡ Apply feedback to openapi.yml * ⚡ Improvements to api-key endpoints * 🐛 Fix test to suport API dynamic loading * ⚡ Expose swagger ui in GET /{version}/docs * ⚡ Allow to disable public api via env variable * ⚡ Change handlers structure * 🚧 WIP create credential, delete credential complete * 🐛 fix route for creating api key * ⚡ return api key of authenticated user * ⚡ Expose public api activation to the settings * ⬆️ Update package-lock.json file * ⚡ Add execution resource * ⚡ Fix linting issues * 🛠 conditional public api endpoints excluding * ⚡️ create credential complete * ✨ Added n8n-card component. Added spacing utility classes. * ♻️ Made use of n8n-card in existing components. * ✨ Added api key setup view. * ✨ Added api keys get/create/delete actions. * ✨ Added public api permissions handling. * ♻️ Temporarily disabling card tests. * ♻️ Changed translations. Storing api key only in component. * ✨ Added utilities storybook entry * ♻️ Changed default value for generic copy input. * 🧹 clean up createCredential * ⚡ Add workflow resource to openapi spec * 🐛 Fix naming with env variable * ⚡ Allow multifile openapi spec * ⚡ Add POST /workflows/:workflowId/activate * fix up view, fix issues * remove delete api key modal * remove unused prop * clean up store api * remove getter * remove unused dispatch * fix component size to match * use existing components * match figma closely * fix bug when um is disabled in sidebar * set copy input color * remove unused import * ⚡ Remove css path * ⚡ Add POST /workflows/:workflowId/desactivate * ⚡ Add POST /workflows * Revert "⚡ Remove css path"a3d0a71719
* attempt to fix docker image issue * revert dockerfile test * disable public api * disable api differently * Revert "disable api differently"b70e29433e
* Revert "disable public api"886e5164fb
* remove unused box * ⚡ PUT /workflows/:workflowId * ⚡ Refactor workflow endpoints * ⚡ Refactor executions endpoints * ⚡ Fix typo * ✅ add credentials tests * ✅ adjust users tests * update text * add try it out link * ⚡ Add delete, getAll and get to the workflow resource * address spacing comments * ⚡️ apply correct structure * ⚡ Add missing test to user resource and fix some issues * ⚡ Add workflow tests * ⚡ Add missing workflow tests and fix some issues * ⚡ Executions tests * ⚡ finish execution tests * ⚡ Validate credentials data depending on type * ⚡️ implement review comments * 👕 fix lint issues * ⚡ Add apiKey to sanatizeUser * ⚡ Fix issues with spec and tests * ⚡ Add new structure * ⚡ Validate credentials type and properties * ⚡ Make all endpoints except /users independent on UM * ⚡ Add instance base path to swagger UI * ⚡ Remove testing endpoints * ⚡ Fix issue with openapi tags * ⚡ Add endpoint GET /credentialTypes/:id/schema * 🐛 Fix issue adding json middleware to public api * ⚡ Add API playground path to FE * ⚡ Add telemetry and external hooks * 🐛 Fix issue with user tests * ⚡ Move /credentialTypes under /credentials * ⚡ Add test to GET /credentials/schema/:id * 🛠 refactor schema naming * ⚡ Add DB migrations asas * ✅ add tests for crd apiKey * ✨ Added API View telemetry events. * ⚡ Remove rsync from the building process as it is missing on alpine base image * ⚡ add missing BE telemetry events * 🐛 Fix credential tests * ⚡ address outstanding feedback * 🔨 Remove move:openapi script * ⬆️ update dependency * ⬆️ update package-lock.json * 👕 Fix linting issue * 🐛 Fix package.json issue * 🐛 fix migrations and tests * 🐛 fix typos + naming * 🚧 WIP fixing tests * ⚡ Add json schema validation * ⚡ Add missing fields to node schema * ⚡ Add limit max upper limit * ⚡ Rename id paths * 🐛 Fix tests * Add package-lock.jsonto custom dockerfile * ⬆️ Update package-lock.json * 🐛 Fix issue with build * ✏️ add beta label to api view * 🔥 Remove user endpoints * ⚡ Add schema examples to GET /credentials/schema/:id * 🔥 Remove user endpoints tests * 🐛 Fix tests * 🎨 adapt points from design review * 🔥 remove unnecessary text-align * ⚡️ update UI * 🐛 Fix issue with executions filter * ⚡ Add tags filter to GET /workflows * ⚡ Add missing error messages * ✅ add and update public api tests * ✅ add tests for owner activiating/deactivating non-owned wfs * 🧪 add tests for filter for tags * 🧪 add tests for more filter params * 🐛 fix inclusion of tags * 🛠 enhance readability * ⚡️ small refactorings * 💄 improving readability/naming * ⚡ Set API latest version dinamically * Add comments to toJsonSchema function * ⚡ Fix issue * ⚡ Make execution data usable * ⚡ Fix validation issue * ⚡ Rename data field and change parameter and options * 🐛 Fix issue parameter "detailsFieldFormat" not resolving correctly * Skip executions tests * skip workflow failing test * Rename details property to data * ⚡ Add includeData parameter * 🐛 Fix issue with openapi spec * 🐛 Fix linting issue * ⚡ Fix execution schema Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Mutasem <mutdmour@gmail.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
412 lines
12 KiB
TypeScript
412 lines
12 KiB
TypeScript
import express from 'express';
|
|
import { UserSettings } from 'n8n-core';
|
|
import { Db } from '../../../src';
|
|
import { randomApiKey, randomName, randomString } from '../shared/random';
|
|
import * as utils from '../shared/utils';
|
|
import type { CredentialPayload, SaveCredentialFunction } from '../shared/types';
|
|
import type { Role } from '../../../src/databases/entities/Role';
|
|
import type { User } from '../../../src/databases/entities/User';
|
|
import * as testDb from '../shared/testDb';
|
|
import { RESPONSE_ERROR_MESSAGES } from '../../../src/constants';
|
|
|
|
jest.mock('../../../src/telemetry');
|
|
|
|
let app: express.Application;
|
|
let testDbName = '';
|
|
let globalOwnerRole: Role;
|
|
let globalMemberRole: Role;
|
|
let workflowOwnerRole: Role;
|
|
let credentialOwnerRole: Role;
|
|
|
|
let saveCredential: SaveCredentialFunction;
|
|
|
|
beforeAll(async () => {
|
|
app = await utils.initTestServer({ endpointGroups: ['publicApi'], applyAuth: false });
|
|
const initResult = await testDb.init();
|
|
testDbName = initResult.testDbName;
|
|
|
|
utils.initConfigFile();
|
|
|
|
const [
|
|
fetchedGlobalOwnerRole,
|
|
fetchedGlobalMemberRole,
|
|
fetchedWorkflowOwnerRole,
|
|
fetchedCredentialOwnerRole,
|
|
] = await testDb.getAllRoles();
|
|
|
|
globalOwnerRole = fetchedGlobalOwnerRole;
|
|
globalMemberRole = fetchedGlobalMemberRole;
|
|
workflowOwnerRole = fetchedWorkflowOwnerRole;
|
|
credentialOwnerRole = fetchedCredentialOwnerRole;
|
|
|
|
saveCredential = affixRoleToSaveCredential(credentialOwnerRole);
|
|
|
|
utils.initTestLogger();
|
|
utils.initTestTelemetry();
|
|
utils.initCredentialsTypes();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await testDb.truncate(['User', 'SharedCredentials', 'Credentials'], testDbName);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await testDb.terminate(testDbName);
|
|
});
|
|
|
|
test('POST /credentials should create credentials', async () => {
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
const payload = {
|
|
name: 'test credential',
|
|
type: 'githubApi',
|
|
data: {
|
|
accessToken: 'abcdefghijklmnopqrstuvwxyz',
|
|
user: 'test',
|
|
server: 'testServer',
|
|
},
|
|
};
|
|
|
|
const response = await authOwnerAgent.post('/credentials').send(payload);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, name, type } = response.body;
|
|
|
|
expect(name).toBe(payload.name);
|
|
expect(type).toBe(payload.type);
|
|
|
|
const credential = await Db.collections.Credentials!.findOneOrFail(id);
|
|
|
|
expect(credential.name).toBe(payload.name);
|
|
expect(credential.type).toBe(payload.type);
|
|
expect(credential.data).not.toBe(payload.data);
|
|
|
|
const sharedCredential = await Db.collections.SharedCredentials!.findOneOrFail({
|
|
relations: ['user', 'credentials', 'role'],
|
|
where: { credentials: credential, user: ownerShell },
|
|
});
|
|
|
|
expect(sharedCredential.role).toEqual(credentialOwnerRole);
|
|
expect(sharedCredential.credentials.name).toBe(payload.name);
|
|
});
|
|
|
|
test('POST /credentials should fail with invalid inputs', async () => {
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
|
|
await Promise.all(
|
|
INVALID_PAYLOADS.map(async (invalidPayload) => {
|
|
const response = await authOwnerAgent.post('/credentials').send(invalidPayload);
|
|
expect(response.statusCode === 400 || response.statusCode === 415).toBe(true);
|
|
}),
|
|
);
|
|
});
|
|
|
|
test('POST /credentials should fail with missing encryption key', async () => {
|
|
const mock = jest.spyOn(UserSettings, 'getEncryptionKey');
|
|
mock.mockRejectedValue(new Error(RESPONSE_ERROR_MESSAGES.NO_ENCRYPTION_KEY));
|
|
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post('/credentials').send(credentialPayload());
|
|
|
|
expect(response.statusCode).toBe(500);
|
|
|
|
mock.mockRestore();
|
|
});
|
|
|
|
test('DELETE /credentials/:id should delete owned cred for owner', async () => {
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
|
|
const savedCredential = await saveCredential(dbCredential(), { user: ownerShell });
|
|
|
|
const response = await authOwnerAgent.delete(`/credentials/${savedCredential.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { name, type } = response.body;
|
|
|
|
expect(name).toBe(savedCredential.name);
|
|
expect(type).toBe(savedCredential.type);
|
|
|
|
const deletedCredential = await Db.collections.Credentials!.findOne(savedCredential.id);
|
|
|
|
expect(deletedCredential).toBeUndefined(); // deleted
|
|
|
|
const deletedSharedCredential = await Db.collections.SharedCredentials!.findOne();
|
|
|
|
expect(deletedSharedCredential).toBeUndefined(); // deleted
|
|
});
|
|
|
|
test('DELETE /credentials/:id should delete non-owned cred for owner', async () => {
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
|
|
|
const savedCredential = await saveCredential(dbCredential(), { user: member });
|
|
|
|
const response = await authOwnerAgent.delete(`/credentials/${savedCredential.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const deletedCredential = await Db.collections.Credentials!.findOne(savedCredential.id);
|
|
|
|
expect(deletedCredential).toBeUndefined(); // deleted
|
|
|
|
const deletedSharedCredential = await Db.collections.SharedCredentials!.findOne();
|
|
|
|
expect(deletedSharedCredential).toBeUndefined(); // deleted
|
|
});
|
|
|
|
test('DELETE /credentials/:id should delete owned cred for member', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authMemberAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: member,
|
|
});
|
|
|
|
const savedCredential = await saveCredential(dbCredential(), { user: member });
|
|
|
|
const response = await authMemberAgent.delete(`/credentials/${savedCredential.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { name, type } = response.body;
|
|
|
|
expect(name).toBe(savedCredential.name);
|
|
expect(type).toBe(savedCredential.type);
|
|
|
|
const deletedCredential = await Db.collections.Credentials!.findOne(savedCredential.id);
|
|
|
|
expect(deletedCredential).toBeUndefined(); // deleted
|
|
|
|
const deletedSharedCredential = await Db.collections.SharedCredentials!.findOne();
|
|
|
|
expect(deletedSharedCredential).toBeUndefined(); // deleted
|
|
});
|
|
|
|
test('DELETE /credentials/:id should delete owned cred for member but leave others untouched', async () => {
|
|
const member1 = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
const member2 = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const savedCredential = await saveCredential(dbCredential(), { user: member1 });
|
|
const notToBeChangedCredential = await saveCredential(dbCredential(), { user: member1 });
|
|
const notToBeChangedCredential2 = await saveCredential(dbCredential(), { user: member2 });
|
|
|
|
const authMemberAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: member1,
|
|
});
|
|
|
|
const response = await authMemberAgent.delete(`/credentials/${savedCredential.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { name, type } = response.body;
|
|
|
|
expect(name).toBe(savedCredential.name);
|
|
expect(type).toBe(savedCredential.type);
|
|
|
|
const deletedCredential = await Db.collections.Credentials!.findOne(savedCredential.id);
|
|
|
|
expect(deletedCredential).toBeUndefined(); // deleted
|
|
|
|
const deletedSharedCredential = await Db.collections.SharedCredentials!.findOne({
|
|
where: {
|
|
credentials: savedCredential,
|
|
},
|
|
});
|
|
|
|
expect(deletedSharedCredential).toBeUndefined(); // deleted
|
|
|
|
await Promise.all(
|
|
[notToBeChangedCredential, notToBeChangedCredential2].map(async (credential) => {
|
|
const untouchedCredential = await Db.collections.Credentials!.findOne(credential.id);
|
|
|
|
expect(untouchedCredential).toEqual(credential); // not deleted
|
|
|
|
const untouchedSharedCredential = await Db.collections.SharedCredentials!.findOne({
|
|
where: {
|
|
credentials: credential,
|
|
},
|
|
});
|
|
|
|
expect(untouchedSharedCredential).toBeDefined(); // not deleted
|
|
}),
|
|
);
|
|
});
|
|
|
|
test('DELETE /credentials/:id should not delete non-owned cred for member', async () => {
|
|
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authMemberAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: member,
|
|
});
|
|
const savedCredential = await saveCredential(dbCredential(), { user: ownerShell });
|
|
|
|
const response = await authMemberAgent.delete(`/credentials/${savedCredential.id}`);
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
|
|
const shellCredential = await Db.collections.Credentials!.findOne(savedCredential.id);
|
|
|
|
expect(shellCredential).toBeDefined(); // not deleted
|
|
|
|
const deletedSharedCredential = await Db.collections.SharedCredentials!.findOne();
|
|
|
|
expect(deletedSharedCredential).toBeDefined(); // not deleted
|
|
});
|
|
|
|
test('DELETE /credentials/:id should fail if cred not found', async () => {
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
|
|
const response = await authOwnerAgent.delete('/credentials/123');
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
});
|
|
|
|
test('GET /credentials/schema/:credentialType should fail due to not found type', async () => {
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
|
|
const response = await authOwnerAgent.get('/credentials/schema/testing');
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
});
|
|
|
|
test('GET /credentials/schema/:credentialType should retrieve credential type', async () => {
|
|
let ownerShell = await testDb.createUserShell(globalOwnerRole);
|
|
ownerShell = await testDb.addApiKey(ownerShell);
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
version: 1,
|
|
auth: true,
|
|
user: ownerShell,
|
|
});
|
|
|
|
const response = await authOwnerAgent.get('/credentials/schema/githubApi');
|
|
|
|
const { additionalProperties, type, properties, required } = response.body;
|
|
|
|
expect(additionalProperties).toBe(false);
|
|
expect(type).toBe('object');
|
|
expect(properties.server).toBeDefined();
|
|
expect(properties.server.type).toBe('string');
|
|
expect(properties.user.type).toBeDefined();
|
|
expect(properties.user.type).toBe('string');
|
|
expect(properties.accessToken.type).toBeDefined();
|
|
expect(properties.accessToken.type).toBe('string');
|
|
expect(required).toEqual(expect.arrayContaining(['server', 'user', 'accessToken']));
|
|
expect(response.statusCode).toBe(200);
|
|
});
|
|
|
|
const credentialPayload = (): CredentialPayload => ({
|
|
name: randomName(),
|
|
type: 'githubApi',
|
|
data: {
|
|
accessToken: randomString(6, 16),
|
|
server: randomString(1, 10),
|
|
user: randomString(1, 10),
|
|
},
|
|
});
|
|
|
|
const dbCredential = () => {
|
|
const credential = credentialPayload();
|
|
credential.nodesAccess = [{ nodeType: credential.type }];
|
|
return credential;
|
|
};
|
|
|
|
const INVALID_PAYLOADS = [
|
|
{
|
|
type: randomName(),
|
|
data: { accessToken: randomString(6, 16) },
|
|
},
|
|
{
|
|
name: randomName(),
|
|
data: { accessToken: randomString(6, 16) },
|
|
},
|
|
{
|
|
name: randomName(),
|
|
type: randomName(),
|
|
},
|
|
{
|
|
name: randomName(),
|
|
type: 'githubApi',
|
|
data: {
|
|
server: randomName(),
|
|
},
|
|
},
|
|
{},
|
|
[],
|
|
undefined,
|
|
];
|
|
|
|
function affixRoleToSaveCredential(role: Role) {
|
|
return (credentialPayload: CredentialPayload, { user }: { user: User }) =>
|
|
testDb.saveCredential(credentialPayload, { user, role });
|
|
}
|