mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-28 05:59:42 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
n8n/packages/cli/src
History
Iván Ovejero 33991e92d0
fix(core): Fix missing execution ID in webhook-based workflow producing binary data (#7244) 
Story: https://linear.app/n8n/issue/PAY-839

This is a longstanding bug, fixed now so that the S3 backend for binary
data can use execution IDs as part of the filename.

To reproduce:

1. Set up a workflow with a POST Webhook node that accepts binary data.
2. Activate the workflow and call it sending a binary file, e.g. `curl
-X POST -F "file=@/path/to/binary/file/test.jpg"
http://localhost:5678/webhook/uuid`
3. Check `~/.n8n/binaryData`. The binary data and metadata files will be
missing the execution ID, e.g. `11869055-83c4-4493-876a-9092c4708b9b`
instead of `39011869055-83c4-4493-876a-9092c4708b9b`.
2023-09-25 12:30:28 +02:00
..
audit refactor: Move community package logic to service (no-changelog) (#6973) 2023-09-01 15:13:19 +02:00
auth refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
commands refactor(core): Generalize binary data manager interface (no-changelog) (#7164) 2023-09-22 17:22:12 +02:00
config refactor(core): Generalize binary data manager interface (no-changelog) (#7164) 2023-09-22 17:22:12 +02:00
controllers fix: Issue enforcing user limits on start plan (#7188) 2023-09-21 05:56:40 -04:00
credentials feat(core): Add list query middleware to credentials (#7041) 2023-09-04 15:00:25 +02:00
databases refactor(core): Generalize binary data manager interface (no-changelog) (#7164) 2023-09-22 17:22:12 +02:00
decorators refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
environments feat(core): Add rsa option to ssh key generation (#7154) 2023-09-14 11:34:51 +02:00
eventbus feat(core): Add command to trigger license refresh on workers (#7184) 2023-09-17 11:05:54 +02:00
executionLifecycleHooks fix(core): Fix missing execution ID in webhook-based workflow producing binary data (#7244) 2023-09-25 12:30:28 +02:00
executions refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
ExternalSecrets feat: External Secrets storage for credentials (#6477) 2023-08-25 10:33:46 +02:00
Ldap refactor(core): Remove slow LDAP query and unused telemetry event (#7068) 2023-09-01 12:05:14 +02:00
license refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
Mfa ci: Fix occasionally failing MFA e2e test (no-changelog) (#7040) 2023-08-29 15:39:10 +02:00
middlewares feat(HTTP Request Node): Determine binary file name from content-disposition headers (#7032) 2023-09-06 12:38:37 +02:00
posthog refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041) 2023-04-24 13:17:08 +02:00
PublicApi refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
push fix(core): Setup websocket keep-live messages (#6866) 2023-08-28 10:26:27 +02:00
services feat(core): Add command to trigger license refresh on workers (#7184) 2023-09-17 11:05:54 +02:00
sso refactor: Upgrade to Prettier 3 (no-changelog) (#6947) 2023-08-16 17:13:57 +02:00
telemetry feat: Remove PostHog event calls (#6915) 2023-08-17 11:39:32 -04:00
types refactor: Move CLI commands types to own dir (no-changelog) (#6658) 2023-07-13 10:10:08 +02:00
UserManagement feat(core): Add filtering, selection and pagination to users (#6994) 2023-08-28 16:13:17 +02:00
worker feat(core): Add command to trigger license refresh on workers (#7184) 2023-09-17 11:05:54 +02:00
workflows feat: Add workflow history repository files (no-changelog) (#7071) 2023-09-06 12:23:40 +02:00
AbstractServer.ts fix(core): Ignore missing user-agent on bot check (no-changelog) (#7153) 2023-09-12 19:57:25 +02:00
ActiveExecutions.ts refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
ActiveWebhooks.ts refactor(core): Delete some duplicate code between ActiveWebhooks and ActiveWorkflowRunner (no-changelog) (#6951) 2023-08-17 17:18:14 +02:00
ActiveWorkflowRunner.ts refactor(core): Move static data handling to workflow service (no-changelog) (#7104) 2023-09-05 13:42:31 +02:00
constants.ts refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
CrashJournal.ts fix: Enable crash journal only in production mode (no-changelog) (#4948) 2022-12-16 15:27:49 +01:00
CredentialsHelper.ts feat: External Secrets storage for credentials (#6477) 2023-08-25 10:33:46 +02:00
CredentialsOverwrites.ts ci: Fix linting issues (no-changelog) (#6788) 2023-07-28 18:28:17 +02:00
CredentialTypes.ts fix(core): Fix credentials lazy-loading (no-changelog) (#6615) 2023-07-10 17:57:26 +02:00
curlconverter.d.ts refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
CurlConverterHelper.ts refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
Db.ts feat: Add workflow history repository files (no-changelog) (#7071) 2023-09-06 12:23:40 +02:00
ErrorReporting.ts fix(HTTP Request Node): Improve error handling for TCP socket errors when Continue On Fail is enabled (#6925) 2023-08-14 17:26:40 +02:00
ExpressionEvalator.ts feat(core): Add Tournament as the new default expression evaluator (#6964) 2023-09-21 13:57:45 +01:00
ExternalHooks.ts refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
GenericHelpers.ts refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
index.ts ci: Refactor cli tests to speed up CI (no-changelog) (#5718) 2023-03-17 17:24:05 +01:00
Interfaces.ts refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
InternalHooks.ts refactor(core): Move event and telemetry handling into workers in queue mode (#7138) 2023-09-14 07:58:15 +02:00
jest.d.ts feat(core): Security audit (#5034) 2023-01-05 13:28:40 +01:00
License.ts fix: Attempt license renewal when n8n starts (no-changelog) (#7204) 2023-09-19 12:10:23 +02:00
LoadNodesAndCredentials.ts refactor: Move community package logic to service (no-changelog) (#6973) 2023-09-01 15:13:19 +02:00
Logger.ts refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
NodeTypes.ts refactor: Move node i18n logic to NodeTypes (no-changelog) (#7035) 2023-08-29 10:46:24 +02:00
Queue.ts refactor(core): Move event and telemetry handling into workers in queue mode (#7138) 2023-09-14 07:58:15 +02:00
ReloadNodesAndCredentials.ts refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
requests.ts feat(core): Add commands to workers to respond with current state (#7029) 2023-09-07 14:44:19 +02:00
ResponseHelper.ts feat(core): Add MFA (#4767) 2023-08-23 22:59:16 -04:00
SecretsHelpers.ts feat: External Secrets storage for credentials (#6477) 2023-08-25 10:33:46 +02:00
Server.ts refactor(core): Generalize binary data manager interface (no-changelog) (#7164) 2023-09-22 17:22:12 +02:00
sse-channel.d.ts feat(core): Add support for WebSockets as an alternative to Server-Sent Events (#5443) 2023-02-10 15:02:47 +01:00
TestWebhooks.ts fix(Webhook Node): Fix URL params for webhooks (#6986) 2023-08-25 13:28:32 +02:00
utils.ts fix(core): Set up OAuth2 cred test (#6960) 2023-08-18 16:18:44 +02:00
WaitingWebhooks.ts fix(Webhook Node): Fix URL params for webhooks (#6986) 2023-08-25 13:28:32 +02:00
WaitTracker.ts refactor(core): Cache workflow ownership (#6738) 2023-07-31 11:37:09 +02:00
WebhookHelpers.ts refactor(core): Generalize binary data manager interface (no-changelog) (#7164) 2023-09-22 17:22:12 +02:00
WebhookServer.ts feat(core): Add unique id to instances (#6863) 2023-08-07 17:03:21 +02:00
WorkflowCredentials.ts refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798) 2023-07-31 11:00:48 +02:00
WorkflowExecuteAdditionalData.ts fix(core): Fix missing execution ID in webhook-based workflow producing binary data (#7244) 2023-09-25 12:30:28 +02:00
WorkflowHelpers.ts refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
WorkflowRunner.ts refactor(core): Implement soft-deletions for executions (#7092) 2023-09-20 15:21:42 +02:00
WorkflowRunnerProcess.ts refactor(core): Generalize binary data manager interface (no-changelog) (#7164) 2023-09-22 17:22:12 +02:00