mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 09:04:07 -08:00
071e6d6b6e
## Summary <img width="1240" alt="image" src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a"> <img width="2649" alt="image" src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe"> 1. Add code node and open it 3. Click the fullscreen button in the bottom right 4. A fullscreen dialog should appear and allow editing the code 5. Changes made in the fullscreen dialog should be applied to the original code editor when closed It should work the same way for HTML/SQL/JSON editors ⚠️ Modal layout was updated so that modals/dialogs are centered, try to test some modals ## Related tickets and issues https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Giulio Andreini <andreini@netseven.it>
91 lines
2.5 KiB
TypeScript
91 lines
2.5 KiB
TypeScript
import type {
|
|
IDataObject,
|
|
IExecuteFunctions,
|
|
INodeExecutionData,
|
|
INodeProperties,
|
|
} from 'n8n-workflow';
|
|
import { NodeOperationError } from 'n8n-workflow';
|
|
|
|
import type { QueryRunner, QueryWithValues } from '../../helpers/interfaces';
|
|
|
|
import { prepareQueryAndReplacements, replaceEmptyStringsByNulls } from '../../helpers/utils';
|
|
|
|
import { optionsCollection } from '../common.descriptions';
|
|
import { getResolvables, updateDisplayOptions } from '@utils/utilities';
|
|
|
|
const properties: INodeProperties[] = [
|
|
{
|
|
displayName: 'Query',
|
|
name: 'query',
|
|
type: 'string',
|
|
default: '',
|
|
placeholder: 'e.g. SELECT id, name FROM product WHERE id < 40',
|
|
required: true,
|
|
description:
|
|
"The SQL query to execute. You can use n8n expressions and $1, $2, $3, etc to refer to the 'Query Parameters' set in options below.",
|
|
noDataExpression: true,
|
|
typeOptions: {
|
|
editor: 'sqlEditor',
|
|
sqlDialect: 'MySQL',
|
|
},
|
|
hint: 'Consider using query parameters to prevent SQL injection attacks. Add them in the options below',
|
|
},
|
|
optionsCollection,
|
|
];
|
|
|
|
const displayOptions = {
|
|
show: {
|
|
resource: ['database'],
|
|
operation: ['executeQuery'],
|
|
},
|
|
};
|
|
|
|
export const description = updateDisplayOptions(displayOptions, properties);
|
|
|
|
export async function execute(
|
|
this: IExecuteFunctions,
|
|
inputItems: INodeExecutionData[],
|
|
runQueries: QueryRunner,
|
|
nodeOptions: IDataObject,
|
|
): Promise<INodeExecutionData[]> {
|
|
let returnData: INodeExecutionData[] = [];
|
|
const items = replaceEmptyStringsByNulls(inputItems, nodeOptions.replaceEmptyStrings as boolean);
|
|
|
|
const queries: QueryWithValues[] = [];
|
|
|
|
for (let i = 0; i < items.length; i++) {
|
|
let rawQuery = this.getNodeParameter('query', i) as string;
|
|
|
|
for (const resolvable of getResolvables(rawQuery)) {
|
|
rawQuery = rawQuery.replace(resolvable, this.evaluateExpression(resolvable, i) as string);
|
|
}
|
|
|
|
const options = this.getNodeParameter('options', i, {});
|
|
|
|
let values;
|
|
let queryReplacement = options.queryReplacement || [];
|
|
|
|
if (typeof queryReplacement === 'string') {
|
|
queryReplacement = queryReplacement.split(',').map((entry) => entry.trim());
|
|
}
|
|
|
|
if (Array.isArray(queryReplacement)) {
|
|
values = queryReplacement as IDataObject[];
|
|
} else {
|
|
throw new NodeOperationError(
|
|
this.getNode(),
|
|
'Query Replacement must be a string of comma-separated values, or an array of values',
|
|
{ itemIndex: i },
|
|
);
|
|
}
|
|
|
|
const preparedQuery = prepareQueryAndReplacements(rawQuery, values);
|
|
|
|
queries.push(preparedQuery);
|
|
}
|
|
|
|
returnData = await runQueries(queries);
|
|
|
|
return returnData;
|
|
}
|