mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-27 13:39:44 -08:00
071e6d6b6e
## Summary <img width="1240" alt="image" src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a"> <img width="2649" alt="image" src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe"> 1. Add code node and open it 3. Click the fullscreen button in the bottom right 4. A fullscreen dialog should appear and allow editing the code 5. Changes made in the fullscreen dialog should be applied to the original code editor when closed It should work the same way for HTML/SQL/JSON editors ⚠️ Modal layout was updated so that modals/dialogs are centered, try to test some modals ## Related tickets and issues https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Giulio Andreini <andreini@netseven.it>
77 lines
1.7 KiB
TypeScript
77 lines
1.7 KiB
TypeScript
import type { INodeProperties } from 'n8n-workflow';
|
|
|
|
const commonDescription: INodeProperties = {
|
|
displayName: 'JavaScript',
|
|
name: 'jsCode',
|
|
type: 'string',
|
|
typeOptions: {
|
|
editor: 'codeNodeEditor',
|
|
editorLanguage: 'javaScript',
|
|
},
|
|
default: '',
|
|
description:
|
|
'JavaScript code to execute.<br><br>Tip: You can use luxon vars like <code>$today</code> for dates and <code>$jmespath</code> for querying JSON structures. <a href="https://docs.n8n.io/nodes/n8n-nodes-base.function">Learn more</a>.',
|
|
noDataExpression: true,
|
|
};
|
|
|
|
const v1Properties: INodeProperties[] = [
|
|
{
|
|
...commonDescription,
|
|
displayOptions: {
|
|
show: {
|
|
'@version': [1],
|
|
mode: ['runOnceForAllItems'],
|
|
},
|
|
},
|
|
},
|
|
{
|
|
...commonDescription,
|
|
displayOptions: {
|
|
show: {
|
|
'@version': [1],
|
|
mode: ['runOnceForEachItem'],
|
|
},
|
|
},
|
|
},
|
|
];
|
|
|
|
const v2Properties: INodeProperties[] = [
|
|
{
|
|
...commonDescription,
|
|
displayOptions: {
|
|
show: {
|
|
'@version': [2],
|
|
language: ['javaScript'],
|
|
mode: ['runOnceForAllItems'],
|
|
},
|
|
},
|
|
},
|
|
{
|
|
...commonDescription,
|
|
displayOptions: {
|
|
show: {
|
|
'@version': [2],
|
|
language: ['javaScript'],
|
|
mode: ['runOnceForEachItem'],
|
|
},
|
|
},
|
|
},
|
|
];
|
|
|
|
export const javascriptCodeDescription: INodeProperties[] = [
|
|
...v1Properties,
|
|
...v2Properties,
|
|
{
|
|
displayName:
|
|
'Type <code>$</code> for a list of <a target="_blank" href="https://docs.n8n.io/code-examples/methods-variables-reference/">special vars/methods</a>. Debug by using <code>console.log()</code> statements and viewing their output in the browser console.',
|
|
name: 'notice',
|
|
type: 'notice',
|
|
displayOptions: {
|
|
show: {
|
|
language: ['javaScript'],
|
|
},
|
|
},
|
|
default: '',
|
|
},
|
|
];
|