mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-16 01:24:05 -08:00
1d27a9e87e
* Add path mapping and response error interfaces * Add error handling and throwing functionality * Refactor error handling into a single function * Re-implement error handling in Hacker News node * Fix linting details * Re-implement error handling in Spotify node * Re-implement error handling in G Suite Admin node * 🚧 create basic setup NodeError * 🚧 add httpCodes * 🚧 add path priolist * 🚧 handle statusCode in error, adjust interfaces * 🚧 fixing type issues w/Ivan * 🚧 add error exploration * 👔 fix linter issues * 🔧 improve object check * 🚧 remove path passing from NodeApiError * 🚧 add multi error + refactor findProperty method * 👔 allow any * 🔧 handle multi error message callback * ⚡ change return type of callback * ⚡ add customCallback to MultiError * 🚧 refactor to use INode * 🔨 handle arrays, continue search after first null property found * 🚫 refactor method access * 🚧 setup NodeErrorView * ⚡ change timestamp to Date.now * 📚 Add documentation for methods and constants * 🚧 change message setting * 🚚 move NodeErrors to workflow * ✨ add new ErrorView for Nodes * 🎨 improve error notification * 🎨 refactor interfaces * ⚡ add WorkflowOperationError, refactor error throwing * 👕 fix linter issues * 🎨 rename param * 🐛 fix handling normal errors * ⚡ add usage of NodeApiError * 🎨 fix throw new error instead of constructor * 🎨 remove unnecessary code/comments * 🎨 adjusted spacing + updated status messages * 🎨 fix tab indentation * ✨ Replace current errors with custom errors (#1576) * ⚡ Introduce NodeApiError in catch blocks * ⚡ Introduce NodeOperationError in nodes * ⚡ Add missing errors and remove incompatible * ⚡ Fix NodeOperationError in incompatible nodes * 🔧 Adjust error handling in missed nodes PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes * 🔨 Adjust Strava Trigger node error handling * 🔨 Adjust AWS nodes error handling * 🔨 Remove duplicate instantiation of NodeApiError * 🐛 fix strava trigger node error handling * Add XML parsing to NodeApiError constructor (#1633) * 🐛 Remove type annotation from catch variable * ✨ Add XML parsing to NodeApiError * ⚡ Simplify error handling in Rekognition node * ⚡ Pass in XML flag in generic functions * 🔥 Remove try/catch wrappers at call sites * 🔨 Refactor setting description from XML * 🔨 Refactor let to const in resource loaders * ⚡ Find property in parsed XML * ⚡ Change let to const * 🔥 Remove unneeded try/catch block * 👕 Fix linting issues * 🐛 Fix errors from merge conflict resolution * ⚡ Add custom errors to latest contributions * 👕 Fix linting issues * ⚡ Refactor MongoDB helpers for custom errors * 🐛 Correct custom error type * ⚡ Apply feedback to A nodes * ⚡ Apply feedback to missed A node * ⚡ Apply feedback to B-D nodes * ⚡ Apply feedback to E-F nodes * ⚡ Apply feedback to G nodes * ⚡ Apply feedback to H-L nodes * ⚡ Apply feedback to M nodes * ⚡ Apply feedback to P nodes * ⚡ Apply feedback to R nodes * ⚡ Apply feedback to S nodes * ⚡ Apply feedback to T nodes * ⚡ Apply feedback to V-Z nodes * ⚡ Add HTTP code to iterable node error * 🔨 Standardize e as error * 🔨 Standardize err as error * ⚡ Fix error handling for non-standard nodes Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
264 lines
7 KiB
TypeScript
264 lines
7 KiB
TypeScript
import {
|
|
IExecuteFunctions,
|
|
IHookFunctions,
|
|
} from 'n8n-core';
|
|
|
|
import {
|
|
IDataObject,
|
|
ILoadOptionsFunctions,
|
|
NodeApiError,
|
|
NodeOperationError,
|
|
} from 'n8n-workflow';
|
|
|
|
import {
|
|
OptionsWithUri,
|
|
} from 'request';
|
|
|
|
export interface ICustomInterface {
|
|
name: string;
|
|
key: string;
|
|
options?: Array<{
|
|
id: number;
|
|
label: string;
|
|
}>;
|
|
}
|
|
|
|
export interface ICustomProperties {
|
|
[key: string]: ICustomInterface;
|
|
}
|
|
|
|
/**
|
|
* Make an API request to Pipedrive
|
|
*
|
|
* @param {IHookFunctions} this
|
|
* @param {string} method
|
|
* @param {string} url
|
|
* @param {object} body
|
|
* @returns {Promise<any>}
|
|
*/
|
|
export async function pipedriveApiRequest(this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions, method: string, endpoint: string, body: IDataObject, query: IDataObject = {}, formData?: IDataObject, downloadFile?: boolean): Promise<any> { // tslint:disable-line:no-any
|
|
const authenticationMethod = this.getNodeParameter('authentication', 0);
|
|
|
|
const options: OptionsWithUri = {
|
|
headers: {
|
|
Accept: 'application/json',
|
|
},
|
|
method,
|
|
qs: query,
|
|
uri: `https://api.pipedrive.com/v1${endpoint}`,
|
|
};
|
|
|
|
if (downloadFile === true) {
|
|
options.encoding = null;
|
|
} else {
|
|
options.json = true;
|
|
}
|
|
|
|
if (Object.keys(body).length !== 0) {
|
|
options.body = body;
|
|
}
|
|
|
|
if (formData !== undefined && Object.keys(formData).length !== 0) {
|
|
options.formData = formData;
|
|
}
|
|
|
|
if (query === undefined) {
|
|
query = {};
|
|
}
|
|
|
|
let responseData;
|
|
|
|
try {
|
|
if (authenticationMethod === 'basicAuth' || authenticationMethod === 'apiToken' || authenticationMethod === 'none') {
|
|
|
|
const credentials = this.getCredentials('pipedriveApi');
|
|
if (credentials === undefined) {
|
|
throw new NodeOperationError(this.getNode(), 'No credentials got returned!');
|
|
}
|
|
|
|
query.api_token = credentials.apiToken;
|
|
//@ts-ignore
|
|
responseData = await this.helpers.request(options);
|
|
|
|
} else {
|
|
responseData = await this.helpers.requestOAuth2!.call(this, 'pipedriveOAuth2Api', options);
|
|
}
|
|
|
|
if (downloadFile === true) {
|
|
return {
|
|
data: responseData,
|
|
};
|
|
}
|
|
|
|
if (responseData.success === false) {
|
|
throw new NodeApiError(this.getNode(), responseData);
|
|
}
|
|
|
|
return {
|
|
additionalData: responseData.additional_data,
|
|
data: responseData.data,
|
|
};
|
|
} catch(error) {
|
|
throw new NodeApiError(this.getNode(), error);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Make an API request to paginated Pipedrive endpoint
|
|
* and return all results
|
|
*
|
|
* @export
|
|
* @param {(IHookFunctions | IExecuteFunctions)} this
|
|
* @param {string} method
|
|
* @param {string} endpoint
|
|
* @param {IDataObject} body
|
|
* @param {IDataObject} [query]
|
|
* @returns {Promise<any>}
|
|
*/
|
|
export async function pipedriveApiRequestAllItems(this: IHookFunctions | IExecuteFunctions, method: string, endpoint: string, body: IDataObject, query?: IDataObject): Promise<any> { // tslint:disable-line:no-any
|
|
|
|
if (query === undefined) {
|
|
query = {};
|
|
}
|
|
query.limit = 100;
|
|
query.start = 0;
|
|
|
|
const returnData: IDataObject[] = [];
|
|
|
|
let responseData;
|
|
|
|
do {
|
|
responseData = await pipedriveApiRequest.call(this, method, endpoint, body, query);
|
|
// the search path returns data diferently
|
|
if (responseData.data.items) {
|
|
returnData.push.apply(returnData, responseData.data.items);
|
|
} else {
|
|
returnData.push.apply(returnData, responseData.data);
|
|
}
|
|
|
|
query.start = responseData.additionalData.pagination.next_start;
|
|
} while (
|
|
responseData.additionalData !== undefined &&
|
|
responseData.additionalData.pagination !== undefined &&
|
|
responseData.additionalData.pagination.more_items_in_collection === true
|
|
);
|
|
|
|
return {
|
|
data: returnData,
|
|
};
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
* Gets the custom properties from Pipedrive
|
|
*
|
|
* @export
|
|
* @param {(IHookFunctions | IExecuteFunctions)} this
|
|
* @param {string} resource
|
|
* @returns {Promise<ICustomProperties>}
|
|
*/
|
|
export async function pipedriveGetCustomProperties(this: IHookFunctions | IExecuteFunctions, resource: string): Promise<ICustomProperties> {
|
|
|
|
const endpoints: { [key: string]: string } = {
|
|
'activity': '/activityFields',
|
|
'deal': '/dealFields',
|
|
'organization': '/organizationFields',
|
|
'person': '/personFields',
|
|
'product': '/productFields',
|
|
};
|
|
|
|
if (endpoints[resource] === undefined) {
|
|
throw new NodeOperationError(this.getNode(), `The resource "${resource}" is not supported for resolving custom values!`);
|
|
}
|
|
|
|
const requestMethod = 'GET';
|
|
|
|
const body = {};
|
|
const qs = {};
|
|
// Get the custom properties and their values
|
|
const responseData = await pipedriveApiRequest.call(this, requestMethod, endpoints[resource], body, qs);
|
|
|
|
const customProperties: ICustomProperties = {};
|
|
|
|
for (const customPropertyData of responseData.data) {
|
|
customProperties[customPropertyData.key] = customPropertyData;
|
|
}
|
|
|
|
return customProperties;
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
* Converts names and values of custom properties from their actual values to the
|
|
* Pipedrive internal ones
|
|
*
|
|
* @export
|
|
* @param {ICustomProperties} customProperties
|
|
* @param {IDataObject} item
|
|
*/
|
|
export function pipedriveEncodeCustomProperties(customProperties: ICustomProperties, item: IDataObject): void {
|
|
let customPropertyData;
|
|
|
|
for (const key of Object.keys(item)) {
|
|
customPropertyData = Object.values(customProperties).find(customPropertyData => customPropertyData.name === key);
|
|
|
|
if (customPropertyData !== undefined) {
|
|
// Is a custom property
|
|
|
|
// Check if also the value has to be resolved or just the key
|
|
if (item[key] !== null && item[key] !== undefined && customPropertyData.options !== undefined && Array.isArray(customPropertyData.options)) {
|
|
// Has an option key so get the actual option-value
|
|
const propertyOption = customPropertyData.options.find(option => option.label.toString() === item[key]!.toString());
|
|
|
|
if (propertyOption !== undefined) {
|
|
item[customPropertyData.key as string] = propertyOption.id;
|
|
delete item[key];
|
|
}
|
|
} else {
|
|
// Does already represent the actual value or is null
|
|
item[customPropertyData.key as string] = item[key];
|
|
delete item[key];
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
* Converts names and values of custom properties to their actual values
|
|
*
|
|
* @export
|
|
* @param {ICustomProperties} customProperties
|
|
* @param {IDataObject} item
|
|
*/
|
|
export function pipedriveResolveCustomProperties(customProperties: ICustomProperties, item: IDataObject): void {
|
|
let customPropertyData;
|
|
|
|
// Itterate over all keys and replace the custom ones
|
|
for (const key of Object.keys(item)) {
|
|
if (customProperties[key] !== undefined) {
|
|
// Is a custom property
|
|
customPropertyData = customProperties[key];
|
|
|
|
// Check if also the value has to be resolved or just the key
|
|
if (item[key] !== null && item[key] !== undefined && customPropertyData.options !== undefined && Array.isArray(customPropertyData.options)) {
|
|
// Has an option key so get the actual option-value
|
|
const propertyOption = customPropertyData.options.find(option => option.id.toString() === item[key]!.toString());
|
|
|
|
if (propertyOption !== undefined) {
|
|
item[customPropertyData.name as string] = propertyOption.label;
|
|
delete item[key];
|
|
}
|
|
} else {
|
|
// Does already represent the actual value or is null
|
|
item[customPropertyData.name as string] = item[key];
|
|
delete item[key];
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|