mirror of
https://github.com/n8n-io/n8n.git
synced 2025-02-02 07:01:30 -08:00
6d6e2488c6
Depends on: #7092 | Story: [PAY-768](https://linear.app/n8n/issue/PAY-768) This PR: - Generalizes the `IBinaryDataManager` interface. - Adjusts `Filesystem.ts` to satisfy the interface. - Sets up an S3 client stub to be filled in in the next PR. - Turns `BinaryDataManager` into an injectable service. - Adjusts the config schema and adds new validators. Note that the PR looks large but all the main changes are in `packages/core/src/binaryData`. Out of scope: - `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now `fs.client.ts`) were slightly refactored for maintainability, but fully overhauling them is **not** the focus of this PR, which is meant to clear the way for the S3 implementation. Future improvements for these two should include setting up a backwards-compatible dir structure that makes it easier to locate binary data files to delete, removing duplication, simplifying cloning methods, using integers for binary data size instead of `prettyBytes()`, writing tests for existing binary data logic, etc. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
82 lines
3.5 KiB
TypeScript
82 lines
3.5 KiB
TypeScript
import { mockInstance } from '../shared/utils/';
|
|
import { Worker } from '@/commands/worker';
|
|
import * as Config from '@oclif/config';
|
|
import { LoggerProxy } from 'n8n-workflow';
|
|
import { Telemetry } from '@/telemetry';
|
|
import { getLogger } from '@/Logger';
|
|
import { ExternalSecretsManager } from '@/ExternalSecrets/ExternalSecretsManager.ee';
|
|
import { BinaryDataService } from 'n8n-core';
|
|
import { CacheService } from '@/services/cache.service';
|
|
import { RedisServicePubSubPublisher } from '@/services/redis/RedisServicePubSubPublisher';
|
|
import { RedisServicePubSubSubscriber } from '@/services/redis/RedisServicePubSubSubscriber';
|
|
import { MessageEventBus } from '@/eventbus/MessageEventBus/MessageEventBus';
|
|
import { LoadNodesAndCredentials } from '@/LoadNodesAndCredentials';
|
|
import { CredentialTypes } from '@/CredentialTypes';
|
|
import { NodeTypes } from '@/NodeTypes';
|
|
import { InternalHooks } from '@/InternalHooks';
|
|
import { PostHogClient } from '@/posthog';
|
|
import { RedisService } from '@/services/redis.service';
|
|
|
|
const config: Config.IConfig = new Config.Config({ root: __dirname });
|
|
|
|
beforeAll(async () => {
|
|
LoggerProxy.init(getLogger());
|
|
mockInstance(Telemetry);
|
|
mockInstance(PostHogClient);
|
|
mockInstance(InternalHooks);
|
|
mockInstance(CacheService);
|
|
mockInstance(ExternalSecretsManager);
|
|
mockInstance(BinaryDataService);
|
|
mockInstance(MessageEventBus);
|
|
mockInstance(LoadNodesAndCredentials);
|
|
mockInstance(CredentialTypes);
|
|
mockInstance(NodeTypes);
|
|
mockInstance(RedisService);
|
|
mockInstance(RedisServicePubSubPublisher);
|
|
mockInstance(RedisServicePubSubSubscriber);
|
|
});
|
|
|
|
test('worker initializes all its components', async () => {
|
|
const worker = new Worker([], config);
|
|
|
|
jest.spyOn(worker, 'init');
|
|
jest.spyOn(worker, 'initLicense').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initBinaryDataService').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initExternalHooks').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initExternalSecrets').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initEventBus').mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initRedis');
|
|
jest.spyOn(RedisServicePubSubPublisher.prototype, 'init').mockImplementation(async () => {});
|
|
jest
|
|
.spyOn(RedisServicePubSubPublisher.prototype, 'publishToEventLog')
|
|
.mockImplementation(async () => {});
|
|
jest
|
|
.spyOn(RedisServicePubSubSubscriber.prototype, 'subscribeToCommandChannel')
|
|
.mockImplementation(async () => {});
|
|
jest
|
|
.spyOn(RedisServicePubSubSubscriber.prototype, 'addMessageHandler')
|
|
.mockImplementation(async () => {});
|
|
jest.spyOn(worker, 'initQueue').mockImplementation(async () => {});
|
|
|
|
await worker.init();
|
|
|
|
expect(worker.uniqueInstanceId).toBeDefined();
|
|
expect(worker.uniqueInstanceId).toContain('worker');
|
|
expect(worker.uniqueInstanceId.length).toBeGreaterThan(15);
|
|
expect(worker.initLicense).toHaveBeenCalled();
|
|
expect(worker.initBinaryDataService).toHaveBeenCalled();
|
|
expect(worker.initExternalHooks).toHaveBeenCalled();
|
|
expect(worker.initExternalSecrets).toHaveBeenCalled();
|
|
expect(worker.initEventBus).toHaveBeenCalled();
|
|
expect(worker.initRedis).toHaveBeenCalled();
|
|
expect(worker.redisPublisher).toBeDefined();
|
|
expect(worker.redisPublisher.init).toHaveBeenCalled();
|
|
expect(worker.redisPublisher.publishToEventLog).toHaveBeenCalled();
|
|
expect(worker.redisSubscriber).toBeDefined();
|
|
expect(worker.redisSubscriber.subscribeToCommandChannel).toHaveBeenCalled();
|
|
expect(worker.redisSubscriber.addMessageHandler).toHaveBeenCalled();
|
|
expect(worker.initQueue).toHaveBeenCalled();
|
|
|
|
jest.restoreAllMocks();
|
|
});
|