mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 09:04:07 -08:00
dd6a4c956a
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571)
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578)
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579)
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697)
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716)
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576)
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744)
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742)
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743)
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748)
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749)
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750)
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752)
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753)
* fix: removed console.log (#6754)
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755)
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758)
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760)
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764)
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f
* fix: lint
* fix(editor): Fix collapsed sub menu
* fix: Fix drawer animation (#6767)
fix: drawer animation
* fix(editor): Fix source control buttons (#6769)
* fix(editor): Fix App loading & auth (#6768)
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
273 lines
6.4 KiB
Vue
273 lines
6.4 KiB
Vue
<script lang="ts" setup>
|
|
import type { ComponentPublicInstance, PropType } from 'vue';
|
|
import { computed, nextTick, onMounted, ref, watch } from 'vue';
|
|
import type { EnvironmentVariable, Rule, RuleGroup } from '@/Interface';
|
|
import { useI18n, useToast, useCopyToClipboard } from '@/composables';
|
|
import { EnterpriseEditionFeature } from '@/constants';
|
|
import { useSettingsStore, useUsersStore } from '@/stores';
|
|
import { getVariablesPermissions } from '@/permissions';
|
|
|
|
const i18n = useI18n();
|
|
const copyToClipboard = useCopyToClipboard();
|
|
const { showMessage } = useToast();
|
|
const settingsStore = useSettingsStore();
|
|
const usersStore = useUsersStore();
|
|
|
|
const emit = defineEmits(['save', 'cancel', 'edit', 'delete']);
|
|
|
|
const props = defineProps({
|
|
data: {
|
|
type: Object as PropType<EnvironmentVariable>,
|
|
default: () => ({}),
|
|
},
|
|
editing: {
|
|
type: Boolean,
|
|
default: false,
|
|
},
|
|
});
|
|
|
|
const permissions = getVariablesPermissions(usersStore.currentUser);
|
|
const modelValue = ref<EnvironmentVariable>({ ...props.data });
|
|
|
|
const formValidationStatus = ref<Record<string, boolean>>({
|
|
key: false,
|
|
value: false,
|
|
});
|
|
const formValid = computed(() => {
|
|
return formValidationStatus.value.key && formValidationStatus.value.value;
|
|
});
|
|
|
|
const keyInputRef = ref<ComponentPublicInstance & { inputRef?: HTMLElement }>();
|
|
const valueInputRef = ref<HTMLElement>();
|
|
|
|
const usage = ref(`$vars.${props.data.key}`);
|
|
|
|
const isFeatureEnabled = computed(() =>
|
|
settingsStore.isEnterpriseFeatureEnabled(EnterpriseEditionFeature.Variables),
|
|
);
|
|
|
|
const showActions = computed(
|
|
() => isFeatureEnabled.value && (permissions.edit || permissions.delete),
|
|
);
|
|
|
|
onMounted(() => {
|
|
focusFirstInput();
|
|
});
|
|
|
|
const keyValidationRules: Array<Rule | RuleGroup> = [
|
|
{ name: 'REQUIRED' },
|
|
{ name: 'MAX_LENGTH', config: { maximum: 50 } },
|
|
{
|
|
name: 'MATCH_REGEX',
|
|
config: {
|
|
regex: /^[a-zA-Z]/,
|
|
message: i18n.baseText('variables.editing.key.error.startsWithLetter'),
|
|
},
|
|
},
|
|
{
|
|
name: 'MATCH_REGEX',
|
|
config: {
|
|
regex: /^[a-zA-Z][a-zA-Z0-9_]*$/,
|
|
message: i18n.baseText('variables.editing.key.error.jsonKey'),
|
|
},
|
|
},
|
|
];
|
|
|
|
const valueValidationRules: Array<Rule | RuleGroup> = [
|
|
{ name: 'MAX_LENGTH', config: { maximum: 220 } },
|
|
];
|
|
|
|
watch(
|
|
() => modelValue.value.key,
|
|
async () => {
|
|
await nextTick();
|
|
if (formValidationStatus.value.key) {
|
|
updateUsageSyntax();
|
|
}
|
|
},
|
|
);
|
|
|
|
function updateUsageSyntax() {
|
|
usage.value = `$vars.${modelValue.value.key || props.data.key}`;
|
|
}
|
|
|
|
async function onCancel() {
|
|
modelValue.value = { ...props.data };
|
|
emit('cancel', modelValue.value);
|
|
}
|
|
|
|
async function onSave() {
|
|
emit('save', modelValue.value);
|
|
}
|
|
|
|
async function onEdit() {
|
|
emit('edit', modelValue.value);
|
|
|
|
await nextTick();
|
|
|
|
focusFirstInput();
|
|
}
|
|
|
|
async function onDelete() {
|
|
emit('delete', modelValue.value);
|
|
}
|
|
|
|
function onValidate(key: string, value: boolean) {
|
|
formValidationStatus.value[key] = value;
|
|
}
|
|
|
|
function onUsageClick() {
|
|
copyToClipboard(usage.value);
|
|
showMessage({
|
|
title: i18n.baseText('variables.row.usage.copiedToClipboard'),
|
|
type: 'success',
|
|
});
|
|
}
|
|
|
|
function focusFirstInput() {
|
|
keyInputRef.value?.inputRef?.focus?.();
|
|
}
|
|
</script>
|
|
|
|
<template>
|
|
<tr :class="$style.variablesRow" data-test-id="variables-row">
|
|
<td class="variables-key-column">
|
|
<div>
|
|
<span v-if="!editing">{{ data.key }}</span>
|
|
<n8n-form-input
|
|
v-else
|
|
label
|
|
name="key"
|
|
data-test-id="variable-row-key-input"
|
|
:placeholder="i18n.baseText('variables.editing.key.placeholder')"
|
|
required
|
|
validateOnBlur
|
|
:validationRules="keyValidationRules"
|
|
v-model="modelValue.key"
|
|
ref="keyInputRef"
|
|
@validate="(value) => onValidate('key', value)"
|
|
/>
|
|
</div>
|
|
</td>
|
|
<td class="variables-value-column">
|
|
<div>
|
|
<span v-if="!editing">{{ data.value }}</span>
|
|
<n8n-form-input
|
|
v-else
|
|
label
|
|
name="value"
|
|
data-test-id="variable-row-value-input"
|
|
:placeholder="i18n.baseText('variables.editing.value.placeholder')"
|
|
validateOnBlur
|
|
:validationRules="valueValidationRules"
|
|
v-model="modelValue.value"
|
|
ref="valueInputRef"
|
|
@validate="(value) => onValidate('value', value)"
|
|
/>
|
|
</div>
|
|
</td>
|
|
<td class="variables-usage-column">
|
|
<div>
|
|
<n8n-tooltip placement="top">
|
|
<span v-if="modelValue.key && usage" :class="$style.usageSyntax" @click="onUsageClick">{{
|
|
usage
|
|
}}</span>
|
|
<template #content>
|
|
{{ i18n.baseText('variables.row.usage.copyToClipboard') }}
|
|
</template>
|
|
</n8n-tooltip>
|
|
</div>
|
|
</td>
|
|
<td v-if="isFeatureEnabled">
|
|
<div v-if="editing" :class="$style.buttons">
|
|
<n8n-button
|
|
data-test-id="variable-row-cancel-button"
|
|
type="tertiary"
|
|
class="mr-xs"
|
|
@click="onCancel"
|
|
>
|
|
{{ i18n.baseText('variables.row.button.cancel') }}
|
|
</n8n-button>
|
|
<n8n-button
|
|
data-test-id="variable-row-save-button"
|
|
:disabled="!formValid"
|
|
type="primary"
|
|
@click="onSave"
|
|
>
|
|
{{ i18n.baseText('variables.row.button.save') }}
|
|
</n8n-button>
|
|
</div>
|
|
<div v-else :class="[$style.buttons, $style.hoverButtons]">
|
|
<n8n-tooltip :disabled="permissions.edit" placement="top">
|
|
<div>
|
|
<n8n-button
|
|
data-test-id="variable-row-edit-button"
|
|
type="tertiary"
|
|
class="mr-xs"
|
|
:disabled="!permissions.edit"
|
|
@click="onEdit"
|
|
>
|
|
{{ i18n.baseText('variables.row.button.edit') }}
|
|
</n8n-button>
|
|
</div>
|
|
<template #content>
|
|
{{ i18n.baseText('variables.row.button.edit.onlyOwnerCanSave') }}
|
|
</template>
|
|
</n8n-tooltip>
|
|
<n8n-tooltip :disabled="permissions.delete" placement="top">
|
|
<div>
|
|
<n8n-button
|
|
data-test-id="variable-row-delete-button"
|
|
type="tertiary"
|
|
:disabled="!permissions.delete"
|
|
@click="onDelete"
|
|
>
|
|
{{ i18n.baseText('variables.row.button.delete') }}
|
|
</n8n-button>
|
|
</div>
|
|
<template #content>
|
|
{{ i18n.baseText('variables.row.button.delete.onlyOwnerCanDelete') }}
|
|
</template>
|
|
</n8n-tooltip>
|
|
</div>
|
|
</td>
|
|
</tr>
|
|
</template>
|
|
|
|
<style lang="scss" module>
|
|
.variablesRow {
|
|
&:hover {
|
|
.hoverButtons {
|
|
opacity: 1;
|
|
}
|
|
}
|
|
|
|
td {
|
|
> div {
|
|
display: flex;
|
|
align-items: center;
|
|
min-height: 40px;
|
|
}
|
|
}
|
|
}
|
|
|
|
.buttons {
|
|
display: flex;
|
|
flex-wrap: nowrap;
|
|
justify-content: flex-end;
|
|
}
|
|
|
|
.hoverButtons {
|
|
opacity: 0;
|
|
transition: opacity 0.2s ease;
|
|
}
|
|
|
|
.usageSyntax {
|
|
cursor: pointer;
|
|
background: var(--color-success-tint-2);
|
|
color: var(--color-success);
|
|
font-family: var(--font-family-monospace);
|
|
font-size: var(--font-size-s);
|
|
}
|
|
</style>
|