mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 00:54:06 -08:00
c378f60a25
## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Continue breaking down `UserManagementHelper.ts` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
104 lines
4 KiB
TypeScript
104 lines
4 KiB
TypeScript
import type { CookieOptions, Response } from 'express';
|
|
import { anyObject, captor, mock } from 'jest-mock-extended';
|
|
import jwt from 'jsonwebtoken';
|
|
import type { IInternalHooksClass } from '@/Interfaces';
|
|
import type { User } from '@db/entities/User';
|
|
import type { SettingsRepository } from '@db/repositories/settings.repository';
|
|
import type { Config } from '@/config';
|
|
import type { OwnerRequest } from '@/requests';
|
|
import { OwnerController } from '@/controllers/owner.controller';
|
|
import { AUTH_COOKIE_NAME } from '@/constants';
|
|
import { UserService } from '@/services/user.service';
|
|
import { License } from '@/License';
|
|
|
|
import { mockInstance } from '../../shared/mocking';
|
|
import { badPasswords } from '../shared/testData';
|
|
import { BadRequestError } from '@/errors/response-errors/bad-request.error';
|
|
import { PasswordUtility } from '@/services/password.utility';
|
|
import Container from 'typedi';
|
|
|
|
describe('OwnerController', () => {
|
|
const config = mock<Config>();
|
|
const internalHooks = mock<IInternalHooksClass>();
|
|
const userService = mockInstance(UserService);
|
|
const settingsRepository = mock<SettingsRepository>();
|
|
mockInstance(License).isWithinUsersLimit.mockReturnValue(true);
|
|
const controller = new OwnerController(
|
|
config,
|
|
mock(),
|
|
internalHooks,
|
|
settingsRepository,
|
|
userService,
|
|
Container.get(PasswordUtility),
|
|
);
|
|
|
|
describe('setupOwner', () => {
|
|
it('should throw a BadRequestError if the instance owner is already setup', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(true);
|
|
await expect(controller.setupOwner(mock(), mock())).rejects.toThrowError(
|
|
new BadRequestError('Instance owner already setup'),
|
|
);
|
|
});
|
|
|
|
it('should throw a BadRequestError if the email is invalid', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
const req = mock<OwnerRequest.Post>({ body: { email: 'invalid email' } });
|
|
await expect(controller.setupOwner(req, mock())).rejects.toThrowError(
|
|
new BadRequestError('Invalid email address'),
|
|
);
|
|
});
|
|
|
|
describe('should throw if the password is invalid', () => {
|
|
Object.entries(badPasswords).forEach(([password, errorMessage]) => {
|
|
it(password, async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
const req = mock<OwnerRequest.Post>({ body: { email: 'valid@email.com', password } });
|
|
await expect(controller.setupOwner(req, mock())).rejects.toThrowError(
|
|
new BadRequestError(errorMessage),
|
|
);
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should throw a BadRequestError if firstName & lastName are missing ', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
const req = mock<OwnerRequest.Post>({
|
|
body: { email: 'valid@email.com', password: 'NewPassword123', firstName: '', lastName: '' },
|
|
});
|
|
await expect(controller.setupOwner(req, mock())).rejects.toThrowError(
|
|
new BadRequestError('First and last names are mandatory'),
|
|
);
|
|
});
|
|
|
|
it('should setup the instance owner successfully', async () => {
|
|
const user = mock<User>({
|
|
id: 'userId',
|
|
globalRole: { scope: 'global', name: 'owner' },
|
|
authIdentities: [],
|
|
});
|
|
const req = mock<OwnerRequest.Post>({
|
|
body: {
|
|
email: 'valid@email.com',
|
|
password: 'NewPassword123',
|
|
firstName: 'Jane',
|
|
lastName: 'Doe',
|
|
},
|
|
user,
|
|
});
|
|
const res = mock<Response>();
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
userService.save.calledWith(anyObject()).mockResolvedValue(user);
|
|
jest.spyOn(jwt, 'sign').mockImplementation(() => 'signed-token');
|
|
|
|
await controller.setupOwner(req, res);
|
|
|
|
expect(userService.save).toHaveBeenCalledWith(user);
|
|
|
|
const cookieOptions = captor<CookieOptions>();
|
|
expect(res.cookie).toHaveBeenCalledWith(AUTH_COOKIE_NAME, 'signed-token', cookieOptions);
|
|
expect(cookieOptions.value.httpOnly).toBe(true);
|
|
expect(cookieOptions.value.sameSite).toBe('lax');
|
|
});
|
|
});
|
|
});
|